From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id C1D9481251 for ; Wed, 4 Nov 2026 08:44:12 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A48h0j7022403; Wed, 4 Nov 2026 11:43:00 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A48h0j7022403 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="hDbcg7c2" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A48gbKG022347 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 11:42:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A48gbKG022347 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48dea677afcso149137f8f.1 for ; Wed, 04 Nov 2026 00:42:37 -0800 (PST) X-Gm-Message-State: APuU4Z/uzf06JayDdY2Dk1y40d/Xa3mJKW+paIqpDbt1gTanFKcTsFTc HFpE3+zQD2uhVLNAnVwNEjH8QzotcCPlC2PGtUNLJQctaE3Ecex4MA9uQFD4ev0en26Z/8aS2rM uqX2K8IqnU02FOvqu08ajlnyjKSrUGoyIo3mqKZMnHXmCc26VFsC4Yw== X-Gm-Gg: AYBFou36igAGG5QyT+lwPc18C8Dcwar8RsXNC/izTFD0dC2oV6WqIGtlQT9+1uLp3BS I1DlnOKNadPUdiEkOmbwNPI/4msVXt5l2/CO2qDtfjD2Qq2K0c4gBwldJyVQ+AwgJalYA1m9FQz 8af1gu40rhoNMCRkgFIX+PsC0ITj6l9Q3lLDUuLebantXnWEJL/2OKRXrAFLvpgVL240ZvK+feN y9xDoQs5sD7RNpRcpA+3fx92G5hFD3v6X7nFel4OWbruQprClNWB8Sgu4zOnDR1Zce6WJ9d/jTs Ia+OlGmgS09AwjljmFRV48NlKNkQc43ofzvol3NP5s26k26fBBZqJDAKL4BR/ELmrwiZldOOnwO AZVnNmGgwgvaUoIQMPXeL61qRP81GvQ== X-Received: by 2002:a05:6000:430b:b0:48f:cd5f:ca23 with SMTP id ffacd0b85a97d-48fcd5fcb66mr3498733f8f.26.1793781757235; Wed, 04 Nov 2026 00:42:37 -0800 (PST) X-Received: by 2002:a05:6000:430b:b0:48f:cd5f:ca23 with SMTP id ffacd0b85a97d-48fcd5fcb66mr3498701f8f.26.1793781756702; Wed, 04 Nov 2026 00:42:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793781756; cv=none; d=google.com; s=arc-20260327; b=UDHmeARmI2/j822tTyeCjJiD0qWFlQNGfAEErsCObHPIGCbIISDOb2LMt2rCjhOV1L LNthjXKVgxnCGwGi/RIz5LhJ7nUmtcgBQV7iJhaU28R1mjqkbj7vsxQM5+IIKowAUZeR xPnxlPWMEAx1WGayCcvUu11Z60M3UC5IiBAyTWjHa3VYPnyv9X3aShQO1JSXFkiE7+kA 1hTRoOLrmuQZ0MIFjHoKaOoltzKVTXVn73+O8YEjzkaK1oSMh19+ico5Jmmx4odrRq53 +cC2eLjOB+KoxMPsqHUjYYuZANyWO9yEghXJJwGyMKJpE87Xk60VQns1lIv5J/6iVXNp lXwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GXAShOiZkt0rixipjKASXjPYAS2T1ac1DrL+0nJtW8A=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=B+Pw3c2JIIoY4mQhq9PzhSZfEUPrsLoPTNYR0nDzyu6R6JTTlVFf0NBp4ZcMG0hgGq taNFkwNZhDwDSfQgVu4hODbh5hztA47ixp8AxQ6iIB/5pWh4vpAexRkjl0AUdOv2rOEz UqFNmaU+r0J80sjeY4BdayOqqPtjOjVxxM/omm+NVGJ1e88GkVWPDnR0hwqgNHWOTuMN wNnoLCubIDiueDF2Td3TvfSf1gAwKaNd38tJlKB0iDQQ8UY5xw7SSUXN6CWb4rzh40SY iWKPJCPGuLRrldwLDC1bfJKYiE/zqksX0A4fbncn4ZfoUlNSDGK5WR+bgqXaMlzJ28ly Gglg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=hDbcg7c2; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48feee326e0si2844937f8f.282.2026.11.04.00.42.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 00:42:36 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=hDbcg7c2; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=GXAShOiZkt0rixipjKASXjPYAS2T1ac1DrL+0nJtW8A=; b=hDbcg7c2b1Ed UG435Ptp4MmkyccwwD8qRPC/hbDr9JXoj+UbcnL0+vpgX/eAQAaxo8iKQbRV4brXYOBBA46zoqXOo +IDK+oTsVJZG8ywvYKbcfJR8km7EVQXeFqrhc4dRQLP1fT8DWx1Tspzskxaq1vZOOg2au3ZGQ4kHv sQG/5gVusifpnHlPHtKmBA91+kCwYQK3isrY4j7Th3GKXPysnU9oDxI56AqgZ4H3nfW+9bqN9BsjQ xBQO0oNCXpwfCyyUojYlhK7oWF8S1N5ZykwOt9uqxnPPuCBr2AB2rFF17irRqcixxVkacUSBNj//Y csrHKF3QbXe4C4hN526E1g==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOWVr-005ttV-2d; Wed, 04 Nov 2026 09:42:35 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Wed, 4 Nov 2026 11:38:12 +0300 Message-ID: <20261104083818.856720-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com> References: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 1/7] dm/push_backup: correct initialization X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Allocate pool and htable after lock, waitqueue and deadline timer init so that pb_destroy() is safe on every error path of pb_ctr(). Otherwise a failed allocation makes pb_destroy() call timer_delete_sync_try() on a zeroed timer struct. This happens to work on release kernels, but with CONFIG_DEBUG_OBJECTS_TIMERS=y debug_assert_init() reports the uninitialized timer with an ODEBUG warning. https://virtuozzo.atlassian.net/browse/VSTOR-152912 Feature: dm-backup: push backup target driver Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: no changes v5: commit message: safe on every error path of pb_ctr(); the zeroed timer triggers an ODEBUG warning with CONFIG_DEBUG_OBJECTS_TIMERS=y v6: subject prefix changed to dm/push_backup, added Feature: tag drivers/md/dm-push-backup.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 885ea7b31cf67..9a6252f2b21e2 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -658,24 +658,22 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb = kzalloc(sizeof(*pb), GFP_KERNEL); if (!pb) goto err; - - pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, - pbio_cache); - pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, - sizeof(struct hlist_head), - GFP_KERNEL); - if (!pb->pbio_pool || !pb->pending_htable) - goto err; - spin_lock_init(&pb->lock); init_rwsem(&pb->ctl_rwsem); bio_list_init(&pb->deferred_bios); INIT_LIST_HEAD(&pb->pending); timer_setup(&pb->deadline_timer, pb_timer_func, 0); - init_waitqueue_head(&pb->waitq); INIT_WORK(&pb->worker, do_pb_work); + pb->pbio_pool = mempool_create_slab_pool(PUSH_BACKUP_POOL_SIZE, + pbio_cache); + pb->pending_htable = kcalloc(PB_HASH_TABLE_SIZE, + sizeof(struct hlist_head), + GFP_KERNEL); + if (!pb->pbio_pool || !pb->pending_htable) + goto err; + ti->private = pb; pb->ti = ti; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel