From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E15C88045D for ; Wed, 4 Nov 2026 08:44:00 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A48gjel022375; Wed, 4 Nov 2026 11:42:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A48gjel022375 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="oiBvC7Jy" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A48gbPu022339 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 11:42:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A48gbPu022339 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e0ef019a4so445166f8f.3 for ; Wed, 04 Nov 2026 00:42:37 -0800 (PST) X-Gm-Message-State: APuU4Z/lXahRb7VuZRy3W2Vvs+PonTClnWidSdv6uOivbRbzTjbmmLgZ JaOSjdZEOgoJnWZEvjPOAt3G6urEStwOF7Gt8oD/jgzgpW6XwX8Iufc7P4Bd6eqRQUlTATCpc/a nEvNqw9JM9F0g4sofQVKZORIXcAyvmHkkdkDttImnkTABY3CAuJeuQw== X-Gm-Gg: AYBFou0d788cKja1Ryx/ExLZwVL8vic9lUTWW4wiv+ggtMXezyzTAJkOB1cHMHS8L2u e8tPTRS0lPVf2UHB4oZfKpCj86qMMrjqBi03fmond2TJZg9Ll7wfMS2IgnVi7gsKQy6utlYz2XB uyX563VQovRTHRtijVKXLfA6t13ZfKywDX+18kEQBAHy21yanH1IB6tGqJA8d1keueGYmuvyCUY HOf8+XkBzToC4G6jr8VWgRatlg46zfljC9SYOyghbCEvuWyfYccbwZ3lUx9rm7Pc/0ZRwZdVnXi RtRgH1Ia7Nefsstams1L097ytT7PsoWt7TRjcTPOeKlIVOBqL8A7fw/Og3cpt49o6Wq+0vUr0Mp yr3trnvG00v5NsUMBg0INHlyjQkiBwA== X-Received: by 2002:a5d:5e90:0:b0:48e:2bf4:e7f1 with SMTP id ffacd0b85a97d-48e6e518492mr34047222f8f.39.1793781757156; Wed, 04 Nov 2026 00:42:37 -0800 (PST) X-Received: by 2002:a5d:5e90:0:b0:48e:2bf4:e7f1 with SMTP id ffacd0b85a97d-48e6e518492mr34047181f8f.39.1793781756706; Wed, 04 Nov 2026 00:42:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793781756; cv=none; d=google.com; s=arc-20260327; b=fIoVbVsgxI5l0d215jnlXEg4QlV/5CBdmGKRBkIFxtChxBx/6hX4s/gc67zU0Xqf61 KWExrgTra4LQpRCjEykhW6FDPlrOs3B2qOhnOXk75qecyhlk5Tc/8eBkhh9iC9l3zcKI e5PlyaP2Ax5hK9X1DwmeIuea08qWpISW+VgrKgzBDMiOJXZA7X7BsU3OuFfN/lxbSKb+ HuASUSSS/ZlpIi/YEqmzYVsQrXaJ/2cjCTi202UjvN5sY8RLok24xceY/pRHUOw9LNkI eLoc99aCL7eKAWKIimQAI1hbx8TIgq8DWqUg3q5WXYPwlIYx3U671E5duDtHqToQZUJR lN+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=d7SIOJCDUHX8DfbwoLHPMwms8Kb+EzjuGdEETvtZyjE=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=DkyeS8D1It6X6TyCYUoH/5Sv7wOApOSuJJ0dsKDoB+gDNRi63wtpTSQjG3PhXL5nts jD4h6hzlLnPutcxaNL6lmhTb+QPhCk1HfAPSqrs7itzaySp+acPBNmctsaerUWpWOL+c pJzNQZu8V+J7QnK9K8s/Jv7qhq88Rij77zYOPFFYUlL8jFMOr5Xk1vkQUFfMzRGUqnIY HGzNcI3xgIb2rGcwEq/1lLIEODRj4knIhV+yVDkgxxD3WRFGXQ8a68CDAJ9P7OGpCLu5 Ssalijg5qEYtc9uPpklenP2+o6+QQYhHodgyRRruru1qW59ax8uYNx34xsUY0ntbJgMS dYug==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=oiBvC7Jy; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48fe9ea184asi2798707f8f.34.2026.11.04.00.42.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 00:42:36 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=oiBvC7Jy; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=d7SIOJCDUHX8DfbwoLHPMwms8Kb+EzjuGdEETvtZyjE=; b=oiBvC7Jyh70C 1t8ubn1SYkjXqYmMFZ565aDaMiOXz6CvJoA4E6bx7U8bk8b3h9DLzOf7Zghmr0sM50IfNvrjmP9uc 3EXfQhj2jhoFZi2vJmSPH0aAe8MbBF7iNzOLvn/WODY7Ua1tbJ2ZQO9G3wxlm2B4Zh6jKua2CS4va vG6u7PhejD6jU/L43zHkRHITHO8wdxcjNX6PeWTkW4LDKtQpK4EgGsO7UcgbvVcceBwHs3j+g69be Yo4eDck4LMhxn2R9Br12aqtbhcvfqQBCv9dWcxD5/OdWGtKRag7yH4rMvXSPVuxPG8THtNnVaNfwm UuoyJLed4goez9CMHH5RbA==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOWVr-005ttV-2n; Wed, 04 Nov 2026 09:42:35 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Wed, 4 Nov 2026 11:38:13 +0300 Message-ID: <20261104083818.856720-3-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com> References: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 2/7] dm/push_backup: return error if workqueue allocation fails X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ret is still 0 from dm_get_device() when alloc_ordered_workqueue() fails, so pb_ctr() frees pb and returns success. The table keeps ti->private pointing to freed memory, and pb_dtr() destroys it a second time. Fixes: 62e07487348e ("dm: Add push backup driver") https://virtuozzo.atlassian.net/browse/VSTOR-152912 Feature: dm-backup: push backup target driver Signed-off-by: Andrey Zhadchenko --- v5: new patch v6: subject prefix changed to dm/push_backup, added Feature: tag drivers/md/dm-push-backup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 9a6252f2b21e2..48d6d6a59daf4 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -698,6 +698,7 @@ static int pb_ctr(struct dm_target *ti, unsigned int argc, char **argv) pb->wq = alloc_ordered_workqueue("dm-" DM_MSG_PREFIX, WQ_MEM_RECLAIM); if (!pb->wq) { + ret = -ENOMEM; ti->error = "could not create workqueue for metadata object"; goto err; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel