From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id C77D581251 for ; Wed, 4 Nov 2026 08:44:16 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A48h2rt022410; Wed, 4 Nov 2026 11:43:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A48h2rt022410 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="AnLh9Ur6" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A48gbWg022344 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 11:42:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A48gbWg022344 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48c6a1d4034so430327f8f.0 for ; Wed, 04 Nov 2026 00:42:37 -0800 (PST) X-Gm-Message-State: APuU4Z8B48oGKzcO9G/RVbE9hB6MPdXSYKNp4jhV3qZaBmvdVaX3B6eI GQTSBDUKjm5365FCyDiVP+aaiRMaGFKmE/MQxkGdH4NtNznuSzwDURUZzugS++rhRQDn6gH9kRi nheS8/3RMFIWpdMV/VeUM/g0i7l/ugWkJYz4sYzwdFpfUh3mpYp1DnA== X-Gm-Gg: AYBFou0TjEkK4HgNXVYHjEM2gwHMGjiAhjiI0S+L8Scq3tI21vMa+SBoGaLNMI4WZS2 z9HOoDC3WKnCxtkaIkuQy7yFJIsdtLAJTCNtjB8hZy38jXVMukB+RmekVzjB3bwpfq1HXEbGgXk YALUiYjVpaJKApRb/AtD6iIAr2Bn1GsitYAYNOXENrrBmmEDxBKHnJSgGwFEbQp8NYu8Ka5Cn9l yLo7WOvV2+ZpEornKucRbgLuJcxE3bjldiHB5RoPocUmAlS7JBCv9GL5e7GBb/V7FuQaxnw1hYy tOgo254ttbvzREPtEWTyo2L1ahFl9AljCVatlgdBxffU0g8CGkcpRWsjgtiTvL85n/EFwSO9BZt ThsFc4C4xOtTJ5unPNNnufksdUZ2yrQ== X-Received: by 2002:a05:6000:2207:b0:48e:e98:8b6a with SMTP id ffacd0b85a97d-48e6e2db50fmr31222058f8f.4.1793781757252; Wed, 04 Nov 2026 00:42:37 -0800 (PST) X-Received: by 2002:a05:6000:2207:b0:48e:e98:8b6a with SMTP id ffacd0b85a97d-48e6e2db50fmr31222016f8f.4.1793781756702; Wed, 04 Nov 2026 00:42:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793781756; cv=none; d=google.com; s=arc-20260327; b=NUO0G+zOaecqWT+UTHEKeWCzW7l7ATjSHort+vUNW2ihEm52hEakp1KmyaJUvlGIGL eeYWRVp+Ms/d6JSjw/XoOD9ArwR29T2PU5l3o4lewZvPFnYIkp+ClG4V7YONm1kotV7w jz6/z0AW4YSmUfWc6SVZkSOXUPNC7zZ5NfYRl4fa/D9Ce5BU1KjRb1+wc0Jh1BS6AcgT kehuzpIQA/TX+Trf/jkP/MLPQ4FU80Zgp1MZXG7h84uyDVzi9wtzHQfQ79btl/0/ol9R Z2I7j13f/ZDny02AImyLGk/5W4E+EjEo4+I0cq13Wv7e4EOU8EJknStlJAJ4Qan5+CKm 7L1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=7nf6UaupqjtC1V1vmHUnkDXJ1NX1aueGQ565dlCGKz8=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=BCKABQm9V1FRZfsc0LqUv5wyJPW5YqWUujGCxTdgn5KfT2TsJYd1hG6UQs6YT4EAiU OpmYM+iWHM15sKoBmGQ91dMmt7SD2XDkRP0AmkErT9QfqB8YuQGZ7Axs/szOfUZ1IEPr u+kQwTn4cHREKjSXfQYMv5nfkU6KzJwgeWL3Cqy3bbcLPw0cBtYRfl6OOo3/W55wppHO h9We6yPF3FlfwO4TiwpGgQ9tfT5SfLlmO82WP9qEGrf0n2wkr78vTGljqbykZDl9IzH/ w+oimMOQHvqm8dQO2/u65PwSVv7UprciCQ0TMXXpx2XZiZ3GPVl9N8uyfPy37Lb+0EC6 qdoQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=AnLh9Ur6; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-48fed833f02si3071459f8f.185.2026.11.04.00.42.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 00:42:36 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=AnLh9Ur6; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=7nf6UaupqjtC1V1vmHUnkDXJ1NX1aueGQ565dlCGKz8=; b=AnLh9Ur6QhWq g//lzBMeBhLR0yqem/GMX+fFI+zzvi+nqCs0AdP100lKhOvo7aOLoNTFtshg8zM8CxMPBdholfCYW 07FNiOLf5pwT4KpO73CLWTyyed3oVMuCJho+sVpuztsDmDL6cmhZnPFlV7QgZ6c6q9bo+b/UwNN9T ZkBtPK0nycnhj6XDaCEotAElrpIUGTn5VHVLlBLiTNUivZVsPZRlaEg2qWbSbHTmWYvnlp+j+0pG6 3sm961wK7ETLiKFlwkuNx7aPRO4/2xhC54vsCb/O5TVD/rgxzLqIYIrlG0q0Fup+cuRLHnWBY0Mjs Ng1Et5mVc2UBZUQBGsx4dQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xOWVr-005ttV-39; Wed, 04 Nov 2026 09:42:36 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Wed, 4 Nov 2026 11:38:15 +0300 Message-ID: <20261104083818.856720-5-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com> References: <20261104083818.856720-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 4/7] dm/push_backup: fix mod_timer() usage X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org mod_timer() takes an absolute jiffies value, but all callers pass a relative one, which is always in the past. The timer fires and re-arms on every tick while a write is delayed. It has worked so far because pb_timer_func() checks pb->deadline_jiffies each time. Fixes: 62e07487348e ("dm: Add push backup driver") https://virtuozzo.atlassian.net/browse/VSTOR-152912 Feature: dm-backup: push backup target driver Signed-off-by: Andrey Zhadchenko Reviewed-by: Alexander Ivanov --- v2: no changes v3: no changes v4: added Fixes: tag v5: moved before "do not re-arm deadline timer", so it also fixes the mod_timer() in push_backup_write(); commit message: the relative expiry is always in the past, not only after 5 min v6: subject prefix changed to dm/push_backup, added Feature: tag drivers/md/dm-push-backup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c index 5c4f3d625fb82..b6d1629245235 100644 --- a/drivers/md/dm-push-backup.c +++ b/drivers/md/dm-push-backup.c @@ -244,7 +244,7 @@ static void pb_timer_func(struct timer_list *timer) spin_unlock_irqrestore(&pb->lock, flags); if (unlikely(time_before64(now, deadline))) - mod_timer(timer, deadline - now + 1); + mod_timer(timer, jiffies + (deadline - now) + 1); else queue_work(pb->wq, &pb->worker); } @@ -278,7 +278,7 @@ static int postpone_if_required_for_backup(struct push_backup *pb, spin_unlock_irqrestore(&pb->lock, flags); if (queue_timer) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); rcu_read_unlock(); if (queue_timer) @@ -532,7 +532,7 @@ static int push_backup_write(struct push_backup *pb, if (!list_empty(&pbio_list)) { resubmit_pbios(pb, &pbio_list); if (has_more) - mod_timer(&pb->deadline_timer, pb->timeout_in_jiffies + 1); + mod_timer(&pb->deadline_timer, jiffies + pb->timeout_in_jiffies + 1); } return 0; -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel