From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 55B9C811BB for ; Wed, 4 Nov 2026 18:47:44 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4IkUl2026039; Wed, 4 Nov 2026 21:46:31 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4IkUl2026039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793817993; bh=ql66xdomMd+tNh9abYtwBL0X+Zg/+PXdYAFy5WQ7CYw=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=QpacPJRYEy7rr+m+Ia/k7oczDp7785+5xJCVaEZhVrPveHXIpxm/2kKNIW+46y00/ sV/teSG4+8dgXPUYqo7BRfG6oWETBAnpB/t0iKDB4SQYKKE7v4YkSl6CztLH4hrWuh yTE9mNsB1Om0mGEbx34rPSAbcpm1UxotKpJpKLs0F6IBaPZ+BlH0GdEzqBpFSv6OOP l3HlNWvUdX66/u0cM3BIuLcIxNDmlXdcP9rypjknmaBY0cv0gzOclr+MAbJCBafCXB RqPBHOEsccebSA/QwmjUSafCx6DjnvxJQP7p9ZWKPTFpUmz4+evvvle79L1PsbHq/c PD2EuW2dg2tbA== Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4IkTKk026035 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 21:46:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4IkTKk026035 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="JLzyzU2y" Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-6b3f6d9827eso975849a12.2 for ; Wed, 04 Nov 2026 10:46:29 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBxDsI/bEJu0NCJYC4ivAGSSDA5YcTXoONkq8tJA6psqd90SBAQ7D17DGn54dgXYWsnpoS9vnQ==@openvz.org X-Gm-Message-State: APuU4Z+0KfobuVi2ohGK9mpogL7XnvxGtkdFq0DL5bf88dXdi3CRdTU6 GJb0xxuPHeP/Yr+WqfuXTC598H9OrPTbX9XqZLCSsldfKXA9IlVwyPhA9eQLdKR/qzcl5qWl3Qt HF9r6aPKnXv0zsjgzdROW8uF4cc66CUOqg1LhE4RMI3ec+mU6ypJz7A== X-Gm-Gg: AYBFou32pcCZDm9luC+MrknQF2piwnKFIsjXLzmCffN4ugfupjsHBq4ucYLt92LSCvr /MUSmECIioobEvpU4JzQcEpGfJDQhAZ1qG8PiCnltdHDkCWxLyjcQHN6AL13d8HuNgWZ6v9/v/r kDggM+eq3e/HIzkoPRuXcClVyS/7djFWJqj7h9r1bdfKpXFsWcVMrzsVdqLEPSwK8vBd6sRUshV mCN151PF2QqDqKRD/Zyohd62BSOZvQSF2XZVsyLxPcP1HnKF+xbQDSPwXRQnINbE4zrPTcdEdih TVUOpaaDuw== X-Received: by 2002:a05:6000:40dc:b0:48e:412:3829 with SMTP id ffacd0b85a97d-48e6e3071f9mr38560352f8f.15.1793815273561; Wed, 04 Nov 2026 10:01:13 -0800 (PST) X-Received: by 2002:a05:6000:40dc:b0:48e:412:3829 with SMTP id ffacd0b85a97d-48e6e3071f9mr38560307f8f.15.1793815273070; Wed, 04 Nov 2026 10:01:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793815273; cv=none; d=google.com; s=arc-20260327; b=Ze8wy9Wpcx5K0LIv0GZQlHhFOfEZ4ROOxL8JBGihWILOD/2r7FsYA7fNlc6Ase7tT6 gRrYv/ALpw2y/s6PduzoFrI6ILSrnt4ffDDrg9lChdF2hdAZy8jMWgKpWSZ9vTMahNdp eCmoqHvREmh8/wnJhzSFxXaUH4IvrxGHVeS5m6YAlQv/WTUhnBRChTLGpyXngU98CG5u 4HCl4T5S46Nvnkp1HUQb7KTtnPJJSbBsor+/YvUVji7lPbr4GAUr6PjsfGDEu4BTdOGn pyayHHEsHl3p4fOuAsfYamb4mIakck2gnl7sJE74Jjgz1z7usEFC+AhEAdEbTokzyyF6 3A0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=lT0UH3WJ0C1CklmU5SaDWsCFurn5G/KBlDjVNRX//38=; fh=EdohYiZXPXf6ZakqMR/4jOYZjeW5RbDcYSjaN1/FBvw=; b=UApbFwj6E5yrwaYo7WiwXmnudY2gY1DJ1DysRgeEUfwJ21A4szGPJUtrnCAC/qMtzc sdL5/RwFJ9KY+f0aXbSe8UoEzK1xeYa5n1MEtpe0k0CQ3+zP95ukjp0o1NMlb/09YQzU /CMfZySNdL1zZ7F8m4nWt8qlfuOmJYk9bZomzr9gNNHe/dXM5fbYHYvjJFIrAOfXIZjn jbedoG3qWfvcevtfILc3QUzRXggC9I3bDsKDGdtWt9AB0ilNwMvt3n2IDqtNbu6C/e3J vLut5aUqskobfuRxBEuFemq8gADFR0cKR+e0VBlI51j8kmj3b3eWIoGN8hZbM6RTbV82 zCXA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=JLzyzU2y; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48feef28e9esor709848f8f.13.2026.11.04.10.01.13 for (Google Transport Security); Wed, 04 Nov 2026 10:01:13 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) client-ip=2a06:5b06:b600:300:162e:5a6e:fd46:18b7; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=JLzyzU2y; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793815273; x=1794420073; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lT0UH3WJ0C1CklmU5SaDWsCFurn5G/KBlDjVNRX//38=; b=JLzyzU2y1rlHiCJ3/MbOmjBMcfoWso8WqOT3uOejdZGU9dN5Jmybgydz4jyx8oq8Ym QDvzw53OXF85dHw4V0slqCIS4i9XyAavta5zzuYtcZ+ktXe6CoyKMpnYbF+cbVAMO+AD LYcZcNYh7kGRaVfOA/H9o+L1GQKH0HeWSj7t14lX/3Yr2hbP189CIDdKPI2W7wUOzrm5 ZkTtK9+FGxYhCnjQy7wU8a7dIQ7UkhGjB0bOu2JDSUw0afoxDMXXd58dIGvwxj/y7aTM sv+j7bY0sIa82t1DSQsSXxJgX9p3vMUIezJIB6Oi0qoWaGhT04JpAwOn8OxzB6bvGet6 V6xQ== X-Forwarded-Encrypted: i=1; AKwUvBzITAM7Xj7BUL8XRwwhQWZxuHqdz5dIzAlKn7EKW7ERJ3FwFzMchfKLgvTZsR0pr0hG46oGyA==@openvz.org X-Received: by 2002:a05:6000:25c3:b0:48b:db7:86a7 with SMTP id ffacd0b85a97d-48e6e517f2bmr34115690f8f.50.1793815272586; Wed, 04 Nov 2026 10:01:12 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:162e:5a6e:fd46:18b7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48feda20521sm5050716f8f.53.2026.11.04.10.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 10:01:12 -0800 (PST) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Wed, 4 Nov 2026 19:01:04 +0100 Message-ID: <20261104180105.1807820-5-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261104180105.1807820-1-den@openvz.org> References: <20261104180105.1807820-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 4/5] dm-qcow2: fix SEEK_HOLE/SEEK_DATA hanging after a failed metadata read X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev qcow2_llseek_hole_qio() parks its seek qio on an md page that is not loaded yet and sleeps until the qio is dispatched to QLIST_SEEK, where process_seek_qios() completes it. When the page read fails, do_md_page_read_complete() ends the waiting qios instead. A seek qio has no endio_cb, so nothing wakes the walk, and the lseek() caller sleeps uninterruptibly forever while it holds seek_rwsem: the next merge_backward complete and every target message after it hang under ctl_mutex as well. Complete the seek from an endio_cb and return the error the qio was ended with. Fixes: 412d5a4f7bf1 ("dm/dm-qcow2: add llseek_hole") Reported-by: Konstantin Khorenko https://virtuozzo.atlassian.net/browse/VSTOR-153422 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-qcow2-map.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index fa535d7716da..eee865989ef7 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4600,6 +4600,13 @@ static void seek_qio_set_sector(struct qio *qio, sector_t bi_sector) qio->bi_iter.bi_size = end > pos ? end - pos : 0; } +/* A failed md page read ends the qios waiting for it */ +static void seek_qio_endio(struct qcow2_target *tgt, struct qio *qio, + void *data, blk_status_t bi_status) +{ + complete(&((struct qio_data_llseek_hole *)data)->compl); +} + static struct qio *alloc_seek_qio(struct qcow2 *qcow2, struct qio *parent, loff_t new_lim) { struct qio_data_llseek_hole *data; @@ -4619,6 +4626,8 @@ static struct qio *alloc_seek_qio(struct qcow2 *qcow2, struct qio *parent, loff_ } qio->data = data; + qio->endio_cb = seek_qio_endio; + qio->endio_cb_data = data; init_completion(&data->compl); data->lim = new_lim; @@ -4752,6 +4761,10 @@ static int qcow2_llseek_hole_qio(struct qio *qio, int whence, loff_t *result) /* one of metadata pages is not loaded and qio is postponed*/ wait_for_completion(&SEEK_QIO_DATA(qio)->compl); reinit_completion(&SEEK_QIO_DATA(qio)->compl); + if (qio->bi_status != BLK_STS_OK) { + ret = blk_status_to_errno(qio->bi_status); + break; + } continue; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel