From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5145F811BB for ; Wed, 4 Nov 2026 18:56:50 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4ItZlx026215; Wed, 4 Nov 2026 21:55:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4ItZlx026215 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793818537; bh=A5uMBxZVsnHZeJEXa7jQmDqTSz/9GEcLe71ZFd0ZV2Y=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=qi0SoSF3VLB+TsXAd1dqL52EOAhqbpwbz1eOfhWfeuLDrY8gMiXdgOYk/jOemG0Yu 2is2R6v7jYfXY6yLfp+UzfWHTAEGmPcoScfwXwBuS3912ym0g0V8ktuVXLm9qaHVnQ MXUNxlmvrWXy9L9pPs7LJnc1bjecjzlKe2WbqEnNdz5D/aDdP4H81HlLdU0yIwWcZV F38pJEocWFrUyM2JOvkYetOe7GLOIG5wwT+2C7qaQg8VKZuu4U6Auu+SdtWGA4Hw3A 1f8OdyOywuorPKhjUhCfI1GHINQNOr2SLNOOOW005vUkPkkmsWiH+dsQ+w0t6kneN9 QY1DNiJ/M/THQ== Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4ItRlG026178 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 4 Nov 2026 21:55:27 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4ItRlG026178 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="qyVvIT/u" Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48e011829easo671981f8f.3 for ; Wed, 04 Nov 2026 10:55:27 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBxIyBhJshnhQJ10Z7+ykNJBFdLRe4nCClW1j3X2vrLDkU7KUCImSD+q6zuZHKzTUuFPiD2tzg==@openvz.org X-Gm-Message-State: APuU4Z/dKa9q36rJ/ValAdIpRkOmmWGdyom29pnZQz3kl8SVdw95uHmJ FRO2MKJCax1Ip9900W0UsyLou354tMLF6v2FLYpfp/7snpYvfMbumEoDr0PSN2Jb23gRoc0DyDX JeuMsjOeND6X/sj1VTW0vT/HcbBySoicrXjeRW3vQffYZrA44pplxcg== X-Gm-Gg: AYBFou24hiiVW5UG7HrmCwwVRU8IIUeYrF3po0bK7vYjxswJ7jOSk/SFjofxlYZYJBM 1qMPXxq7fUvcJp/aVaqa2b50zeV3+qGYsqg0RYyvQb/1z34/nRh9wwJzD56ChYpzceD/THzGVMO VE+3ki2IzEHP3KoDbZWBwGIUdjnVylLZrdEO6BUDSaialKqw9qOODNa7CeOoD4tGCsdzAAaycdZ s9k3fyLovIzo31G5cA598c9/fwMAlu/M4g03eyXYtI0c4Ss4Y0fpCMJpcCQIijNe3ev/kHVHi2C euGQ9G0H5g== X-Received: by 2002:a05:6000:420c:b0:48d:f855:d1e0 with SMTP id ffacd0b85a97d-48e6e50b9ddmr38462046f8f.57.1793818526927; Wed, 04 Nov 2026 10:55:26 -0800 (PST) X-Received: by 2002:a05:6000:420c:b0:48d:f855:d1e0 with SMTP id ffacd0b85a97d-48e6e50b9ddmr38462022f8f.57.1793818526502; Wed, 04 Nov 2026 10:55:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793818526; cv=none; d=google.com; s=arc-20260327; b=oohqjlVGzEUkBYaT8vOTFi6L3FGaR7nXKf23plEAcO0/qUnvOJGOFVhz1H/vIaBYgX H2Xu8zZqJlCpt9TbWigVQFhGF/C5w9zCS1/6mvmn8585LIgqrlk/foixdVeUEc3JX09D qp2UnMRkBlEhcbltJpphxTpd7RdkCrkosCZ+ycrTbHUCwNsd/CTAt/+/A9RSyv5NKmMw 5BZ6FQ+oyMh4OBF362DyCKnNyoTyNE6IkbKAQ7KKH3hEzVlv7gBvIrP8h09H6XOBqQU4 he2NERadDTIk8DLquJNPZzgrzL1bXjbLXLzUJCEDWQL/CbRG0npjsEAz8vNERJm1A+5C LwcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=WOOWOfPlnJrNbksqgKbe9kR9EBU10L1Ms4pOig5OYzI=; fh=ivZY3+nYJ/7LD/+aiiSeld/zi6zMczLR83IgGo+m7WU=; b=jKjRRz2CvaiHyz1HE7cizKnTiHA2G/LDN02IVe28mXRondwL/pDx1VgHHyvJW0lHBb erx34ZlqLWWFn3ooufCofrrqnpeKCFiaVLtsS2n/EM7a+L8MC+7npufTbnEkfDYgYpiB L4w28Ng1Es/2Oee+tweXRl3lFr0QYo4S0N4c2C2XVhPOq0a0VfbngsdyZacUHm9ckCec APO9V31as3HdMsduHwcf19OeL+TP//7CbcMdsRM7yJKyHIfBZ/Wf5vmZj+J93saXYpzo Vkhh63JXtn8vMrnB6qtfMmh47btOWf39o/a5jTk2C+6BzY8N33z4BrMLiRISUp5K+Cdn oZMQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b="qyVvIT/u"; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-48fed648c71sor479145f8f.17.2026.11.04.10.55.26 for (Google Transport Security); Wed, 04 Nov 2026 10:55:26 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) client-ip=2a06:5b06:b600:300:162e:5a6e:fd46:18b7; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b="qyVvIT/u"; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793818526; x=1794423326; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WOOWOfPlnJrNbksqgKbe9kR9EBU10L1Ms4pOig5OYzI=; b=qyVvIT/ujqZ8ARGhOdhGkL9fUidbk4MouZd6Mg9YGXcZjlEcEF3yyBIyWzGExyeLYA ghmXNDggoLv4guIrXBVMurJ0FdjXNL3U5sq3Lgj32BNKDdJuJjIN8klPQtuk+1WcrPov PU/4iRhwazIKwZrORkI4AWS8wR17K+WzB9ZG6b6AIPTgf5Me0Kh+JZOS1NaaP4dmXFOW e7pYF98/n4UtrIXtV+q/BBKgItOfz/YW+Sr243g0lvbsPbc64sflBbfOQFwkYX6bzAWb rcFqnXsjo/azAyKHPJWTpTb5SgZOhGp4R+ObIPi+Jib15zN6Q/tgXj0fvzwPCAhKTRL9 +A6Q== X-Forwarded-Encrypted: i=1; AKwUvByUN39h9mq/CMNwkIzQBmW0saj6LlHwbfU9yQC0wFqMSPivA2T5M5DmUFMgdgJ4akHZKW8G7g==@openvz.org X-Received: by 2002:a05:600c:1f93:b0:4a5:87b3:ddc1 with SMTP id 5b1f17b1804b1-4ac180f1ec7mr400480075e9.13.1793818526083; Wed, 04 Nov 2026 10:55:26 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:162e:5a6e:fd46:18b7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b56e2ae762sm4482435e9.2.2026.11.04.10.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 10:55:25 -0800 (PST) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Wed, 4 Nov 2026 19:55:19 +0100 Message-ID: <20261104185519.1870488-5-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261104185519.1870488-1-den@openvz.org> References: <20261104185519.1870488-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 4/4] dm-ploop: fix a failed cluster copy on grow leaving the BAT page busy X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_prepare_reloc_index_wb() marks the BAT page of a relocated cluster MD_UPDATING and MD_DIRTY and allocates the cluster to copy it to. When ploop_write_cluster_sync() then fails, an I/O error or ENOSPC on the host file system, ploop_grow_relocate_cluster() only frees the piwb. The resize fails and submission resumes with both bits set: - every allocating write, discard or COW on a cluster of that page is parked in md->wait_llist, which only a writeback completion of the page drains, and none comes. These requests never complete, a dm suspend of the device hangs and later ploop cmds time out in the inflight ref switch; - the allocated cluster stays taken in holes_bitmap until the image is reopened. Clear the bits as the error path of ploop_prepare_reloc_index_wb() does and give the cluster back. Submission is stopped for the whole resize, so no pio waits on the page and none has to be resubmitted. Fixes: 018063db0eeb ("dm-ploop: fix resize and grow to use the new way of updating md pages") Reported-by: Konstantin Khorenko https://virtuozzo.atlassian.net/browse/VSTOR-152981 Feature: dm-ploop: ploop target driver Reviewed-by: Andrey Zhadchenko Reviewed-by: Konstantin Khorenko Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-cmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c index 29f9a7ee7540..1cb186a2e0cd 100644 --- a/drivers/md/dm-ploop-cmd.c +++ b/drivers/md/dm-ploop-cmd.c @@ -351,6 +351,12 @@ static int ploop_grow_relocate_cluster(struct ploop *ploop, PL_ERR("reloc: failed write: %d", ret); /* piwb can not change here we are the only user of md page */ ploop_break_bat_update(ploop, md, piwb); + spin_lock_irq(&ploop->bat_lock); + if (add_for_wb) + clear_bit(MD_DIRTY, &md->status); + clear_bit(MD_UPDATING, &md->status); + ploop_hole_set_bit(new_dst, ploop); + spin_unlock_irq(&ploop->bat_lock); goto out; } -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel