From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9E3B58017D for ; Wed, 4 Nov 2026 21:48:05 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4Lkniq027164; Thu, 5 Nov 2026 00:46:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4Lkniq027164 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1793828811; bh=OFD4C0BrVU3+T8IOzCkLQFgSnTC/pDq2CN5K+TcGaUw=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=INiSzFMSqEWV32Niw/mwBOFEthz+gmW6oFhsjeH+CSrJNYSUtwX+iiw6U0JeP9W3a EDzv9DZDe5e0K6m1hcNOQTKoiITS7eCt+tO5VlJH7ElRbhn6jdiiYgRIKvh+aAJVlh 7Bbyxs0UPbNOMJca0AzIjlacZBTlmTZbJunPUQlk33jiaxkenlSB6KbCv+M4VvDXY/ K1WaXLbyCnIzLWEbOeT+0yTVXK1ad9if10ezaQViuSnC3Qa42P4vg0PBgQsB+uiaSD uqnkm/bKbDOe9nhmTj4XbxaCsikyZ9SXsYaPPNDWLx++3k4CpCHFH4QTt1JNMOjD7u mahwXquyh5tEg== Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A4Lkfjc027146 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 5 Nov 2026 00:46:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A4Lkfjc027146 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="SOAJRZgd" Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49953abe51fso9979085e9.1 for ; Wed, 04 Nov 2026 13:46:41 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBzfI6mn+pZyNEegs5nYP3INETAytnK4aE3AjhnwRiADCT3bKTDAWB6efeic3jvmpESSi3o25w==@openvz.org X-Gm-Message-State: APuU4Z/9EnIkPX9TGRnn9RrIrufoF1sIwWPnnKFNzhd2vQ3gk7IB64Lz OCHWqLxicc4HY2qSDN9Bp0TNIyv6QT8Ad40wegFtBvf57opodzoQNgY+vCQ7LEiYlOJc12+3AAD SnrLJuf0sKg1FM+M7h3MYBoyulBsaIT8ufyxe3IEJSk/eDLEme/ou6A== X-Gm-Gg: AYBFou2RWUgQK+OirJeAMlHXPbHIPQv9eiGXpWT3BzJzJoKV4LPrjMaX9JuZZM7Vw+3 ItgGDnzJ/j+Ylo5YtBDXKXwUk/OU0QmcLnzTozRJ6UqZTcwlG46CN6+pZmkiOpoInNvLsTFuBQt 5lAOUumS3mKphV0d9FenmRa5sKIotCLKOO0AEhU5x1lXUSXW4kxadUzasnj8uzFuHMjqpPVsamg FqkN77vOl486kAThwJRjRJCCWFV+XBFL9S8TAYjXx7qAUf0ihXJKPS3/zbEJ3789xzeKnAxS4sL I5Okb8uKYw== X-Received: by 2002:a05:600c:c16d:b0:4a1:e00b:a0ea with SMTP id 5b1f17b1804b1-4ac150b204fmr372182675e9.1.1793828800938; Wed, 04 Nov 2026 13:46:40 -0800 (PST) X-Received: by 2002:a05:600c:c16d:b0:4a1:e00b:a0ea with SMTP id 5b1f17b1804b1-4ac150b204fmr372182515e9.1.1793828800558; Wed, 04 Nov 2026 13:46:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793828800; cv=none; d=google.com; s=arc-20260327; b=BlRSnqftwifqTZjcG6qAkvZ1KEjFgcbMhjshqgIVCYuuQXJ4pbiJJjgPESfx/Tu9H3 xx/+INhcNeRjTHxC52jZnoyVZcJnQWDRRyYX+5QNkUBimxO+VEM3rknCKc2WJfAXUDIv 4Q4ki3Q5s5PMCm10YvtNhEBBsW/TeTuqGg3+vPs753hENhQNswBGOMpNtX/RZNNClFPY u+LBut0ZY2UwCP+fZc+4nKvXMvGdUcpjgx5DgfaX/6ZJswUdjCtvTdaafNVkQnpB253k zgLnMfquUUVW9F7yta6mylXHLnDPuhKRI4FE8Ewbj4raDPYZC/T3KVcbuFZ/bmTkCqPV qYCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ZUhO/pT1E+IN973jvIT9VAhNFHPOrN+wcEJTnYOdPB0=; fh=UJs08OFEKw54xxNrf0nhsmrfbGvWzP4ZU1xV2pjavo4=; b=XvG6e+b5xq/5Z1iTU8v744Ne9lhPK/qcQ5TaB0dTsy6xLjvmRu6v9/ucI56do28D8e Iy20Z684kdzmiC3QPwYrUk5HRnmllp5HJLhZ3B8HDXZ+ROQcnBEufGb63odl0pOfoZUf iQ/2eJyVjxoRToRlNzO0BHXgIGdcj+Ip1hOvbUnqa5u4wnHlKCEINJd398UdhUi9nX+a Vxo12r1vn3/gFB060/1YHKyNp6LJMlbvh7KfsyVV02AJEh89C3fEu8AAYmt3at6sA45F IoEKptgv2m9YDlbTeyEGqHijm424YwTFebdzrRyJ7assIwu39cK1DfDytR4jE/HPaemR il6g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=SOAJRZgd; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4b43d3d4fe2sor6791945e9.8.2026.11.04.13.46.40 for (Google Transport Security); Wed, 04 Nov 2026 13:46:40 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) client-ip=2a06:5b06:b600:300:162e:5a6e:fd46:18b7; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=SOAJRZgd; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:162e:5a6e:fd46:18b7 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1793828800; x=1794433600; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZUhO/pT1E+IN973jvIT9VAhNFHPOrN+wcEJTnYOdPB0=; b=SOAJRZgdQWzX0KshPnILGJxW1qJ0X9G250AaY70uqVwn24XoX50+s2woOI2THiYgE+ fQKB/o3CZp7wU/+SnhHSJSEQIXzCdWxpJTKsDzYzJDQmVvVdWkuIH/JVa8G+mBbiughu sHNVXtVmuV+ZHrgHjLC75sllXYLDvaegKiTXv4EQcdVzAOCQnS6v4RBybzotg7+qNzPE zjL88YhCh0emSGaevst07MtMhueV9PEHjpT3uKX28Kg9o7plBQytxZFL4cvlomnIaO39 EONFYdHMhNbJfcEcr+v7PK9BJThLhJ0jBeifEhqlTA6aCrbMS5tfa7CbuvaqX75uyoHD rZ0w== X-Forwarded-Encrypted: i=1; AKwUvBwwVYZyxkKh+C6TSMXxRdrscuPbdSAr0nIWNhjO/PqS7a1XKWyUer5NUZpa6Ph2qwFPsSeQTg==@openvz.org X-Received: by 2002:a05:600c:198e:b0:4a0:2488:71cc with SMTP id 5b1f17b1804b1-4ac1932a23fmr394163175e9.32.1793828800156; Wed, 04 Nov 2026 13:46:40 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:162e:5a6e:fd46:18b7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b56e2ae72dsm24489635e9.3.2026.11.04.13.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2026 13:46:39 -0800 (PST) From: "Denis V. Lunev" To: andrey.zhadchenko@virtuozzo.com Date: Wed, 4 Nov 2026 22:46:35 +0100 Message-ID: <20261104214635.2063009-3-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261104214635.2063009-1-den@openvz.org> References: <20261104214635.2063009-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 2/2] dm-ploop: fix flip_upper_deltas walking past the BAT of the lower delta X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_check_delta_before_flip() walks the live BAT pages together with the BAT pages of the lower delta, and means to stop at the page that holds the last entry of the lower delta. It takes that entry from i after the scan of the page, when i is already one past end, so the stop never matches. Once the live BAT has more pages than the lower delta, as after a grow of the device, the walk runs off the md tree of the lower delta and dereferences a NULL page: the flip oopses. The reverse merge of the ploop library grows the lower delta to the size of the top before it flips, so only a flip outside the library gets there. Take the last entry of the page from end. Fixes: 6ddad5a4d226 ("dm-ploop: Add ploop target driver") https://virtuozzo.atlassian.net/browse/VSTOR-153445 Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c index d6abbdc3c7e3..74674011a888 100644 --- a/drivers/md/dm-ploop-cmd.c +++ b/drivers/md/dm-ploop-cmd.c @@ -1154,7 +1154,7 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) if (stop) break; - clu = ploop_page_clu_idx_to_bat_clu(md->id, i); + clu = ploop_page_clu_idx_to_bat_clu(md->id, end); if (clu == nr_be - 1) { stop = true; goto unmap; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel