From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B89C7803F6 for ; Tue, 10 Nov 2026 17:28:27 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHRCkx017470; Tue, 10 Nov 2026 20:27:13 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHRCkx017470 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="CX8FgrE6" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAHR8aK017441 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 20:27:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAHR8aK017441 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4902ce85f72so1763852f8f.2 for ; Tue, 10 Nov 2026 09:27:08 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEYWZ8EWq8ovqx3XRJIOQ8EmzhqLX7HDCi4/wlz2kYC7qCdMCdnSuzu3NSktPSzaf0dYsLVvA==@openvz.org X-Gm-Message-State: APuU4Z/YTl6hqfBJ1a98EFOGchsVUEByYMTw3ZDAmAm3J3Td9YVTkTSm Y39tCZfLlxIgAGLhaudR0tSxL2jJsHNoSu0mzgKcZ23Bck+76CY+HUDH7JCmZm8rPQmkBoYa6Rk 6UYix260DSi8nI8zAeA/TDURZF8z2a/KPK5RNLN8lzlzol4D7ogc7ZA== X-Gm-Gg: AYBFou08aSp7qEEqXxPsbN1e2zZqcskwfSU6WA9GxNVTpKg8BlLeIRYn1I7YnPeyiZx SCubJ62HvMJvmMkinXBpoViU3uSQVpr1IfVDru1ESbi2O30lMGgtrWOkjnZff4gnEM+i4AmFb1l XGA35JAAEz3qS1gT6oKpCJ6qCOXiZm1IzaCJXo6qW9JdDbtaxjGLTgo0SivotOiSRPj56I/U4uY 7g7dGAGbDZsTC9X8yXXqx2Tz5gx1UrT839DgeYMjRKN96J7+rnZtxzTqQlgbdPhNjPrWxGlji8l 8SeO90xZn5emfHB2tQeY4/mLI5YFNt/6X3hrKl8sGEgreA20dQPA+8QXqKDD1UljuV+GW47vbkP DSno1l+c9o+sjLJRN7C5FJx5avc42gg== X-Received: by 2002:a05:6000:4b08:b0:492:8dd4:baf8 with SMTP id ffacd0b85a97d-4982ba32923mr7094044f8f.6.1794331627791; Tue, 10 Nov 2026 09:27:07 -0800 (PST) X-Received: by 2002:a05:6000:4b08:b0:492:8dd4:baf8 with SMTP id ffacd0b85a97d-4982ba32923mr7094002f8f.6.1794331627276; Tue, 10 Nov 2026 09:27:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794331627; cv=none; d=google.com; s=arc-20260327; b=BL+waO+HVxLiGxsfFfueGu92r5D9Q9lgySEvM6ZlhhNwFIMFePUJBt4WFTjpmfrodA UlwMpxnVFBK5LTOL4BjV3YO38IdcnuFqnmiQk4+lXp6AEJX8q7Ed4rTNAiGUAfuUfunB UJivOb4HfxZSpHsLbmqK+qByq8bNoqz6Y4fxhq3MRTvQfZ7d+jGkf26UDhOJNCMml4Nd 72/cZh1A3BVKApLPxWq8LPYzk7xg6Fi3cZpdroteu3sTXh/E9rfg5KQWElHJbNzzXso9 cbbuPo+SBLSRPTomYuj4HUQ2Bd3jnfd/d5uk/Ah/BLvEXdTqI65aF9un1OdPCFVTgkSh XK7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:dkim-signature; bh=zwfRiK6KiNt7CH+jXCehAinqlKXom04/+UfIe17+qNc=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=qxa0um5EG6wGcgY2naUEOuHZttrE1DfASQu2lbSYi6/xvaKMnW4TycVzoPXP+xD/Wi rDF5rZiv/ENvVGV+eqX/5TE7ERJwC7MT8Exe5qKfxREPJTEQDdVsE51JUs0NJ7iHCEdA sMKpjfUh+BPN+IX8/NE1CDAhtFeAfrNxZ3FkLrNkE3ktKBxJNftRO9neSz3e+VzJSN7B J6oy//Rb/6yLhMiZ2ujAL2ccGN242sZiUzdeRq40SESlJT+/Yq6nTjogpWFj5NEX2Lkw CRqTFXpQxjEzOoiCVNFK1f6e8cbR5A6Ifb2aCjjsALTfZ8cUmVfmt4Lzip2Uw2VxV2lh iTxQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CX8FgrE6; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4984770a160si6221064f8f.137.2026.11.10.09.27.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 09:27:07 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=CX8FgrE6; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Message-Id:Date:Subject :From; bh=zwfRiK6KiNt7CH+jXCehAinqlKXom04/+UfIe17+qNc=; b=CX8FgrE6lMeBLnmvSi5 DqigGTbmpuBF+AMD22+6ipnIiq5sJ25cKAyYHlgOeRHt+Aqua8bKSKkwViDdtCuXFUJGQpN3zt8xd +0U7uvX7Ope/StSoNqAg2yh2HmN1cmKroxXmWJ21liAB/xyJG8fzqjhJgNDAsDnBwG8fc+NxTLEnv JVcdupmDUDaOU2P/MnZ8SOpY++3a5cauv6vUXfaB2R+f5eBSs/cpq82mhTZ2m6dmAXqNz+taA2+vq dR4NGh+sW3TEDjAiKz+SN2SCpVz3NwFau067HsD2XPbFE205Lioe4UD4KIL94p7e1KPykNTol4uMb nE1Hzijq1FFiQcQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xQpYa-0022KJ-1w; Tue, 10 Nov 2026 18:26:56 +0100 From: Vladimir Riabchun Date: Tue, 10 Nov 2026 18:26:47 +0100 Message-Id: <20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIANdT82oC/23NwW7DIAwG4FepOJcKHKCkp73HtAMxbsO0lgkSt LXKu5ekh1VLL5Ys//7+G8uUAmV22NxYohJyiJe66O2GYe8uJ+LB152BACNaaXksX3zMxGMKJ16 Ig8fG6HZvaoLVr+9Ex/CziO+sx8DtTrKPxyGP3SfhMHtztA95iOl36S5yeZhrpABY1RTJBffOK hQCrTD6rYQ0jPF6jTuM56WhwLNh1gZUg1ynbXdEaNG9Mpo/Q4pmbTTVcN4LBVin3b8y1LPRrg1 VDWvJaGWVR939N6ZpugMJjOwnmQEAAA== X-Change-ID: 20260918-ovl-use-orig-ve-2dc365976202 To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v5 0/5] Fix kernel crash in overlayfs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When testing CRIU with containers with docker images, we found an easily reproducible kernel crash: [ 2300.870181] BUG: kernel NULL pointer dereference, address: 0000000000000005 [ 2300.871537] #PF: supervisor read access in kernel mode [ 2300.872577] #PF: error_code(0x0000) - not-present page [ 2300.873595] PGD 800000010a18f067 P4D 800000010a18f067 PUD 10730c067 PMD 0 [ 2300.874900] Oops: Oops: 0000 [#1] SMP PTI [ 2300.875742] CPU: 1 UID: 0 PID: 5419 Comm: criu ve: 0 Kdump: loaded Not tainted 6.12.0-211.39.1.16.6.vz10.x86_64 #1 16.6 PREEMPT(voluntary) [ 2300.878057] Hardware name: Acronis OpenStack Compute/Virtuozzo, BIOS 1.16.1-1.vz9.2 04/01/2014 [ 2300.879684] RIP: 0010:ovl_get_index_name_fh+0x18/0x70 [overlay] [ 2300.880859] Code: ... [ 2300.884128] RSP: 0018:ffffd32582e0f7c0 EFLAGS: 00010246 [ 2300.895807] Call Trace: [ 2300.896397] [ 2300.904435] ovl_create_index+0x82/0x260 [overlay] [ 2300.905406] ovl_copy_up_workdir+0x30a/0x330 [overlay] [ 2300.906427] ovl_do_copy_up+0x10d/0x2e0 [overlay] [ 2300.907387] ovl_copy_up_one+0x456/0x720 [overlay] [ 2300.910736] ovl_copy_up_flags+0x81/0x110 [overlay] [ 2300.911740] ovl_create_object+0x51/0x130 [overlay] [ 2300.912719] vfs_mkdir+0x194/0x250 [ 2300.913470] do_mkdirat+0x14c/0x180 [ 2300.914223] __x64_sys_mkdir+0x46/0x70 [ 2300.915019] do_syscall_64+0x7d/0x160 [ 2300.922814] entry_SYSCALL_64_after_hwframe+0x76/0x7e The cause is that overlayfs does some feature checks on superblock creation using capable/ve_capable and it stores current credentials. But ve_capable check result depends on both current creds and current VE. Later, overlayfs switches credentials only, leading to unexpected feature disappearance. This was reworked completely after v2, the approach is different now. 1. Patch 1 removes separate STOPPED state - VE goes directly to DEAD. 2. Patch 2 adds helpers for overriding tasks VE. 3. Patch 3 delays ve cred drop until final destruction of VE. 4. Patch 4 adds VE owner to overlay superblock. 5. Patch 5 fixes the bug by switching VE together with creds in overlayfs. v2: http://lore.virtuozzo.com/all/20260920-ovl-use-orig-ve-v1-0-b3e63f6ff80d@virtuozzo.com/ https://virtuozzo.atlassian.net/browse/VSTOR-143259 - non-CRIU repro https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- Changes in v5: - Patch 2: report non-host VE changes, also treat VEx -> VE0 and VEx -> VEy differently. VEx -> VE0 might be allowed, VEx -> VEy - never. Replaced most WARN_ON with normal warnings or WARN_ON_ONCE. - Patch 3: updated commit name. - Patch 5: allow VEx -> VE0 case. Now creds are switched without VE. - Link to v4: http://lore.virtuozzo.com/20261109-ovl-use-orig-ve-v4-0-88e65484dc5b@virtuozzo.com Changes in v4: - Patch 2: clean non-NULL overrided_ve in fork and report it, Report revert_ve(ERR_PTR) usages and reject them. - Patch 5: changed ovl_override_creds signature so it returns error. Added checks for it in all places to avoid. - Link to v3: http://lore.virtuozzo.com/20261103-ovl-use-orig-ve-v3-0-add042cdd087@virtuozzo.com Changes in v3: - Patch 2: added a separate field for ve_override to fix problems Pasha spotted. - Patch 3: new one, delays init_cred destroy so dead CT can still use it. - Link to v2: http://lore.virtuozzo.com/20261026-ovl-use-orig-ve-v2-0-eab58bfc29ca@virtuozzo.com Changes in v2: - Patch 1: updated description as Sashiko suggested.. - Patch 2: moved stubs outside CONFIG_X86 section, added task_lock protection in helpers. Verified via lockdep, no splats after vzctl tests, C/R and crash reproducer. - Patch 4: fixed typo in comment. - Link to v1: http://lore.virtuozzo.com/20261022-ovl-use-orig-ve-v1-0-da84c00c8065@virtuozzo.com --- Vladimir Riabchun (5): ve: Remove STOPPED state ve: Introduce override_ve/revert_ve helpers ve: Defer ve creds drop until ve is completely destroyed ovl: Keep creator VE in overlayfs superblock ve/overlayfs: Override VE together with creds fs/overlayfs/copy_up.c | 6 ++-- fs/overlayfs/dir.c | 59 ++++++++++++++++++------------ fs/overlayfs/file.c | 65 +++++++++++++++++++-------------- fs/overlayfs/inode.c | 94 +++++++++++++++++++++++++++++++----------------- fs/overlayfs/namei.c | 39 +++++++++++++------- fs/overlayfs/overlayfs.h | 9 ++++- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/params.c | 3 ++ fs/overlayfs/readdir.c | 36 ++++++++++++------- fs/overlayfs/super.c | 3 ++ fs/overlayfs/util.c | 49 ++++++++++++++++++++----- fs/overlayfs/xattrs.c | 35 +++++++++++------- include/linux/sched.h | 1 + include/linux/ve.h | 38 ++++++++++++++++++-- kernel/capability.c | 6 ++-- kernel/fork.c | 2 ++ kernel/ve/ve.c | 10 +++--- 17 files changed, 316 insertions(+), 140 deletions(-) --- base-commit: fd34de0d39ec34baee8af703df9c34bc0851e2d3 change-id: 20260918-ovl-use-orig-ve-2dc365976202 Best regards, -- Vladimir Riabchun _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel