From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 150248017D for ; Tue, 10 Nov 2026 11:52:21 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AABp48r014478; Tue, 10 Nov 2026 14:51:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AABp48r014478 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="DefTLknn" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AABoxZm014440 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 14:50:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AABoxZm014440 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-49034831bb3so1769295f8f.1 for ; Tue, 10 Nov 2026 03:50:59 -0800 (PST) X-Gm-Message-State: APuU4Z+GHGcS1ZLLy22XfcE2CS27XNtGY8FhGUCn08NoikQpG2/kGPTV OgENJjg+ka2WHMdO9uw5RggADiz7Rm2BEM2Yan9Lovr0pYHO+ktljGKd84fEzQjU6nImzZuZvcy mL4dwN2iapW21lK0N15H+1u5NZk6kHTgcWkcizlwUX0Evqj55xtXAxg== X-Gm-Gg: AYBFou3vpbOZMVzTQfw2cJF6NBcoR73SQbq21XljdtmWWSZrFFZlWKM1+4bor2MFu1B 9vWRiXQle8yS++VP2WajL58GjgKKkOeCo1GrAn9YLUgOjdZ/IBcZ/UULynkJB28vjGLlEz0IxAy nen/dXPdgy0da3Hkzi1Tl+FTCCqQ0TyOLIun64MOSWxnDg4UaDJHvdGx66ZVOTL/btKKz0KcueY tG0lMjKnvomfPtcHjl/wwkrJIbYoRH1EnIwF+e6C8k5CPY34MuVhYzvQsPNNtEr0szMTpZywrIL +UmNTntq1oIsQYHA9rZHxowmF2PokwiPM4sWtWbXuAvOVRiMPkfmK+kObYwXM8yWHR9F8TD51QT 7Xxav5kke7jaDyDdhi3ufS7pfA6XDXA== X-Received: by 2002:a5d:5d10:0:b0:490:6327:96da with SMTP id ffacd0b85a97d-4993880d2cdmr531143f8f.0.1794311459081; Tue, 10 Nov 2026 03:50:59 -0800 (PST) X-Received: by 2002:a5d:5d10:0:b0:490:6327:96da with SMTP id ffacd0b85a97d-4993880d2cdmr531094f8f.0.1794311458501; Tue, 10 Nov 2026 03:50:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794311458; cv=none; d=google.com; s=arc-20260327; b=r+Ta+CxUkZ6VBRdVrsdt7nzI4cRl/SrVhMQVaSzGUoTpNG/jdFLtuj7FI3qmvPRaq0 W0MmSia1BmW8CpiXHWVstLNo+R9XHeGiqeLSOS6QEg6zzXeoyjUoJDP8WduNkqPW9ZDt C4oHzbyN7hFgSe0rjYipUmBf+/E1op120ro6aPo2RcoHCkEcMixOlg5BrIYqJ+PGXej0 lYgF2vUyP0E+uTDHra0lUkXXGUZVn6DMrOskTazFFqefckCjBZFGWuQeyZEEUSLYx4I7 65/wmhNdJ9vOA/ZMO8abJ7OuRongdVtuDbp2eTPKbrHUUwjn+fib3wkQ5Fa+TNu1hZ2E M+Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tm0XpG5s9CAaAYtDMdSSNIa/v20XkDDMIHbDvLCGmUQ=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=Yv43ce0XiX3YOhAO1E0i9lMBAWo1Nybt9B/poKdlUSkfWKOnU2lqrvanuSHwJky60n luFM19A7ceuHvy7YJrspXeynizwwisPdSdlfMNMzHclnIjh4m04lRcmZ5QAbRsngQQMl 2Hsntg4hiozE+JcBy7+rKgiXb48qyk4XEaIjQZ0QfnjdvE37NqjA2r1tlTG40PJxaBFT fsn0Q8c+Hp9Ke/QyCB2iUSi68zPtSott0fx+k1Yf/rrXL3S1WZRT7AeRziHfRB0ehu9b EFTfRdFk4tNLsPrDKmGjn9tFC/Ia1GENBcWDK+4fzG9/IBx+/UbdB8uXO4oQExox9QxV Pbew==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=DefTLknn; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4983847ceb4si5149478f8f.496.2026.11.10.03.50.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 03:50:58 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=DefTLknn; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=tm0XpG5s9CAaAYtDMdSSNIa/v20XkDDMIHbDvLCGmUQ=; b=DefTLknnD8q7 Z3LSYWO83R6UzysG2zY+fgGUMTuMw0bGhhYILhYW+xCmWo/5WvaAEt8+onYNGE5W4Fiu1Bj3ySyFf LJ0a6Mk03gHJHVvi0aYK0kXURffvLX2Nh7t08xsYUBgfFrYXDaTNS1xgwW+/8WSLA4IcnSu7wHi9C J/k+E3PIuxe3mtwE0cn2EQxu4QyliHw/2NmvqXDRbvfo3k8BV17Vlw9qdppUrKiN2GZfiQz9d8boH vzzMHHNreiE8qWdC8f4mm4bDs0FMwJBnKIDFSd5ZcoJ7Qmk7K+vUH+4NV7ytdWFS+AKsEbNSvRYKs Vmpf/Nn6BC6/XYMYHnAIxQ==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xQkJI-00DBlM-0z; Tue, 10 Nov 2026 12:50:48 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Tue, 10 Nov 2026 14:46:23 +0300 Message-ID: <20261110114629.416695-2-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/7] dm-qcow2: repeat md page lookup if it was inserted in parallel X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org parse_metadata() is called not only from the main kwork: qcow2_llseek_hole() calls it in process context, in parallel with the kwork. When both miss the same md page, both drop md_pages_lock in submit_read_md_page() and try to insert a new md page. The one that loses the insert gets -EEXIST from qcow2_alloc_and_insert_md_page() and returns it as is: a guest I/O on the kwork side ends with EIO, or lseek(SEEK_DATA/SEEK_HOLE) fails with -EEXIST. Teach __handle_md_page() to handle -EEXIST by repeating the lookup: the page inserted in parallel is found then, and the qio is either served from it or postponed until its read completes. https://virtuozzo.atlassian.net/browse/VSTOR-95494 Fixes: 412d5a4f7bf1 ("dm/dm-qcow2: add llseek_hole") Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Andrey Zhadchenko --- v2: say in the message what fails without the patch: the race of qcow2_llseek_hole() with main kwork; added Fixes: tag drivers/md/dm-qcow2-map.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index 34d9d9810f601..21d1c8975af99 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -1594,20 +1594,23 @@ static int submit_read_md_page(struct qcow2 *qcow2, struct qio **qio, /* * This may be called with @qio == NULL, in case of we are * interesting in searching cached in memory md only. - * This is aimed to be called not only from main kwork - * for L1/L2 pages, so all callers looking for L1/L2 - * must care about submit_read_md_page() may return EEXIST. */ static int __handle_md_page(struct qcow2 *qcow2, u64 page_id, struct qio **qio, struct md_page **ret_md) { struct md_page *md; + int ret; lockdep_assert_held(&qcow2->md_pages_lock); +again: md = qcow2_md_page_find_or_postpone(qcow2, page_id, qio); if (!md) { - if (qio && *qio) - return submit_read_md_page(qcow2, qio, page_id); + if (qio && *qio) { + ret = submit_read_md_page(qcow2, qio, page_id); + if (unlikely(ret == -EEXIST)) + goto again; + return ret; + } return 0; } -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel