From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2F66D803F6 for ; Tue, 10 Nov 2026 18:57:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAIu4Op018168; Tue, 10 Nov 2026 21:56:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAIu4Op018168 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794336969; bh=T6BjnYTCkNCmPVretSwrLPq0oIQevkxinCig/gdUZKA=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=WZ1tsfTpHPrOqVFko6gcquuUVI4GCqvXME2ol3MmhK6xB07BU2r13tqjceAxJju9E YaA00d0eQv7cY+TUm3/O7Yn/c0GIG2QRsx15V6hrQaBcn5uYiztdda2ZfvkE2UMFXn BlRttT1QxDEYxJhML3nMRYCOs6feK+fFTtzt30UxD4UKgwqvJActFRVo2oyNuMMq8M TuiNMlvIb22FPZ5ESZBxwbWtB0vyesX8P4dXpIQwjgf7/aMbIzI68pMVbBZs7nns5o TlhCTedjRjUeBDtrE4sr0KZyTdRoaasuAUdqz8PWS1EkIwDt7z0efPm75C4A8YTESE UlA/vAAqWzKOg== Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAItxhj018144 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 21:55:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAItxhj018144 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="mgfYNbl+" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a214a5f8a1so24131905e9.0 for ; Tue, 10 Nov 2026 10:55:59 -0800 (PST) X-Gm-Message-State: APuU4Z8IoRae2IilC9B3+je2bAnj0zIqAYrG38wlwyML/ZxgvvxarJt4 HRFAQy/1AUwQabt6v8/B0KObX0jxVSftyoaIuvPH7AoQIIMxD5rzbMO7LTVMVxZLfWL3z5R3BlI qRDqaXgFA6vltuJ+B4iBaYbrEOmVCbFwhRXdZv45PkQV7Zwp+irjasQ== X-Gm-Gg: AYBFou1cpfzB/DtLT5tZuT06ZsorImyRbbETppKk8vu4OhpWAvgFNxntku3+HE37Pld LzNZMaQEnzJdTefJd3pjl4RWRoV/mNPDq0T7259qnah1vguI3Mhsm+aWe2WXPZD1qTvkZ7pkuOu 5w3RkWiNedjFqO+II4KwGBQfzz68qi2e8ZDZaNZSTGzID2liiRoPGUDwIzW6rNYdCHhhyG4d2GV IPyVLkram32uJ9Lzqg9J2I47wgL2HZ6fKwWfYBLyY2ux3rTiHEFo0EhzyjC/JiibCRiZzZC6ry2 OwVf2DSHHg== X-Received: by 2002:a05:600c:81c5:b0:4a1:dade:f049 with SMTP id 5b1f17b1804b1-4ba09376130mr740685e9.15.1794336959356; Tue, 10 Nov 2026 10:55:59 -0800 (PST) X-Received: by 2002:a05:600c:81c5:b0:4a1:dade:f049 with SMTP id 5b1f17b1804b1-4ba09376130mr740475e9.15.1794336958955; Tue, 10 Nov 2026 10:55:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794336958; cv=none; d=google.com; s=arc-20260327; b=dar+poUCT/Rb4KX/scz/fuqCBWrAAiTw78iImy8F6IGjn5L4YEZhR9S7W+H6gpGL3n G9PNIsAVopjg5lVT/gyZgqgGPKrXfK52rOKNSIbZqnxyk8EJ7Ou+pJriMqXYPz8l3/5J +QdB7IezqI5gRi+kEIBmLOVr7iDyfHafrqydVHFTAAqKrBZJU7jpbTMu+GoQznbJoUPG HJYPub2uJO+pvsG7P1WP02r9ALSEdTjyBfrL1Dl/425HtzXS9dubX56cFGK1ojBji1xr O4omFz8SHEhlA4c9K7BUat4eT7p5LAFViHKbO6Dh8FZ4vv3JX/3AoSoA3HCqIkbRtXIl l+TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Ho3H70fMJ1odZSWVE2DiEwkdvWpKDC9Sq+X7gsEPRHk=; fh=KS4b3qG8sbRVXfRulBh4+PAboOCaaLCHgG4nm+k60uk=; b=QSj+1h1eXvdW5wh930eZw1cGl5+K0ygFY23rxii60e5O/hBalNbZFvBpG+YNMxZXRr p4JLl4iStc0if08Z3RYYbsK1YZPFWxMt5TX65nT8bw+HGDoFBZ4DdbOGaEDgpqsxH6qq gdfkRuprZO1/xhNuRJCXIsO4TxAvQMwFw9+IAqacFF9KDUaMl5x0NWhDwqGHrvU8YpoT 9AlOsM1rCZ8BDk1R25BmGvka4Mj8WZPxx+aYWMFG/vVCWqiQUO3FdoiLwv4mEHFRv03P iwQO3cn5v2RtJZ2NWEz6ISIsy2GAj4NYnnuOSGXuNz1DyI/6jmyYijmR1Sp0tEuAL2lK HrrQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=mgfYNbl+; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ba01ff40ccsor8492505e9.12.2026.11.10.10.55.58 for (Google Transport Security); Tue, 10 Nov 2026 10:55:58 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) client-ip=2a06:5b06:b600:300:4f78:6441:d0f1:22af; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=mgfYNbl+; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794336958; x=1794941758; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ho3H70fMJ1odZSWVE2DiEwkdvWpKDC9Sq+X7gsEPRHk=; b=mgfYNbl+iS6kgz3lpPNkFscCF3IhGCQy1SijG03VF0PHBLbFWO997FGFPTbUDfnKMr fIxUbRZTmTcG+TTvc7Klk8+Lvo0WoLUyZ8P0gxveKe2hgPZpGKD3hGnRiZmnax9mR7M5 vPUjaulZA9TkvWDwOs+MsADu+ENeswkaAIbC0UQswpgwM6VqSkwVie6cRG9qYRKljcdN m7qu2o9jmkIbhBsfu3WVJ0DfQD7tkzjVepSoJNXAmPr5rPSr46UEwEVyQ22bs1fqRKcK jwiHbC0N4UvaQVcSXZmAXgTek+ltOBOhgALovjQiQymQPAMcFaAiCWkEAvMr0SVxhw2q buvg== X-Received: by 2002:a05:600c:4e87:b0:49f:e772:6ddf with SMTP id 5b1f17b1804b1-4ba0938ae31mr568705e9.32.1794336958513; Tue, 10 Nov 2026 10:55:58 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:4f78:6441:d0f1:22af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba02387ed4sm55207475e9.4.2026.11.10.10.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 10:55:58 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Tue, 10 Nov 2026 19:55:52 +0100 Message-ID: <20261110185554.2970417-2-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110185554.2970417-1-den@openvz.org> References: <20261110185554.2970417-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/3] dm-ploop: fix flip_upper_deltas returning with two md_locks held X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev ploop_check_delta_before_flip() takes the md_lock of a live BAT page and of the matching page of the lower delta before it compares them. When it finds a cluster both deltas map, it jumps to unmap past both unlocks: the cmd returns -EEXIST with the locks held and interrupts disabled, after freeing the page of the lower delta with its lock still taken. dmsetup comes back to userspace in atomic context, and the next pio touching that BAT page spins on its md_lock for good, a hard lockup. A flip_upper_deltas message on a chain where the top delta overwrote a cluster of the lower one gets there. The ploop library does not: its reverse merge clears those entries in the lower delta with the device suspended before it flips. Leave the scan only after both locks are dropped. Fixes: 0d4b4d0a20a9 ("dm-ploop: introduce per-md page locking") https://virtuozzo.atlassian.net/browse/VSTOR-153445 Feature: dm-ploop: ploop target driver Reviewed-by: Andrey Zhadchenko Reviewed-by: Konstantin Khorenko Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-cmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c index 45fa4fe7a45a..d6abbdc3c7e3 100644 --- a/drivers/md/dm-ploop-cmd.c +++ b/drivers/md/dm-ploop-cmd.c @@ -1146,11 +1146,13 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) d_bat_entries[i] != BAT_ENTRY_NONE) { ret = -EEXIST; stop = true; - goto unmap; + break; } } spin_unlock(&d_md->md_lock); spin_unlock_irq(&md->md_lock); + if (stop) + break; clu = ploop_page_clu_idx_to_bat_clu(md->id, i); if (clu == nr_be - 1) { -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel