From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 82FE3803BB for ; Tue, 10 Nov 2026 19:01:59 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAJ0mTT018280; Tue, 10 Nov 2026 22:00:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAJ0mTT018280 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794337251; bh=RCB3A1SmizrtYVzz1BDptGj6DwCRJWswQDQcyenvt4A=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=sdi6/+RyzsK3XRU+of4lYxQ0V/olENuEtBp4v1yFBnZnbeANahaOQXymTLl/ixQxN I0GauTi5g7EXTTrqA+seM/it1Hxns4R31A5P3zCWy3bPcsruJHlc5FZg01HQKIo/On k9RpQ67oPm+zriQcyVGD+JoHPILpUsku7gExtpB+ZxdHow8DcJgrFOnJlp5OgpysfA QZxgC8/rdsov08IkkgQetjIonW3kwZfN3NfoTRXIdrapG8rkAQGgj4XoC16k8hJKB7 fzXnY3UE8jHtqjZzL5AentJqPxM7hLG2WJtUKeVcQOgqx7JmmEit1pEvmTYmngZ83I 1Ab8Ia6G826Ew== Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAJ0dbN018264 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 22:00:40 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAJ0dbN018264 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="VfO76Azz" Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490c69dc02bso1985949f8f.1 for ; Tue, 10 Nov 2026 11:00:39 -0800 (PST) X-Gm-Message-State: APuU4Z8ByVYRuZsWBKVPIb6s8Z3U2H08oLpr/4otz/Vqezc0P7NtbcO8 y95nlXE7zGEuLvj1Xis1BCFLwCN7wWDF9HADlIZshbPQfDfttUVpRbUjcoog0klfBWuH92Fg7O+ BHoL5abPoQ7onUGbetSwVIcGIDiEf670vwfotkq/HAXpR9jSx3paWwQ== X-Gm-Gg: AYBFou08bFptVhJvVc07T879TvYbm3V0VYYsj/uvRrhu21mZGVbJrGG/05NApBQSJ8j HUI0M5zQGqIGlPmKvqaRfF4X6XuyyMihXm0itsZgz3NM09NT4HS6Uiz2pHF7uxQN9ZlWvdk3ugs QauQA0XkG4HP9e7ZX7MmJVszriw4peD0sefqJ0A+8rZ63fV4CNGhZ2//QsWpDYjhVTcHuPv2Y3o 6I0xf97HXL8jufZRcbYLGneMK6py/QJzzO8WzjA4ocTZCtnCKXVnyTliuFVqKyXvVPG5o+/5uPG vguwUKMrWQ== X-Received: by 2002:a05:6000:468b:b0:48e:7476:9205 with SMTP id ffacd0b85a97d-4982fc496d8mr4894492f8f.31.1794337238945; Tue, 10 Nov 2026 11:00:38 -0800 (PST) X-Received: by 2002:a05:6000:468b:b0:48e:7476:9205 with SMTP id ffacd0b85a97d-4982fc496d8mr4894467f8f.31.1794337238537; Tue, 10 Nov 2026 11:00:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794337238; cv=none; d=google.com; s=arc-20260327; b=LHx6S3Uf2wHBdb2gBtUoqDw3hqfIMpaiicqfhjLRtG75XF/tphalG4iGULl22gtqrO GmbQTsD/1pZ05xuncHQLEtKeBwsyPMC5+FjTNw/6JcE7flAItAeCwdSyix/STOF4FfgI 6n6Vb7kQuMMtCh29QZco98xz4BWO3Qy5KgLvY2RnOk7mYaeAANu7OYj0dF4rs6VtPxYq KiF0G/1SiBLTkgCI1VxN47CFp+KcOHyVjRYEszka0lH1sTHKSk+2h3ynUT4crlSvsh6N fqDnWzFjtRaxNZn9OjAITyzIlAIJD793T/+7G1zgzNeikmBh6R7oytVurPlQe2T4VyBy ndqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=tW2z9thwjXP19GCQn50YLsiE3XKoa9JySSuMMjGkZF4=; fh=ozrYJQ1t3QIP6s65KBq5xgJxiFM2qf+5wwn3ABTusyU=; b=dG43kmuPxL4s1ExtI5Af4Ki9A0f9vQnksthk8UpoUCNIS4eitUjQq3GP+9pFTFHJTM 7xs9gevprhAn0WpyCQdHETcjK24FPbB9gVG4gW0a/+sob5zY1c/wMg4ywJHGZc4xGQIe ydn3SFbgKMgGTeAqw9h7yPA2sWgc4EMnuWMC/NT4wpGSHwylPjAw026LtXixfDmMSv9L phED6QNoTvKaXVk4wO86Fh8eRMqmYR9r0Ojuxdr8aw4BnX7A9k1UVQxHNdDpKxU1Q43q ih92pA7AD9liODx8Ier03qw94RAI03iqI7l09f0AbKBaq3EoQ59aXOItqVncNCUBIwP/ se9g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=VfO76Azz; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id ffacd0b85a97d-498349e40d5sor887863f8f.16.2026.11.10.11.00.38 for (Google Transport Security); Tue, 10 Nov 2026 11:00:38 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) client-ip=2a06:5b06:b600:300:4f78:6441:d0f1:22af; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=VfO76Azz; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794337238; x=1794942038; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tW2z9thwjXP19GCQn50YLsiE3XKoa9JySSuMMjGkZF4=; b=VfO76Azzvgd+6xHzk6nudJqa43a14tD2XN4q/pMxZMC4pjYoFgF88LAI/3nwPOnf6Z FMzhINAzDJNAUJiT0EnpSijbkFdW/HlRw7xgpR1KmWtnKDCLS/nfmgPXuEarJoqAZM4P bjwQRv4ZLdzntuiEhYx34TJSb1za4x5t+7JrpB1ZW/0zqi08Y+4YeJsy82jVKMsH0OUE /neElXC/ygES05XC1sKn8iVKqmaQSpjgkGGdk+tOpLCqp9Jl6BCQxc32xcus3guKwJrm CyW2rcHptfFTrwDAjksVpCEU9wvmQere4RFeBkLFodEA/bHW0NHFyNK4zfCUEzVVTSzk TNnw== X-Received: by 2002:a05:600c:3b88:b0:4b8:d17e:da27 with SMTP id 5b1f17b1804b1-4ba093c51a8mr583125e9.27.1794337238102; Tue, 10 Nov 2026 11:00:38 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:4f78:6441:d0f1:22af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49944d646f9sm2245827f8f.32.2026.11.10.11.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 11:00:37 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Tue, 10 Nov 2026 20:00:33 +0100 Message-ID: <20261110190033.2976967-3-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110190033.2976967-1-den@openvz.org> References: <20261110190033.2976967-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 2/2] dm-ploop: fix the ENOSPC retry timer not waking the dispatcher X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Denis V. Lunev A write that fails with ENOSPC on the image is held on enospc_pios and retried when enospc_timer fires, so that I/O resumes once space is freed. ploop_enospc_timer() only sets submit_enospc, which only do_ploop_run_work() consumes, and nothing wakes the dispatcher for it. ploop_worker() also goes to sleep with the flag set, as its sleep condition checks the pio lists only. The held writes are retried only when other I/O reaches the device: on a device whose only I/O is the held writes, the writers stay in D state after the space is freed. Wake the dispatcher from the timer, and keep ploop_worker() awake while submit_enospc is set, so that a wakeup that comes while the dispatcher is busy is not lost. Test and clear the flag with xchg() in do_ploop_run_work(). https://virtuozzo.atlassian.net/browse/VSTOR-154182 Fixes: afc60480b037 ("dm-ploop: resubmit enospc pios from dispatcher thread") Feature: dm-ploop: ploop target driver Signed-off-by: Denis V. Lunev --- drivers/md/dm-ploop-map.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c index ae3e287604b7..a4e17aa090a6 100644 --- a/drivers/md/dm-ploop-map.c +++ b/drivers/md/dm-ploop-map.c @@ -165,7 +165,9 @@ static void ploop_init_prq_and_embedded_pio(struct ploop *ploop, void ploop_enospc_timer(struct timer_list *timer) { struct ploop *ploop = timer_container_of(ploop, timer, enospc_timer); - ploop->submit_enospc = true; + + WRITE_ONCE(ploop->submit_enospc, true); + wake_up_process(ploop->kt_worker->task); } void do_ploop_event_work(struct work_struct *ws) @@ -2241,10 +2243,8 @@ static void do_ploop_run_work(struct ploop *ploop) current->flags |= PLOOP_PFLAGS; - if (ploop->submit_enospc) { - ploop->submit_enospc = false; + if (xchg(&ploop->submit_enospc, false)) ploop_resubmit_enospc_pios(ploop); - } llembedded_pios = llist_del_all(&ploop->pios[PLOOP_LIST_PREPARE]); @@ -2447,6 +2447,7 @@ int ploop_worker(void *data) llist_empty(&ploop->pios[PLOOP_LIST_DISCARD]) && llist_empty(&ploop->pios[PLOOP_LIST_COW]) && llist_empty(&ploop->llresubmit_pios) && + !READ_ONCE(ploop->submit_enospc) && !ploop->force_md_writeback) { if (kthread_should_stop()) { wait_event_interruptible( -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel