From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9A3888017D for ; Tue, 10 Nov 2026 19:19:57 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAJIhj2018386; Tue, 10 Nov 2026 22:18:44 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAJIhj2018386 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1794338325; bh=G29Q/Jw4/B35yyk7e7NEU2SmWWsVo92mkFOpW1DvluE=; h=From:To:Date:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe; b=FIhibQSup1FX1oqh6CMaYP1QraSpWPtvH0UFU6OZSnAujtG/V2/wJNB4c5CSUaV/u 2jjIJF/nCLkVmV1A+dHpI649IjPIME0HaoAirV741RIo9qAbXxY8SRKX0K4pkQgj8e szrMEJejSkWVWEqh3hdELGI5PobdDOSdaeSXCNjkYWc2aLpLdOQmIU4sp8nvLpCBm4 GeGjxHWaI/B304BMH0njbinw7LbMIOW9gT3nvXTcLSjN3YIls0S9dkojg/fqWJDhyW Ngv6LhY8QPaAyl0EQhDpdg/h7wgwVm1BWTz0Twn1rGiPb9wsEJ0Joxji4Ff7Q9ADvy T1zVKj3cOgRZg== Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AAJIfqT018370 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 22:18:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AAJIfqT018370 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="mKT4Xvzx" Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a359c7f47bso20435185e9.2 for ; Tue, 10 Nov 2026 11:18:41 -0800 (PST) X-Gm-Message-State: APuU4Z8C8ilSy9G6jI++whe86mGjzByqiIENsCwwebJN9r60cUcXDo98 gMruc7qQlpadub+VXmUYg1WD9ZPpu4Y2YxvFLNheKbFk9vH9mQM7fWsVfJvlrpfmM3B82/celJ7 /R1KeEvxK69Dnn3qczYY45Ye37HiU/tDQ1ttHu7vu/b5viXrydsHLbA== X-Gm-Gg: AYBFou10wKV/Z83HNPkp/FIsX+ChdQRClC9hs3KAma9EIRbhq/MYz+MJKPhWnZXdluC 13XUD7qkzvpLdZbKTIsqdUW4Bj0ApfABL5JJ84X/oBDvjAvgWQ/5emhbSuyEOrJxoOenGt5EhrB LuOhXGwMTH3vnSwaMx2cDW1YqnbOLMC56Io/rD4SWxE1x9MPflwZOjx5EBR0CZkvL3EcCA3cgSu a0vtBaGMA2kd5l7BAHmLegYegrSsf9KlQTRHSLrKqfhMKh4BQN3rVEey1N2BfDbNQBUrR3VFHT/ r+AI5yGQ+A== X-Received: by 2002:a05:600c:5251:b0:4a7:4697:dae3 with SMTP id 5b1f17b1804b1-4ba0938d96dmr1664045e9.24.1794338321110; Tue, 10 Nov 2026 11:18:41 -0800 (PST) X-Received: by 2002:a05:600c:5251:b0:4a7:4697:dae3 with SMTP id 5b1f17b1804b1-4ba0938d96dmr1663795e9.24.1794338320764; Tue, 10 Nov 2026 11:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794338320; cv=none; d=google.com; s=arc-20260327; b=WioAUYp0HWCdvLPgt//qex/mPn/fFXS6R6W6857tJPw0NxFn7FP99moDNRwdb9CPw1 QxxOHERIxVjXvD9JDJuwdmp3qDJH1PfOKIxAo+jJ5gbwy2QMpSlY8k5IaFilKrvpulfF vOM2L/TjeTGz3vrKrA/e1yDoGSqvF1wlBeQ7T4Pmof3aoHpi1tCgU9nWHOzkfUG4Kc8Q LIP/l4Z9IHdwYfY6Np1oIMfl+Agu8XJY8yJA7aNef70N+26fXWf/rkZcGmS0xzkosVVf W4eRLANPjAA/dNTMnBh1RMPy9fSzdx7w8YkmDoc9QZ9mn5uZgv3AW4KxN6wrB8p6JPCs n6dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SyGlupZ5AG1ySCL5pbfbawQWqcO+4HVSljFoeYQ2oU8=; fh=ozrYJQ1t3QIP6s65KBq5xgJxiFM2qf+5wwn3ABTusyU=; b=B2UrouFIsVmQDi4bU5BGFmEHdewFhOXN6RbBJd05JfGyUJS9laRncKe+N9JgCWvt8O 2gjDFIDEWaW425YEhd48ZkxixCmg5tb6eoZYvr+12CwRFcBWWzPEiPYj0/sobP0ImjD2 htGXwjPOcJyjTWuHzfdCXeZq0vybpw8l4BZZ+2mAX63j64FKj2llN8xMX+gX+onDG/Co apbsDwkljnspnCZUdaUKf/LHc5LJxcz4+t3AynjsknUvdXT5wvB+GGxTWhuwAXYx2onx TldAhjAQaJqnrhi7MwED0VXKuBZRQtTATiwwIzztdQjiJGrn/4yMLQnmWuYqaB2oUT4g 5+vA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=mKT4Xvzx; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4ba01ffd364sor6814945e9.17.2026.11.10.11.18.40 for (Google Transport Security); Tue, 10 Nov 2026 11:18:40 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) client-ip=2a06:5b06:b600:300:4f78:6441:d0f1:22af; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=mKT4Xvzx; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:4f78:6441:d0f1:22af as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1794338320; x=1794943120; darn=openvz.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SyGlupZ5AG1ySCL5pbfbawQWqcO+4HVSljFoeYQ2oU8=; b=mKT4XvzxWUZ3jaOiE0Odg6ueX7rutsHHe9WRKqlSILl3GujwacECcVuy7X8J2Q6Ju7 3lR/f33+RS36ctjfH4VRehbETl3H8EX2fq3qdAf5UiVXipUX8wr0uyorBAjeZAXS0XLC plNjwDeyUbdJLUN/xcKPkkdlqgJQMEAv3/dNsb8JUJ9BvbSqBkqbAB/U1gmcj8/OBy+6 B+wvss2c4GHbtywfNo4j8TEnHavV1Koy3zeU/7jV/9k+RewFW75T4pwsFBox0Axe762O Z+TiiulfoMsmMJ6Kyapbf6EhnITTRh/aKagdmNgvcaoyYu3XOyFBTvWOfEVdZwJTBSOx Z+Hg== X-Received: by 2002:a05:600c:1914:b0:4ad:5e09:ae43 with SMTP id 5b1f17b1804b1-4ba093a1edfmr1394555e9.29.1794338320293; Tue, 10 Nov 2026 11:18:40 -0800 (PST) Received: from athena.sw.ru ([2a06:5b06:b600:300:4f78:6441:d0f1:22af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba01fea745sm80156815e9.10.2026.11.10.11.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 11:18:39 -0800 (PST) From: "Denis V. Lunev" To: khorenko@virtuozzo.com Date: Tue, 10 Nov 2026 20:18:34 +0100 Message-ID: <20261110191836.3000352-2-den@openvz.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261110191836.3000352-1-den@openvz.org> References: <20261110191836.3000352-1-den@openvz.org> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 1/3] ms/iommu/amd: move wait_on_sem() out of spinlock X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Ankit Soni With iommu.strict=1, the existing completion wait path can cause soft lockups under stressed environment, as wait_on_sem() busy-waits under the spinlock with interrupts disabled. Move the completion wait in iommu_completion_wait() out of the spinlock. wait_on_sem() only polls the hardware-updated cmd_sem and does not require iommu->lock, so holding the lock during the busy wait unnecessarily increases contention and extends the time with interrupts disabled. Signed-off-by: Ankit Soni Reviewed-by: Vasant Hegde Signed-off-by: Joerg Roedel (cherry picked from commit d2a0cac10597068567d336e85fa3cbdbe8ca62bf) https://virtuozzo.atlassian.net/browse/VSTOR-154424 Feature: fix ms/iommu Signed-off-by: Denis V. Lunev --- drivers/iommu/amd/iommu.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c index 7c502c7d514e..00608e55e70c 100644 --- a/drivers/iommu/amd/iommu.c +++ b/drivers/iommu/amd/iommu.c @@ -1161,7 +1161,12 @@ static int wait_on_sem(struct amd_iommu *iommu, u64 data) { int i = 0; - while (*iommu->cmd_sem != data && i < LOOP_TIMEOUT) { + /* + * cmd_sem holds a monotonically non-decreasing completion sequence + * number. + */ + while ((__s64)(READ_ONCE(*iommu->cmd_sem) - data) < 0 && + i < LOOP_TIMEOUT) { udelay(1); i += 1; } @@ -1406,14 +1411,13 @@ static int iommu_completion_wait(struct amd_iommu *iommu) raw_spin_lock_irqsave(&iommu->lock, flags); ret = __iommu_queue_command_sync(iommu, &cmd, false); + raw_spin_unlock_irqrestore(&iommu->lock, flags); + if (ret) - goto out_unlock; + return ret; ret = wait_on_sem(iommu, data); -out_unlock: - raw_spin_unlock_irqrestore(&iommu->lock, flags); - return ret; } @@ -3094,13 +3098,18 @@ static void iommu_flush_irt_and_complete(struct amd_iommu *iommu, u16 devid) raw_spin_lock_irqsave(&iommu->lock, flags); ret = __iommu_queue_command_sync(iommu, &cmd, true); if (ret) - goto out; + goto out_err; ret = __iommu_queue_command_sync(iommu, &cmd2, false); if (ret) - goto out; + goto out_err; + raw_spin_unlock_irqrestore(&iommu->lock, flags); + wait_on_sem(iommu, data); -out: + return; + +out_err: raw_spin_unlock_irqrestore(&iommu->lock, flags); + return; } static inline u8 iommu_get_int_tablen(struct iommu_dev_data *dev_data) -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel