From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A933C8017D for ; Wed, 11 Nov 2026 20:37:10 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABKZl32030931; Wed, 11 Nov 2026 23:35:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABKZl32030931 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ceDEJm3R" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABKZY26030905 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 11 Nov 2026 23:35:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABKZY26030905 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-49166c8a60dso2546278f8f.0 for ; Wed, 11 Nov 2026 12:35:34 -0800 (PST) X-Gm-Message-State: APuU4Z9YGvGtL60nfJnf4rQ+aH6k22tWoTXkx6H6vJIToP3Xg4/nV8si L5ifrlJNCJmqEzIew6xoBvGgud7gcn0ATo3fxj6Cef7AnbQ07y+Raio+NX3wZop7TFAPR+pWmIi XuAkayk3UISCjHYt4TXyuDEJ4NntzJ6aVKe5ueApvKrzz+X8hSfvdbA== X-Gm-Gg: AYBFou1+FkCgFeDsD4XVamFJ097h+O/NJ28Psjp0YN2KhcvHiwItTi+TEEk4SR0l64e kDGMk0PYuoF9XtSkFYG8AbIwllAI2SAC+9IYOdTY3mujUSaVRAPqSKvZH/Azd7PUM9ovT48azC/ 45DVY5SitOlSr5yjn87MAkbuwVn8YyYPbwkXKZrtqOjIbJYzLKedXNBPcgijY+8+P51llzaEznN c7JTroI9ZtihiZFFqfkir8H4TnNMQCkFlMxt6Y4JesPo9N11McYWuoVGfFMPF68GVT+NbeRdCfm lWjHlCCiQp4+7X7oKNU1QDlj4SztDxiOzyHjjBBRq5KtrvBKScfO0FwhtY+q+MY5SYpKHskxUlk oi4rf0sd0MnMSB6jb0IAeTl72WQ== X-Received: by 2002:a05:6000:2007:b0:490:1358:2265 with SMTP id ffacd0b85a97d-499c80de903mr6091180f8f.34.1794429334206; Wed, 11 Nov 2026 12:35:34 -0800 (PST) X-Received: by 2002:a05:6000:2007:b0:490:1358:2265 with SMTP id ffacd0b85a97d-499c80de903mr6091158f8f.34.1794429333753; Wed, 11 Nov 2026 12:35:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794429333; cv=none; d=google.com; s=arc-20260327; b=Q2EbsxGbMbamae33Hn3NH05TwKtavVhuvMWFHk3wwpm86fQ34CdktpRQfM9xSc2mI4 P5nER7ODJK7XsGwJ79hPk/hpdSwH/Y7L2NxBLNxE1Ju0wN4N6213rsmuMgekLZuBEnLb rEMmQt6qVaBz3xlYAZuaeYpIAoRW9CebxpaJ+14e0NySREg695V8nQ93dMgXZVJwiS3i qmdTSMl3b3SRdfkBjZobhOE/Wy1CkilwfYgCn8HJDZdpfkRdQLdZFNm3on3+qRNKbv7a 3W1xmHuIfC9R+FQjebJhmfH9xnODGrmaal0krVEp5B0Hfb+tNJvIUJC1im5tNay5p25V a0Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ldDWy/FMpodnYxcgIFYkCoaO9wfLeS0Md77PowLrMFk=; fh=WpT6aB7RBAGHZeWZzqAr71yzRFbPTYkPWKsRagLn48Q=; b=rvYbDhdzbO/MSTNqg9EjzOQn2hfAZQ58BPyhL4AuzJZUPmYvC7Cgv+Z6vgN1+soZRz R+9o9KQWX9NNZT8br4YgSIX/Rb7cN3RqNtTVMvFPQQ8aF6JtglHnMOupRQHShf02SF1l qiAlZcdcOlYCimENKxA5/veoPGcsgSqL+zswhN0k8iEXttmjfLNYvDCzLsSsZB49WORy fa0WuNk3YqFgtHRIz2l5C28IJesIPdLfKXnFoisckA30qrd9gkCTh7urJTNEiRKl1wYk u4UrR+dWp8d//3hp6zFRNObyf2+AEQnyeTzUDvynsd9LR1oDfnI9k0/35bdXfaYr6RPY FlIw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ceDEJm3R; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49837ccc116si12681703f8f.426.2026.11.11.12.35.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 12:35:33 -0800 (PST) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=ceDEJm3R; spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=ldDWy/FMpodnYxcgIFYkCoaO9wfLeS0Md77PowLrMFk=; b=ceDEJm3R6M4h 7OESs05oVBKu4w1eNHlf4sbarkroVjz9ts4fsCRaREOFqhDVp9Tp/flc7LwXte8rS5NcdIsMo+74H N6+GaAjZYZO6F9JsG/HT+MB5TUFBrf0/DYHioxlms7b/VwT9SA6nEShSVpiYM4w9lBcq6kTI5fq36 DFYwRktIzdR62sPm4CDZCb2TfDumiQS3ipTPsoySyW/UL5QfIJsByjyqTDbgNBRw/TeZ3gRUUHy5x wOZ1p5BnSuwRDMRu3j8y6zSMqVy/6Xk7RPMyOUdKKuRf8HIrQlmBrs/VXRBtiEmeBd1dMk8Tl0qW5 thkib7T9/02ZXwKy7l0Ryg==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=LekKit-T14) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xREyT-00Fgix-1h; Wed, 11 Nov 2026 21:35:32 +0100 From: Eva Kurchatova To: khorenko@virtuozzo.com Date: Wed, 11 Nov 2026 22:34:17 +0200 Message-ID: <20261111203529.363554-2-eva.kurchatova@virtuozzo.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261111203529.363554-1-eva.kurchatova@virtuozzo.com> References: <20261111203529.363554-1-eva.kurchatova@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 1/4] ms/eventfs: Fix use-after-free in eventfs_remove_rec() X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org From: Shuangpeng Bai eventfs_remove_rec() recursively removes the child at the current loop position. After the recursive call returns, list_for_each_entry() advances by reading list.next from the removed child. If free_ei() drops the final reference, release_ei() reuses the list/rcu union to queue an SRCU callback. The child may be freed before that read. The eventfs_mutex serializes list updates, but it does not keep the removed child alive or prevent the SRCU callback from running. Use list_for_each_entry_safe() to save the next sibling before recursively removing the current child. Cc: stable@vger.kernel.org Fixes: 43aa6f97c2d0 ("eventfs: Get rid of dentry pointers without refcounts") Link: https://patch.msgid.link/20260806022719.375354-1-shuangpeng.kernel@gmail.com Signed-off-by: Shuangpeng Bai Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (cherry picked from commit fd73b691702170d37d66f4b0278530cea8ed419a) https://virtuozzo.atlassian.net/browse/VSTOR-154529 Feature: fix ms/tracefs Signed-off-by: Eva Kurchatova --- fs/tracefs/event_inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index ce61795a7ed5..cc08218d6e26 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -848,7 +848,7 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry */ static void eventfs_remove_rec(struct eventfs_inode *ei, int level) { - struct eventfs_inode *ei_child; + struct eventfs_inode *ei_child, *tmp; /* * Check recursion depth. It should never be greater than 3: @@ -861,7 +861,7 @@ static void eventfs_remove_rec(struct eventfs_inode *ei, int level) return; /* search for nested folders or files */ - list_for_each_entry(ei_child, &ei->children, list) + list_for_each_entry_safe(ei_child, tmp, &ei->children, list) eventfs_remove_rec(ei_child, level + 1); list_del_rcu(&ei->list); -- 2.56.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel