From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B5E7C803BB for ; Thu, 12 Nov 2026 11:18:02 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACBGgal008189; Thu, 12 Nov 2026 14:16:43 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACBGgal008189 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="sc+CvwAg" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACBGaum008166 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 14:16:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACBGaum008166 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a77c1cbd15so33541725e9.0 for ; Thu, 12 Nov 2026 03:16:36 -0800 (PST) X-Gm-Message-State: APuU4Z/wn+yULx9bEm5umIY0/nq8B6kCTg2XT7oAbThVli4VIox3oiYs Anj/gvJKHwdlzEdQAxV6pHwgrEXeTP3TJ1rs9y+bWQ4+5K0o7zoPD9rW31XkaaWPi8N17YS89SV MiBkGY7fzMJCCmLBllr4asGzexibClK5LzvB+dfUKzpYW4sfOLItYMA== X-Gm-Gg: AYBFou3gf+vXopG9BnQoiPanxAvcdPTlsO8DNXYLkYsXCY0GmzfKRujUJDkQ8TNaEuA VcprlyosJVM37vUB2QS7JfBvnvH98TYMW3m8z3iXVgfWhxVI0mXT6BocKLDTaM+KXbkF6IobP5I v9eTQKvsu1f7ZteCq4VfMVSkNG3p+eRn+fMUCS40arIpTIZS15HXaH0BnlYfYbwag5JDimKtzPN BKWI+ZvqDSpZhEqK+8VYZcpvnNazxavkaaDo+3YvP1dQCIFovwu4W2MG91snw5y3Ja8iTP2GlyH DGppdgaRuFWIqCM27dyYCaj21/4qMV62bO69KNlL+MEmwVFvNzSLtQpUj0z3tzwk81rmStN1L5n jTVjU6znYJRy8FSC2JXlhVHGW+tvHLw== X-Received: by 2002:a05:600c:6218:b0:4a2:1a:a116 with SMTP id 5b1f17b1804b1-4ba091a73f1mr98099565e9.0.1794482196354; Thu, 12 Nov 2026 03:16:36 -0800 (PST) X-Received: by 2002:a05:600c:6218:b0:4a2:1a:a116 with SMTP id 5b1f17b1804b1-4ba091a73f1mr98098985e9.0.1794482195897; Thu, 12 Nov 2026 03:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794482195; cv=none; d=google.com; s=arc-20260327; b=ZcXdLNBgrME0t7T55oIz0K/36SZZhDPNSX3LUDRXomiPYuzFM1NtTIMriIdYzmKewA 496pC+v+hJVxGew4aTbkl4JxtKxrjInwTazMFudG4YH7+JqCezL5gWPRW7DMyQtfvoor AghRDXCUqR3v9bPTPHKbr/0PgwoF57Ql3shDQqLXfyxwhZr7nAXp0KTzjpLwg7qAkzYq IDjiRfrskIaPjk+WpUmLjWIa1OVr8IvQeDBnYHmqMu3+DSGHAISPTpghBJAajma3a0Gh LxSCXKA8uOFTHkN+8M0d0wON3+1RVTl1M7LRK8JX8I2tiU64RwoKwsi6W5yCAd8pfFPn h00Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=ry1UD11BuMOTzEqXUyy+XVKVy5SPHIbcFGAfqKnyDv0=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=iCLul2r+vLKYJPlgMnVSNzAREVMSfMes8M7iunLJ/vVD9ql9ImzhTR6zs4Q5TpQdqk bgWSJBaFRfJMlKK/42KQMy/ydPE1qKxGqJQGW7ULmPoyaWPLXylKS/LX53BRoL9qnhVz zmIWRgyLk8bUb11MMSPVifM2BEtG81dbYZjdhe8CtZctTgPhaoy2xmWFkQ8mDnyCx2IE tsQfLKIN3UZU7wLiFk18qZ1JN6On2OJzsUjd+1C+6q+jP2K7BbyULGm58DnQsC9aE0wY xHhkUZdvskP1yPIon2ECBFRkAt/EJY6kmFRe2OcHLl1V3Iv7iMY7HAtnnv6LrkY1MWJx VsqA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sc+CvwAg; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49837bd7a2dsi15426508f8f.425.2026.11.12.03.16.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 03:16:35 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=sc+CvwAg; spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=ry1UD11BuMOTzEqXUyy+XVKVy5SPHIbcFGAfqKnyDv0=; b=sc+CvwAgor7A ZHWrSIrIxFYK4X/P7gsXq/t88SbSyagoz6HSP66dfGNs/1B0m4zpKhI6tnXy5xpISuYvBODrVlPF+ ijIgG25OKCF42rIJ8A8hwWsUtYPN1ujE/HlnZPh5iIytDzSLbvTFrT+2KpPs/nKsrEpbaKF12cSRa 2lGr5nhkzBPcnpK2ZJbMiGf0XbQSyrQqerCvpc2BISMAdrpO9ORTDPdSZkx1SpIQTiX/RcSCqKMcG MzlLPTH7FM+ctLATrhWX31ChJvnE8XMK886nLKn9ZZNzjlDYGEuvbWTcLC0e+JWrwari8gXDH9pbN S0ernsXbd9Gmgp47G6m3+w==; Received: from [130.117.225.5] (helo=vz9-demens-1.aci.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xRSj4-00EzHk-2A; Thu, 12 Nov 2026 12:16:33 +0100 From: Andrey Zhadchenko To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com Date: Thu, 12 Nov 2026 14:12:02 +0300 Message-ID: <20261112111205.736027-1-andrey.zhadchenko@virtuozzo.com> X-Mailer: git-send-email 2.43.5 MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 0/3] dm-qcow2: do not free a discarded cluster under in-flight writes X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org A discard unmapping a cluster locks its L2 index, so requests coming later wait until the discard is finished. But a data write, which has resolved the index before it was locked, may still be in flight when the discard drops the cluster refcount in process_indexes_end(). If the cluster is allocated again before this write lands, the write corrupts the data or the metadata of the new owner. Make such a discard wait for these writes before the cluster is freed: Patch 1 counts in-flight data writes per L2 page in two generations. Nobody reads the counters yet, so there is no functional change. Patch 2 is the fix. The discard switches the generation of its L2 page and waits for the previous one to drain right before the refcount is dropped. Writes submitted after the switch are counted separately, so the wait is bounded by the writes already in flight. Patch 3 is an optimisation. Discards of clusters mapped by one L2 page usually come to process_indexes_end() in one batch. Let them wait for the same generation together instead of one by one. https://virtuozzo.atlassian.net/browse/VSTOR-154659 Andrey Zhadchenko (3): dm-qcow2: count in-flight data writes per L2 page dm-qcow2: wait for in-flight writes before freeing a discarded cluster dm-qcow2: let discards of one L2 page wait for in-flight writes together drivers/md/dm-qcow2-map.c | 118 +++++++++++++++++++++++++++++++++++ drivers/md/dm-qcow2-target.c | 6 ++ drivers/md/dm-qcow2.h | 12 ++++ 3 files changed, 136 insertions(+) -- 2.43.5 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel