From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 217438017D for ; Sun, 15 Nov 2026 10:30:36 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AFASK46010632; Sun, 15 Nov 2026 13:28:21 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AFASK46010632 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="YXZMCS9u" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AFASF83010613 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sun, 15 Nov 2026 13:28:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AFASF83010613 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490d2ac331bso2222693f8f.0 for ; Sun, 15 Nov 2026 02:28:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHF5Vnl8yn2PclKGzFYdblgP8AsTXPPnvSw98SCSga5aCS6BoeFTmLsBLyLZTgzQRy3CEEKYA==@openvz.org X-Gm-Message-State: APuU4Z8cYN2Sod/sqcdjynNUeZHw+EFPkYr+LUUDFJeGI4JohTHtHp9a FdUvzSRO/pBGmrjPO2MgRe9atj3i0xgBcR4K8V8oa/urrfmOwicrzRHzLLlXp5YDAE9k6zczUW+ A7chF08slah180LGwp+WtCsyT5+NTmQR4wA6B9qS1jEJalj5eOUb8BQ== X-Gm-Gg: AYBFou111mTBSOzgZhpPyf5R8Y+ATel1yRS6RA6Bk1zCGwRtdIMk6Kq+KgEZXL9Zozf XoIbHd/tlgiFQDKmjTGIIdm4p2Mg0iSB3VeFwv9A33vPkmdiXsICatoJ+gsZHLBskYHxZCjgUoQ TOwMuw4PVKXyW/Dc1jYLTajp3oL7V/OeWAhygiDBI0NGnnu5kiLRDoQRqPIGj0+noZcxVsWvG6C Q/lvqyNB7kouJ2rwt19uBbbBUhnueBg/GofqEgrfn+ta1spmwlTVpBGUmiVDo81+jsfprx6zaFE /7St/iUt3VtONGcri4TWmcFIk71akQcWxH6ETl4xELcEbKiQdmv5au1EnFRpOmby3ulw0MrK7tR O0sDAY/V7tdq/erqNWdp41bVpKfQ= X-Received: by 2002:a05:6000:428a:b0:491:8462:20be with SMTP id ffacd0b85a97d-49c70de380emr17486830f8f.12.1794738494762; Sun, 15 Nov 2026 02:28:14 -0800 (PST) X-Received: by 2002:a05:6000:428a:b0:491:8462:20be with SMTP id ffacd0b85a97d-49c70de380emr17486799f8f.12.1794738494236; Sun, 15 Nov 2026 02:28:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794738494; cv=none; d=google.com; s=arc-20260327; b=WYqTb71zZfgEdJmF+TpFbQy6+jV9E1OdmewvFGUPLwTKlpqaQEivH8ruopBzq6fSA3 /jnGEX000tbyfGbUP98nQux8LNIquw0hZAobzhEFUCXRTSroK7eYHKqCKLVJhbS50SOu r8Ag2Oc9QVbQnKM1zRAgRioXcrfVANDnGgu7lX2sT4aSlg6+RAb6yoHJXwBlOdaDfjtK YL4hHF42+oMG0YC3Cmsniue5GGMHGGgUYfQcbz0kIp6K/xRQP+mmR7mKcIpFkOjr6m+f G91XAX4y6eLdVxsKAb6r4VbVCbaMEDoQXdGlYPdeiDRYZzqT0JdyS7b8fy3eEeG0kdWR G/fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Awo1a8PIlNnQaNWLl2KBHeU8ZXrgGPcKhr+LhiOBjSI=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=inWzrszM3RQ9+SqtMTQqWGbSh5StAwmKrxT0snmh/qermTJOC4feP40Qz84Ao51c3/ pRvO1ulH/9HuoJuORzmKCmMrC7oQvvMgmLN6P7lTk3pl4LSC6rJ8T1BeIpUSDCWY00FB /mL8Xr8Tsu4warurIyfPLAaNcv+XEMcJjbp1vGfQEhdodCVSQRlphZWlK2l/TyMCkq4z dQ1cd7ms8YoxxoHVzyfa3SriN3Tnpoj/Jk1WJ5AALk6nuxJ2P+HeKLBiudntO+gUAtp5 dPlKZQVHsniNMCPoWLPYWphfQL+Ilan99fn8+L11gQOaCnAgvHs8dMyjQ70dkl79MQx7 S7lw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=YXZMCS9u; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c636edc3dsi15498116f8f.190.2026.11.15.02.28.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2026 02:28:14 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=YXZMCS9u; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=Awo1a8PIlNnQaNWLl2KBHeU8ZXrgGPcKhr+LhiOBjSI=; b=YXZMCS9uIzPp yzbA81iXsFse/xIpkyrhfwSEcPl/h16dSUnn+HPiQGzMiW2YYPoL6BGpk4iN/j6ERQRHVHkDY08kf YXuYBJkdUVtRz1qs6x09XKXU267p/rJshoTB8GraAjvFwYMVfYrFWZ+jYgWctPAp0pnaQP4h7j7Ch oRZj/Wuqn8VlY16hRPfMU9PNyUplPHBzx7IZPixWUK43i1pcWTKYsff37iWhotEO3yHxHnAXZqp3T pMN7f3KQCzX2ZL0TI5sd6lXMnrs2YQso5mX0oQftQG7MP8lwH6WD6zfgRi08fzvRvCGTAhxeRXtxv 9jw42Qx3JTCfqtdZMbn0fw==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xSXOq-007tix-23; Sun, 15 Nov 2026 11:28:07 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Sun, 15 Nov 2026 11:28:10 +0100 Message-ID: <20261115102811.2745757-2-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261115102811.2745757-1-alexander.ivanov@virtuozzo.com> References: <20261115102811.2745757-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v2 1/2] drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org vhost_set_workers() and vhost_propagate_workers() store workers into vq->worker directly, bypassing __vhost_vq_attach_worker(). The workers they install keep attachment_cnt at 0, and the default worker keeps counting every vq. VHOST_FREE_WORKER then destroys a worker a virtqueue still points at, and the next vhost_vq_work_queue() on that vq is a use-after-free. VHOST_ATTACH_VRING_WORKER on such a vq drives attachment_cnt of its worker to -1. vhost-scsi already exposes both interfaces to the device owner. Attach the workers with __vhost_vq_attach_worker(), so VHOST_FREE_WORKER fails with -EBUSY while a vq uses the worker and both interfaces can coexist until userspace moves to the worker ioctls. Userspace issues VHOST_SET_NWORKERS before VHOST_SET_VRING_KICK, so the attach takes the path without synchronize_rcu() and VM startup is not slowed down. https://virtuozzo.atlassian.net/browse/VSTOR-107537 Feature: vhost-blk: in-kernel accelerator for virtio-blk guests Signed-off-by: Alexander Ivanov --- drivers/vhost/vhost.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 1057ba7e3fc7..5092eed75b8f 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -1094,7 +1094,11 @@ static void vhost_propagate_workers(struct vhost_dev *dev, int nworkers) int i, j = 0; for (i = nworkers; i < dev->nvqs; i++) { - dev->vqs[i]->worker = dev->vqs[j]->worker; + struct vhost_worker *worker; + + worker = rcu_dereference_check(dev->vqs[j]->worker, + lockdep_is_held(&dev->mutex)); + __vhost_vq_attach_worker(dev->vqs[i], worker); if (++j >= nworkers) j = 0; } @@ -1117,7 +1121,7 @@ static int vhost_set_workers(struct vhost_dev *dev, int n) ret = -ENOMEM; break; } - dev->vqs[i]->worker = worker; + __vhost_vq_attach_worker(dev->vqs[i], worker); } vhost_propagate_workers(dev, i); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel