From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 63D108017D for ; Mon, 16 Nov 2026 16:07:38 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGG6NLI027995; Mon, 16 Nov 2026 19:06:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGG6NLI027995 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="YgU2owmW" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGG6A6K027953 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 19:06:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGG6A6K027953 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a35db2d6b3so23305765e9.3 for ; Mon, 16 Nov 2026 08:06:11 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErG5WsJsL1SmwEC82ZfP7kCdAxbTeYEXBDxOFYizYpzt2qcuyHX4r99O+XCbzhWNR+gU65GKDw==@openvz.org X-Gm-Message-State: APuU4Z+c0qjuDc6S404o7OGwmiHwq9TGak1667BgJ6ntotCbTFo3fVeU LP/S1i4CqkwRpAq16z1A/tX2JMUgb3rprp+zSRIEAKCSs2qPo7RlrKw+y69s6UdVIBVPXiqFZ7I AY1lZF4uObUSCJ308iRU23Tz0ovGqfB0HeRBqVCLyhsqp+euG3GLUSA== X-Gm-Gg: AYBFou13Y00zagORAubCq6TjPThBKPhtzzm1TAIXCbk0iIyHkBepq55qUcGGTnk8Q+e IdvjKBmgVKI34thzWZqnTsYmuFlFZaXT+HFswLjXDhVtomC+JeK9BE02DCCFGryEx2z0UuiKe8+ 11s8UM3ed0LkeaBqnITtF3k9QDfrW7+zxQjV9FPH1ZC7wiegLMCucwxSfZqJP4mSuq4N804fwZP K5h3k8YY9YLNz+0MaBoVhtSzkxahZpcp7DNTQ76JJA/KM9O3gZkO2AjvCr0tx694H9yOgUiAMsY rU6HyYlLbdvV11hUWXUmJ87btpUcRpawkM17AzDhjgVfDywFKbdau5uc0BPqgwe7nUZvpgmBagk IvWCLTGak+O0jzydPEdDmU6Sq3VLumg== X-Received: by 2002:a05:600c:3b29:b0:4bb:6519:477e with SMTP id 5b1f17b1804b1-4bb65194d7cmr170135565e9.17.1794845169229; Mon, 16 Nov 2026 08:06:09 -0800 (PST) X-Received: by 2002:a05:600c:3b29:b0:4bb:6519:477e with SMTP id 5b1f17b1804b1-4bb65194d7cmr170134955e9.17.1794845168776; Mon, 16 Nov 2026 08:06:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794845168; cv=none; d=google.com; s=arc-20260327; b=nwKbpAcfGQ/IH9QzBAMQHUBec22KZDMM4Tk0wDSXvHzBXVPno6zvDuTa7fNhQ02tua hqN1stL9vo3jRB4QJa+maPWeV+HdZUBirFRWHTtj+Zik2s/0FnP2+uyHO8Uz/IRCdESh j2d7LDvRsIbAP2ia9l306dOqsfMV3J0QpQFKLAGLROE9wzoEH6798ydeCPTCi214CMp7 Nk3uELJ3B6CWdnX234sO8+eZIsEduwnHNOiDBgBBE3i1zojF1DlpjNsok4cUxU1X8rqV 81TkWToaWdHobNNYrj3iXVBTz6X+eaqfJGvKkGE9jBwjrm6OWmmizcL/mzmCkfQZA1IN 2Utw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:dkim-signature; bh=/AA3N2fMdSL0h63+gKNY/OQQ2hnmOM+l8jaCTXMjpJA=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=igwfuAT3VpaLRZuR6v0RE9uFl+H4pi5qXhCVOikp7eDtZuHPN6Mx9cWY6zgbj8JwRD 4hdLfokNWlu7HtuloswrZrgs/2ZntI93FzZpYAg/X30Aqy1hOYxFgnIeyDiItxVbAuNe MAwWIghaY6RsVJHdJWTVvDrw4Se2UPaFdYAfi0UWC++qjzgElBI0YOFlcxZuIwglQ3w1 ME00HtyoDhPeM2RqjuNjEXHMJUk679uHywAmDz0JEup8fZm1TWYBqaYKmqKN9IE1YbAv 1TtDqp3K836povaio4cQ0pWA3n8RLDqs5LC6IuAxkq47TnOehDsFNq/asSEJJLv6VGjP ziVg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=YgU2owmW; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6417804fsi23010839f8f.278.2026.11.16.08.06.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 08:06:08 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=YgU2owmW; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Message-Id:Date:Subject :From; bh=/AA3N2fMdSL0h63+gKNY/OQQ2hnmOM+l8jaCTXMjpJA=; b=YgU2owmWjRYI6cYJTE3 75uDCwgdr9akhigjM6/iP10dClrIPJ1iDlWNn3hTDyCh1W4sbS0fEh80QgReyu0G2Nwk8whQ7bgQs TopFg+iIIDCqkMLnm9MsaUXHGKveIE1W9h/imTNTNSW851I2o7ecLgIO2x63lAuYA73C+wpBm0eo/ rml7stcaG7v82RadcQYi34jv9Uprc0CgDHUmUNNW0f0IOe2vmKRS3MDDjJMQVggpQMA2sxT1uOSkr 4fSgRgINH/038IyDmtTtlGwtqjvq9JB8rGoNbITjzHP5Je1ZSlAsHs4PGf1e174HLWQ/NZzZoIPiO jGgV8KXuKz+/UAA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xSz9N-006Mia-05; Mon, 16 Nov 2026 17:05:59 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 17:06:00 +0100 Message-Id: <20261116-ovl-use-orig-ve-v6-0-7cfb41c8c973@virtuozzo.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAOgp+2oC/23NTW7DIBAF4KtErEsEw09wVr1HlIUZcEzVhgps1 Cby3YvdRa3am5FG8+Z7T5J9Cj6T8+FJki8hh3ivi345EOzb+83T4OpOgIFmDTc0lnc6Zk9jCjd aPAWHQqvmpGuC1K/P5LvwtYgX0mOg5sjJ9feQR/vmcZi9OdqHPMT0vXQXvjzMNZwBbGoKp4y61 khkDA3T6rWENIzx8YhHjB9LQ4G1obcGVMO3VhnbITTY7hniz+BMbA1RjdY5JgHrNKc9Q66NZmv IahjjtZJGOlR2z1Arg7OtoarRiQ6ss9B4EP+NaZp+AKu5oJXdAQAA X-Change-ID: 20260918-ovl-use-orig-ve-2dc365976202 To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 0/5] Fix kernel crash in overlayfs X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org When testing CRIU with containers with docker images, we found an easily reproducible kernel crash: [ 2300.870181] BUG: kernel NULL pointer dereference, address: 0000000000000005 [ 2300.871537] #PF: supervisor read access in kernel mode [ 2300.872577] #PF: error_code(0x0000) - not-present page [ 2300.873595] PGD 800000010a18f067 P4D 800000010a18f067 PUD 10730c067 PMD 0 [ 2300.874900] Oops: Oops: 0000 [#1] SMP PTI [ 2300.875742] CPU: 1 UID: 0 PID: 5419 Comm: criu ve: 0 Kdump: loaded Not tainted 6.12.0-211.39.1.16.6.vz10.x86_64 #1 16.6 PREEMPT(voluntary) [ 2300.878057] Hardware name: Acronis OpenStack Compute/Virtuozzo, BIOS 1.16.1-1.vz9.2 04/01/2014 [ 2300.879684] RIP: 0010:ovl_get_index_name_fh+0x18/0x70 [overlay] [ 2300.880859] Code: ... [ 2300.884128] RSP: 0018:ffffd32582e0f7c0 EFLAGS: 00010246 [ 2300.895807] Call Trace: [ 2300.896397] [ 2300.904435] ovl_create_index+0x82/0x260 [overlay] [ 2300.905406] ovl_copy_up_workdir+0x30a/0x330 [overlay] [ 2300.906427] ovl_do_copy_up+0x10d/0x2e0 [overlay] [ 2300.907387] ovl_copy_up_one+0x456/0x720 [overlay] [ 2300.910736] ovl_copy_up_flags+0x81/0x110 [overlay] [ 2300.911740] ovl_create_object+0x51/0x130 [overlay] [ 2300.912719] vfs_mkdir+0x194/0x250 [ 2300.913470] do_mkdirat+0x14c/0x180 [ 2300.914223] __x64_sys_mkdir+0x46/0x70 [ 2300.915019] do_syscall_64+0x7d/0x160 [ 2300.922814] entry_SYSCALL_64_after_hwframe+0x76/0x7e The cause is that overlayfs does some feature checks on superblock creation using capable/ve_capable and it stores current credentials. But ve_capable check result depends on both current creds and current VE. Later, overlayfs switches credentials only, leading to unexpected feature disappearance. 1. Patch 1 removes separate STOPPED state - VE goes directly to DEAD. 2. Patch 2 adds helpers for overriding tasks VE. 3. Patch 3 delays ve cred drop until final destruction of VE. 4. Patch 4 adds VE owner to overlay superblock. 5. Patch 5 fixes the bug by switching VE together with creds in overlayfs. As a side effect of this series - CT1 overlayfs mounts won't work in CT2 and this is a good thing. There's still a gap - creds may be overrided in other places and we should handle them - a separate VSTOR-155347 task is for it. https://virtuozzo.atlassian.net/browse/VSTOR-143259 - non-CRIU repro https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- Changes in v6: - Fixed various typos spotted by Kostya. - Updated comments in commit messages and code. - Rebased on rh10-6.12.0-211.75.1.24.1.vz10, overlayfs got one more place with creds override ovl_copyfile. - Patch 2: helper always returns -EPERM for non-host switches. - Patch 5: CT -> Host switch is handled by overlayfs now, code updated with Kostya's suggestions. - Link to v5: http://lore.virtuozzo.com/20261110-ovl-use-orig-ve-v5-0-f3f2bdb29e23@virtuozzo.com Changes in v5: - Patch 2: report non-host VE changes, also treat VEx -> VE0 and VEx -> VEy differently. VEx -> VE0 might be allowed, VEx -> VEy - never. Replaced most WARN_ON with normal warnings or WARN_ON_ONCE. - Patch 3: updated commit name. - Patch 5: allow VEx -> VE0 case. Now creds are switched without VE. - Link to v4: http://lore.virtuozzo.com/20261109-ovl-use-orig-ve-v4-0-88e65484dc5b@virtuozzo.com Changes in v4: - Patch 2: clean non-NULL overrided_ve in fork and report it, Report revert_ve(ERR_PTR) usages and reject them. - Patch 5: changed ovl_override_creds signature so it returns error. Added checks for it in all places to avoid. - Link to v3: http://lore.virtuozzo.com/20261103-ovl-use-orig-ve-v3-0-add042cdd087@virtuozzo.com Changes in v3: - Patch 2: added a separate field for ve_override to fix problems Pasha spotted. - Patch 3: new one, delays init_cred destroy so dead CT can still use it. - Link to v2: http://lore.virtuozzo.com/20261026-ovl-use-orig-ve-v2-0-eab58bfc29ca@virtuozzo.com Changes in v2: - Patch 1: updated description as Sashiko suggested.. - Patch 2: moved stubs outside CONFIG_X86 section, added task_lock protection in helpers. Verified via lockdep, no splats after vzctl tests, C/R and crash reproducer. - Patch 4: fixed typo in comment. - Link to v1: http://lore.virtuozzo.com/20261022-ovl-use-orig-ve-v1-0-da84c00c8065@virtuozzo.com --- Vladimir Riabchun (5): ve: Remove STOPPED state ve: Introduce override_ve/revert_ve helpers ve: Defer ve creds drop until ve is completely destroyed ovl: Keep creator VE in overlayfs superblock ve/overlayfs: Override VE together with creds fs/overlayfs/copy_up.c | 6 ++-- fs/overlayfs/dir.c | 59 ++++++++++++++++++------------ fs/overlayfs/file.c | 71 +++++++++++++++++++++--------------- fs/overlayfs/inode.c | 94 +++++++++++++++++++++++++++++++----------------- fs/overlayfs/namei.c | 39 +++++++++++++------- fs/overlayfs/overlayfs.h | 10 +++++- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/params.c | 3 ++ fs/overlayfs/readdir.c | 36 ++++++++++++------- fs/overlayfs/super.c | 3 ++ fs/overlayfs/util.c | 52 ++++++++++++++++++++++----- fs/overlayfs/xattrs.c | 35 +++++++++++------- include/linux/sched.h | 1 + include/linux/ve.h | 34 ++++++++++++++++-- kernel/capability.c | 10 +++--- kernel/fork.c | 2 ++ kernel/ve/ve.c | 10 +++--- 17 files changed, 322 insertions(+), 144 deletions(-) --- base-commit: 7f638aced7fd165f1a711b8bbd90f63ffaa8dd9e change-id: 20260918-ovl-use-orig-ve-2dc365976202 Best regards, -- Vladimir Riabchun _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel