From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 750CB803BB for ; Mon, 16 Nov 2026 16:07:29 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGG6Ii9027981; Mon, 16 Nov 2026 19:06:19 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGG6Ii9027981 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="IW9OfVd+" Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGG6AZU027943 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 19:06:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGG6AZU027943 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48e0461e040so3198573f8f.0 for ; Mon, 16 Nov 2026 08:06:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErH4Wl838bsWCpE3jx/IjhsJG3EGD3DwxaG63pSIE0ozqTWWqrUVfr8FgcJKMAncVP4mwZ3OJg==@openvz.org X-Gm-Message-State: APuU4Z/exhovy/VQXnJqY3qi6rdVppRTF8LZi05AXNycKbdGCm4W8BPW gIWFaI/Z4dbdf/JdbghVBoMqKjdCJ22AZI8npKzC9WnwvxEddJxSdmTLjenZqOxeZnwwGTFkQ02 4/ydei4WDAHYfHpES1uj3nv5ouU6LVDq1OrQZRHXvU2h1ska2ySs80g== X-Gm-Gg: AYBFou2Cf/l+z+aa07MVx1wEitqFbhiQncBSFiG+b9LT27NHKdq21b6JXgLNRb08dpj LOTc8G9J9FrQboNyrZoc7V6QBdZPtOy2jkFrZ809WLonVptgyynShvpOKTW/6MY413+fdGcJVFK Gitnf2SY+po/ucbt7N4P8zOwrOcEEv2EIRrPIkJgZhkHaazDhz3at22uAxz0kfAZrYDUcYR8DaA y2ALqaooPgZ1c3G2QCmuR/SLPU4OfqqhESWRIAS0rB+LEuam3JBhsQXTcA+5U6sVaLm/i+/islr s5bxJVMcniGPDzF/PBfluBQDdvYnXpyoJYYcCvEzb4Vpwviv/c6+Wes0/Ec1Ru1KFTZZZnu5Qsf 8Y5/adz8arihGd5K7skwbNXTBOP4O X-Received: by 2002:a05:600c:6308:b0:4b7:6942:39bf with SMTP id 5b1f17b1804b1-4bb55a68492mr251049495e9.28.1794845169917; Mon, 16 Nov 2026 08:06:09 -0800 (PST) X-Received: by 2002:a05:600c:6308:b0:4b7:6942:39bf with SMTP id 5b1f17b1804b1-4bb55a68492mr251048685e9.28.1794845169444; Mon, 16 Nov 2026 08:06:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794845169; cv=none; d=google.com; s=arc-20260327; b=YkYWTVqS+J7N2GMtUnCcyhURyTKU69+RTj+rjLHBZLz3M3e+c8IJCNClyQgn70xOsC ioD9pznKVAfJOaZ3EzfvxI0to9VldK3AxNzmnCROqqAilwJt7Utr6QYsGc98qPj3wjpP oujR9YagX88OfRXRysm4JAedgNZYu8Xm1F4sdpCVqbPZ/aXwljv28V+kwGN4YEqHJNDM tlau+6njRJpxasCTymHxCWRXqO32bVVTOBgA748gQKCVWfeKgfJXjZif8PmVbgklRhLL xh6t5ii9eRgCHdripXySdOGHli0De/L4elILujM4HKzupCtvl4wKNt+QA2uubHvAcYEB lpjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=i//1GG+ZxeheNj6Jr1SpRTRZyT6Ut3U40Ht2GuE9AeU=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=f4sgT0PFU67MzdPAxW27hNzkw10b2mGeJgaPUpqfe3ZKIdG3707SaucSB9GSgnG4OZ fPM9WeLb11+a4XrFnOKeLM6Be2inoQjhDb7AB1CjLcYUw54PBnxrdK0ZtQiiP4XUfWgI 21l33sCgGNz94TAogM8SGnO22lq3rMGoMPuj0RuNMwyEfqxq+mGTyx/gDQaadU0hcpYW FUkEQuRNmLOuPrtjaFiXsatLxQ3L6Njwt9OUjWVqs6o3aFNH4zoPaIMQ7SOZLdZyrQo/ KqTT84WXdtWYQ/KOOO1xPGPhAE1QJfTc8lFAppRFSsMF5fjLbCsr8Pq+m3dVhThhqOna vOtg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=IW9OfVd+; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c714a3553si22413441f8f.291.2026.11.16.08.06.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 08:06:09 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=IW9OfVd+; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=i//1GG+ZxeheNj6Jr1SpRTRZyT6Ut3U40Ht2GuE9AeU=; b=IW9OfVd+9mddctvoPov N1VcBknbGSCQwtU+Qn9nvGQPNJZkgHAn6gHcMjAYyKTW/Cg2Ln/vBwEr1n2+2RrdjhktrTDIsS7Bo sLmXMmpxM/3l7MWzYebnoxDEFYzXKESsulVf4iDVHnbuQMpBTWKpUXsEkeSm/Tsfc1AzkNCTFqE8K TF+pXgxsRd49AjO6iqaRkxLu2dKtPRBG9PjO5AGq3Xy/ka7MfeP/5Pcfsl1IzBMA6Xun4wl81QKSV qU6ddPQSsoW1SRxDeZzGxpnzJf139OF2wi4HxJS7NIb0mXNQ766xeKd4fZX7TJ5+W+h6/LOwZolER 9s3JUjQccyvcb/w==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xSz9N-006Mia-3B; Mon, 16 Nov 2026 17:06:00 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 17:06:03 +0100 MIME-Version: 1.0 Message-Id: <20261116-ovl-use-orig-ve-v6-3-7cfb41c8c973@virtuozzo.com> References: <20261116-ovl-use-orig-ve-v6-0-7cfb41c8c973@virtuozzo.com> In-Reply-To: <20261116-ovl-use-orig-ve-v6-0-7cfb41c8c973@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v6 3/5] ve: Defer ve creds drop until ve is completely destroyed X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org We may have a case, when VE is dead, but there are some users of it, overlayfs superblock for example. This user may want to use VE creds, so we need to keep ve->init_cred alive. Drop creds in ve_destroy. We need to drop ve_nsproxy early because ploop waits for refcount going to zero, dropping ve_nsproxy in destroy causes CT suspend/resume hangs. https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- kernel/capability.c | 4 ++-- kernel/ve/ve.c | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/capability.c b/kernel/capability.c index 6de4dcba2283..68c3d5288ba7 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -395,7 +395,7 @@ bool ve_capable(int cap) rcu_read_lock(); cred = ve->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; ret = ns_capable(cred->user_ns, cap); @@ -413,7 +413,7 @@ bool ve_capable_noaudit(int cap) rcu_read_lock(); cred = ve->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; ret = ns_capable_noaudit(cred->user_ns, cap); diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c index b3988a8d590f..1e0c092f080e 100644 --- a/kernel/ve/ve.c +++ b/kernel/ve/ve.c @@ -378,7 +378,10 @@ static void ve_drop_context(struct ve_struct *ve) rcu_assign_pointer(ve->ve_nsproxy, NULL); synchronize_rcu(); put_nsproxy(ve_nsproxy); +} +static void ve_drop_cred(struct ve_struct *ve) +{ put_cred(ve->init_cred); ve->init_cred = NULL; } @@ -929,6 +932,7 @@ static void ve_destroy(struct cgroup_subsys_state *css) { struct ve_struct *ve = css_to_ve(css); + ve_drop_cred(ve); free_ve_devmnts(ve); kmapset_unlink(&ve->sysfs_perms_key, &sysfs_ve_perms_set); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel