From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1BE0B817C6 for ; Mon, 16 Nov 2026 17:20:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHJAc5029331; Mon, 16 Nov 2026 20:19:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHJAc5029331 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="gabvxMwQ" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHIwsU029289 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:18:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHIwsU029289 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48e4d1e29f3so3581678f8f.3 for ; Mon, 16 Nov 2026 09:18:59 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGBy0Set3LmpQ/MT1lPnI4zNSeebBxySJHKrJ95YxEbHfus1o88oAq7amGZ5wyU7fUMj1tueQ==@openvz.org X-Gm-Message-State: APuU4Z//w/mVBEnHPQI8IzmCDmGoaVO2MWkNW+i157nzT0MykFubBK+3 L82SAUfZQ0AUL5u0+HqOwQiFIW0jDgOIc18YIlxguHnMtsXEdquvIE9Ucb0wnUG4KrUQk1Is2mr nWBHCDzGwkuR5LD2axzH9eL03nOg8ha2pai/kncJyIfa7pPrWW6CnFA== X-Gm-Gg: AZFdTZdk6i4QN/q2Um895WRqIk6TkhQvahtI3RlAG7BQJntGmFuu51yihp4nFiam3g2 0YVYvOFzCkIEGkTeaCOFBa6UxL95Wt6g8ppM3y27TL4grHolsPP7oHx6ErK2yZn7h6feA+Dk/c0 q182QQMXccTy5kCMNP2s8eec0DL+DY+T+zbmd2DHRZWHjtS/5EMuMXz1IPu4S4rk25x56gKy67j lfzSxP9sbBxATnS7sq5Ca0shKTIyZUa3wnL6eDeXGMK2u/bLsRVgltlmqqz20fIzSHQJ9GG9jFl 5lLaiH6D3QAxnday0cdFUaficZ1qvFiDneUooCA0JcSfr8QZBFUvg3kOw3WI+9dItd2i8H2wXEt n58d2VoMYeSUPreNzIE3cPNUBXFGB X-Received: by 2002:a05:6000:992:b0:48d:c29e:40c3 with SMTP id ffacd0b85a97d-49c71e3db14mr21883088f8f.33.1794849538653; Mon, 16 Nov 2026 09:18:58 -0800 (PST) X-Received: by 2002:a05:6000:992:b0:48d:c29e:40c3 with SMTP id ffacd0b85a97d-49c71e3db14mr21883014f8f.33.1794849537855; Mon, 16 Nov 2026 09:18:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849537; cv=none; d=google.com; s=arc-20260327; b=XKeHOO15dAo9ywGzT1bn2Cs0s2m03K5rDKM3gFXCO5KZb8TD53w6TKSx4bIppsnO93 GXLTpxFyMQSgw2Lp1mSGd1K6ILdIh88HLzzV5b92rPP+ijkSBEhwtAC7kdU2tMd+bAKQ P48SAWesAgZGcROmbSK5VqX4ESMfQ7pSUtgmrn07744Fc5w5DQ1ar3meTkMwbZEUv4jy zsEThzCsdy0DxwwTC9WI6jf2N+51Ez4ldsE67oZKZcPyt8S7+00q+EztAX36VMBS7uAJ soxjyCA+NwMkCDCqTAz8r80uhd0SQBsgoMNZxKNKdX1mE6MKyuBfrrDX+w4ckU/1ySx8 s9uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=QaMqIuRTe2uGYlRQsFCcjn1zOKZ9M5dSmAuYSS6dYr0=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=mzqNRpfiJZMmgw0J/09aImrTEe1sKwdoNeEpPFNTqUn2pCevhv9YeJ5t8WvvqCTXSA Pnv1734z3y3V+IAD3rjqWy4whWldTrkgnmFHns9hmXZ+zJIq0TXwtAxmatYUzGAdHhtj y8DlIBa9tXyjuqXjoCvVIAhTGSPhbYWifRBE8N+UDWxq7fQO2By1Iw7kZ53+PJY/fwop F3PrJxLOxwisNW/OC/UlfJgEyYfgH1SyO7iqYaTXtU3iIywV0XiWlrC5/V4aJ9mrFTtS UPC7SEhaJz6xg/+KOHybWQ1OvecY2ROebX4IdZZ9ULGDAJH/XsLd8JqR+sgbzM2V3NWH x5rQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=gabvxMwQ; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c636edc3dsi22719683f8f.190.2026.11.16.09.18.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:18:57 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=gabvxMwQ; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=QaMqIuRTe2uGYlRQsFCcjn1zOKZ9M5dSmAuYSS6dYr0=; b=gabvxMwQkJANGmtl4Kt spGFl1xQNASiPUc5nXSPfV1tzCkVTRdYTDV0RWrp797+cjvmGXwgX1B0F4ga5DqOeYKAstub2XO2K Pw47O0dfmROMR0xGBCIoi+fNb1pWBcpkobvxSuWEXGSE3jal1LJzix4x2NTQYGAtDdPHOe+7lxtlq Y0acXoGz5PUvaGMEJKvrHMNMOdDlr+u/DTIt5Iq/yacQ1FbWV+HkmPccENYw9CthXLfmjpl6UQ5VA PAUJcs20goEpas/PGM/Z5ILEvUmAr2RhOKG0YBbqg6ZauSFTmIDC13QZ/6ZIrRK65+4vaMmaUiquz ExJ5sMuNJxsq3sg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xT0Hq-007kVE-0v; Mon, 16 Nov 2026 18:18:49 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 18:18:53 +0100 MIME-Version: 1.0 Message-Id: <20261116-ovl-use-orig-ve-v7-3-37daa56081ed@virtuozzo.com> References: <20261116-ovl-use-orig-ve-v7-0-37daa56081ed@virtuozzo.com> In-Reply-To: <20261116-ovl-use-orig-ve-v7-0-37daa56081ed@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 3/6] ve: Defer ve creds drop until ve is completely destroyed X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org We may have a case, when VE is dead, but there are some users of it, overlayfs superblock for example. This user may want to use VE creds, so we need to keep ve->init_cred alive. Drop creds in ve_destroy. We need to drop ve_nsproxy early because ploop waits for refcount going to zero, dropping ve_nsproxy in destroy causes CT suspend/resume hangs. https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- kernel/capability.c | 4 ++-- kernel/ve/ve.c | 4 ++++ net/netlink/af_netlink.c | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/kernel/capability.c b/kernel/capability.c index 6de4dcba2283..68c3d5288ba7 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -395,7 +395,7 @@ bool ve_capable(int cap) rcu_read_lock(); cred = ve->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; ret = ns_capable(cred->user_ns, cap); @@ -413,7 +413,7 @@ bool ve_capable_noaudit(int cap) rcu_read_lock(); cred = ve->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; ret = ns_capable_noaudit(cred->user_ns, cap); diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c index b3988a8d590f..1e0c092f080e 100644 --- a/kernel/ve/ve.c +++ b/kernel/ve/ve.c @@ -378,7 +378,10 @@ static void ve_drop_context(struct ve_struct *ve) rcu_assign_pointer(ve->ve_nsproxy, NULL); synchronize_rcu(); put_nsproxy(ve_nsproxy); +} +static void ve_drop_cred(struct ve_struct *ve) +{ put_cred(ve->init_cred); ve->init_cred = NULL; } @@ -929,6 +932,7 @@ static void ve_destroy(struct cgroup_subsys_state *css) { struct ve_struct *ve = css_to_ve(css); + ve_drop_cred(ve); free_ve_devmnts(ve); kmapset_unlink(&ve->sysfs_perms_key, &sysfs_ve_perms_set); diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index f686e6ea30ce..c4a25ec2a15e 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -887,7 +887,7 @@ bool netlink_ve_capable(const struct sk_buff *skb, int cap) { struct cred *cred = get_exec_env()->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; return netlink_ns_capable(skb, cred->user_ns, cap); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel