From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A411F8017D for ; Mon, 16 Nov 2026 17:20:27 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHJEq3029350; Mon, 16 Nov 2026 20:19:15 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHJEq3029350 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="M1IBckEy" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGHIxfx029293 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 20:18:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGHIxfx029293 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-490c1867460so2294758f8f.2 for ; Mon, 16 Nov 2026 09:18:59 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGe82r8VtxOy51mvYwNGUgfzTiHrS7bNzZuSoDqV2rnHZfxI9tRToie3rbPSfMSl1805Z/Qxw==@openvz.org X-Gm-Message-State: APuU4Z8BQ9/dQ+rl2Xsskvf9ZbusHmvt01DJ1F0VjScbJD2UDteZnZWX kz8ejkrmf0GJ61vrym7pNuHvM/Yj8do2Lzx5CD3ZsGMnIKI2cpwpG5NNtFUclYXmqzlujZXCSFB FKhfJShFIDBppov5FDCaQyr3otkaBbI5Z77tA+NvGjV8/CarfxOGWcQ== X-Gm-Gg: AZFdTZdUpYbvhyPyje1/40MVy2Nti9VN7I+TlD1m/vAflQSi+1AcbERtkVSsZod5MYv S/nYCt7nMwzZ16/sIjiLlwgaeSO0g81lu+cAuaV1YMeeflZI3So+OU43LrRFjZ/3vx+BImwwN0t p04HbOHwXQJeBubeHbGgrc++X4ggfDvFpHW9K4Vz/6Pcl2fQB/tlb3qQ76Qe0M7lcQck2V9NVjc 7pjuAsij+Id2M0kgZAi9lY1JWCl6RD9cilLVbYJ+mP/2Y5eLisXsevXMYd+AnW6vqXVFKHrmBcB SSCaM1VPtWhzNmkQI8sVhvY8PQ+fCVtebDMqYiaYrAmSXFWcNg2RXV46ty/G+tMfJnl1IxvbAwa N2I+T/GER5JZjyPS0IeJhRBn1KuZ/ X-Received: by 2002:a05:6000:2587:b0:490:2bd4:5c42 with SMTP id ffacd0b85a97d-49c7353bd0fmr22771427f8f.44.1794849539038; Mon, 16 Nov 2026 09:18:59 -0800 (PST) X-Received: by 2002:a05:6000:2587:b0:490:2bd4:5c42 with SMTP id ffacd0b85a97d-49c7353bd0fmr22771365f8f.44.1794849538461; Mon, 16 Nov 2026 09:18:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794849538; cv=none; d=google.com; s=arc-20260327; b=e1M9WkgLinCg1AIDuRuxnI5kwJnTPcXfCjZEPMcOcjrrxskd6IFdFGaWVrNrfmytYg rOtIcJJyDIKrwnwNGG0lx7LTqwCwxmTgpnnpdAlGqBW0v7L4fbKVMEVLpGaRsL4ho/ZC 8ls6uIMH5Fxy1QXnBED10Bqnu/DNvOg1s09uyXPRcVr9kPRuQIsgfBzqil+hcRd8jcR2 3jT1V+JW+ZyFLnkHXhCjMZXGdwOyC9MwVouxaU4GH0ymqbZ3ELehQgpXWGZNZY3txFFw MIaI1NMR2TIXnk6j8chMJkDIOhnwBHvGcQd5sv56W3zkn8YSPjCxCFYr5rs+6JwoynnE PBSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=xakkFnlcqs7dAmpl+XrKPseiJtqVzh4fXZ/MepUhuqY=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=OvBrV3Z6iGUgtJ6z7Px39AjAxhf/gXH67FKpLlgTIbR3uWHQaprFSq4DInHhT+p7VI GWqQ5sd5M06jWpm8jakQq7Kil/CrL15DrbhSO2Alzgkvrjb3nvjLtDtGJhceG5yTlz9a 0xfhk2RDNkCh8mA1V2n0ID+RNTkZMu2kteOs/DGyPmycDGq2WtWMebwOeHI0yqd0l4Ft 3PK6lBivMG7wC21RfxZaIYV8z6WZRF2YWch8YDxEM9IFaFAVBNVsUptq0tXZphBFTmOQ aJHu7+iWZ0U5Ch0T24CImKKrUq/Ww+wWYf0tba03FHsKv1FxoCpXFz+JSfnqQ0rQJdBz NWKw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=M1IBckEy; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c8cfa5e81si20297151f8f.40.2026.11.16.09.18.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 09:18:58 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=M1IBckEy; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=xakkFnlcqs7dAmpl+XrKPseiJtqVzh4fXZ/MepUhuqY=; b=M1IBckEyfLKHIulFg+U BSoEK0mtXktfv7znsoO4k3plBSewhYHh/x9E4RVC4KbWOA64hO8a5zO8uYjplifAdZ2CrkNnn1d1D IXMb+c0ynS0D66V7OEqtmwuXpROfkDqquXJ6ZN3IyDwi0Mp6JjegfCWxLdaQhu8nHAMr38VLxYVGe cUa5VAKtasCqzksGgm0LpzJDAGGP6J9e2SYTd8f90TVDgJpMjFbYwU1vdSvjO7rI55mp8kDdRaI0G Xx4O6zKqVPC0VJ7i/+VqPV/hkCQLCKQz3ZPqdTOyVMtjGr95sSYzGemaXnYbmbtDNJaL+9CSpX7oS 6iYeNJWQOlhnmHg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xT0Hq-007kVE-2z; Mon, 16 Nov 2026 18:18:49 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 18:18:55 +0100 MIME-Version: 1.0 Message-Id: <20261116-ovl-use-orig-ve-v7-5-37daa56081ed@virtuozzo.com> References: <20261116-ovl-use-orig-ve-v7-0-37daa56081ed@virtuozzo.com> In-Reply-To: <20261116-ovl-use-orig-ve-v7-0-37daa56081ed@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 5/6] ovl: Fix leaking fd references in ovl_copyfile X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Latest rebase onto kernel-6.12.0-211.75.1.el10 introduced a leak. We lack of ovl_real_file, added in d66907b[1], which changed logic so we need no fdput anymore. Imported commit a1e0eb8[2] didn't bother with fdput cleanup, because it relied on d66907b existence. We still need to perform cleanup and put fds. [1]: https://github.com/torvalds/linux/commit/d66907b51ba0 [2]: https://github.com/torvalds/linux/commit/a1e0eb8f55cf https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- fs/overlayfs/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index 2531433f47bf..7588449809ec 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -524,7 +524,7 @@ static loff_t ovl_copyfile(struct file *file_in, loff_t pos_in, ret = rw_verify_area(READ, fd_file(real_in), &pos_in, len); revert_creds(old_cred); if (unlikely(ret)) - goto out_unlock; + goto out_put_real; } old_cred = ovl_override_creds(inode_out->i_sb); @@ -550,6 +550,7 @@ static loff_t ovl_copyfile(struct file *file_in, loff_t pos_in, /* Update size */ ovl_file_modified(file_out); +out_put_real: fdput(real_in); fdput(real_out); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel