From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id BC4A2817C6 for ; Mon, 16 Nov 2026 19:22:14 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGJL08L030980; Mon, 16 Nov 2026 22:21:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGJL08L030980 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="V1a6W1d1" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGJKk5T030941 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 22:20:46 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGJKk5T030941 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4925ef75fc4so2229582f8f.1 for ; Mon, 16 Nov 2026 11:20:46 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErF/xesTpA1AygcVbgkz4X8PPFW0STU14Y5KN+0zrEfSh+D25le3o7x3jMXUYXyNU26aMpEDKg==@openvz.org X-Gm-Message-State: APuU4Z9A/x4jIc8a/zA9LzOXOzsbxSqR0Qkj43hpJuJcEwWflIUyLm15 UoWK9fOKGJ8UAprF5YPgmP7YlZqCzfoM7qTfFJhL0t4QuXbfTUMhrW1L/C13tiaavMaN+NFf21F Gb6HnBuenMiI6Q+tnP04nZlBcgJNWuqq1EYmc9vSebFkMpaSNSxzMJA== X-Gm-Gg: AZFdTZcyn/wVZ+GbLTEYtOhtr85gGrw7ShCNSdT3ik1QZ2CmWHia0qF3na7/O4sjSrl XzwK+SavLn/r756RCidhsB/1i3eNuvJfXqZ/oynS0F22wsg+LHSZIFlq9Qa2VoOMs6f1KTHVUOl QCibBDQEuoV3UWgqCpHu/4UzNHKcJKL8CWG6qBcO2eWGbtVcQZtRFETwsLYJ8Azpq6KHWwLlc3a NXrQayxdaq5Efn26k8lHpbNasSjzeOLTf8zEXceLR1s8fZXJy/YAkRvvEJyh/wIUYqGlpQtR8cX EylWvvPXmpxsXC9ZjT0r+6V4MbTMLreqMjnfO2DuY3hrd/Pvl8f+VUbbOXQyNeyHNhkNC/ywdjd L0RoZoNPX82KKuJXa+hFM9rSiij6FPQ== X-Received: by 2002:a05:6000:25ee:b0:48d:ee0d:8b3d with SMTP id ffacd0b85a97d-49c71a66cffmr21840913f8f.28.1794856846438; Mon, 16 Nov 2026 11:20:46 -0800 (PST) X-Received: by 2002:a05:6000:25ee:b0:48d:ee0d:8b3d with SMTP id ffacd0b85a97d-49c71a66cffmr21840871f8f.28.1794856845945; Mon, 16 Nov 2026 11:20:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794856845; cv=none; d=google.com; s=arc-20260327; b=Fi7qwCFIxJ5PD0LmCYuaiibEA4zqK6qElWaX4puKjQvXt++PEL4J5a+0zA15nnIx9u 4zMdRpWtakgrEsydSBIsQ0/D/eMQW2MBEO21XKOxCNuTgD2ONPBj9OJI2/bkEQ0I8iIo Rib3xMM7dNzp65SLOOpUVHEwUnQztuP82244YddJPHOMeXjqXoa6cipI7cbKXArvRZYg XQWtKfGNrlBz1Cid1cMZwmWvZUEnKZj27bYnRVtCQ04TGe7mxYNCBdzY+kYEDSGDs9wR bZ4E4CoQPZIYzURYpYtmMNu1tTJy6Uhu7dnTz9FEXe0jCo9sf3crS4fjryAQL5XWdGHv C3rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=Uay/V4jIsfN8HOILO1MacEjJEXezowJOpA2A2mBR0WI=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=DRd/FLeMGuFLgwA+vUa6svdoidTCOoX4OGzYQBoprs7tSn7EqM7+Uvnb4NMVACXFW9 0m28C9FNxligpeTF7iHjpXOOqAzX5el6+4yXe88utQGICk3N0vEoxtiy2rKJKWd5KvND IX9liWygk0QBKLj+njbVibiQmLbtf+3/KRmHW8uX8uByYk81ZHHznqOkrE3cp5voCJSR +z6B7cZfb32gPzj58JGfGsXVDZobvMGNMgXQKlYox57ihNhV0ODOQRfhBsE2mRIj/EpY HFdFw3oPXoDXYm3H9kC8RpzdzGoV4d3OZmH8lEUzQunDiNZtx6NiJaHLDd1HBC3JTIYD 3uzw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=V1a6W1d1; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63122018si23361563f8f.105.2026.11.16.11.20.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 11:20:45 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=V1a6W1d1; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=Uay/V4jIsfN8HOILO1MacEjJEXezowJOpA2A2mBR0WI=; b=V1a6W1d169Xx0XCWTH6 +BS7sn+YP0xhvjz5p/CD8tG/tTlUTCB4zx5fxzJw7r/tdMMizDLetI6LqY4MyMPMUb/1vhbXAfm8O SwgXhcPEWmRIOaKQNmzNVkHUjf9tvt0Inkr8knLmlSjkxoYtK+M/jDG/yvjzVq0Of17msZJBfyJLi b6bz42pNEjbmAG2Pk65QjzeGeGfJMnr7oSHg8qjx/F+II+qxJkhHSYkubaCcXsM6cij+/aU/o3ZU7 ENExx9CZPFz2zibxbFuqUkg/x36Q+eeLLDUNpWXCUnAIeB1SLveitFxcXbsv3sHAAyVjRX/hKRfbl rGgEP7yaYkz6KgA==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xT2Bi-00A2lb-0y; Mon, 16 Nov 2026 20:20:37 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 20:20:41 +0100 MIME-Version: 1.0 Message-Id: <20261116-ovl-use-orig-ve-v8-3-dfe427bfd902@virtuozzo.com> References: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> In-Reply-To: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v8 3/6] ve: Defer ve creds drop until ve is completely destroyed X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org We may have a case, when VE is dead, but there are some users of it, overlayfs superblock for example. This user may want to use VE creds, so we need to keep ve->init_cred alive. Drop creds in ve_destroy. We need to drop ve_nsproxy early because ploop waits for refcount going to zero, dropping ve_nsproxy in destroy causes CT suspend/resume hangs. This commit changes ve->init_cred == NULL meaning. Now it means that VE is not started. Dead VE keeps its cred. https://virtuozzo.atlassian.net/browse/VSTOR-142405 Signed-off-by: Vladimir Riabchun --- kernel/capability.c | 4 ++-- kernel/ve/ve.c | 4 ++++ net/netlink/af_netlink.c | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/kernel/capability.c b/kernel/capability.c index 6de4dcba2283..68c3d5288ba7 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -395,7 +395,7 @@ bool ve_capable(int cap) rcu_read_lock(); cred = ve->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; ret = ns_capable(cred->user_ns, cap); @@ -413,7 +413,7 @@ bool ve_capable_noaudit(int cap) rcu_read_lock(); cred = ve->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; ret = ns_capable_noaudit(cred->user_ns, cap); diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c index d3f02fe118ca..de7fe776d4e6 100644 --- a/kernel/ve/ve.c +++ b/kernel/ve/ve.c @@ -378,7 +378,10 @@ static void ve_drop_context(struct ve_struct *ve) rcu_assign_pointer(ve->ve_nsproxy, NULL); synchronize_rcu(); put_nsproxy(ve_nsproxy); +} +static void ve_drop_cred(struct ve_struct *ve) +{ put_cred(ve->init_cred); ve->init_cred = NULL; } @@ -919,6 +922,7 @@ static void ve_destroy(struct cgroup_subsys_state *css) { struct ve_struct *ve = css_to_ve(css); + ve_drop_cred(ve); free_ve_devmnts(ve); kmapset_unlink(&ve->sysfs_perms_key, &sysfs_ve_perms_set); diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index f686e6ea30ce..c4a25ec2a15e 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -887,7 +887,7 @@ bool netlink_ve_capable(const struct sk_buff *skb, int cap) { struct cred *cred = get_exec_env()->init_cred; - if (cred == NULL) /* ve isn't running */ + if (cred == NULL) /* ve isn't started */ cred = ve0.init_cred; return netlink_ns_capable(skb, cred->user_ns, cap); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel