From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 3C4C8803BB for ; Mon, 16 Nov 2026 19:22:20 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGJLAiB030994; Mon, 16 Nov 2026 22:21:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGJLAiB030994 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="vu3wG8C+" Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGJKl1J030949 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 22:20:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGJKl1J030949 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a20e41008cso24108435e9.1 for ; Mon, 16 Nov 2026 11:20:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEpoPmRd+bwqkqgXyS9heFn2FgJq81A8PP0dObtdDWchL8YZnTUVB4TnQZTxV8qCCMrWTTNrw==@openvz.org X-Gm-Message-State: APuU4Z8Br5XpILY/hlSCXr3cJutzj12pZev2EU1rgh7CoRitvUv2mrX/ 89pKfbK0dCQZWpuT4hcISNbYKYjmNvSbNa1ZYV8/EW1nKpcMN2oCpupHcfLCtDuk10lvkqETM6e nD4b2D1gisSLBcknMJkZhPP/WptMMxG2AoSuPREs5RUcpri5vD+wCoQ== X-Gm-Gg: AYBFou31OtpD9k3XFrqcIPheiWLoypkpYJvkH6KJCChuNHE7YeiSuSq+IHHWkcfhhhL 5LdNShip99sEFpUY5T5R858SSpoCC1/yCq8IRaFkyxl0Zf3Ys+6/FWUd/s9O/yziStwwLN0cV7U BiFmjLdy1AHYLoga6XCpfP3RPNZuSS6LdpHgjuZSU/DQMLw9TrTXz1hrxMYBRqlBiG/Lo4lRZtf Z1i3inBDlc+TwTRQeLEuTsmRvPjNYBFmDEeBDBQ7S0tvqIWvECcagQUud0f9/5SMRIIijziXqSU T9k82XM08otEdefX3btP/VgN3qEwpsJnN1B21et8G3RVAzFqyX8Fn0hUJRbNKKz0C6V+++V6Jz3 IwUOIR1Y5GAWoIILgPYwA4GOYBmR+ X-Received: by 2002:a05:600c:1988:b0:4a2:1a:a116 with SMTP id 5b1f17b1804b1-4bb5e2693b0mr216096915e9.0.1794856846970; Mon, 16 Nov 2026 11:20:46 -0800 (PST) X-Received: by 2002:a05:600c:1988:b0:4a2:1a:a116 with SMTP id 5b1f17b1804b1-4bb5e2693b0mr216096485e9.0.1794856846579; Mon, 16 Nov 2026 11:20:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794856846; cv=none; d=google.com; s=arc-20260327; b=iUyLGp7bGSqCkI5r2nAs2eiFeJnxCNvwDtQ/xm5Nc3/CNf9klOqjBa+7kwHSiLhwbF VjIp8k+2iOlxFOseVxX5jVl2CbWWCJA9+avgEzPQQ4XQ2rD959OwUQ5eKN5OcKmWM0fg 6hDa8DJaxmTLPfFjZqpLvwpTxeeLAP6k2p9lo3l6aJuIuT89AAh6varticSLTxJU7lmN GZFuHT4Z2s/HxsZ2A6UoGcR5v3kX5Dz44ddL/hvqONVS2SuQiPrMWix2lqE1uDhzJLUJ 7cIQwljcbnCudfuf+x7nNvFXEtevFawAW50BKDMPaJWGTE8vEBA/dByuUY+mQuzJEMMW YUCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=clNb7sK3cFmtGlD5+89hyY9/NPxNEUJFvqH+9HUgT8o=; fh=eCOFrBZAqsL6jjT8ApulcBPCLrgIlXlNCEpSn7Ap5O8=; b=d3A9IVjYA4nY7U12jWx8skJeXNNlLeQhYdrmf3sxx81xvFc3cIlr1UOmvQ4/Or42U8 6FNd6bQd6zbmhBzxPnh6bWcqzX5/BQVUwOgUJXFSJpA71s5ZU58oxNgxzUiMsy/IO2jo TYQ2OxfinGs2xNltM0B+SgiLsu2VA8FtNc1WK1KJh4woDx777PDS0Qjjjl+vU0vRerOL 6yP7+uyKrr7PAESaCg3snQlMBJI2xf5hhZrQB91+nItg0MRzf6sBhSVAWgtznkpwHlwA KFj3HHIU2QQ2yL47P5kYkMCktkwxQtHTFGYY7ESLJXVKcxXn+hTP58F2nIQByfRdCt4E x9RQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=vu3wG8C+; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c63122152si24493602f8f.129.2026.11.16.11.20.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 11:20:46 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=vu3wG8C+; spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=clNb7sK3cFmtGlD5+89hyY9/NPxNEUJFvqH+9HUgT8o=; b=vu3wG8C+uHqfWAvU0YU p5flDy5s+yuZ2JPCi8knvkTGJ73XOTG1D/56Tp4A87amixkY6kscLh2/1visyCJSGdjBDuhfiQI7Z IzdcmuoelTf/BFrxjqZkyZip1izQ3Ja9n8clNMXYLVlSgLzxe4gAkKiONyKIwDqyTz3gFn1BhU6Zn hlBuq/jdCIVSoZmsRlHedyvhsGh4vFWlWPvRUtyy5vHhXSfAIw1K0UUckVKBhTWAWKGivpWvvRa/c NhMZTzb6sSRd4e+1Bovdue6jEoXCl3cXraXZe4UGXYk9DsCWR+fH+vQQaE4hABUHzH/URTr4c+ejK 9SVzuUnx7KTt9Qg==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=192.168.1.87) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xT2Bi-00A2lb-31; Mon, 16 Nov 2026 20:20:37 +0100 From: Vladimir Riabchun Date: Mon, 16 Nov 2026 20:20:43 +0100 MIME-Version: 1.0 Message-Id: <20261116-ovl-use-orig-ve-v8-5-dfe427bfd902@virtuozzo.com> References: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> In-Reply-To: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko X-Mailer: b4 0.16.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v8 5/6] ovl: Fix leaking fd references in ovl_copyfile X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org We lack of ovl_real_file, added in d66907b[1], which changed logic so that the code needs no fdput anymore. We still need it. Imported commit a1e0eb8[2] didn't bother with fdput cleanup, because it relied on d66907b existence. We need to perform a cleanup when rw_verify_area fails and put real_in/real_out fds. [1]: https://github.com/torvalds/linux/commit/d66907b51ba0 [2]: https://github.com/torvalds/linux/commit/a1e0eb8f55cf https://virtuozzo.atlassian.net/browse/VSTOR-142405 Fixes: d5a10d38e534 ("rh10: import RHEL10 kernel-6.12.0-211.75.1.el10") Signed-off-by: Vladimir Riabchun --- fs/overlayfs/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index 2531433f47bf..7588449809ec 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -524,7 +524,7 @@ static loff_t ovl_copyfile(struct file *file_in, loff_t pos_in, ret = rw_verify_area(READ, fd_file(real_in), &pos_in, len); revert_creds(old_cred); if (unlikely(ret)) - goto out_unlock; + goto out_put_real; } old_cred = ovl_override_creds(inode_out->i_sb); @@ -550,6 +550,7 @@ static loff_t ovl_copyfile(struct file *file_in, loff_t pos_in, /* Update size */ ovl_file_modified(file_out); +out_put_real: fdput(real_in); fdput(real_out); -- 2.52.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel