From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DCE118017D for ; Tue, 17 Nov 2026 14:01:05 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHDxn6q009745; Tue, 17 Nov 2026 16:59:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHDxn6q009745 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="YDJJ0cz1" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHDxlNR009741 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 16:59:48 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHDxlNR009741 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-49034831bb3so3177986f8f.1 for ; Tue, 17 Nov 2026 05:59:48 -0800 (PST) X-Gm-Message-State: APuU4Z9Ri6oK2G020Jd3i20MdOlU8jB6r1LeLCb/+D6UUWuONtVFYr9V 7gWo6r/WC3aCJ5nwpFeMkYjZbznosgZ54FEu7AnMvLVZoi/PuAqVKbSfvzXwt5iilUeMEgRdW+B wfFZWUHsQlAcrtx+20mqXmvL+dpfUu7xoMpfa1OomU2aR56bnznbYJQ== X-Gm-Gg: AZFdTZeA1K/wDC6UPXTRiYljGYZdQStVUPloxV3Eob1A9FBE5+D6KdrLEaxldCL92Uo bXYnB6v1wTSAMT4JVgMC5tpqNejjqlnK/nzWQWcaw691J++br/IIYeCE63iEkW0+5KKfhyFs6Bx L84jU0gyJPHkcTsNNG/4CsptXRhl0gtDjAxV4kXyhRwgjVZ9iNOZfBojt84XWbNcOKRWITALk9V /yoZ4k1Jt45gkfgIE3PNuhKXNemc5ah9+p+dZvLFjfAAHgl8VkhqMtpVlp04F1UJvQiMTBbg54b qTkneywH1kmNoRrmq4XzpRxT10QCWZezbAWjH0AdVj/1N8cCr+a9VbeT7QoLf/0GNHrKaoaDbqE 0lzQlyHuGKEqz+cYXFUrVAbh1wgz0CA== X-Received: by 2002:a05:6000:4013:b0:48b:d9:cb52 with SMTP id ffacd0b85a97d-49c723fc62bmr29192663f8f.27.1794923987637; Tue, 17 Nov 2026 05:59:47 -0800 (PST) X-Received: by 2002:a05:6000:4013:b0:48b:d9:cb52 with SMTP id ffacd0b85a97d-49c723fc62bmr29192604f8f.27.1794923987092; Tue, 17 Nov 2026 05:59:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794923987; cv=none; d=google.com; s=arc-20260327; b=Ps1RYl0W6PBYzONYFFRrmZc8eUWtAaROzMiBkwkYdOZJboEvb8L4FVfu4MZzMXJrUY EyqAbUVD4nS12St9XxwjKz6U47gYkoHcFS1Id5KwEGtGUFfcBG0Q6no+ESQOl+xbwH3R 7aLNa7r20KG0n30VqrYtWJc6UDB56vyUWoFFfblqwPMrRn92OAkyCcbUdZiGacvoid9e QOvSWpPjTgc/2zEnexKkmVwzw1pog/U0uEEMNj9R8dQrVrU5W4C5SmEZbLBMNl6r0oKU SekEcvFecgoPLToYb5sWEQBqDHhsNhFgjtCiA5pTBhz2Tj8kg0d5hDC/gLn/gGHQz7y3 496A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:dkim-signature; bh=c91SJc+Yk81Fm1jao3LX4O4p9M5SlI5mvhYi1wdPs0o=; fh=q8lSvsnhtepfoDbGLWKvcia9sl7+7cl6g1V7iYrfAtY=; b=SxL7l1ztw7VBLstXBiFRIu9usbzRgb8EqGOXmRVSfTBji0WDDaIP+PMpHCGefxs3Jr jmAPuNHsgb/e1TwbXBRnD18QmyEC78j2C095eciC64DNK2v162v1bWBCddU9yoK4fBWB uedOUFDuBsOm8BYDcbdzQx9PnZpzG8rQ7iv6G6OssjazpuddzOCr4ch0Q2a62NcjH0+V EBAUN3m1uXQWmGKPrRj8INq23J8tgt10xF0Bs7RK0LaPunEqQEIOQzr8CgypTtEXRjp5 i3r+NvF3epsN7sIQX3lTRRLehjku7sKdqWcusizZH9Ut0p1u91lQDp6WCbTp0ZtHnxAw G3VQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=YDJJ0cz1; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6302d88bsi28134126f8f.145.2026.11.17.05.59.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 05:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=YDJJ0cz1; spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Message-Id:Content-Type:MIME-Version:Subject:Date :From; bh=c91SJc+Yk81Fm1jao3LX4O4p9M5SlI5mvhYi1wdPs0o=; b=YDJJ0cz1VyBmRPil5+p o2KIGn41DVhXbReGMFgYrAI0uMvhwm4UtpAJ+zvv/2km6IDeIkBGJ/I4GH8EQc4Q7rqfXIb1TjFt4 3CwmIpxMVLM6IviP1PNof1nXLldJcqwpgRt/6VaSO6ZN4mw+0R5TBN6YAOPo/4u37xPsHB128Ubik fAbb/aiPHRneUwPbflmRuXNepjncVUCZMH4DDhICPUCw9Nu852KnVaujTKrqeWKvDFSUKKpKougAr /DbzVYJk/rs2yaQyzqEWcugkof0kGEAxRxDf9mCFd6z1NI3cq/JCOeyZQY6KZHJKoCsLv7mDIBOzq gHiVHKoDCNQt2dg==; Received: from [130.117.225.5] (helo=dev010.ch-qa.vzint.dev) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTJeb-00Ddtz-0G; Tue, 17 Nov 2026 14:59:35 +0100 From: Vasileios Almpanis Date: Tue, 17 Nov 2026 13:59:28 +0000 MIME-Version: 1.0 Message-Id: <20261117-ct-fsfreeze-v1-1-23272094ba36@virtuozzo.com> X-B4-Tracking: v=1; b=H4sIAL9d/GoC/yWMzQ6CMBAGX4Xs2SVuw198FcOh1K+wHtB0gRgJ7 27V42Qys5MhKYwuxU4Jm5o+5gxyKihMfh7BestM7uwaEWk5LBwtJuANbiHN4KvO11VNuXgmRH3 9bleagnJXOur/wtbhjrB8X3QcH5bjcdZ4AAAA X-Change-ID: 20261117-ct-fsfreeze-7e16ba48a545 To: Konstantin Khorenko X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794923985; l=2116; i=vasileios.almpanis@virtuozzo.com; s=20260812; h=from:subject:message-id; bh=Hq6xoWyNSzL4nbDeSzp+i02JmbzuP2P7QCEyvRPq7DY=; b=9KJnwS9o17JWdTAUtvFAX6HZLtFWjaCJ1yrhGEpY+1YwFQrJEpxD7PhjuqrVtYx85HBglPICQ F9ns35Ni7mgABPtFlRYRlXXMPWdKQ9UDugMO/ZbtFUWWFe+WWZv41YF X-Developer-Key: i=vasileios.almpanis@virtuozzo.com; a=ed25519; pk=HhuHDXAcPva9A8zccWEMRsb36reu+y4IVbBjXKxNUjw= X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.2] fs: forbid freezing and thawing file systems from a Container X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org A Container can freeze a file system it mounted itself, since ioctl_fsfreeze() and ioctl_fsthaw() only check CAP_SYS_ADMIN in s_user_ns. That is a bad thing to allow: * Processes on top of a frozen file system hang in the kernel, so CRIU can neither ptrace attach nor freeze them and the checkpoint fails. * CRIU does not dump the frozen state anyway, so after restore the file system comes back thawed although it was frozen on the source. Nothing vital inside a Container is known to need it, and most file systems a Container sees are not freezable at all. So keep the existing check and return EPERM for FIFREEZE and FITHAW when called from a Container. https://virtuozzo.atlassian.net/browse/VSTOR-155592 Feature: ve: allow various syscalls in CT root userns Suggested-by: Pavel Tikhomirov Signed-off-by: Vasileios Almpanis --- fs/ioctl.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index d8b2c630cb3e..1927a10ad8a0 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -22,6 +22,7 @@ #include #include #include +#include #include "internal.h" @@ -394,7 +395,8 @@ static int ioctl_fsfreeze(struct file *filp) { struct super_block *sb = file_inode(filp)->i_sb; - if (!ns_capable(sb->s_user_ns, CAP_SYS_ADMIN)) + if (!ve_is_super(get_exec_env()) || + !ns_capable(sb->s_user_ns, CAP_SYS_ADMIN)) return -EPERM; /* If filesystem doesn't support freeze feature, return. */ @@ -411,7 +413,8 @@ static int ioctl_fsthaw(struct file *filp) { struct super_block *sb = file_inode(filp)->i_sb; - if (!ns_capable(sb->s_user_ns, CAP_SYS_ADMIN)) + if (!ve_is_super(get_exec_env()) || + !ns_capable(sb->s_user_ns, CAP_SYS_ADMIN)) return -EPERM; /* Thaw */ --- base-commit: a656d0a24ddd1939d7deea2f7450873e662c828e change-id: 20261117-ct-fsfreeze-7e16ba48a545 -- Best regards, Vasileios Almpanis Software Developer, Virtuozzo. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel