From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 89E3F803BB for ; Tue, 17 Nov 2026 10:16:31 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAE95t007942; Tue, 17 Nov 2026 13:14:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAE95t007942 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="MACLrkKh" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHADbFO007890 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 13:13:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHADbFO007890 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4a339a24cd1so594960f8f.0 for ; Tue, 17 Nov 2026 02:13:37 -0800 (PST) X-Gm-Message-State: APuU4Z+W5VdhrgZlZTMeuPnjWt66KmmVt09uaO/yHh9C4MvdxtuRzoko xYFT64wqs3ZSPOobHXavax96xx1j0AG1pHhSSmyAMSzgOe0PNJASt6pJCyYrv0htIYh9LZKTjVP Eq1D2PH2Fj6YclRAchfh7gndI5Sv5h7FHCL6NDcsg9fd64oo9dtLSUA== X-Gm-Gg: AZFdTZdeCMw8FuuREXdAEYUqu+AdqR6U4452P6NGBTLrSmvIYAMGAsC2HjvyeQeH8XX /YOcIZkUZjtCqyklDa+6Y57f/h9LmYy+MDtq/INL1cqGbAWMeLdnYepBQL9qxRuIF7TYIWf+8Ql cSPRINCsq4uDRJyN/6GhRJeP6HTJNkihSv7s5VhjtNxXdZImUvrmtolqVNH8QfgwNcrfLsxL+nB cOpqtYGw+5xARvOdNR9LVjTp6/JUKiXDz6arUepFXcfZGdCMoa6t/+z3gtkexqPn0TVWhTVOSZE 2keQ0ut5GWrHnJCHCtgky/KDIF1/p+jOUdgO+2OCa62EPnzeke18S8eqPQoSpmsslS3a//soiA7 BQJgXR84IDWzCz3dZbFqvvSvNOMxUBw== X-Received: by 2002:a5d:5f46:0:b0:48d:cda6:4dd7 with SMTP id ffacd0b85a97d-49c72ba6f5emr27395218f8f.44.1794910416467; Tue, 17 Nov 2026 02:13:36 -0800 (PST) X-Received: by 2002:a5d:5f46:0:b0:48d:cda6:4dd7 with SMTP id ffacd0b85a97d-49c72ba6f5emr27395172f8f.44.1794910415975; Tue, 17 Nov 2026 02:13:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794910415; cv=none; d=google.com; s=arc-20260327; b=Sem/zeUP4DjJoJmgQiBdSZz16iy/WhXkta/0ZP0duIhnyCqn2792lDgIb9w2ZxhEAh 8+33Qv0tSLC7FXjf8WsBiryX2y1zScQLCDw9UIvK1sSp7foeyXHVtqiT/VrlD+HkvGum kx5PE324JTPH0Wv5KXUx/XEIMZvbS4Zd3ElQQbzBg/efryLt99jcVm7oCZ35PCLMwjuc Z2nYtqbXwKzKQaKCowwzc/ptHE5LFQGcZHzxEFB+H9XUQXxQQQFXAMZkDx4+6hrLEKlq /5ZGRZprEUFMlGc1oHdUQFd6IE12WQ6k3QGwaVTLgJ1fEDYj4B2lTOdtDUO52kiMzamv Whaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=pEUgUs5IkG2lQBApk3YSNaFcSAU7KQD23eGCuSyURyU=; fh=wpoNUURlquLpJK/14Kny0oMIYkY7mYwjJ/Ils9UT2kk=; b=CFIYf8yDnTHTWZFaR/MUnOUzUprY7NmobNon3CoL1okMq2BQdJY/49Kk0qKah2bytl D+zryLzNIhTiJv3eNGzeIOYtdqirWkY3UvWzGPnxrFzucHsG/b/8739yfscTtnIfdkfs puaogKdXqkGDNGjMS1BqPN7pYXAlOaZQDmvlWMu87r5kU4NbbMJFJKJihOyLTdA9QpKM +oWUQUJH7i7kmEz+kT+2E2ga9dihy6IuAmQnZ7ouzBONbdNKqJUYGQxi05bunc15IOzU LSZbrcunrEYr3MJBsQjBB1C3db8gLydRH0rQUrwQaRjO1tGuzmWRmcKXE+QgJoUDVlFZ h0JA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MACLrkKh; spf=pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=mirian.shilakadze@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c64b0b2f8si25091895f8f.395.2026.11.17.02.13.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 02:13:35 -0800 (PST) Received-SPF: pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=MACLrkKh; spf=pass (google.com: domain of mirian.shilakadze@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=mirian.shilakadze@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=pEUgUs5IkG2lQBApk3YSNaFcSAU7KQD23eGCuSyURyU=; b=MACLrkKh9Hjg UWXrRnJXOLX77kWmhLEjAM8puNxaJovNl2JzFuHaOWZTsK7JMf9SpBTlZO/TFMPPC0QnGfSlTWkFd q9cihZhrCtbMQwJZIdE1eLXCmkrpKXT/4kF8jme+kVfePUM37L020R9Ej2FiybA6T4c6PikISHZYa +1UVcBPcFrw8UWP5smFt3DWCHgAhl4M7e83+dGF0wJ9CqzFsr+V6/6I9PV6BubtBpT3yoBK8RbeQs mp1W9+3e90mKysKrqN6Yp/jhoK3FVGUCF4/4JmSnmLrQzTkfaN2zO+dNAm2D42L5S8r8efFn6Io6c KeITp/CDLlq8A6S+1rFETQ==; Received: from ch-demo-asa.virtuozzo.com ([130.117.225.8] helo=localhost.localdomain) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1xTG7j-009MQ7-0x; Tue, 17 Nov 2026 11:13:26 +0100 From: Mirian Shilakadze To: khorenko@virtuozzo.com, ptikhomirov@virtuozzo.com Date: Tue, 17 Nov 2026 14:13:24 +0400 Message-ID: <20261117101329.225854-5-mirian.shilakadze@virtuozzo.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261117101329.225854-1-mirian.shilakadze@virtuozzo.com> References: <20261117101329.225854-1-mirian.shilakadze@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.2 v2 4/6] cgroup: give the CT root file writes and hidden roots only to setup tasks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org While a VE is pseudosuper, any task in it may write the read-only files of the container's root cgroup and sees the hidden cgroup roots. That includes the container's own binaries that vzctl and CRIU run during start or restore. quotaon at start can rewrite the root memory.max, and any of them can write 0 to ve.pseudosuper, which ends the window early and makes CRIU's restoring tasks reachable again. Use ve_current_is_pseudosuper() for both, so only setup tasks get them. Feature: ve: CRIU support https://virtuozzo.atlassian.net/browse/VSTOR-151265 Signed-off-by: Mirian Shilakadze --- kernel/cgroup/cgroup.c | 4 ++-- kernel/ve/ve.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 77903a56b79e..b0f2e7a24b5f 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -4765,7 +4765,7 @@ static ssize_t cgroup_file_write(struct kernfs_open_file *of, char *buf, if (!ve_is_super(get_exec_env()) && test_bit(CGRP_VE_ROOT, &cgrp->flags) - && !get_exec_env()->is_pseudosuper + && !ve_current_is_pseudosuper(get_exec_env()) && !(cft->flags & CFTYPE_VE_WRITABLE)) return -EPERM; @@ -6947,7 +6947,7 @@ int ve_hide_cgroups(struct cgroup_root *root) * Hide ve cgroup in CT for docker, still showing it to pseudosuper * (criu), and also hide non-virtualized cgroups. */ - return !ve_is_super(ve) && !ve->is_pseudosuper && + return !ve_is_super(ve) && !ve_current_is_pseudosuper(ve) && ((root->subsys_mask & hidden_mask) || !is_virtualized_cgroot(root)); } diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c index 1cf4e71e8779..785d0ed4a05e 100644 --- a/kernel/ve/ve.c +++ b/kernel/ve/ve.c @@ -1019,9 +1019,9 @@ static u64 ve_pseudosuper_read(struct cgroup_subsys_state *css, struct cftype *c * operations such as mounting cgroups from inside of VE context * is allowed in a sake of container restore for example. * - * While dropping pseudosuper privilegues is allowed from - * any context to set this value up one have to be a real - * node's owner. + * To set this value up one have to be a real node's owner. + * Inside the VE only its setup tasks may drop it, see + * cgroup_file_write(). */ static int ve_pseudosuper_write(struct cgroup_subsys_state *css, struct cftype *cft, u64 val) { -- 2.43.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel