From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B8E29803BB for ; Tue, 17 Nov 2026 10:45:04 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAhoSP008350; Tue, 17 Nov 2026 13:43:52 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAhoSP008350 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="cZCArX+3" Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAhWuQ008299 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 13:43:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAhWuQ008299 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-48df02b91f9so404321f8f.1 for ; Tue, 17 Nov 2026 02:43:32 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFAaTGD9tdeSrat2xN3IVUZaJulWjEl2H2/Dnjaz1ygRSMdL6H99tukYBkN2zcIFhtDRAN1Aw==@openvz.org X-Gm-Message-State: APuU4Z84+WpMQsJ9Q97cGdxmWKwcHItctOFnTOEf7HbKjDBgwFenlykF dpPESAeyS5VkFEYuIR71Svxsd6ytDogY1kDSicHTh7pZGnDAGrJu2+uMWzBMmlhtleqOZoisfZD 2uIQWORy0fl//fgJS9QsQ5MoB7OfDXJmACJNWCH/jyds4CeOWWwKcmQ== X-Gm-Gg: AYBFou1xWx2Ujm6kxXwQxp4z2Mm6Cpe0KoE7HGum/uzpl1+12H5WPpVdkrRvaSomE8n GXxxbQKhw1G61Z+X5WL2v32Hvr77r3r1Xrarv8SdHJaVTl/RXTM+cRJqSS7tA/Bq04HiIWYDJvB uoY+GxOimHB0inRReL0G0pNvP4K03bHHGgTdSzCCyqKAREBsn4fUqrCDob46EXcK03O9c38NV+S 12KXaI4nhWeXfZSnEsGThFv7f8q+WaGgKDX6+XDIOct16BS7Jb+9AwwrPY/IPkE8dneHaY6SBhf MDJoXG/aYIsFNGHwToww72KdK037NiK1sVvxSRBL/mhIaeDLuvXE7tEpTjmrqDcbzGXAsDwignK CYVzOC6upaUvO+g6d9WWQTtK9BiCW X-Received: by 2002:a05:600c:a54:b0:4bb:5fd1:92aa with SMTP id 5b1f17b1804b1-4bb78a1b3f1mr42066575e9.15.1794912212198; Tue, 17 Nov 2026 02:43:32 -0800 (PST) X-Received: by 2002:a05:600c:a54:b0:4bb:5fd1:92aa with SMTP id 5b1f17b1804b1-4bb78a1b3f1mr42066155e9.15.1794912211750; Tue, 17 Nov 2026 02:43:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794912211; cv=none; d=google.com; s=arc-20260327; b=H7LC9Z7JwNNmcK9uEOaQkOg5lOMArI1mxrB9V/hICXYGDT2fY6tSSi9cH02egJDlf+ cNyXrjXI4/Et9qz0+B5FnpJKlQ3VJY+UmTQL4q9xXY4MdmKGizYUfA1X4iEtVTuJjdKj o7ZNPqog7Q+6sTojyzecoIS360NdUc0Qg+a2JIhxAFAOyRjAXIAdmL67qVt4YCgm1ydG c0xvc32hR0rvhBAaBaJwkvMSPe4muT68PczEyE50AhECp59lmWJ5chngsFgRSrUIPzCh xuK+EE/yIFqqGVy+Bk8a6kyeYjoWQYXQ6iyPKynb9gmMHnzNiDeKErOpwfpC9iHyUCxP MhnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qd369UOA5UJ6S7kp0rs3czdA41E7zEaNLsDz/JoUbvk=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=VSoUm3MPArAwalndYg+dpYuQIbl5dG7gnIxbYHOqlGEp+l2Uor3VwXIK/bUigAVTkN GLY79Umt6G4BBGWglkJNiX0GpNgC7RTkGvbC6RMYABitXo5RRUF9SSW9AlShOlbtQGm8 bTNWLFScQ6RtlHV9I39s7va1vafPjLRKKrG3TvE5iUCzrqEb4ILEuvtFFqQgFCWOlaEV iuv0lfJuECQwVNOhJiTTYG8ZflfapwEWj0vQSY46VgiO3x8+nzZVbPpyz6OU9p8iFiNA 8tC+HDqeNjvZ9XB0kM5WpkYBnGglOb8HdZlS8jzOLdEi1we8sv0QHbF6yIbzZFYNUM4d tLOQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=cZCArX+3; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id 5b1f17b1804b1-4bb567229b4si29507965e9.1.2026.11.17.02.43.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 02:43:31 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=cZCArX+3; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=qd369UOA5UJ6S7kp0rs3czdA41E7zEaNLsDz/JoUbvk=; b=cZCArX+3LISN YCO+vMZHlX16caJ++VPU7pU4KK9XFiMdPpDMNw+8RYWOwznQoU2jPrHxqagNCSyVhoIumFa5OAdmb R30lYnHpGHFHVMdInXuklOLRVNyoAY0SH9Xrw37mdIjXEmpU0Ep9d7zC6Z8DwE3j5pCcaFeHVfqD/ tVxzDxTQtLqhp5QGikyTj490wAU5A0T50JUZdlUoQ7faYoVNKssmmzwxaHofPFgZ0G3phouA92WXt rsH/+9ArcBseIeMeKCyY6dHcYsoVY+eHWGJl2/Nz9bwsgO05PTRl2nxPpgDLdv7DamToMgbes7Nyk d9IyVS1KrG5Tt7XhHZlsWA==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTGag-009vj8-3D; Tue, 17 Nov 2026 11:43:21 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 11:43:21 +0100 Message-ID: <20261117104329.3079812-2-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117104329.3079812-1-alexander.ivanov@virtuozzo.com> References: <20261117104329.3079812-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 1/9] drivers/md/dm-qcow2: cancel the event work and ENOSPC timer in the destructor X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org qcow2_try_delay_enospc() schedules tgt->event_work on the system workqueue and arms tgt->enospc_timer, but qcow2_tgt_destroy() frees the target without waiting for either. A work item queued just before the device is suspended and removed runs on freed memory. https://virtuozzo.atlassian.net/browse/VSTOR-152175 Fixes: 6e2ec304689f ("dm-qcow2: Pause IO and notify about ENOSPC events") Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-target.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c index f4004f6095a7..c49b0f466867 100644 --- a/drivers/md/dm-qcow2-target.c +++ b/drivers/md/dm-qcow2-target.c @@ -254,6 +254,8 @@ static void qcow2_tgt_destroy(struct qcow2_target *tgt) destroy_workqueue(tgt->wq); } qcow2_merge_backward_cancel(tgt); + timer_shutdown_sync(&tgt->enospc_timer); + cancel_work_sync(&tgt->event_work); mempool_destroy(tgt->qio_pool); mempool_destroy(tgt->qrq_pool); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel