From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 585E9803F6 for ; Tue, 17 Nov 2026 10:45:13 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAhuXM008357; Tue, 17 Nov 2026 13:43:57 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAhuXM008357 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="LyElxLKq" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHAhWnb008302 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 13:43:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHAhWnb008302 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48e29c25101so2006658f8f.3 for ; Tue, 17 Nov 2026 02:43:33 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErF83paldKqFy20MbQcWqPSkvrYB8vj8ce4ScxAmEYklpK1MPirE+a0wImeW8Eg2bSwxy46a7g==@openvz.org X-Gm-Message-State: APuU4Z/sTx6FLxbGGc/Bvpbw5wRsYAfj/ZFcBvh+BVK6oBi+7pu/z6/8 8NoVbjfME9qxqJCfk6oDLrHVyXgQmqo1U+VvbKzvyBnnna/bH7m5CiWCfVQ4uzqPue3CZbMsbz7 kvZYq74ec0/weomG+/8LDmQh+W4DKntg3NuIz2su+t1pJoA0niS5E8g== X-Gm-Gg: AZFdTZcCIcrJbM+nhUlMaggJNB28X+7A42lnhVkmqh28RqS/876PRpVE1d8JyO7gqaH LEGimA+GkUqOpddBARECo7je3+ddFnglLJFWCbHsmgCZZCKr5Quc/vhptKTrp4RHgQIekBF/lum uD08GQ17BcPEvxBUNm4EVZMkP7p9PePPjLpjNerRHrdsIv/u9Ph31+4mSuP4yZJuB7y1DbLrirv CsTKgFXAN2ejgZDXJy4V1zA8VqKkvy3ED80hFpgurw1TfWCEQbLVnzpU6chNc+fqGkM9yhrRz0x fUFpBNPdW5pjG0JXlzjYbI7CrH8cSDW1Pa03jdgAFc4or99/X+qTkvty8wkao7z4SKvGoU9l/+y A34rerY6n56YTfl2r0nKXRFEtZiFm X-Received: by 2002:a05:6000:3102:b0:48e:4300:c6d4 with SMTP id ffacd0b85a97d-49c747700e5mr34154417f8f.53.1794912212513; Tue, 17 Nov 2026 02:43:32 -0800 (PST) X-Received: by 2002:a05:6000:3102:b0:48e:4300:c6d4 with SMTP id ffacd0b85a97d-49c747700e5mr34154367f8f.53.1794912212015; Tue, 17 Nov 2026 02:43:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794912212; cv=none; d=google.com; s=arc-20260327; b=eQWH3giPht1P+Oif726TQtiEwNJRTBzu4K3A3sq7F9evHHjlO3RTD3/hH/yE4TDXP0 MqGbewVhbUQMwuOco9I3zG2v/z8eV73b9dCWLkrTdMgwQrs/xvhiSX37ZoCj0vGUlaSS tx3I2Tf6UnKvVRJuI1sEY59jL0kI8kOMY8RkQuNs9+QymrFG3jldLYKp6eu3XgxGqmAX 1kRNFHHRkWft8f1Cx83LHGhJzxCdSfAqeao0azUbL+4TfBTaDWKSi/q4EPv4CjU/2D83 D0BW+w3HlBZMfyAILyFnSlkC+6O3u3VQ4Mps6L8B0Kq3aaboznGo8WihtXE7HNm/LiyB XPTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=lXFKW1tAYPqnJUORJRdHrly3A20voSWR2KlITfJWek0=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=jGBdStgdu4pSaaGIrtFR92IbDwgzVc4gl6506/KjEZWeNfxuihf87bZ+7Hu0Bf5ijX 7p42xrX9nAaUI/E9VYY16/9g3FKOvlEACM475zLGWLf3FMjGtUnz9xP3CPNUWUpPZ29Y GlkQ12je08mLzDnvN9cZJevPyFEreM4w0jIuDTUAI6V//hMSZTukSiemq6AWod+FWYQq Poe9hUfO/GIuU069o8Xy4F1tZ1YLFn4gI5YsaeZZ8LulxrTEbymK5079bnWNfsIPH1h4 jXWmPW6b03m+w4/Rq+468MDVE9Hkfk9kUbyjqKN7/ceOh3E55LwIrhVGkqQyPkLNrZZ4 sK/g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LyElxLKq; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4a4aba7c33dsi2184541f8f.354.2026.11.17.02.43.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 02:43:32 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=LyElxLKq; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=lXFKW1tAYPqnJUORJRdHrly3A20voSWR2KlITfJWek0=; b=LyElxLKqxEIc 2KZJ+71mEzdhK+sahnN7qfhHNjpV2yHAqL7cuh699/Dm81fugZFvSr2OoJyKePqHy7z5O9UPfoXVn +r27sfWiOL+QP0BwbxbwP7yb9QUzd8P23+1FZPqUtGjiExoUrK5QDDGhOEHF/hWp/OuzL6fwLbv8m tVu3CdLy85p5eqiTwFeua3+8YrQH+iBWVR0alrsy4nRigUdw3No0N/ZVB/yRXTQU8QKT8TfPnfXHC HPVmSJchiarDMSP4aUgSSS6PN++QN0vQC7Za7Ln/npop0KnhqqdEIQjdAcmAfQ/nIPGbycOoaXSC/ PuPF/9gLBI+F4JK4ySwlLQ==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTGah-009vj8-1G; Tue, 17 Nov 2026 11:43:22 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 11:43:23 +0100 Message-ID: <20261117104329.3079812-4-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117104329.3079812-1-alexander.ivanov@virtuozzo.com> References: <20261117104329.3079812-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v3 3/9] drivers/md/dm-qcow2: rename the ENOSPC delay list to a held request list X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Requests that fail with ENOSPC are parked on tgt->enospc_qios and resubmitted by a timer. The same mechanism is going to hold requests failed with other errors, depending on the disk error policy, so rename enospc_qios, enospc_timer and qcow2_try_delay_enospc() to held_qios, held_timer and qcow2_try_hold_error(), and let the latter decide whether a status is to be held. Drop the WARN_ON_ONCE() for a non-write ENOSPC. A read can get ENOSPC from the read_iter of an image on FUSE, and a WARN on an error of the lower file system takes the node down with panic_on_warn. Such a read is still held, as before. No other functional change. https://virtuozzo.atlassian.net/browse/VSTOR-152175 Feature: dm-qcow2: block device over QCOW2 files driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-qcow2-map.c | 31 ++++++++++++++++--------------- drivers/md/dm-qcow2-target.c | 16 ++++++++-------- drivers/md/dm-qcow2.h | 6 +++--- 3 files changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c index 32373114580e..b987d459863d 100644 --- a/drivers/md/dm-qcow2-map.c +++ b/drivers/md/dm-qcow2-map.c @@ -4566,14 +4566,18 @@ void do_qcow2_fsync_work(struct work_struct *ws) current_restore_flags(pflags, PF_LOCAL_THROTTLE|PF_MEMALLOC_NOIO); } -static bool qcow2_try_delay_enospc(struct qcow2_target *tgt, struct qcow2_rq *qrq, struct qio *qio) +static bool qcow2_try_hold_error(struct qcow2_target *tgt, struct qcow2_rq *qrq, + struct qio *qio, blk_status_t bi_status) { - bool delayed = true; + bool held = true; unsigned long flags; + if (bi_status != BLK_STS_NOSPC) + return false; + spin_lock_irqsave(&tgt->event_lock, flags); if (unlikely(tgt->wants_suspend)) { - delayed = false; + held = false; goto unlock; } @@ -4582,15 +4586,15 @@ static bool qcow2_try_delay_enospc(struct qcow2_target *tgt, struct qcow2_rq *qr pr_err_once(QCOW2_FMT("underlying disk is almost full"), qcow2_device_name(tgt->ti)); tgt->event_enospc = true; - list_add_tail(&qio->link, &tgt->enospc_qios); + list_add_tail(&qio->link, &tgt->held_qios); unlock: spin_unlock_irqrestore(&tgt->event_lock, flags); - if (delayed) - mod_timer(&tgt->enospc_timer, jiffies + ENOSPC_TIMEOUT_JI); + if (held) + mod_timer(&tgt->held_timer, jiffies + HOLD_TIMEOUT_JI); schedule_work(&tgt->event_work); - return delayed; + return held; } static void qrq_endio(struct qcow2_target *tgt, struct qio *qio, @@ -4602,18 +4606,15 @@ static void qrq_endio(struct qcow2_target *tgt, struct qio *qio, if (qrq->bvec) kvfree(qrq->bvec); /* - * Here is exit point for rq, and here we handle ENOSPC. + * Here is exit point for rq, and here we handle errors. * Embedded qios will be reinitialized like they've just * came from upper dm level, and later resubmitted after * timeout. Note, that we do not handle merge here: merge - * callers receive -ENOSPC synchronous without intermediaries. + * callers receive errors synchronous without intermediaries. */ - if (unlikely(bi_status == BLK_STS_NOSPC)) { - WARN_ON_ONCE(!op_is_write(qio->bi_op) && - qio->bi_op != REQ_OP_FLUSH); - if (qcow2_try_delay_enospc(tgt, qrq, qio)) - return; - } + if (unlikely(bi_status != BLK_STS_OK) && + qcow2_try_hold_error(tgt, qrq, qio, bi_status)) + return; mempool_free(qrq, tgt->qrq_pool); dm_complete_request(rq, bi_status); diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c index aa0bbb6b4a97..89b12c4f971b 100644 --- a/drivers/md/dm-qcow2-target.c +++ b/drivers/md/dm-qcow2-target.c @@ -254,7 +254,7 @@ static void qcow2_tgt_destroy(struct qcow2_target *tgt) destroy_workqueue(tgt->wq); } qcow2_merge_backward_cancel(tgt); - timer_shutdown_sync(&tgt->enospc_timer); + timer_shutdown_sync(&tgt->held_timer); cancel_work_sync(&tgt->event_work); mempool_destroy(tgt->qio_pool); @@ -480,14 +480,14 @@ static void inflight_ref_exit1(struct percpu_ref *ref) complete(&tgt->inflight_ref_comp); } -static void qcow2_enospc_timer(struct timer_list *timer) +static void qcow2_held_timer(struct timer_list *timer) { - struct qcow2_target *tgt = timer_container_of(tgt, timer, enospc_timer); + struct qcow2_target *tgt = timer_container_of(tgt, timer, held_timer); unsigned long flags; LIST_HEAD(list); spin_lock_irqsave(&tgt->event_lock, flags); - list_splice_init(&tgt->enospc_qios, &list); + list_splice_init(&tgt->held_qios, &list); spin_unlock_irqrestore(&tgt->event_lock, flags); qcow2_submit_embedded_qios(tgt, &list); @@ -542,8 +542,8 @@ static struct qcow2_target *alloc_qcow2_target(struct dm_target *ti) init_rwsem(&tgt->seek_rwsem); init_waitqueue_head(&tgt->service_wq); INIT_WORK(&tgt->event_work, qcow2_event_work); - INIT_LIST_HEAD(&tgt->enospc_qios); - timer_setup(&tgt->enospc_timer, qcow2_enospc_timer, 0); + INIT_LIST_HEAD(&tgt->held_qios); + timer_setup(&tgt->held_timer, qcow2_held_timer, 0); ti->private = tgt; tgt->ti = ti; @@ -1165,8 +1165,8 @@ static void qcow2_presuspend(struct dm_target *ti) qcow2_set_service_operations(ti, false); qcow2_set_wants_suspend(ti, true); - timer_delete_sync(&tgt->enospc_timer); - qcow2_enospc_timer(&tgt->enospc_timer); + timer_delete_sync(&tgt->held_timer); + qcow2_held_timer(&tgt->held_timer); } static void qcow2_presuspend_undo(struct dm_target *ti) { diff --git a/drivers/md/dm-qcow2.h b/drivers/md/dm-qcow2.h index 3f1d5b5eef26..ea6bc6258cb0 100644 --- a/drivers/md/dm-qcow2.h +++ b/drivers/md/dm-qcow2.h @@ -19,7 +19,7 @@ #define MIN_QIOS 512 #define WB_TIMEOUT_JI (60 * HZ) -#define ENOSPC_TIMEOUT_JI (20 * HZ) +#define HOLD_TIMEOUT_JI (20 * HZ) #define PREALLOC_SIZE (128ULL * 1024 * 1024) struct QCowHeader { @@ -213,8 +213,8 @@ struct qcow2_target { atomic_t service_qios; struct wait_queue_head service_wq; - struct list_head enospc_qios; /* Delayed after ENOSPC */ - struct timer_list enospc_timer; + struct list_head held_qios; /* Failed, waiting for resubmission */ + struct timer_list held_timer; struct work_struct event_work; spinlock_t event_lock; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel