From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 006A7803F6 for ; Tue, 17 Nov 2026 17:19:06 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHsVs011098; Tue, 17 Nov 2026 20:17:55 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHsVs011098 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="qI9E0Ocp" Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHn8Q011053 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 20:17:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHn8Q011053 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4bb68a5e792so6573385e9.0 for ; Tue, 17 Nov 2026 09:17:49 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGUkcWCO/dEiqnO/qP9dV1SES/7GRAiayIO2URTWclLnSXPcK22jRdBOvWYHBfCaUVXvhWu9Q==@openvz.org X-Gm-Message-State: APuU4Z+Lpo060qIXu9ky09/+101O7mfzAGFXanbyWRRX/J6CYKY/n49R q4CxSOB3nHXWFOx5Ep8W5jyg+WhKvyxCmZRUdkIguuQMsljmTfmpGfaB7D5cUmXKKND1g5fyrKI klpKHmwvkeqOL/i7069BDjc1+epEcXKMr1FF/qGR6+x7YGspzZWevFg== X-Gm-Gg: AYBFou1ppVznw+/4lM1XOQZBwTrtXgiew6YyEX+wKb5QF75ztgMVD6Y/6klLvpEK1r9 vdbV0/PRJj2EYQsf1rimOeHKZ/gzXSg9KF62n4F3bBAUd9c2yRRWjXyfzD368bDYJVsD3uEiG+C U5atwUaDGLEiId2fTsYufzsqodj2DYlTQzn2CqpKE4jQ1eKMMFPKCQzjAFhnW0MvZ/wvsYFIfnA zJRbatqmf9auWS9QuYq77KHQ6/m3JlEE0Izz3vTVXK6HTBz5ZNQeLnJfyNkOoJKyvG9PLHUgaoj Vt7i0tJhI6Ytt6Sz3dmbZpL78q+/zbtac3UnFjE2qMrNYgaleAdZv4GqLE/5oW2CXXomy9iR0Cg hE2ZbBavSdjuKl6LxH6m38KDFuu8= X-Received: by 2002:a05:600c:678a:b0:4a1:d49e:9ce with SMTP id 5b1f17b1804b1-4bb78372a20mr90531055e9.2.1794935869203; Tue, 17 Nov 2026 09:17:49 -0800 (PST) X-Received: by 2002:a05:600c:678a:b0:4a1:d49e:9ce with SMTP id 5b1f17b1804b1-4bb78372a20mr90530385e9.2.1794935868678; Tue, 17 Nov 2026 09:17:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794935868; cv=none; d=google.com; s=arc-20260327; b=F2jPh6rdzp4YG2nPpiQWfF8owfU3W30n/d8KDG+sxZnoZP42PBC63qZyE+SkbotAH3 ssA4eXA00cjWFwAQdReTSSiKICz0XbD0d0A/ckPl6ucHIoyUWjyf5YI5hb9LIYpqgQqI C0+FEfrcTUUnIEBp5ws3ZkcItP6FhcODbtkenf5fk+PlqFbIWkAjK97gIoa3Pp/gpiQx D6iF4S/fHdELtg4LwnypxmMKU3qkcWM0IarQQ8VtzCkEmUNL5KsBzkT7l3QuuFkdu0DF p/8LcfxXhr7FPL2s63a/oAaweuWU846PtI9GRLQgLndXKjKpu2spiG4MLOxltMyVgPbv 5gRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; fh=CMILZ+goaghq6B4UpCDhf0EQp6kYD0LAlmOkUiVCOvs=; b=fZZDelYQ24LZRNxWOAG6hTieTOK3K+wy5YKwSliOoc358/0vy+iEpXTWu46lAkrIK7 IrbF/hS1fcdTiA892v0OfSGUmDMUBUHV+Sdu1Ja7jUiSN4u5Woz0iQ5F9p4VilIYCjM7 NvX++XH/cN59rXSKKc/FSOxhYBaL6foRgGxnil1n+mJsvHiCvctoM121Yh8TFMJAnOxQ 7CFDifhEgurCs04V9CMGmwDBeh2o9kxbr0BphCUdeg9ecyGhR/jy035viCCLKJ/d/Cjz 5/7MFXugjdvX/fX/IxxHTLA/mU+BkWA5V4994cRF2flXuM/F1mBbn/jY84rUcse5kPxj xqFA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=qI9E0Ocp; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-4a3f3354f77si5545141f8f.197.2026.11.17.09.17.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:17:48 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=qI9E0Ocp; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=n4RoA2oCHudzQin9z0lH8XL1ON6Z6pp2K9ak5gjAdT8=; b=qI9E0OcpAjOt Qat/xSzCE/Jrz6VuEkOiJO3IJK8AOw+AQJqNkKF+9acDlwVb0EvH6M6DTbPgHYlE+mCdBBa8oBIve GD3cXouH/NDOCQQVp7L0uXow2EQhK6uw0ItXQ3qAylZb2lgRfAEPu5wa1n9/vIIdz13R22+BvbK2g ZHu2auZMct3NiLfOycAdedmKrSphITe39w++DHsNgxzW+4HF6v/gFRIKQzATYgQEiNWrFFGNBnOue w0dBKo1ZxVJp5zz4IsmysaDSaGujhZfSSHnbAeYC9dMIfW8Sqiyko1ax8qU67S7/srnhOy0YntHOn r82FIoHTEqcNkDXbgtEz2w==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTMkF-00HOVM-1v; Tue, 17 Nov 2026 18:17:38 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 18:17:34 +0100 Message-ID: <20261117171743.3216794-2-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> References: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 01/10] dm-ploop: reject a delta header whose BAT does not cover the target X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_setup_metadata() takes the number of BAT entries from m_Size of the top delta header, but checks only m_SizeInSectors_v2 against the target length. A header with a small m_Size (including zero) and a large enough m_SizeInSectors_v2 passes all checks. Requests past the last BAT entry then hit WARN_ONCE() in ploop_rq_valid(), which panics the host with panic_on_warn. Reject the header if the BAT does not cover the target, taking the skip_off shift of request positions into account. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov --- drivers/md/dm-ploop-bat.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 5ddb8ffdff07..7b12b0f9fe81 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -10,6 +10,7 @@ #include #include #include +#include #include "dm-ploop.h" struct md_page *ploop_md_page_find(struct ploop *ploop, u32 id) @@ -189,6 +190,7 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) struct ploop_pvd_header *m_hdr = NULL; u32 bat_clusters, offset_clusters; struct dm_target *ti = ploop->ti; + u64 end; int ret; m_hdr = kmap(page); @@ -229,6 +231,11 @@ int ploop_setup_metadata(struct ploop *ploop, struct page *page) PL_ERR("Too short BAT"); goto out; } + if (check_add_overflow((u64)ti->len, ploop->skip_off, &end) || + SEC_TO_CLU(ploop, end - 1) >= ploop->nr_bat_entries) { + PL_ERR("BAT does not cover the target"); + goto out; + } kunmap(page); m_hdr = NULL; -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel