From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5C51A803F6 for ; Tue, 17 Nov 2026 17:19:14 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHI1jt011118; Tue, 17 Nov 2026 20:18:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHI1jt011118 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="xyeKsSFJ" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHHHogJ011063 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 20:17:50 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHHHogJ011063 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-48df02b91f9so645825f8f.1 for ; Tue, 17 Nov 2026 09:17:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErFY/0CDjqXpFarW8nfUK0YLOXj6oNKcuvH1HjwcL+7SXTc73+JZnaTpipSzGzMOdzjRxD1GFg==@openvz.org X-Gm-Message-State: APuU4Z9xlwkq7tPbila1ZclSilGbW9d1cNWl4O4ZdP3JILS/eLM/N8DK dKvhMKqMBbHeHotC50C+cg/TIfeA8VNz5xbzQjkIOEAkBeZaS1w2x+SFqYR/SySA5aPJH1gpaLo Q2sotZi0BaJKzf4+WlbSrv2tyeSOD5pDjopCDCGYU4yLjE8X3uLlzgQ== X-Gm-Gg: AZFdTZdNV25N4HmA0xTZDlH44gQAaO5g3KqyvNU5l38j2HPSoJi48MO5co91cdzAoo9 e+cMp3c1o0T4z81pRPuIDJ7lIStto+D9FpEoWQBw34CCibg3f0vs+VC0leJ7XqI7k/MhQfb+MuS oCL62+alPmJ3qZw5a9j0a7MKXWBort44+rPEAWBwleYn7nl+D8ynG1qE9vHKd4Ht8evphKf4Swb Ds7+i19WbTeMwLHbykRka66YGkzTMW5E3W1ByFCeXO6AMrPoidUeR7ZdNLM+pUgKkwSokB+N7p4 LXEm4pIlgLK5eKUO+pkUwF09qWuWKYo0jt0ZZqdOKqueWQ3pLS4Tz9L/YDB9DSjbHRpFLCHYNZA mXGx8bE9ZaHxi1pIMEE1pmiYWZTfG X-Received: by 2002:a05:6000:15e6:b0:48e:6669:fefb with SMTP id ffacd0b85a97d-4a63ab74288mr133552f8f.22.1794935869910; Tue, 17 Nov 2026 09:17:49 -0800 (PST) X-Received: by 2002:a05:6000:15e6:b0:48e:6669:fefb with SMTP id ffacd0b85a97d-4a63ab74288mr133518f8f.22.1794935869424; Tue, 17 Nov 2026 09:17:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794935869; cv=none; d=google.com; s=arc-20260327; b=F/muvXkclKQhr6GfW6BTE1qRB03mNbPiFhjWVLz+EAal4Doh5JVioDAh5Spw6j3D+F vc20mWNg2lxDuCiQ1lf27NPWydcNGnFdwFDR4WDjpiQr1uf8IqKskE+AdPZh2U0IdvGd g95TafD7RQGHZkOtmLchRVgGZ5XXVGJ4KtM5lJFUaQCndEm8hRoIcdJotdDMbBd5NyA5 wdPsNf7LPzf7uzptDi5fsyEfSHiAjJfkNLd4fzPMDhxGoRWSvhbrsidyrYRQ5YBeezyl ZpnVMXZwUB3uFLTIDQnuWvWE/hth1ppho5uHxXN1/Tr0YbCyHFVbMz9lrD8M1KLYGbZE rGrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=S5QUIifMVuW+KNmnsUSGD5keveOqhz2JhJaix7xxq2g=; fh=E3vCAgcov/hQ3XWh2CqQ9wok33eMAQJstV7H9y+Mjr8=; b=iHdROT11CWE6nV1FrD1Yv1mz3Yg528dP3gnPlSzf4KlOE6h1u+lN8JL0Fi3ABPHXky XzRgNqEb921Ow8rpw38IgcVEO2wfD/AUHomUeXp8uEps+ERMcYrLV6UMLiMV7HFu/A91 nUHMrU2YY39e+dLA5q8deFDHqFbsjtT+tAK/kpOr9zcrjtJI1mviOmI7ailrtW20nY3l /GS2XGIfavunJaEp0kVGg0+RphaacoQ7tN+ZJWKJcIlM/xAoPAZoRTuVLMOo99cOFxf2 5MD4vHvxn1PhxbEuKfh332re89P6kwe1l+Grn8UEIlPJH+DFtSG6EC4osu07XxZNabst KgJg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xyeKsSFJ; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from relay.virtuozzo.com (relay.virtuozzo.com. [130.117.225.111]) by mx.google.com with ESMTPS id ffacd0b85a97d-49c6426d376si30638669f8f.295.2026.11.17.09.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 09:17:49 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) client-ip=130.117.225.111; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=relay header.b=xyeKsSFJ; spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 130.117.225.111 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=S5QUIifMVuW+KNmnsUSGD5keveOqhz2JhJaix7xxq2g=; b=xyeKsSFJBuCk RMYjb/JnAPNcs49RI7NDuoYTO+ln+DWTX0bjX3Neqfw2C/qtfsR+xWXrDjJ7tXhec2GaLOSQG2/3R 1OcBT/rw33e58McyF784N3cQVC7LBpQhQMFUOWwxxP+UOGCPtmuAOTuSta3HJ5G0brFi4UTH3J0gP Pf/TmzSOlTdjYhWRvon63cjdUz1RcaGcXgEY0nQSeLckPh4gBWKFsDpLV3IEhu8M9C6LEQTFfE2BE Uk4TawEhWWx16nagDstqaW+1TQUKfo7TtqMZwCO+uKiUNyYYvicM80EysA7iXzgQMXgZLMZjv0eEH qPBDcvXdsfQ27/1Of6y7/Q==; Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=sky) by relay.virtuozzo.com with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xTMkG-00HOVM-04; Tue, 17 Nov 2026 18:17:38 +0100 From: Alexander Ivanov To: andrey.zhadchenko@virtuozzo.com Date: Tue, 17 Nov 2026 18:17:36 +0100 Message-ID: <20261117171743.3216794-4-alexander.ivanov@virtuozzo.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> References: <20261117171743.3216794-1-alexander.ivanov@virtuozzo.com> MIME-Version: 1.0 X-OZ-Fwd: true Cc: devel@openvz.org Subject: [Devel] [PATCH hci-8.1 v7 03/10] dm-ploop: set delta is_raw before applying its mappings X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org ploop_apply_delta_mappings() takes is_raw from deltas[level], but ploop_add_delta() sets deltas[level].is_raw only after the mappings are applied. So a raw delta is handled as a non-raw one: its md_root is empty, ploop_md_first_entry() returns NULL and d_md->kmpage dereferences it. This has been the case since the driver was added in commit 6ddad5a4d226 ("dm-ploop: Add ploop target driver"), i.e. raw deltas have never worked here; this is not a regression. Set is_raw before applying the mappings. https://virtuozzo.atlassian.net/browse/VSTOR-148171 Feature: dm-ploop: ploop target driver Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- drivers/md/dm-ploop-bat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-ploop-bat.c b/drivers/md/dm-ploop-bat.c index 4fc99400a0a4..3427d1a90d81 100644 --- a/drivers/md/dm-ploop-bat.c +++ b/drivers/md/dm-ploop-bat.c @@ -512,6 +512,7 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r if (level != ploop_top_level(ploop) && nr_be > deltas[level + 1].nr_be) goto out; + deltas[level].is_raw = is_raw; ploop_apply_delta_mappings(ploop, deltas, level, &md_root, nr_be); deltas[level].file = file; @@ -532,7 +533,6 @@ int ploop_add_delta(struct ploop *ploop, u32 level, struct file *file, bool is_r deltas[level].file_size = file_size; deltas[level].file_preallocated_area_start = file_size; deltas[level].nr_be = nr_be; - deltas[level].is_raw = is_raw; ret = 0; out: ploop_free_md_pages_tree(&md_root); -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel