From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D36478017D for ; Thu, 12 Nov 2026 18:13:25 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACIC7Q4011430; Thu, 12 Nov 2026 21:12:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACIC7Q4011430 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="axjJp8+3" Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACIC5ZL011426 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 21:12:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACIC5ZL011426 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-6b596e9b1caso89220a12.2 for ; Thu, 12 Nov 2026 10:12:05 -0800 (PST) X-Gm-Message-State: APuU4Z/lwFpVRuk3ui1+IoJFlXQUs9y/XFMDrReoykOWz9swL8znPKMJ ioGkJEE16xJvPC7BOMpDXbpSnrMAJjkfcXxDR80oyBp9VhjrY9RHwy2wfkY8z761HpTPLm6m5nz AHOdUx6v8XsukePfdoLofnBQxtyFkBfHbCbv/9HTmYFcn0LsNWScOIA== X-Gm-Gg: AYBFou0281p4L48419vkZF0PfZEhHTUScKhPRdnLVyuAnMrsenIe49LBzDqHL/DtI2H zw3MbqIMSzOIeSn4HrqDOdMb/SicV2muFHEt+TASfn1cw2gaQKZczDKUzH9vSRs2af8+R1/ppR4 geo9r2ocVHHSpNgtz3AVQSWrW7n3vYY74H+pQA7ZwroCe5OCj+7zl4T8gufIjTCXCVbQ5iSolQm nEzsKS5yFG1c/CYu0rFC9hdeW+9WSXJvfUMBp6TiIM8hYZkJbyMDQ4WzlbzUlEZTzIhmGMtz4B9 PNgo87ZjTbgGCM0lJXPryDVJ6CjlmDDtIbkMi6MLQ6+ZhjyJHgm335WtECmyLuizgvKc3JAGB8I zab3va7AKpd1dpPljylw/8cOPWJqicJ1ZaaTdE7U/MNYruy8KQzs0mAF2pkKZ1ui+48kmW2IGIn qG+WK7bZoEAO7T+1+BRi+YGOAh X-Received: by 2002:a05:6402:4402:b0:6b6:f7f7:dd8b with SMTP id 4fb4d7f45d1cf-6b7c0bbe2c8mr399568a12.14.1794507125005; Thu, 12 Nov 2026 10:12:05 -0800 (PST) X-Received: by 2002:a05:6402:4402:b0:6b6:f7f7:dd8b with SMTP id 4fb4d7f45d1cf-6b7c0bbe2c8mr399553a12.14.1794507124556; Thu, 12 Nov 2026 10:12:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794507124; cv=pass; d=google.com; s=arc-20260327; b=q3rTmO87JVNngf3foWGIMSXEZMpnbqwT/CApSgEZ6rQDikcznSGMIy3CG6/rUXcXZz YQ9kA4jN+Y6eupHeP0f+jdsjvvAODSVjm7FAi68UYbikDpEXZr3tcupGSFGl4OCtdnia ojAQCUjP7dsVdIhUnLDEBMPcSol7XNbH0ZNtZViE+Vkk215BGpg59y9aTLDcylPsRnl+ QcuN4lNtOmcOBSCAU0UR61bVB6zsG6jL4iH8pMrjtHMZjpxJIdkoeYUroEuXcdGqbrLK C+E/L6JCvFPxLI6e7L8MmhJPDXbzn87Qj2pooklnFhQWm3hxLYIS7AcU788s7e5yQadq 07vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=pbYaCWfRYqld0NLTGfc36Q0VySqJlOfkt+fZpw2eyeo=; fh=XWCApJJLo44OtxINQeRRTjaEbIS7MFg+xjlkutr7pjQ=; b=fCx77ZDfAQ4tE7ZXHKsqtENpQuOHUHZShdZB52n+LlMTXUEBCtVkSaWziVGjXXBzp3 sR1BgfrQzTOetlKgpoEmFzs2vmdEMe4FNqPwYZVP72j4eF0+XieCJnOaF4w4nwRSYZ6N R3MhEsxs2OsvEi1Kydy6ao0UYAaKEgPYAZOlaBi6R8y2qiG2uX+gI3s4OtMvVVw25Dhx VVN2FKd9Ei48Q6FWHa8PBUss2HTckLqC9a/lqOEscgUgXxvLPDOoIx6pCl3+xBpiai8c nbYImz02mDHcVYOE3lipdbK9fDDLaLXGXEfDE7M/mnMZu6gTwa83mei2ya/6E1o0BNIv L5/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=axjJp8+3; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c200::1]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-6b7c26bee0csi60436a12.217.2026.11.12.10.12.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 10:12:04 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) client-ip=2a01:111:f403:c200::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=axjJp8+3; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mWBVWdtXJVWvAqoWhDGSHjjWd1SqvNbg6M9DJCOc1cvOn0KrpRxWqSHfKCEXU+M7gLssUDD94h/LetH7qoZ1WGQ3PvCmJbzD/Ab1fFIJoe8PxpLzJWB3WOjjYFeCHmhMYff7P4r60Z/hrgq2iAVZj8hNPhR7mcXvI/1LKvvDIhG+D/x0sDT2v8AeZIz5ohzay0/SB+KB1YEJmv2AKqeXmQahnze5dIDiEzptdu72dlJ2Dz59kbR8N50htPFcamSwmGr6YQzQ2PZv/UTNIpagc1qsFcrU1z0yUiagogE4tCLcqL0pLzGgD4Ox66u4xzFzNF7zmOa+LA9HgDdHgxa+fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pbYaCWfRYqld0NLTGfc36Q0VySqJlOfkt+fZpw2eyeo=; b=DEu2WoZmS2HHGBRP71WWi4WyFnR612tzA5n54koVUPxRjGjQWt4D3r2D7YVCWoj3vh/IqTZJ2inHvQnnPQJlyts5sEPR5F3rkdAv9f64aAwkfB5xpJkMTbHYKMeYA84yCwiOvr13x74qmRQHjXLADFGCxkHWDTMzkdC6lQulrnXePsAkhnwNgdfjfQkd0ZUPXCcohI0DQrP8xHF8Fivnxw+xuzAuc4kr8YAjnQ/JACCfX+Is+u3y3lHkB5ZwxLZ7V5+csNw3xb+5vd4FNl0GKsVPmELeah+TQIEa6r576NEBprdj5Iqhd4jU2Ep+TClbVheHhYPMvOgZWPC5HAxxjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pbYaCWfRYqld0NLTGfc36Q0VySqJlOfkt+fZpw2eyeo=; b=axjJp8+3JFTWTLdCThVa1/b9u0f8wDDmPrfOty6TnWVhvWiYdTJKwpf4LR6E9PXXi+yHoZ7b7VnNrZlo8QvF6qZikCTDaM+ephU6dhLALSwQDCsykY4uPu66eQrgr/6RorsOz0fGlYBo8pnDcFJYDPMs9HBPf35wO/7ZIJO2ZCJMA2fZNmRShThyP/l4Ae/fPS+Uia6Sq2iJcptwKtSwL+ds4iKCE9ScvBX8GE3rqp3U11U/drLq1ZfFHlYsw+7mw3CN41BQC+XWp3ZKjolPvqbXkuwwFpOt8gMn+FoMI2CQgIEULLpV/FAxb8ucNEfdMw1QuoTFLeJG0nmOFyoAGQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AS2PR08MB9075.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::9) by PA6PR08MB10858.eurprd08.prod.outlook.com (2603:10a6:102:3d8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Thu, 12 Nov 2026 18:07:03 +0000 Received: from AS2PR08MB9075.eurprd08.prod.outlook.com ([fe80::3f57:9ced:7a37:1bd8]) by AS2PR08MB9075.eurprd08.prod.outlook.com ([fe80::3f57:9ced:7a37:1bd8%4]) with mapi id 15.21.0615.008; Thu, 12 Nov 2026 18:07:03 +0000 Message-ID: <2ab01511-2fd2-4404-9560-4795eba364de@virtuozzo.com> Date: Thu, 12 Nov 2026 19:06:55 +0100 User-Agent: Mozilla Thunderbird To: Pavel Tikhomirov , Andrey Zhadchenko References: <20261105-b4-prep-khorenko-vstor-153709-dm-ploop-drop-the-lock-of-local-md-pages-v1-1-82fed22d5591@virtuozzo.com> Content-Language: en-US, ru, sr From: Konstantin Khorenko In-Reply-To: <20261105-b4-prep-khorenko-vstor-153709-dm-ploop-drop-the-lock-of-local-md-pages-v1-1-82fed22d5591@virtuozzo.com> X-ClientProxiedBy: AS4P189CA0020.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5db::9) To AS2PR08MB9075.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS2PR08MB9075:EE_|PA6PR08MB10858:EE_ X-MS-Office365-Filtering-Correlation-Id: 166d3cbe-e2f9-423a-856f-08df40e7c11f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|18002099003|22082099003|261009223027099003|56012099006|261102123227099003|261022075727099003|261021123027099003|261021121427099003|5023799004|10067099003; X-Microsoft-Antispam-Message-Info: UAWp6SvcJrZ7axBEfJRgDr2/wsAtIizkC9OfCI5vV+AMyZFE2c9iJB1Nngei00z/qrH4/SKzMj8UigurYS38y5cK03NDmrR/cBA2fXzJ06XU7fjYWv0hTQu7DErQHqsjfNNYkMCqw0LNLjAtxMTidh69gO7kccQ9rSrVaz8MZeVV+CaexjCCXfboU7siLH+jMdQgXSLvdxx+5K/31TxU57uEhjUSYwAh4uoXOJfKb4rzDvjwrEH0TGazC/5qSOPgNp1kldOHoYnnhkHKmx96t7NXpfZuJ6bsV2NidRFeXSA2rVKpIxXhieE7wWCDEtbtEYZ5732FcNqzRIOdSYpCLbEJ9ZErdHgwAounQaCnKA5IkUtaWwihrlxA+W3zbvPC6LwclzTqZO23CLeXdVsvraOzBcyHXRkC9/5RFP10EoCuukpxmMi+XiiACgCG6E3XSF4B0jYecWPXDlQFWeC852mqj4LybuUhn7O1DGW74950ZRBurGNdEWEHlkGLErJbvrFhjCtVfBIrr0UGUf6MVgkhmFiEUkZIbrRpX8u6o6FZXeEVN1DZinkbuYxPYktEC7+YLHO6y6CAu0DMrUKXMnVw8KGPce8WufLxvtVO6KdTLNv8H4gfws8OMOa8w5B0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS2PR08MB9075.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(18002099003)(22082099003)(261009223027099003)(56012099006)(261102123227099003)(261022075727099003)(261021123027099003)(261021121427099003)(5023799004)(10067099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3VBQmNkODY5a3piRDlHTURSU0R1cUZDL1lUSmhDU001dlh4YzJwZ2JMQmdX?= =?utf-8?B?ZDgzWVJSTFc3QU5YemhLVlAzU1FzdjlOSFgrMC9MWUxnQmFyak8zWWdIMzN1?= =?utf-8?B?V2hXV3Q0RWFnbDZIa0UrMmYzWGpuSkxZbkRSZ3FaQXZ6ajM0MVIrSURxekRP?= =?utf-8?B?OUV2Zjk4RzlLNG9oblVXMnhVRFJFR1d2bnJhR294Y29qRDZ6UHhHNVVWL1Vn?= =?utf-8?B?ajlJS21IcVhpaGE4UkFua0NZb2ZySndrU2l0Z0pkNGJ1TzBycDZYRm11OVFL?= =?utf-8?B?YXRRRTFhck80aTBBbUZrMnNqOEluVHQ3bTNKdnZjS2FpcGVTWmFEbGhMcVdi?= =?utf-8?B?WnNIME1ObWFrdHdueE5oSUU2YXhBSmhHS28zUG1kT0hMdDFuVEdjV21zenY2?= =?utf-8?B?ajJJdlBLUTVjdWFoSnlsTWJLQkJmSENGSURvcHpzQ0hkYjNEOTRJazQwNllj?= =?utf-8?B?U1RXVmJOZFBMUjhFemhwYm1GcU94d2U2WDIxWmRNM01rdHB2eTA0UHBTYk1j?= =?utf-8?B?R1VIQkU5NFNodlRuQkE5K095aS9tbHQydWRxNFEwMktwZ1pLdWlqYkRPVGNB?= =?utf-8?B?Y0g4M1pKTWZUVVh1TXprRzZQNDh4Sk1EV1NtYWMwa05VQ2x6cmNWNWRBREJV?= =?utf-8?B?djRCR0QxY016ZFZYNkZUdGxhU3hQWlIzZEZvT1hWK0xHUDJadmpxN0tpanVy?= =?utf-8?B?ZzJoQ2U3VDFHN0J2OU1iNVd5cmxXYUt5STk4bWxmckpzRFBadFhIeWloL3py?= =?utf-8?B?Ynd0aklYWkZZWFRVdk9zZ0QzVkt0b1dORGg5MWpMcE1nTGZXK1VzUWhEdGhs?= =?utf-8?B?eGlYd3ZsTWR2em94QjBhUUpHdk5JVlM0SFFYYzB3d0YrZnNPNjlTRjF5VTg3?= =?utf-8?B?WlJLbGxBckZrT24wVkhlVmVEOFhuY2oraTREMzFCUzFvbDdPanRLaHcxYktk?= =?utf-8?B?dUhKUHVxVlhEVW4vQ0pSK1o4N3ZqcW9ZbnRKSTFydkp4Y0dJbVZTR0JYUWdl?= =?utf-8?B?VW1SbU8zbVdldXpaOXo0VlYrLzRBRFBoOVhqSlRQOUhSRnhVeVNheTNsS1lB?= =?utf-8?B?dnJzK2thTEplSXUraGZXU3RscnRDRis1cWRJdjI1SW5nWW02bWhVc0VXdmNv?= =?utf-8?B?akxVQUVScTIxUHZSNkIwS3pKYUxKOU1QeTA3ckljL05oZXZPTFNXbDgvbkxO?= =?utf-8?B?Y3VlOEliMUE2aFQxWmg2dXF6QVR4YXRtcm1qcFRKeUhkRUlYakMyd08zeDlI?= =?utf-8?B?akwyVnBiclN2NkJEQzNrcG5rbitCa2xrSmRoMjUwZjNacldHOSswNThOVUNz?= =?utf-8?B?T2JBdGtMUUo5Q0czbTFGU1hSV1VQek5SVUJ1R0hkRlpSODRSZVpIOHJzWFVz?= =?utf-8?B?TWJZMFlxc1I5bXlMcS9HQUJrMzhERDZLQUk4d0JzU1dwa2duYzU5VUc0d3RD?= =?utf-8?B?eUEwTWFyKytDNWo1c0VvQ0w5Y1hPYWRCSWNLb3d2dExHdjU4UU12VlQ5Rmpa?= =?utf-8?B?UEgzdEhQL0dBYjVJZW1JRitRcm5HL3AwdXJNT1VKRHlhMkNxcXlLVGlsVVB5?= =?utf-8?B?RlpwaDk5WkpqdDYxN2txSlY1Y2pqT2I0bG5pQ254MlJpczhmYTRlcUUxc1JM?= =?utf-8?B?bHB6V3FPR2dEM1hEcnhZWWxwRHpEWFUzT2V2bVRralZhVDNERWhQRnZXSWhz?= =?utf-8?B?TW54THlOWWRnZEszUHc4VG5qQTREUnhwQjNuUUw0UGg1bEpydGhPOC9BVFFB?= =?utf-8?B?WjBjRDQrTzNEWXUraVd5OGJPSW5rWnE4NVp6U05tVjk1eTE5VHlrVEs4N2ps?= =?utf-8?B?TlhnZEthY3FIOXhKbGpQQkZJNXJXamxCa1FLYTRKK0pxSkdRUU1aM3BpQXFN?= =?utf-8?B?MUtsMTM1aHlFM1hNa3pLU21ya0pmbmxma25YN08vcjEwd2NRUDZGZDA1RUhp?= =?utf-8?B?WS9YSmNiWjlEajgxV2NFdHBCdi9RUnlNeGZEQmVNSXNqcDVaKy83ZGdzSHRG?= =?utf-8?B?L2tzY1ZrUmRMTUJkRzNISnBMMEd6dlZCN3ByKy9XNlJVM29pYXk5Y3QyU3Qv?= =?utf-8?B?ZkdMZG1VVGxPRGFGMmxKZmJpOWFUcm5XWlRPRU1EazJwcjBFV3BtN3ZQQm5X?= =?utf-8?B?dXlURkFXNTlqaHNXUy9VamtWa0FJTWJnb1Z6R1g1QWpNYmZhWUlKdW1hL2Q2?= =?utf-8?B?djNNZ28ySGpmY24rN29wd0F3R2ZXUTVhYklCeGRlOEVVWGowUDlSclhwZzhZ?= =?utf-8?B?Z3Q0WEY5OGR1VHE4MkhPQklraDI5SDJQSXFFZWxlVEpRQk5BTlNtZEo1MTZr?= =?utf-8?B?bHlHa2hFV0U4elQxK2p0SC9xN0xzSGM3bkkwOEtOSDFtdDVHZEZaZz09?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 166d3cbe-e2f9-423a-856f-08df40e7c11f X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB9075.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2026 18:07:03.2630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2b6ohGtEoMo6J2NMyWWSfMNJkEdtxDV0k40G/zuEi8PDLJWOXYClIuOuf9HTQk8Fl9dsO2HVjjEkqluZHasIJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10858 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] dm-ploop: do not lock the md pages of a delta read for a BAT walk X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org a kind ping :) -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 11/5/26 20:17, Konstantin Khorenko wrote: > notify_delta_merged() and ploop_check_delta_before_flip() walk the live > BAT together with the BAT of a delta that ploop_read_delta_metadata() > read into a local md tree. For each page they take the md_lock of the > live page and then the md_lock of the local one. > > Every md_lock is initialized in ploop_alloc_md_page(), so both locks > share one lockdep class. With CONFIG_PROVE_LOCKING the first walk > reports "possible recursive locking detected", and lockdep turns itself > off for the rest of the boot. > > Only the cmd that read the local tree can reach it, and it frees the > tree after the walk, so its md_lock protects nothing. Stop taking it. > > https://virtuozzo.atlassian.net/browse/VSTOR-153709 > > Fixes: 0d4b4d0a20a9 ("dm-ploop: introduce per-md page locking") > Feature: dm-ploop: ploop target driver > Signed-off-by: Konstantin Khorenko > --- > This obsoletes "[PATCH vz10 10/24] dm-ploop: annotate nested md_lock in > ploop_check_delta_before_flip()" of the VSTOR-137234 selftests series. > Pavel pointed out that the SINGLE_DEPTH_NESTING annotation works around > a lock that is not needed at all, and that notify_delta_merged() has > the same problem. This patch stops taking that lock in both walks. > > Assisted-by: LLM > --- > drivers/md/dm-ploop-cmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c > index 2d1fa449b052d..f6135e07c2737 100644 > --- a/drivers/md/dm-ploop-cmd.c > +++ b/drivers/md/dm-ploop-cmd.c > @@ -812,7 +812,6 @@ static void notify_delta_merged(struct ploop *ploop, u8 level, > d_bat_entries = d_md->kmpage; > > spin_lock_irqsave(&md->md_lock, flags); /* write */ > - spin_lock(&d_md->md_lock); /* write */ > for (; i <= end; i++) { > clu = ploop_page_clu_idx_to_bat_clu(md->id, i); > if (clu == nr_be - 1) > @@ -846,7 +845,6 @@ static void notify_delta_merged(struct ploop *ploop, u8 level, > WRITE_ONCE(md->bat_levels[i], level); > } > > - spin_unlock(&d_md->md_lock); > spin_unlock_irqrestore(&md->md_lock, flags); > > if (stop) > @@ -1147,7 +1145,6 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) > d_bat_entries = d_md->kmpage; > > spin_lock_irq(&md->md_lock); /* read */ > - spin_lock(&d_md->md_lock); > for (; i <= end; i++) { > if (ploop_md_page_cluster_is_in_top_delta(ploop, md, i) && > d_bat_entries[i] != BAT_ENTRY_NONE) { > @@ -1156,7 +1153,6 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) > break; > } > } > - spin_unlock(&d_md->md_lock); > spin_unlock_irq(&md->md_lock); > if (stop) > break; > > --- > base-commit: f0cff9cebdb0d481d05b02bdb7bdafe864adca1c > change-id: 20261105-b4-prep-khorenko-vstor-153709-dm-ploop-drop-the-lock-of-local-md-pages-4f25ac778924 > > Best regards, > -- > Konstantin Khorenko, > Virtuozzo Linux Kernel Team > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel