From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5CE15803F7 for ; Tue, 10 Nov 2026 08:37:04 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA8ZmVR012545; Tue, 10 Nov 2026 11:35:49 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA8ZmVR012545 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="gpSotNnM" Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AA8ZkeC012541 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 11:35:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AA8ZkeC012541 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2e8e16d22d8so28985445ad.1 for ; Tue, 10 Nov 2026 00:35:46 -0800 (PST) X-Gm-Message-State: APuU4Z+HvaIDV0l/CEJk+bhAmQSNfZOtacbJlk/G98xIl/gemxKtiv3l CzmRRFM0KOxAe3cMMf+6z4Pxj6dU8PdmYlVRfsZrMZfemAzOSFZAuoYhtS6QXJugBt2dklEccRb f657Hea0YKnsS0nx0bdsFWpZRic+xq7+pAdXaKd2L/NDj2U8khXYbaA== X-Gm-Gg: AYBFou2OzzqRA8ivdSyNlr0EusF16Zdsyc6y9XFaik1SGYRXQiohw4/jpjq+iHZu3cj 83G+vGFyjieZmU1CIQHOGmh8T1+heUNZzN+Tt3ncC/WpOGPGsBehJM+rvRjnixNf9LCYNiql+Qk Sgz2YGM+SlEl/ukR8QenZ/moC498HJS+PqFu2nS1H1ZXRfDnZbbf+BHBuUPrtvTO39tCkKc/oRR ZJWaUPR92D7knhqCvkoWTIZipUtGY5+5ZfjvHMaARbITjw4zHrgeoGwvbeZEVSROVi8nrAq5jiZ XDcdw/EQBRPEN+KgP+3Ydoa/TPIO8kllH86YJB3qIsqOZo8tV6zlk6rhJNm0P+kZxnTL2ENNLHV UmDfBCoaIPfcVB8x4IJHt+xrRVYneHL9EwU5nNsOhWNjwKlbMzTpP7haamIIAKblFwG3SQ/cyHw Idx98vjCAt78DVYLmb/IyW4+6Dy+8ybQU= X-Received: by 2002:a17:903:2f45:b0:2ed:352d:c612 with SMTP id d9443c01a7336-2edb9283c34mr19399745ad.51.1794299745399; Tue, 10 Nov 2026 00:35:45 -0800 (PST) X-Received: by 2002:a17:903:2f45:b0:2ed:352d:c612 with SMTP id d9443c01a7336-2edb9283c34mr19399475ad.51.1794299744800; Tue, 10 Nov 2026 00:35:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794299744; cv=pass; d=google.com; s=arc-20260327; b=SyiWBkOUhUBpq9eCOmRINzS1HNPAEGgCPVhFnOQMnkUAjs49x7IDHL3daWzqRp7sKO OCaKyQqwMwpJadmIQptsqe2OU5RSBMT2TjvzmM4e9kNCK96K00na4y3o4RYlCG9K7Aek Hxybkx2jmzhXHW9bFhFrUVmb49AVliUAjLidCqSULLWNazisyfNxA8b1ixKGz7/wUcQZ z0vAGwkEKIDtbgrkeLE3XOI1J1Syw9cc9M/w2Be7NzZ32RfD5sv1imo/42vGfegfzh0C 1BuiX38I9+s8rtWQCG3jpy5hK7pVmTVZ3NY+bXnXq9d77jqsTLseBf+8tAiYi3SPl2gJ /K5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=yvAym8048hG+cxWWRnkfgdmoSmowaSvdKUc4Z0ZxSzI=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=F3PmSXnFun+50c9zVvfPWtKU9+Y+7N9yfHcDJROYiHhiQePr8BAsTd8VpcSJbQZdK8 jStHr07eCq24e7Z7OdxOT7EgYqnWlo/mzXnJeWtCh5ceaboXHOcXdpzciIvcu8JgZSeK xrdX/iGbQkeN4RPFdtm7NEmGdNMZPpDgNqD0NDwjiE5whp20184RQ5inhmbu511nokZw sUey/Ng6EgXfyz/ZtXC8X3T4P1yBbcWflw1+rjUFgu0esjOjXNZl1WJta73pDFVjQQEG Lmke7PHOof7lSaggHkQ0CdsS3UGx6rste8lBavXrOI4jUKcW0S/dJzGcP0cu1wQ6EcAO aUkQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=gpSotNnM; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com. [2a01:111:f403:c200::5]) by mx.google.com with ESMTPS id d9443c01a7336-2edb6dc4518si49580145ad.96.2026.11.10.00.35.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 00:35:44 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) client-ip=2a01:111:f403:c200::5; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=gpSotNnM; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VWrD1mIuC+AOm+oodoe06kB2Evw0YFyVrhbuPyrKel5ioiW3P8D48dqrBAIBdDjJEqfVv8k3a8iAHwrSck7T2lUvIGQFFCE4gGht3fhcQssVDxXyqdIVHX7urnDmm/xZIH3wcu5zipBWpa2qeOCBERfpyrjqqtcMvF0D5ijHWeHbSJOyCqh5y5K8i3/JvLxK4OP5V+e9SXDQBxmMcTRHe8RZQ8JVgwSjkagsF4zshJisK89/94uqdAt/z9wrCxYKaXMYcsGl5X6Cwj7KBpVvHXs5DTGZ+ciY2jVOatFpuoEtQGvzVsD5tDJY2pUoO6RIyTArfRp1jRcIyR65bhgwEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yvAym8048hG+cxWWRnkfgdmoSmowaSvdKUc4Z0ZxSzI=; b=A4HGbZqiuw99MlRzX/vx++gaYHCIlHcTDl+Kz/QHo5cGHVWZwbxCG1VBKqBONISq86IW4JRzKZU2Sk6b68YJdku/l+HSMNYquZsJiwcbBIdNL7zBQJotUAkIFvlcMZd6nZzNT3e2N0CNhtm4v1vK4T4YNkbKDJCy6gQXbrobyU7lLeYCYO+OIEDiddwvsbpkba82HeHtAIHFToIcV8tRYrPtVNqoJM9o8tzngmextGBQvo7rBpXFFUh7q6ldxUV2XQZ4YOV5zhw8oXsFvA9PjhVi+wkUNHrr6biyeA59nk4Sn+UVFDJtByDb3tb7CkUbHoSdtU7B+eHhW6j1Jl/I2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yvAym8048hG+cxWWRnkfgdmoSmowaSvdKUc4Z0ZxSzI=; b=gpSotNnMbmp/dlXSmIZ/BHQiv0dXu67tzzZ0BxWUjyaCjErlrSjsJAt2UGDtqn2ue0IApxJEaEmEyZq3FfeI/ayg2NNscMLUKiHnSWzACW8SIzOv2xbzb9Mjz37qixCXMdDOqmUI0R7lpQZPqaJi5EG0P3QdBYZWUipAPPKU8AR9MgW/qLgPCqN6rTvvmx6xqb+P11IUy0DaxM8aGVXOoKWkBIV7Yz5cOKS0rKpYsWb/wI7XdnCTEr01GjcMG/T5UkBom4UnQ/rBhIqTDsjz+AOEDpcYrFCb2TahFO/N074bzIU9cLiSmV+3K2beEJ0Da2ijBrUM1pikfEE55fSDsQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AS8PR08MB8222.eurprd08.prod.outlook.com (2603:10a6:20b:52a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.10; Tue, 10 Nov 2026 08:35:41 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Tue, 10 Nov 2026 08:35:40 +0000 Message-ID: <2dbd57a4-d703-4570-8418-bcd5f1198706@virtuozzo.com> Date: Tue, 10 Nov 2026 09:35:39 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261110075140.1475607-1-alexander.ivanov@virtuozzo.com> <20261110075140.1475607-13-alexander.ivanov@virtuozzo.com> <010701a1c47fb471-53e30c8d-3fbb-4b1e-8251-53c60e0911db-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1c47fb471-53e30c8d-3fbb-4b1e-8251-53c60e0911db-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR2P278CA0052.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::16) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AS8PR08MB8222:EE_ X-MS-Office365-Filtering-Correlation-Id: 21d9c61e-a6ec-42af-7376-08df3f059a3c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|56012099006|4143699003|5023799004|261022075727099003|261022105027099003|261021121427099003|261021123027099003|261022115727099003|261009223027099003|261026121527099003|261026140227099003|261102123227099003|261028144727099003|18002099003|10067099003|22082099003; X-Microsoft-Antispam-Message-Info: EDO0J/0pXhttcsWVRqZoAb39N5AL3qJDEf1meAgSxnwHVDjl8NzkO4RDokrogpO30/CX4sO+EPd86MI/eul2RpuB7Q7b//O7M0mnkXJfIQp4MTYufNOQ9pW5/LQSfRAV4XxzzlnNRuOm+5qmzKrVlN1ldPNEuB5/zqzliaHao/6d9TBeLFOW6nM0zuXSVScRWyJ6KNFVPcrpoyeWYlkkHQ+9KqVaBftLarHQJdzmA+BK1fBZqC6+gl3l6nAJMqzsxDAt/9NjVBRoqUzY7DgNbTg2fpaMAXzu4BmWgYuSjFQQwi9TrdwymgSq1uwTxmYTtI3Z4I0f9hilz90ABmQzjIMtDgLiwK4fq4YntsNzhRZfciAAUiQ5CTxCDZtD2b2FR8EykbhC2Z1WdW5zALfOBdjtYJoHKiDjsKRVdIBKj0+OZDdcPISf0eKLSM/yd366nv6wNmBF7+EmtbDRMBzp/1Vud4zuJJpSV8HLWQ+MOvoWq/XlUDVOTuHvS6of2PPL9S2MLuFhNPGL+YlYhz6RnGqnIlsko7Am9tZwkbieGn7ciS1rdWHodfY++07xBPHGpKLsuavl+umt9pgD03hbNuk5/Z+cuEo9PD7lMuYhQ38cojWuoVNTWCNKIygysIdx+v2FqcYXYz8W4sWLt8bhcEYDmKZxuekns5eoN2NW/Ws= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(4143699003)(5023799004)(261022075727099003)(261022105027099003)(261021121427099003)(261021123027099003)(261022115727099003)(261009223027099003)(261026121527099003)(261026140227099003)(261102123227099003)(261028144727099003)(18002099003)(10067099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWZvWmhKS1J5QUV3SXNQZGJmZ3VHdUxmK1cvbFBIeEFZbzZ6T3lzSzBPZWdY?= =?utf-8?B?YmhWaEd2LzB3VHJ6M0JuUURlQldscHJyUldVZnVnYXhEZnZjci9DQmxSNnRD?= =?utf-8?B?KzZsM0g2TzlOQzdoNDBNWHNXVC9RYmYyTjJYV1pYWHVBYzUwVU5BVU02OG1j?= =?utf-8?B?NnJCOEJNaGg4TGtDQzA3bE5GNXVQZHgrS3FBMURsd2RLa3lPcG1Id3V4YkFh?= =?utf-8?B?NWcxeVV4YUptb2VtZGIwbFRPNHU5Skx2czNReXBVZ1Vxa1VjS0xZUHJKdWpS?= =?utf-8?B?N1NRTmt2VzZqUU1ZdVdKQ3N1QnBKcFlKUy8zajQ3TTNSbzJoWVQyczE3NmFH?= =?utf-8?B?OW1qMXFPOVBTbDNhUEhwSEpHOXZRQkdNdFJyRXErU3ZUUm5aYUw1Q3psdWVj?= =?utf-8?B?QmtYa0szekZlU0NYU2tDZzV3N2JjR2hudEJjOTBPR1UwSmpsU2libU9GdUJu?= =?utf-8?B?UUJ3Z0kya0p2TmNyRnlQRGRXQXVod2prOTV0NnRaQ1U3ZnVhanZLK2RDdFgz?= =?utf-8?B?SXZGcFRvaW9lWWVXQ3pRdTloM0g1SG80MDNsaFVobXA0b0JiWDhDbU1aMVhE?= =?utf-8?B?aldLd1V4Y0lSOTZMK21mZFpEZFgxbEVlSnBmdS9HVFU0UjhTZzNEZnhLQzZE?= =?utf-8?B?MEI4MTlDdHI4UjEyMUlpdWlEUEhlLzlWdFZEVDN1Y1MzaExFREZzOTNZTVlP?= =?utf-8?B?SzFhQ0haQmRwRVNiaXZibXB1SGx6OSs3QVVzOWJUTFlYOFpqcWJsWG0vZ2tL?= =?utf-8?B?bzBsSGk4aHAyZE5KSmQ4NzJhVlYvQjdrNTNpZi9sUFBiZ3ZtcFVOVFAwUEpK?= =?utf-8?B?WVRybk9zRGxHZzAyRzlraW9LNGNFNm5JWE5FY1ZsaTVNSDdhWHF4cnJ4WWcz?= =?utf-8?B?TGo1aWhFbVNCMlgzOExEc0lKY2V0ci9ZcFRWUERpazh2d0xZdHc5UVJ2Zndr?= =?utf-8?B?cWxlYVRXL0h4M1FwdWttbER3YUZFSlRlUzZkYUdqc2diMDRWZ1RPcVUxSVZh?= =?utf-8?B?d1ViRERabGdhTHhzc1N0cnRNNW51WXhjYkk1R1pTREszR1dRTjh4eGpSanFx?= =?utf-8?B?RkV0MXN0OWRyL0hteUlKb2s4T0lqcm5kcExhTU1XNkNRbnUvZ0VJMU9ZUzFD?= =?utf-8?B?Zlp4VmdVVi9xMm50bFZWakZKcFdEU3FwcDVPVlpYa0tMcStYS2RxSVZMTUZY?= =?utf-8?B?WVQ1SndmYkdIZ3FJRkpaemhzUzd4U2g0Tkl5MGJkSVJ3eWJrRDZnVmNGcWZN?= =?utf-8?B?S2RRY1c3QXVnNm00VHF1d1JzRTVWcnIzWkJCL3Z6ektvM0wzeTYwSjdrYzhj?= =?utf-8?B?NU9IR3ZrbmtmU1VxYkY0Q2diOVJzajhPOWFpZnB5Ly9NRWh3MHQ4SXdHc1ZL?= =?utf-8?B?a0tZbVMzeFc5N1FSb3p4ZGxjYXdoQ0pyL3VlS2pvVXNvbm9EZm9kUDlWNUhp?= =?utf-8?B?ZitGQWxEem9iMHlGdDl4NnVzdG9NMnZTeCtRR1BmNk9vdkliWlB0SmJIL0dl?= =?utf-8?B?dXF0SmZaRHBmQ3I3aEtPVnFkWFJFeWdYWmR1K2o3SURkRmhTeXJGdkRtZHZz?= =?utf-8?B?MSs1Vi9icFU5cG1VZDV6RmZUTzI3WktTSFdCY2s3MGhOWldFUW1xb0o2SHJQ?= =?utf-8?B?S1BFUnB0cnQrZWpzR0lrZG5abm1VSkZoWlBKS3pCWk9MSm44NGxDZ3JFaFhm?= =?utf-8?B?VXZnUWdpRENPaU8xeUk1djY2SnNub3BBOTFmVGowb295WDJpLy9Hc2s2RU9H?= =?utf-8?B?OEhxOE9XQ1FZWmVPSzFId2RNSEhkQm9sY0RuU21ZcExVKy92REptdmhjVnFt?= =?utf-8?B?QTRtS1JEeWJWRGlCcGdWZWZVMnJZZlVIRk5VUnJBR3JFYkJHMHlvWEZNMGdH?= =?utf-8?B?K2FlSjhObEtSVU1nMzNyaU1tVnc3RTd0TVJiempia0FQUC93TVZiTVdZUUFw?= =?utf-8?B?NWlWcUpaL1RPV1o5bjlURVR2U2pSRUlNYk9sV3RrMkxSRUJtd2dvYUNHNXVS?= =?utf-8?B?M0JGY1Q0TG00MUVFakF1S3VFTjRMUE5jOTVuZWpxZmErTjdlTlNLWGVPOUor?= =?utf-8?B?RVVjWkRqM3djcGQ1Qy9Qc1ZoamV0Q2YxTGk2SDEwcGV5NlJQbFY0QVlDcVdH?= =?utf-8?B?dFBGYTdSQlE4OTcycXNyZmZXYkFpSElKYUEvYnZkcFRFaGU1RGJLUXJSdVBw?= =?utf-8?B?K1pVdXQvcjZ4OElHMlZlaVBENVA5QllId0o1UitEZ1lDam90NGJ2eTdVOXhh?= =?utf-8?B?b0lQejRxUURsNytqeC9GeitLaFB4bWhKNGducnZUYTBSTjZINUFQT1k2U1JI?= =?utf-8?B?bDRsUmNpcVRSRHZ1RGNrMG00R1paTnhKdlp2REFnaGxYVW1VbXFEaFhGUGpl?= =?utf-8?Q?w9VpcPMI5f/pKlCU=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21d9c61e-a6ec-42af-7376-08df3f059a3c X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2026 08:35:40.7427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BVZjV7sOiFPoy66DQNds0HoMgD7PXF+zlK4ve5iHZz5dAez8pOGGrMa2shrDyVl7DEn5Mceje4+MbJi5Ks0rKYNJYKQKmeZRBsGwZQAzyM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8222 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v12 12/12] dm-qcow2: fix WARN in qrq_endio() on flush failing with ENOSPC X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -4491,7 +4491,8 @@ static void qrq_endio(struct qcow2_target *tgt, struct qio *qio, >> * callers receive -ENOSPC synchronous without intermediaries. >> */ >> if (unlikely(bi_status == BLK_STS_NOSPC)) { >> - WARN_ON_ONCE(!op_is_write(qio->bi_op)); >> + WARN_ON_ONCE(!op_is_write(qio->bi_op) && >> + qio->bi_op != REQ_OP_FLUSH); >> if (qcow2_try_delay_enospc(tgt, qrq, qio)) >> return; >> } > [Severity: Medium] > The commit message says "Delaying and resubmitting the flush is already > correct". Is that accurate? > > The flush ENOSPC originates in do_qcow2_fsync_work(): > > if (fsync_ret == -EAGAIN) > fsync_ret = vfs_fsync(qcow2->file, 0); > > end_qios(&flush_qios, errno_to_blk_status(fsync_ret)); > > On -ENOSPC, qrq_endio() calls qcow2_try_delay_enospc(), which requeues the > qio on tgt->enospc_qios. After the timer fires, qcow2_submit_embedded_qio() > sends it back to the fsync worker: > > WARN_ON_ONCE(qio->bi_op != REQ_OP_FLUSH); > queue_list_id = QLIST_FLUSH; > worker = &qcow2->fsync_worker; > > The worker then calls vfs_fsync() again on the same struct file. > > Writeback errors are reported through errseq. As documented in > file_check_and_advance_wb_err(), fsync reports errors that occurred since > the last fsync, and the call advances file->f_wb_err: > > err = errseq_check_and_advance(&mapping->wb_err, > &file->f_wb_err); > > Can the retried vfs_fsync() on the same qcow2->file therefore return 0 on > ext4 or xfs, which the commit message names for "a failed delayed write"? > > If so, the flush that originally failed with -ENOSPC would complete with > BLK_STS_OK. The upper layer could then treat earlier writes as durable > when they were not. > > A retried write resends its data, but a retried flush resends nothing. Is > there something in dm-qcow2 that retains the earlier failure, or that > otherwise makes the retry safe? > > Could the commit message explain why resubmitting the flush is correct, > given the errseq behaviour? dm-qcow2 refuses an image file without O_DIRECT (qcow2_attach_file()), so it leaves no dirty page cache. Allocation failures of direct writes are returned to the write itself, not through errseq, so there is no one-shot error for the retried fsync to miss. An fsync ENOSPC can only come from the backing fs's own fsync handler (e.g. a FUSE daemon), which reports it again on the next call. Besides, this patch only silences the WARN: the flush was delayed and resubmitted before it too. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel