From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F19FF80474 for ; Mon, 26 Oct 2026 15:28:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QFRaOI012127; Mon, 26 Oct 2026 18:27:37 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QFRaOI012127 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="FEHocgw/" Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QFRYBu012123 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 26 Oct 2026 18:27:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QFRYBu012123 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-934963b2bc0so603640685a.3 for ; Mon, 26 Oct 2026 08:27:35 -0700 (PDT) X-Gm-Message-State: AFq9FYJYJNYbmk7sIKTUA6V8M5G0xQCMcea5rus2EdTdm4mSO54ZwLKY WGG+M6Wag+L/4aWD9ETG2wXluSElXT67+OiwPPcM62AJvRmlHln4qOUjhq0wa77ka6K1sxaYIFA prdR3iGJy5t/ARTWWNOuuW0LPw7RYocuWCn45/KC4/2UZO/YDwvS2mg== X-Gm-Gg: AYBFou3PQzEPnWP2yHOLsjMZKZDB9/wh16+6DHUBG5k5MeLTQVkxekUmfwqWbYlbcco uSJ2CSIaPO9TlQL4rUhOHWlHLqoJQ+npR+35mZGp+3I1LUCgWR0JiO3OOI97JUvHxERWHiymzcS 3VZb8dxaGfBB96gIEkMfUo9gpaPLlf5ylq1K7FHjKAn9qmDFC1b9tYZCnAqy3HPz5T48ciK5JF9 M3yGofsD0VrTnS4s6iRXonmoPT3ugW9QRWDby914AT7PhXbYxLJ1CaTTLFx0TCD94nnOeF/ZPGE 3R/RvKHorSNatzkBzWtlinbTCu1f1OptYQbmBYRw5OwzK6Y/OgYrKfmxQBIFwVdPBsDF3U5dg/o IW+DlrferjmQK6qW7q26lerr7NVsHXxtxFz6bgnMiIPo3GyxgVBAooUWCIPkzriWTLMjFNOxKIu MD2ma9GxzfmbVP/ZO9bQI0z8OKx3Bsy9fTcb4B X-Received: by 2002:a05:620a:684a:b0:93f:1d71:41d5 with SMTP id af79cd13be357-940ef97fdc2mr1000480085a.52.1793028454357; Mon, 26 Oct 2026 08:27:34 -0700 (PDT) X-Received: by 2002:a05:620a:684a:b0:93f:1d71:41d5 with SMTP id af79cd13be357-940ef97fdc2mr1000476185a.52.1793028453755; Mon, 26 Oct 2026 08:27:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793028453; cv=pass; d=google.com; s=arc-20260327; b=FLc3NixXkaLadEKU4YrSlx+5ojs88HGnG8e1CNRbRv5kf9dqnwK+pNQv9QYry5gYL4 uE0t/JDDV4ZBYk8Pk+gb+hAZ6tdzZUwRzMkFFFoNAjG6ovum6GbmCsadc7mm9QbXkX7M cp+rHMfrEJFs7INNqRb6+X4xNjUz5E1LQGNS/mo5+PJdZL4CvubWASBZn8VkTojDlhZh 8vzfAqUOFYajvHsgZRe/D5zKpuX3BCGilOrNMtSsKI7kdmEV9C9IhqMHxH6qHP06U9aX tSqrgh5RoqLzpSheHkCLjqNdOxBVx140fuwrAb1G0GJ5uyG2kYTKvt78frv7u4NkKp0n N45w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=nlIeHAnOZKH7E8FvKJ1c9qWUXStDjPuBPU12KJmdsao=; fh=qWizwBfIgY1pj2qmgAZ0rb6jR5FK98YLWy0DF5OyPV4=; b=azyFmj+VSnjj8Aapw714jH+z4F+NHy04Rx6bVKVYydoTu1e89IAmSIvGy2UdCbmmDB zUD0PsiaDuVP/wQ2ZJkcb/k7AKIAExBuPg1osQhRB79B69SP2pFaaw+J/w0f2c6iu0FJ NvdfbOuEW39AJItlWpVuVhaF84Oy9YhqXJBLUraQ3CtyPKU1N5N9w70Lx/23Kn6tT7jJ /dnP8c9vItP+PPXx1fOU7aHNVeSqziZ+612HGC63cb1CxZOlnOKSjE1dpj3WZbWdgePX gUAq/nL9nfk1+b/2wVdJnAtm+ssiWunn9cjVxKObclE7qN78nucntq/wHRkI2KaGsSLE EY4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="FEHocgw/"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c202::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c202::7]) by mx.google.com with ESMTPS id af79cd13be357-940f0ac0058si586917185a.407.2026.10.26.08.27.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 08:27:33 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c202::7 as permitted sender) client-ip=2a01:111:f403:c202::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="FEHocgw/"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c202::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HXBQv1+ucTkgaP7fdS3/701qbnxk9g/1DVr58o2qqVn1VLimYPOsOphBtG3uIh2W5gzEBZ7HeA32yE9bueHuUK5p50AmPGcaPWcACOpq6s/1PPWeS8u8m/htRxN+Gxzw/o3NVdGr58LtY34x7sJYgxNIOGACMOcrQr70adC8AWRfkIhUTE2BT5hmkdvaXWWZy7sIMcbr7S+cnn2dgqlw8arQ9EMmvsmZHg4A9H7UihlFs+pjOj189ctfim7MrT94rpVvli2AB2Wp5V2fnRu7dJPpYaqVryRMy2a/nGpSRxn8wcTB26JUNadtT8SBFZmlXvokUe7TZdwoBvLfwco3Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nlIeHAnOZKH7E8FvKJ1c9qWUXStDjPuBPU12KJmdsao=; b=ExXmgTvrdy9noAlK+CxHtIl6AQzonpjjnJbYXgO5kFDi89VaeZT4cfnhu09WnT8HpBtxz0p3sOJWsW2asKUUlbwYglaTgOc7CnUgJiV1Rj1YZVSFwIKmE3RFqLT2kmobHHZ2uTZK9FFS13h3ZXz/eJBGBC4sYZxt98hG3cwtzUb2ZXjeYWsjB45wRalI7i5vm6io7PdVALHEFqOUN4170URsCsUDEv8NwRDeA7lPagIm0b9/usOaMnHRmSwcKP1/PkFK00HbTSYKcgMRRB8C6Xc3hJeTYtKCz7uw1gJMuWHVMSmtMpsrJ7ApMhjmmTFBio8AvPqJXh364lsNDwM5FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nlIeHAnOZKH7E8FvKJ1c9qWUXStDjPuBPU12KJmdsao=; b=FEHocgw/1ci5i8ZxxgEHUK99TKK+w5ZUyI75TxC/Mvvx8SywgRDYPvml4lUsP3KNOfdN4e7/D4AVxbjJj+4tCFCcOnIWEg655VmbQbIkg03uyQbfBpFc7RXd+G0j2VuqGIIe0GWTmKZHFLKl2i8ZNIQNoXR1l/c2WbKPeuTz0GXkRjouboHLPsxdZ5Bs74RGBPBYL4TdcA6u+shizgqWC6b3OJWJ1ySyXr5Lt/zDPcoRMxvy24AolYo4T8JGnXpkolh2CA1lI7b5BxJl8OhIHdIfc6W5jntuxwHaF1xOfbTceqIbzhskajzkLC0KU5oC977J8EmEPgMEck5jNOpQgw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by GVXPR08MB11661.eurprd08.prod.outlook.com (2603:10a6:150:325::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 15:27:29 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0546.021; Mon, 26 Oct 2026 15:27:29 +0000 Message-ID: <3796e8c6-7ad9-4e12-ba48-631a1970fe3a@virtuozzo.com> Date: Mon, 26 Oct 2026 16:27:27 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, ptikhomirov@virtuozzo.com, vasileios.almpanis@virtuozzo.com, Konstantin Khorenko References: <20261012-ve-printk-irq-v3-0-efc95fd5c78a@virtuozzo.com> <20261012-ve-printk-irq-v3-3-efc95fd5c78a@virtuozzo.com> <010701a12d345369-5d179f41-d21a-45b0-82e2-87a06104ee54-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a12d345369-5d179f41-d21a-45b0-82e2-87a06104ee54-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::14) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|GVXPR08MB11661:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f9fe0e2-b57b-450c-1943-08df3375a580 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|23010399003|376014|1800799024|6133799003|22082099003|18002099003|261026121527099003|56012099006|4143699003|10067099003|261022105027099003|261009223027099003|261021121427099003|261022075727099003|261022113327099003|261026140227099003|260925021311599003|260925022911599003|260925021911599003; X-Microsoft-Antispam-Message-Info: ghcDo955ylgnNs7wnc31yBuPYsMivgcpU/70/mJp1brVWX5ge/kRPNDrpUZHGYeOp/GZ2aI6fxvqepmPtw3+VF5IVqgT40MD7dwxRzy9/+zJvyj910NGvlxwGCsTmHmRqHkckS57vGyPJ1AXUKTsHZai4JZXaVW0oaFtHX5xYDir5cYWlpOaZcJGoEj0LhQQjLsrQozUSI9USdtPa6ZJCjMWKMOHrcusyDautP0u3hepw+zGWMlhMPGdNJkBbeUlFtbPpyaZG4/yaVFH4kEJXSCo5WSmwaHbjEAMaktHt6nBiF/Q4FGhh77aiXhHJCV25H0BM2YVLIdtzB1ivp83KWSSIwLynY9pUb7lRYPoqTJe1ByJMQAw+3IW/8HQW8+0CvkCEFOxXe7K0VjsKRp6UzGPp8grIObC1g0wsLTEbpFxGXdyJ2BV7Bm/whAToPThewx12iC9Kr/b4t3ysB7IT2sdEc3c5gylJZwSj432wS8VYNhtVES5ePPaoELXrOxTAE+dgaYCZxGi5RTVA3ZnY6IVUKVIzjiFbvvaGK7ZlmLxPx+Cry1dKA04IPhwidgnPLb/oPp1Qff5auuogj8zl9ZCwiVp8GfkjxUVhmNCfsHcrtzORlGzSbQlw9ObXyLM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(6133799003)(22082099003)(18002099003)(261026121527099003)(56012099006)(4143699003)(10067099003)(261022105027099003)(261009223027099003)(261021121427099003)(261022075727099003)(261022113327099003)(261026140227099003)(260925021311599003)(260925022911599003)(260925021911599003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkszOWZTUE9GMXBEaUtrby9zM29RSGFib3JSVXo3OWZpWldFNGFrOGE5U3Fn?= =?utf-8?B?cUdtTUhnT2UvTlg2ZVZKK0Z4U2dPU1BVaWV1RGliTzcvMll3NVdWdGtIRitF?= =?utf-8?B?UkFqdWtSTmw4NDQ4TDBEVlVTczZ5dGdlTEhXR1lyT1AxTWh0QldqQ1N2M0NQ?= =?utf-8?B?VkRWaWVrUDZyWi9kbnBubWkwdUxaTDlmdk9WbWJodXEwcFFVa005OEZQM1dT?= =?utf-8?B?eTBSOXlYWElobXdWNnVGcUN4YUtBUVNtZmJYLzhhL1lnai9abExDL0QzVzd3?= =?utf-8?B?VERvZkRCRlRGSk5TWk5xY2F6Y05NQWozQUhoRkVhVlpzbkVTZkNOYUhYSXhT?= =?utf-8?B?WmVMUjlVOHNOVTZMMGs4RHE4YW9PYS9qeWsrMzk0eWZNcFVKbElnTFBhODgx?= =?utf-8?B?RHo3MEFoNkMvalVyZE9jR0lGUHRQN1poNkIrZG42Rk9KNlpVeVN0SERGeWRO?= =?utf-8?B?UmNTaEZqdjdMdGd6bXBzQmpiK3p6Q1djTVNSLzJJQ1FIdmV4RHNIRmFOY1d1?= =?utf-8?B?c3NRQWhlOG5nWnNDTzBSM3p2TG9DTklwUUdnT005amdjaThpdmtmdnZNRzU3?= =?utf-8?B?WWFjM1poV3JtZjYrU0JVaTlSYW1kNUJEVVdHS1h4di9qYnpnamtlL2JLYnhH?= =?utf-8?B?SDc5bzZqK2QzWVd1K1FMMEw2MytEZC9TM21mQ3ZROVRETC9IaldxWlZ0YVpO?= =?utf-8?B?T2dpVC9qZS9JQ0VnTGFkdHdvNWp5c2hqRERIbFVNM0FXYW9wQVJaZldKbWg4?= =?utf-8?B?Uk4xSGYvaDRiQkVTalpWclhTVFZWM0hVT3luNFROdW0zSDIrN1g1bzFXTWht?= =?utf-8?B?b1RiM1k2OE5Ld0lJLzVUQW1TSHRKS0k5ZFIydW1TTXlYaldDSHpMNkFTWmpM?= =?utf-8?B?WEMzbGpiQWV3NDMxTW03ZnNqQ3UyRzJPdC8wNmU0OFNxS2FrZG1xcUlyZXlY?= =?utf-8?B?VUN6cU94NURnVk16bmF4aG1waGt6MEFpU1NCRCtRVndRYzVEYVB1ZStMaHBn?= =?utf-8?B?dGcxWXM0TFU5QmUxWDZ4MUxxMTh1d05TZHcvZnJVQ1lzR1FUQWR6WllOYUN1?= =?utf-8?B?VmF5UlJ6YXR1cVpOSE5WcFNnZ0lQa2dVQ3owMUNMclE2dlBzOEFQQ0ZtQjVU?= =?utf-8?B?OVNyVk1Wb1B2WE4yRVlGRkRwVnJEVkNWVXdkYmFwZWtPR2RnWGR0ZHFRWVNK?= =?utf-8?B?ekdmLzJuRzZvb29PTlIwUlpVek5tU2N1SnZ0K1lMVGhKM1ZaZUZZSjZRM1BW?= =?utf-8?B?YlBCWG1xMjBLZHkxNFhTdUpCaENVTzNMdXNNVnlLbzdTSHVsL3ZHaVJWMmEy?= =?utf-8?B?Lzg2TGIybDIrbmJrcmVoZzR4OFM3Tmk3VXpOSzVCaDlYWlVCNXNHRHpxYzZ4?= =?utf-8?B?WWdBTjlSc2JyN1IrUmsrL3UzZFU1bzYvdi9UZG5xeUVkT3RrZ0NvSHo3K0VD?= =?utf-8?B?cU5aWGRuYjcxb3d2VmljbWRjNWVWNkc2dVZtYW9FTzlpVkgvT3N5bURtWUZn?= =?utf-8?B?SmtlNlQ5N1JRbGNSZEx1TVZURU5uYkYzTjdOR0NvWlF2YkRVY2FYL0JpUCtO?= =?utf-8?B?WWdFbkNLLy9KV2Q2OVhoT2NFalRyRkdyTENSR3FyMUdOK0lWdGozVTFQQ0t6?= =?utf-8?B?LzBNYjNrQ1JCY0hjaWNBYTNEUVdBaklHSnFNQzR6WGZRY1JaRGdmTXBSZGNR?= =?utf-8?B?ZE9ualB3ZmdNYWRFc0x3ZkZYZGhNaWhuNk1hckh2NU80NFcxbkl0anQ4YXY4?= =?utf-8?B?bC9lRE8xb2tMc3FxMy92QUV2TzJMdUpwb2FRZWV3TzJVL2ZkTkFGM0hscTM1?= =?utf-8?B?Z0dMWElPd05MN0ZsRUJDdjFDa2dIOTNtT0xudENTSzJEUU54L2YxeGpxWHhq?= =?utf-8?B?NzUrcjREbWMzMU92dHQvQTZTZFY5OE8xMExCUlF4RGZhVnpCWC9SNkErUk9i?= =?utf-8?B?clowaUpmR21nbVM1aE12WnhzOWl0eEF6Qm5qMytENEFyMVpJaU1OQnNMbVgv?= =?utf-8?B?YXg3eVF1REhDU21YVVlqYkw4SEMwanZaQVZ3MzNQdUhON09Rc0NaU1ZZQmFk?= =?utf-8?B?aXlxOWNJYXlTNGx1U3M5Tno5dGZjSjNpeU00QTdVeFNYSjBUeEd3UmlKUW4z?= =?utf-8?B?YzFuUGNrdVFKT3RmWXdmVTNIYTFFdFJtdlpINXlBVk92Um4yNUNCV2JnZmlD?= =?utf-8?B?eGhSRjFidjc4c1J1RytoY1R5eW4vc0dRSmRvUFZMVkNVZXBIdmlDNGR0RlV0?= =?utf-8?B?dHMvL2M5MWNXOTVSVEQ1SnBXa05xTUU3ellGdlRVMzFMdnczdkdUNXlFME9E?= =?utf-8?B?VXVxUjNldUpLTjlJMzVxMHJ0UkVTWk1pQlN1MEVRWUpKUlFoaVBlV2FKMkdP?= =?utf-8?Q?1lDVpBY7JSUIUqRk=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f9fe0e2-b57b-450c-1943-08df3375a580 X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 15:27:29.1218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 73VO4LQXAPXEUT/J898YWfer062/nF657QV0bdxIv/XcpWjy9zv+shV5BW4Jl6uYNjVOcu61t5RNgUrLnH3V86IgnqizRjkbuHKmH911rCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11661 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 3/6] ve/printk: Specify ve in printks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/12/26 01:02, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] ve/ratelimit: global net_ratelimit_state mixes suppressed counts across VEs > -- > > commit e1b1b77160f4d75abebd7d4609682186ec201a82 > Author: Vladimir Riabchun > > ve/printk: Specify ve in printks > > This commit adds ve_printk helpers that take an explicit VE pointer, so > that printing and ratelimiting no longer depend on get_exec_env() where it > is unreliable. The VE requirement is forwarded through ve_net_ratelimit() > and the net_velog_ratelimited()/net_veboth_ratelimited() macros, and the > netfilter callers now pass net->owner_ve. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/lib/ratelimit.c b/lib/ratelimit.c >> --- a/lib/ratelimit.c >> +++ b/lib/ratelimit.c > > [ ... ] > >> @@ -55,7 +56,7 @@ int __ve_ratelimit(int dst, struct ve_struct *ve, struct ratelimit_state *rs, const char *func) >> >> if (m) { >> if (!(rs->flags & RATELIMIT_MSG_ON_RELEASE)) { >> - ve_printk_deferred(dst, KERN_WARNING >> + ve_printk_deferred(dst, ve, KERN_WARNING >> "%s: %d callbacks suppressed\n", func, m); >> } >> } > > [Severity: Low] > This isn't a regression in the new interface, but the miss count printed > here comes from the shared ratelimit_state, so it includes suppressions > caused by every VE. Is it intended that the aggregated count is written > only into the log of whichever VE happens to reset the interval? > > The shared state is defined once in net/core/utils.c: > > net/core/utils.c: > DEFINE_RATELIMIT_STATE(net_ratelimit_state, 5 * HZ, 10); > ... > int ve_net_ratelimit(int dst, struct ve_struct *ve) > { > return ve_ratelimit(dst, ve, &net_ratelimit_state); > } > > For example, if a container fills its own conntrack table and triggers > net_veboth_ratelimited() in __nf_conntrack_alloc(), the "N callbacks > suppressed" notice in another VE's log can include misses from the first > VE. A busy VE can also consume the shared burst of 10 per 5 seconds and > suppress the netfilter warnings of other VEs. > > This patch now makes the target VE explicit, but the ratelimit_state > remains global. Would a per-VE ratelimit_state be needed for the ve > argument to give per-VE behaviour? I don't see an easy solution for this. Printing to host isn't very helpful - it will just print ratelimit message. Adding per-VE ratelimits is a bad idea. So yes, somebody may miss log message if another CT is spamming them. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel