From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DF0AE803F6 for ; Thu, 12 Nov 2026 11:48:47 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACBlPAC008718; Thu, 12 Nov 2026 14:47:26 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACBlPAC008718 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="T8mRB0B7" Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ACBlN7J008714 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 12 Nov 2026 14:47:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ACBlN7J008714 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cdb8b260bb4so2475235a12.2 for ; Thu, 12 Nov 2026 03:47:24 -0800 (PST) X-Gm-Message-State: APuU4Z8wChuPYVg71vApXykVrfs9PnhwyTPEKrAv7mDwkpgJfIkMHgYq yU5DXlko/LL8a2pyrm4ZXxsxKHkUFTlajT0huit9o2O5f+1HF1K/4pOSLUSB2akJnR8m+noiXDl L9fHXE7gmVzBhHp3W4E5wfze9e+twLXJ0lbDCfJwP9h0PUvNdJzMS/g== X-Gm-Gg: AYBFou3uJ1lBuLHuGnnOngcPwHGHPAkOuTfBaKwlvelcOoo7yBrcVWpEVFlSBhjAqy1 RtPR/iL+ohbdIqzkwgGirRNY1bMKVOjX0F2atkhcsFefkUOfZsHxbrKjuPBHqT/mFJmFcnF+TxK oCVBmNP+xtlaJoDKmkIDcxKwh4UNcmEM19xkP5kyFWH66YrSUCUopMu+Sh5/FadZHRIWEcSlLJJ d5mtiQY85iY0UQD8qz+Z8i63RsYxLQ5EPlL7rGSpXDz4M9o5XxNjiQDkxHsM30Ah9mJwxRxt8ZX wCuKbq+jGZ2v5h2QNx6Bsm7cguQa7a/JWoZFtPqIYWtCaVn7vRlfxWlVwn3P/k7jr2xrq4uaRX0 BJh0FrGNUhzFnmIjbDcCZu+XZcUSlZ7+sv25vKUbRGnFIj4dVOv3HrUUTa8tl6YtNykL/c3n7jr BavMtKEqi9P3zo+B1H4crnllcCpCMXUpKv X-Received: by 2002:a17:90a:b107:b0:3b1:83d4:5d33 with SMTP id 98e67ed59e1d1-3b183d45eacmr3414906a91.60.1794484042832; Thu, 12 Nov 2026 03:47:22 -0800 (PST) X-Received: by 2002:a17:90a:b107:b0:3b1:83d4:5d33 with SMTP id 98e67ed59e1d1-3b183d45eacmr3414895a91.60.1794484042196; Thu, 12 Nov 2026 03:47:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794484042; cv=pass; d=google.com; s=arc-20260327; b=YI3qbc+T8qfgg2mIAbhX8uhSrVj4Ooum4fPZ4LM6ZSAREKnJFeKoju7BKq2jfT5xzN Rc4Ihx8MsEZ8J1mNtVXKAeLruKI0qJCFWL8ezcVDY9zQ/jo/BwUuA6rQQr0VshJxjMFB INL/EVXWTV4NvvbIF3QB2/p06X4pD0NZHtFQihpik5mIACyGUfHNW5IwlCR3DQoDi0qy Ahw/uR5qtKHgvz/qHuNjNI5N6ObrZWNlb3gQvpgJMAsXUnkhF/ZsixVzSPmaSQq2ZXgR e1AM3U6XKUWtSKcf/QcxQ658H3L2y4vEHZSSE+cUsUOJSl02lj8Q1YNzd8bWwbeC/QnM osfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=cJ8pl9eRZmjRfIeXawj31g537lHIk4FBjrotwFZn3u0=; fh=/dRgTijvo1ePWcNOaQjvarTNnlaHT6OMdL9Zu0+G4+8=; b=SL/MUdAE60C6nPlT5yWNjc+DCGBCZdvTxRQQwDY9hniQjYxBE+KCqIqQ3h7V0taCne RnBt9gJzPE6xGtheZeQIupGYg44EF5IcGR3LPlki3WMF8twd/DyajMu0+dp1iSk0pG8F FfNLQX7o94DM1In5P7jE1gCoQ+QsB3+GvE48Jf3gKwy8ThZsG9adgXf1n/mlmOOk1QWQ qsTnJTThN95tDomQ78206U4P8zjMgUH5uVCrMV8BK1DNSm0msIUNUJHR1bbnh0p0VU3c WjCzYSIz3MYzLkqHYpUOCpVZrvjICkG2GDVP+T/s+zT+UvW+JG5FryShkeLeFQ1W1hHO ekLQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=T8mRB0B7; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-cdd8da4eac9si12088344a12.396.2026.11.12.03.47.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 03:47:22 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=T8mRB0B7; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N61ckWbUuS53n/gSbzuPpGzj4UbKMJL2uL3yqGxakVtPpWjYeRzE8f6ZHsgMltNa/2jsuz8knv7a3y7Au8Lfu6+dLi/ETTDPSyMw+aeZ1AsqoIduoKRsKH8imjQWr5P2NiVO/LjMslV+zKo9SBLdZEL03VoirELqIsb+vdTgP2V2ULW7bmEsLAHTcr7o6K80RrFCocO4ZTPYVz4ykr3LlOAievYI1u/jmwet9MHbQOqaI7yDA9KqNCf2aTXq5+Wt7WZE3eA+pe/UUL/qSb2rDI2xz4alGBWaV/Rc66JqtSvavIGxLQWimQesxqdXVnk0WNGrWZGnUbtJIttxfZdEag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJ8pl9eRZmjRfIeXawj31g537lHIk4FBjrotwFZn3u0=; b=Bmk+kjjeHWd/0oG0LoeZX5Ex6iknFO4tcPMuZIV5UO+ULVuQZ6H1Odfx5bAjq5kDi+mkBDjebHgN8yYNhNdV5CiJYw2OdfbwzgHiI6j4JgWil4r7pVmfJzh5oSBP2L+S0EmJ0Etgj43VcJAOq0UNe01WUzWBhgFxKKgsmvfR0E4g2nRpit1Dw3e2m9lsfHzbIWyLg8GfnYb7lGbH7SJnu2W3iGV2yJbwBUQAc5ZFYNfuh/LHv2dBhZbCbuWd9oRzvm18bHcAdxDCwol2vxv0DM8IEpwStCVN2yQ/AUwqwtFC9nIV9p4RY4eqisGrJq1fRkzkx84RaE5oAJBh3P1yrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJ8pl9eRZmjRfIeXawj31g537lHIk4FBjrotwFZn3u0=; b=T8mRB0B7ybuTpnpDaegiAaMKzD7cjvgSDzStxKe3RR2AFGgD8nf+rwgMfl7hgTvqFeLOPmnSbNEoSxb2nXAFz3FG3Qi8lIrGf3IfPp6V0fPqr5jMZket+T2rmDRgAFrVfQTbEeMBwTD2I4N+T8HpmMu5VWI5zfL2eMvozBUGcf1LfQnYNERW5R9lAtJZH+qVq9il5WSWDpMxUpr4L4GrGqTmv8wCevFQ93OfWOCF8ldDR5P+tiTMqjzLSYUbEFOYx4fnHdf4PobzDSGye6I9KGyL+XFP59hxEJZzD0a+PZU7V1Zh1+4/2RI55xNPeCN4HsB4sUcaEvTrLgmXLLAZCw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DBBPR08MB6059.eurprd08.prod.outlook.com (2603:10a6:10:202::10) by DB4PR08MB7958.eurprd08.prod.outlook.com (2603:10a6:10:38f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.10; Thu, 12 Nov 2026 11:47:18 +0000 Received: from DBBPR08MB6059.eurprd08.prod.outlook.com ([fe80::fb27:b8f7:2c54:34e0]) by DBBPR08MB6059.eurprd08.prod.outlook.com ([fe80::fb27:b8f7:2c54:34e0%5]) with mapi id 15.21.0615.008; Thu, 12 Nov 2026 11:47:18 +0000 Message-ID: <499de529-c8b6-4b7f-bfc0-1333927cb400@virtuozzo.com> Date: Thu, 12 Nov 2026 12:47:16 +0100 User-Agent: Mozilla Thunderbird To: alexander.ivanov@virtuozzo.com, khorenko@virtuozzo.com References: <20261112111205.736027-1-andrey.zhadchenko@virtuozzo.com> <20261112111205.736027-3-andrey.zhadchenko@virtuozzo.com> <010701a1cf82d0c8-0a580438-f948-49b6-bc29-3a42a922163d-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <010701a1cf82d0c8-0a580438-f948-49b6-bc29-3a42a922163d-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: MI1PEPF00000D64.ITAP293.PROD.OUTLOOK.COM (2603:10a6:298:1::48a) To DBBPR08MB6059.eurprd08.prod.outlook.com (2603:10a6:10:202::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR08MB6059:EE_|DB4PR08MB7958:EE_ X-MS-Office365-Filtering-Correlation-Id: b004ba9e-c282-4bd1-93dd-08df40b2b468 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|10067099003|4143699003|56012099006|261022105027099003|261028144727099003|261026140227099003|261021123027099003|261021121427099003|261102123227099003|261009223027099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 1fVpxSzvbDYFpDEqPE6JvJ6CwqQaC4PXbaU7Z59cnPks9yVviXVP8/OtmXNEhHemdVN5TqOChH1ntqxmFJfVZXGOuHKbxdQ9ZVxY/F7J2spZgYGu41i0XbIXBZ5VAPtY1xg/hehaKd00T/cC1rPW6b8h3DG8xwz9SKNT8X3W6KWAhk6X+PxM7q50oY/9O1XDxn4SHCMpWKPf6R8tWcN7c+ZarTX+QpJAKKPI77RvQZAcUI7BRVKYS+ZV4hj/MjrlUmDC3qCHjF5IKRBtT0TD4mIRqfpKvigPaiL/Uo2czsINSZiB7a97fcC6c0W8U4r1lN3KB1G/GA2MPOFX24udttz0R+ZZPfJduGV+F9hJpupQ6a36fVrVJGuzDfsil3NLa+y7EnMg3OfJPMzI1LGtUP0E1kMX4GOOQYc7vIzAnVttKDlp+evtXwskEZPBpAY9fcCR1RNSpyQ+y6yiK01MHSFPtk+CJBFu+yZsrwSPUJBYKQVJAx7gKk14xNONBzabtW171tJlTE1WAwTdzcuYowdLOrPZRCZ1HVhmbuItDBMcgaLYkf3hSP5qHRsSBEvVkyHTK3pen/t3h4Br1ixpNQhsNoGGcFvEarYxe+s5XeWqSV7u8KJNx9LtqbzBetM2qqKyINrTq5uTNt9t0+fgLgmt1oE9Kw97ycZPG/ntHz4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB6059.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(10067099003)(4143699003)(56012099006)(261022105027099003)(261028144727099003)(261026140227099003)(261021123027099003)(261021121427099003)(261102123227099003)(261009223027099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmlJQUxaU1VYSTBLTFV2bCtsUk90RmxyWWEzSGw4RTBjZXAwd3k5K3BPaU4y?= =?utf-8?B?OEMycVdXTGZFRG1jVS82UnI4Q1I0dDAzem10MTc3eGdkV01uYVVtR1dIT3A3?= =?utf-8?B?WDRKUTZIWGhOa28vaEFSQ2RXTHNwZ29qZWh4aG5YWHpsR0tVZVZ1SWUzcnZO?= =?utf-8?B?c3gzMUI0c3FwNnpXY2ZiR1NLUGxmQjJqYWdwTkt6dmo3ZC9qY05vV0tIRUZo?= =?utf-8?B?d0FZZ1NhK1Z2TnhoWUN2UDRjNElXdkRHMDdOLythRjZCUlFzcGlzSWhSSlZo?= =?utf-8?B?OU5nMkh0SjgyQ2hwZEVKZElFclI1bW0yU3ByWkV3OFFPYTZaMG9JdlFLZ3Az?= =?utf-8?B?blMrUy9CZDFLYnkzOWdZQzBlbUNmS2w5d1czUlVCbWYrWk95QzJDaDllRUMw?= =?utf-8?B?V0ppMlhXR2FSYWRDQzNXUEF0WEE5QnJEN2VYd25wbDBwL3hoTGhBbktzUmMy?= =?utf-8?B?SnZ1aHdqTmtaUEczVmxXV1dIZjdkaVRidDB4OThRcVpOZURwbFVEWmdyekhH?= =?utf-8?B?a1h0aWVvczNDQkg5TlEvV2NUNUdVbGpPU1VmcDJoWWNSOGFiMmVZbC9MZ3V3?= =?utf-8?B?WGNQWFRLWEEzdDNzTXRnRG1oOTlDU0xocEVrWWRNZGpZOWdrVS9TNTZSajRi?= =?utf-8?B?MVZYa0JGWU1oa3dvcEducVMrOUhrWTg2czYzWndrbHY1ODRHUFZlZytoTXhs?= =?utf-8?B?ZFdMaGJYLzVGWlI3cUg0OUNTOThkZGFKNkhOd1pZTitLclJIV1BQellSWkR0?= =?utf-8?B?RCtCM3duTmFhRi8zcVVVVmlsdEpnS1NSSGFxK2szSVQvdVdJZW9kNWhkQThF?= =?utf-8?B?cHE3anJSZ2h1WmdZN2JwbGxsbFl3czlPWGFpdWg4K2RiQVVWN0MxazJOazhI?= =?utf-8?B?VmdNaDRFT2ZnY1NJdGlPQjdzenhYU002WWd4dFlCUTViblA3Z3N6Vy8rL2U2?= =?utf-8?B?amFmY0xGcW93ekNERW1lb1A3M3VJQXhwN3VUaENPNFF4YWFuWDYvTXVic2RY?= =?utf-8?B?ZjFEejBDaWxVTFZPSGo1bk5PTDlIV0l0UHZVWGdUMUE2czRIby9wam1oTVRl?= =?utf-8?B?UEg1SnJPbVpFZ2pHSTdYTHlmUXNLZDUwUmxxV1BwL2s5RHpWVkFOSjlRaHFX?= =?utf-8?B?QzFmdExtN0FGUDlETmt3SmowWHJacnlveUdISHdDZzBEZ2E2VUVOSThiYVNk?= =?utf-8?B?YnBzNmFxQmNrWlIwcXB5UXBUbWxUbkFob3FkbmVYdXF3cEpoOWNrc1p0aWZV?= =?utf-8?B?dHNHeWRkTVE3NFYzc2pWc1B4SnE5NGlCaDUzb0tBaDRjU0grTm9nbGNxd0kr?= =?utf-8?B?UEVZdWs5WlRhL1RMcmhXSzFWVktZRXFycGViNHh0ay9INFBLZzF0dVY5Zng1?= =?utf-8?B?Qlp6clE1bGY2R1hjUDNmNnBkT2dEaEljMzRabUpPSzZJNW9FZkpQUWIvYi9r?= =?utf-8?B?a2FXdG1WMlhzWjErQ3Rxb0dkN1ZsSFlrUnloNkRReTgreDlsREdVU24vczE2?= =?utf-8?B?b3hTVDVySitHTFFHNzNUNjBMbmtZbDZpOFV5NHBxVi9ScVR6M0Vrb1paSEVB?= =?utf-8?B?SjFzWTU1MTgwU0lhdDdKclpRcmNkQm5ldmhMU0lobFFxTHdpd3hNRVpodFpS?= =?utf-8?B?TzNmdnlCRWNLcGpXcHovWGpCVCtaVDJtZTZIYkxMaDIrOC8xb0hGQkF5bDFj?= =?utf-8?B?Ykt1eFB4QlNZcVk4cC9xbzZYUEIvUzZEbXFXdUhtdFAvbzVROGhwd0FxbXBR?= =?utf-8?B?a3BWdmJRSmdVc1FwNTZrSnZrbHdJY3pwc1k1LzU4SE5aZjZGWVFBdVg5M3pL?= =?utf-8?B?R25aVWRxc1RzbDJ2QzVMZ0IyYVpmUUs4VWw3UUxQZUw3MDIrVEZJcFZXM1dZ?= =?utf-8?B?by9Mc2VKK1JNeWJlVGdRWkg5YWFwRm1hdnVaNkloL1U0empGRkw0OWw3eUtP?= =?utf-8?B?UW1za0FMUWZ5ejYzVGRXeC9pOStoeVp2SlVyM3JSd3hwYytuSklXZDVuWnlu?= =?utf-8?B?QnFxWUNGaTg2VmVsVm1GV2JLUjZxaWp0NUdpNk9vOWVXL3Q2MDhRd0RnaWZ2?= =?utf-8?B?R01sbTNvVjFUVkkxV3NnTlI5VlNTRzJsaHQyRE1BdEdib3ZjMURQVGlQNTVo?= =?utf-8?B?cXdDOVNiVkpKRGd2VXJLVVBXc0t3YWNHUGVlb0dzeUk5QlI2VVRWTFkrVENr?= =?utf-8?B?K0x3VUJRR3NNc1llaWNwQVQydHlTMXlxK1NHN1pyNXBxc0FFa3Via0hvY0lN?= =?utf-8?B?Z1F6d3Vnek5NWHhSY3JPU00zRDR4dFRtWDFtci9lRG9zU1Z2WWJpRm4yUDRh?= =?utf-8?B?UzhTb3hDb1loVGFyalhtVXZsMFlMcXc4cElnQ3lGT1NoekpoNEdGYXFEUkUw?= =?utf-8?Q?05TdZfmF/caXt8ZA=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b004ba9e-c282-4bd1-93dd-08df40b2b468 X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB6059.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2026 11:47:18.6875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /sYcBl8qydhF2HOpPDxNkCmozSMuMQRazDStqE1cqSnrve9VeVXeAHlbbp/+69ZyfQC3j//SxeTqCE20DSAmgERaQDIyHqfcLl8xfSF/vz4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB7958 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 2/3] dm-qcow2: wait for in-flight writes before freeing a discarded cluster X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org It is true but so far this is more like a premature optimization of low likelihood scenario that increases md memory footprint. In the worst case it is the guest that actively slows itself with parallel writes and discards. So no for now. Maybe we can consider this later when we add per-md locking On 11/12/26 12:26, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] dm-qcow2: dec_writers() scans whole qcow2-wide discard_wait_list under irq-off lock > -- > > commit 8c3ab12e988e2b5f6106aa1b1403344b45fba8ab > Author: Andrey Zhadchenko > > dm-qcow2: wait for in-flight writes before freeing a discarded cluster > > This patch makes a discard that unmaps a non-shared cluster wait in > process_indexes_end() until the data writes counted in its L2 page have > completed. The discard switches the writer generation of the page and > waits for the previous generation to drain. A per-qcow2 discard_wait_list > holds the delayed discards, and dec_writers() wakes them. > >> diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c >> --- a/drivers/md/dm-qcow2-map.c >> +++ b/drivers/md/dm-qcow2-map.c > > [ ... ] > >> +static void discard_waiters_to_list(struct qcow2 *qcow2, struct md_page *md, >> + struct list_head *list) >> +{ >> + struct qio *discard, *tmp; >> + >> + lockdep_assert_held(&qcow2->md_pages_lock); >> + list_for_each_entry_safe(discard, tmp, &qcow2->discard_wait_list, link) { >> + if (discard->ext->lx_md == md) >> + list_move_tail(&discard->link, list); >> + } >> +} >> + >> static void dec_writers(struct qio *qio) >> { >> struct md_page *md = qio->writer_md; >> + struct qcow2 *qcow2 = qio->qcow2; >> + u8 gen = qio->writer_gen; >> + LIST_HEAD(wait_list); >> + unsigned long flags; >> >> qio->writer_md = NULL; >> - atomic_dec(&md->active_writers[qio->writer_gen]); >> + /* >> + * Fully ordered RMW pairs with smp_mb() in delay_discard_if_writers(): >> + * either we see switched generation, or the discard sees our put. >> + * The generation can't be switched back to ours while a discard >> + * waits for it, so the same generation means nobody is to wake. >> + */ >> + if (atomic_dec_return(&md->active_writers[gen]) || >> + READ_ONCE(md->writer_gen) == gen) >> + return; >> + >> + spin_lock_irqsave(&qcow2->md_pages_lock, flags); >> + discard_waiters_to_list(qcow2, md, &wait_list); >> + spin_unlock_irqrestore(&qcow2->md_pages_lock, flags); >> + qcow2_dispatch_qios(qcow2, NULL, &wait_list); >> +} > > [Severity: Low] > Is it intended that dec_writers() scans the whole per-qcow2 > discard_wait_list with irqs disabled? > > When a discard switches md->writer_gen in delay_discard_if_writers() and > the last writer of the old generation completes, dec_writers() takes the > slow path: > > dec_writers() > spin_lock_irqsave(&qcow2->md_pages_lock, flags); > discard_waiters_to_list(qcow2, md, &wait_list); > > discard_waiters_to_list() walks the single qcow2-wide list and compares > discard->ext->lx_md with md, so the cost is proportional to all pending > discards on the qcow2 rather than to those on this md page. > > It also moves every discard for that md, including ones that were only > delayed (no QIO_DISCARD_WAIT_FL set). Those re-run > delay_discard_if_writers() and may be delayed again, each costing an extra > qcow2_dispatch_qios() and worker pass. > > This looks like a minor inefficiency rather than a correctness problem, and > the list is bounded by the number of in-flight discards. As far as I can > tell the later patch in the series ("dm-qcow2: let discards of one L2 page > wait for in-flight writes together") leaves dec_writers() unchanged, so the > wake is not narrowed there either. > > Would a per-md list, or waking only the discard that holds > QIO_DISCARD_WAIT_FL, be worth considering? > > [ ... ] > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel