From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D185F80726 for ; Wed, 14 Oct 2026 11:38:13 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69EBatkK031648; Wed, 14 Oct 2026 14:36:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69EBatkK031648 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Kh27FJ3r" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69EBar1w031644 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 14 Oct 2026 14:36:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69EBar1w031644 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-677c4ca2265so649885d50.2 for ; Wed, 14 Oct 2026 04:36:53 -0700 (PDT) X-Gm-Message-State: AFq9FYJvcQkKcSRCilCIiL1e4MoPQMCoBVRqnu/3szv6gxAF8le/l8Sj 4qANNAg+wotqyWqDnEsWQ7w4wHkZAcXKsEmyTLyAZi+7rh4H5Du6Jzk/VzSb80eSWrHs+A+tZUf M2dyFnltt4Kv0z/DllOAeTHejYDrsjzPDR74Qu7WO218DK3kG2uMFpg== X-Gm-Gg: AYBFou3GntAyXCwg+Sk4YF5ZLixRyF5q9+qHcfOQXJW+WdcKIA1iHWB1XdI6gG69mau qWUi51O1xP8tSwMwETZBiLjV321jSDN3CAR0JMRqZy+jqsA6guHFHICY/0INeZdPROZNzkAP5yU WJxH5na77CWJIyT6Bsr2XW7SQNO7zjWlyaTxhYbs1YCr4XX7+KC4pzAVzhWgjhIe6zp+Icsf6sK DKvvI3RsGnnAoN/V892JU5hNClsV76ffKV06XHCbKmklMdFsQsTWX4/6RknZTcreD6zu63j+eS1 hR7JeXDXGwkLY+wKuzsMGlNVbbZ0aweJ5aH16/Vfi4I2LH1f2RqS/whQBg5jSf0MwpS9pEbpqY8 n+tA72q41H9F1C6LMh9NiqPx2Sh4Vc+rQbdSPlvxqrDoGIOWh6zVTq1401niRTLCkTOUEXn4k3Q t/bO9L9d1T28jrE/4lvSLqNXtrn45RVqjYYHqzzw== X-Received: by 2002:a05:690c:7402:b0:8b0:cf3d:7b39 with SMTP id 00721157ae682-8b0cf3d7db0mr1088867b3.38.1791977812471; Wed, 14 Oct 2026 04:36:52 -0700 (PDT) X-Received: by 2002:a05:690c:7402:b0:8b0:cf3d:7b39 with SMTP id 00721157ae682-8b0cf3d7db0mr1088717b3.38.1791977811928; Wed, 14 Oct 2026 04:36:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791977811; cv=pass; d=google.com; s=arc-20260327; b=XpO+EYytGbsx3YtYolW1LFJ+N64TbiF7HvavYVK5S7lTl/UJqXz3ASCqnB5zfJ5ADv l2Mf4kM4SVBgbtau0XhQh6NE5jA8dFnco4xQYc24NN/SHQjNmU2SKwVds1M7rnGlFRrz w6Q/6iOCTVc+qfE1B3uvkMIHCwfH1OPObTXtItLH64n1lgnugjekLaYbVgK0QshmpNg7 xvYM0hpGk9eWGzh/cLJjTIfLJDz/6lAW0O+OrczEKYPf58egglNN4MLGqu08ulRTL8hd D607a/dxdSOHHXFzRUz8nPuSsHhjUFUFXlj/y16SNGpy8gsMXzBw22UJLdHvP3LgV1jH iv4w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=W1kTDaJB2oz2hP3rTaA01lUU0fISMD0/g3DzbETwiH4=; fh=wUbdsZk1ckznbwX/zBKTv4zJXOw9YHjJzJNno49byhI=; b=ZJiw/6djTEdOnbeEhVrMn9ZLv6JWW17HjGXnwHPQxcIhLlpiqCRYYTW9c8Ffp5s08W blxFNqkTzfbQ4cHfKQiYDwSEm0NA9w327d+lIXScJSb5MOjY++blSFFgG3mWnlnCOVRX 82KeWJx8fZUDcu0sH2kf61GNEn2+r7kEpTHmmJrPCUDlt4Fqxl5TSKd3LA51As2I6cTV 6oJNJ+TgA3WF/2zwRZ46fSAxtRNcqWePXFwjPeZrASELSR0n4RrWNMDMnDGue4uUvlu7 e10pgAXGl733EhZL08O1cS1BNePJu6RsW32w6+7Cuv5X6XmIihGyJJhzDb83ul2T6uHL yPWQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Kh27FJ3r; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c200::1]) by mx.google.com with ESMTPS id 00721157ae682-8b07f24fbf1si49022737b3.143.2026.10.14.04.36.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 04:36:51 -0700 (PDT) Received-SPF: pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) client-ip=2a01:111:f403:c200::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Kh27FJ3r; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vasileios.almpanis@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=vasileios.almpanis@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VSTooRO4vnrK8Zh3j4NcuvVVBnoQ6uiqZPXbhbzfa0FLXoP1bnLFZt8szY7Q6IzPhfoa9LrwhTmLzayBRA9bAwsHj9ZuYDntV9YgohKCGcar7DPlrNaRDey8xFdvYMzUJvbho61ZmOS6HFya1L8/aA/xMqw2V1FSRSOtIPXYk2sQr6fCrMUadTkpOZADZgvs30q08w1h6Ib8/BG7VsWEWuIoLruxVbMtHcnjbeysEfIg01ua3r58CheBYmOeo8JNZmgK6uATAKu1Syoph8YENUa+gbVJq+eHRxYOtOL4lunvql/80bPFDAnseWCepKU/Udc2OViGjHCGs2E2TeZuXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W1kTDaJB2oz2hP3rTaA01lUU0fISMD0/g3DzbETwiH4=; b=qmxNd4vQMgp2jBByq2EEt5tazEJrTy7YoE29nu81FO4C6flQ/V4vYeGlM6lFZjcDW+tCINVWERlZUlyR8vPOhCcHShAWCa8UNTjjjYYfRV2X+lB6GMQOVTwbVbRQhMCcA6+d/Tp1AJuAb62lvCBUuw9w/pK+I6lzq2zfEHf8Yha74ABsHOQ7EIHvI9jaGx/o4fGA5UK1Tbm8FZXzqw+aI+dvFaqbkImMRwVy+BPbv+6E4ixhLXaRwJC4AwBPZgBq8+mGFXXS8B/FmGAdGc9pLmKSFxuWkXXU25sqkV5aC7cMJMLDmuPDldBIedETDGV67MvZvmA/vv0ChY/iNYSteg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W1kTDaJB2oz2hP3rTaA01lUU0fISMD0/g3DzbETwiH4=; b=Kh27FJ3raqLJzZViE+JwZgNC3EefWQ1g9J+4xWdYKAUChz7ivnCH5RZzGTbtIfisY85Sz8qbcCVM7L0As/oCYvL4GXF4d2il1hndd/im5o8Tsb2LuVTEIG6kqTxFvYRDLGRGAKkVmyR5vQeactHKwMq1PXlsuznNm8q3VlA9KFEOc2qtFByjolbOV8srHgoijHDtIByI8FoWWiehsj4m0ztq0tJpiSHqvVxX8WF2563H23iW6wPgcL1QU7PhfHr9QMDwx32EqpuKQ2A/PgEYkwfm00nykaRDVMQJvh71RiniOdf2DQZVZciX3hnubBhys1AaCA+yHZl3jXzMd0Rd3g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PAXPR08MB6942.eurprd08.prod.outlook.com (2603:10a6:102:15d::17) by MI7PR08MB398370.eurprd08.prod.outlook.com (2603:10a6:290:111::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.6; Wed, 14 Oct 2026 11:36:49 +0000 Received: from PAXPR08MB6942.eurprd08.prod.outlook.com ([fe80::fe53:d5e4:a1c8:61e6]) by PAXPR08MB6942.eurprd08.prod.outlook.com ([fe80::fe53:d5e4:a1c8:61e6%3]) with mapi id 15.21.0546.006; Wed, 14 Oct 2026 11:36:49 +0000 Message-ID: <54aa08de-a10f-4c54-b24e-312356f0eb3e@virtuozzo.com> Date: Wed, 14 Oct 2026 13:36:48 +0200 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, Pavel Tikhomirov , Konstantin Khorenko References: <20261014-ct-iowait-v1-0-9d65fe37cf89@virtuozzo.com> <20261014-ct-iowait-v1-3-9d65fe37cf89@virtuozzo.com> <010701a13a2bd5dc-7ccbac73-8a80-4be0-b3eb-24c3b15d1910-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vasileios Almpanis In-Reply-To: <010701a13a2bd5dc-7ccbac73-8a80-4be0-b3eb-24c3b15d1910-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0431.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d1::19) To PAXPR08MB6942.eurprd08.prod.outlook.com (2603:10a6:102:15d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6942:EE_|MI7PR08MB398370:EE_ X-MS-Office365-Filtering-Correlation-Id: 5409c138-8abe-43f3-affa-08df29e76f23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|1800799024|23010399003|56012099006|5023799004|4143699003|261009223027099003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: IYdhHJzbENWWRI19PRtnBD484jrgPgJoG0zXyE1xkvhiEsBx2NbkMbZRoXNfbHt5pwA1NmjYH2xmGGSUhnLZlzWoySQWY5X2CMui0PeuihOEyy1JdbmdXgVEwEHDvvDCtr00s3M+TCjwgORAEINEBtTPxTUNeKoTQ5ITgwxnasT9iTzjeZpxyuoyYpXm98vf5gm0oR57UKtIj6yBqGCB0U6tBNpvwU7S65xs4r/SzLZOdFKsast2cKlgjXmtdb3HPkjDJDReFzLqUK4gfXZtVuGkSJQQ+ZLIJ4+YERTuYIMeHlI8ZrDShw4Y5WXhUKpvGUQVtXSTV+SnjtZKpLYgaT9qpJX0VVU3fIiDn8hXI4BQMQFoBhIPl+o3Kh8pGhXFkps7Ko/z1eTvZLSrvh3PBJZdrPwJl4egY1+UNAsHxDosUpcWudXDqkztmiPnwRFoD1DguPWkZvB57cUrc5GoJBpyn1mIcdQwO3jsAM8M1Q+c/mAqXq/dUTVtwUPHJBMsvzEH0I+vDSg8XjuZf6cHybb5Ynr/3aTeXv7WenF6zvHjWIVOa/KiTEyrl03UxE3oIuD4T2A+3s2iknMC8yZupg/HNk+/tTicBZ/yzRpUQGUmSLV6E4vlHkuOxO7lJ+yOAR5Jd8xBWS5qR4YeZ03FzuYY0YPiJM97KY2YeUCB+QM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6942.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(23010399003)(56012099006)(5023799004)(4143699003)(261009223027099003)(10067099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUJmL3RpcTUzbFI3TzlNR0xRUVFjc1laeDczQXVNY2UzdzloWW9qRjdRQ2tN?= =?utf-8?B?THNqM0hrckQ2WUxXSTJ3MVRZV1BGdGJPWnA3aXRLWHludTZnVmtTRi9SbE5l?= =?utf-8?B?eXR5NFk3SFFFWE5yQVdlTmMzRWhka2ZhdlVhZHFlR1pmY1JqSjFvNkVuemNR?= =?utf-8?B?Vk1QYTNla01lNnFEYTM3SkhNVzl6MlpLZGVVcUtORU92U1JXME5nRkxhUU5G?= =?utf-8?B?bHpkVEI5MjZhMkphejVzbTEvNWdYRG5qZUx5b1FKcGxsUjBEZitnREJMOEl1?= =?utf-8?B?RHlaTEYrT2pvcVBEdEF4TWljdFhWSFZxOGk4RmxsdURyNE04UVZ1ZFc1NWRo?= =?utf-8?B?NUJGSkpuVjU0SHJPUlFDL010KzJEN0tCazlQclEwTzUxU2JKL29jRkUwbFhY?= =?utf-8?B?VW5NbHBob3hramZuc0dwVkJ6cVc3OGhDem9iWjNNVlZjTWZCb2k1L0tOM1Az?= =?utf-8?B?UjJWTmYxeGVnU25VQmI3VktwNkliQUNlZGtNZFF3blgwRjZqQ3hCNkRXcU5G?= =?utf-8?B?eWUxNGhjUEpNYTEyd0xzR3ZiTkNPQlVHcWd6aFd5WjVwdlN1UldFa1NEMGg0?= =?utf-8?B?a2ZzTXQxSnY5Uy9XM2lwSW04UmgvOTZOQUx2UDhXZE1YR3hVQXRVVUw1R3lw?= =?utf-8?B?anRWRkt0WGZ5eVNmeUNQMElDTUdpalEvMVR3eDFNOUpDQlVDL1hucWlwbGVi?= =?utf-8?B?bjY4MVNpYjJCQVhFaDJoUmxTL2krTTM1aG9iOWRMcnVzUjAzeTBQajdobGJY?= =?utf-8?B?c3d5cWJaTHo5MnVSdW1oSkhuMlp1NjUvdzVZVC8zMzNzZFBiN3B4TW9EZzRB?= =?utf-8?B?YXcvQUhZQkhveld1d1hVOHBFUUgvQ1FDZGJoYnFNKzJDSkMzVlM4MVRnMGti?= =?utf-8?B?SEpRQVR5K1FKU083WWpwRXJhdkFzbHUwUjlLSWM5Wml4TUh6R1E5Vm9LL2tZ?= =?utf-8?B?akNOUHBldEhpeDBFeFlSVnhFNzFuTkNvL2xpQ09sc1RseExrVjBhUlNrbkRn?= =?utf-8?B?cGFYckFUM3AweDNkcDJnTWxpL2M1QTlVb1lPa3JldGJMbmtWT25aYkUvTzY5?= =?utf-8?B?UWdBREZkT0NaY1BTSmZ6SUw1MXlkQkUxdjZBcHA0T3NMYXBpQVlCR3BpOWN3?= =?utf-8?B?T0diQmRpZm5UMitaTEVBQUNXbE1WdWtHRDVVWWNPb1UzUGtsQmVLMGx0b3po?= =?utf-8?B?elBWRkh0N0k3VzBHSVBock00ajNEWVlyd3oyU25CSjdWZlNuYzdFVDQrc0hi?= =?utf-8?B?dEhJcS85MXZEOUxjWFJ4b3pEOEdPdkh0QXY2ZVpJbVZ2VU5kTjJnUlhYczd4?= =?utf-8?B?MkpYTGJMVWkwdk4rVTViQm5OWE05RmZmdk9aWnZ0ZS8wMHptUTNHNWlIN0h6?= =?utf-8?B?VW5DYVBaZTJnL2dqYSttd1ptQ3BiWHpEVEl0d3dBV29RSjdLUnVOb21VWGNX?= =?utf-8?B?ZTNicUZ2TGk2YXVtcEU0ZlZtdDVTTXpZb2w4eTJmV05TYmlOVXBDWXdyeW0z?= =?utf-8?B?b3k1UVpCNDRrVzVlYnJGdWdqM1Rsb2lSMzZRUFEwSjQwbTNoZU5ncDI2NE84?= =?utf-8?B?eVpESlZ0S3IvVGV2T3NMcTNDTjNnRnB3T29xTkUyNENkbHljT1BHNHVRUGtm?= =?utf-8?B?RlduWDRuK09STjBPMEs1cmtmM2xhcHRsMURYT1dOdEhvNnhvWGk0NVd0c2o5?= =?utf-8?B?T0Q3OWF5U2FCRHFuOEFLSHVtbTlqdHp2NTRPcmtCZTdEZ0NJZGg4KzgrQW9C?= =?utf-8?B?KzlTcTZPUmo4WkV2MnRuQnpKYVYzbk96N1R2WWY0a3U2MGJuODlpU0dDRjFK?= =?utf-8?B?TGprV0hYNS90R09MNUpSSzJrVUZrbHJVWTdqa2Z1Mm9EUWthYlhnQUZsUXlo?= =?utf-8?B?MGFlZTdqd3FiamJFMUVXZlVDTGFkOGkzUWJHLy9pNUwrcktKNGJIRXVydkZl?= =?utf-8?B?S1IvYUhYbEpLVGpTWDhudkcza0xrQWJRWndhb1NwRnNzL3JPZ2s1bFBNckVu?= =?utf-8?B?S2ljVkRXakVwd0w1d01BK0FML3dGRzZaZm9yVDRtb1RLSDRDNzFPS1I3THBq?= =?utf-8?B?eGg4UGgrY1NEcVh1Q09MdWJOTGdOMEFNWVlKcUpMYnlTMXJ6MjYyZndsTGVs?= =?utf-8?B?di85cy80UmErblJLNzFZa3ZNdkJ0eUZGS3ZvQXNRVmdTOUhtcEtMajI0MjBv?= =?utf-8?B?K3c3aGt1cHZ3amNHUDBsem9Udm5lYjRGMk85Qy9KL1huSUJ3bXhOcUNVdXNQ?= =?utf-8?B?c2JDbCsvVlVabjNLdlF5TXFlOG00SDVQNFMzK2pmTldwTE12S2ZxL2ZKM1Vs?= =?utf-8?B?eW9yWFoxRW1vS3J3OXRXcUgvOU1kRS9GMTZmWjVUN1VzcHBnVzVWY0ZqWVBw?= =?utf-8?Q?DfyCFDR2hUIswiHs=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5409c138-8abe-43f3-affa-08df29e76f23 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6942.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2026 11:36:48.9982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2EvRlJsAq4+BUpbZXEOfGfKl09Gu6GXxpCO6SXrgS4cavJbMHWFxEb5PoKDQwHQF4nTAVBig3SHgGT3y/t9ekdG29OQjCbrynnDb+ensuZ+SRDHY4hPe8Q6lUV4WS7q+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI7PR08MB398370 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 3/4] sched: account sleep and block time of a task group entity X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/14/26 1:28 PM, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] sched: group iowait/idle classification uses non-hierarchical cfs_rq->nr_iowait > -- > > commit b026bcc4d4882c5ba1716b8736a28e5f90a38798 > Author: Vasileios Almpanis > > sched: account sleep and block time of a task group entity > > This commit makes a group sched_entity start a sleep or block period when > it is dequeued with DEQUEUE_SLEEP. It chooses block if the group's cfs_rq > has iowait sleepers, and sleep otherwise. It also starts the period from > tg_unthrottle_up() when an unthrottled group has nothing to run. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-147823 > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c > [ ... ] > >> +/* The group goes idle, blocked if it has iowait sleepers */ >> +static inline void >> +update_stats_group_sleep_start(struct cfs_rq *cfs_rq, struct sched_entity *se) >> +{ >> + struct sched_statistics *stats; >> + >> + stats = __schedstats_from_se(se); >> + if (group_cfs_rq(se)->nr_iowait) >> + __schedstat_set(stats->block_start, rq_clock(rq_of(cfs_rq))); >> + else >> + __schedstat_set(stats->sleep_start, rq_clock(rq_of(cfs_rq))); >> +} > [Severity: Medium] > Is the classification here hierarchical? group_cfs_rq(se)->nr_iowait is > the counter of that group's own cfs_rq only. > > dequeue_entity() increments nr_iowait only on the task's immediate cfs_rq: > > if ((flags & DEQUEUE_SLEEP) && entity_is_task(se)) { > struct task_struct *tsk = task_of(se); > > if (tsk->in_iowait) > cfs_rq->nr_iowait++; > > Consider a task with in_iowait set that sleeps in a sub-cgroup S of a > container CT: > > dequeue_entity(task) > S->cfs_rq->nr_iowait++ > dequeue_entity(S group entity, DEQUEUE_SLEEP) > update_stats_group_sleep_start() > S->nr_iowait != 0, so block_start is set > dequeue_entity(CT group entity, DEQUEUE_SLEEP) > update_stats_group_sleep_start() > CT->nr_iowait == 0, so sleep_start is set > > cpu_cgroup_update_stat() then reads iowait_sum and sum_sleep_runtime from > the CT group entity, so the time appears as idle and not as iowait. > > The follow-up patch "sched: switch a sleeping task group entity between > idle and iowait" (5de73903cb61) adds nr_iowait_update_group(), called from > nr_iowait_inc_fair() and nr_iowait_dec_fair(). It re-evaluates only > p->se.parent, the immediate parent group entity, and the increments and > decrements still stay on the task's direct cfs_rq. > > So even with the whole series applied, it looks like the CT entity stays > misclassified when the iowait sleepers are in nested cgroups, and the > stated goal is met only for a flat hierarchy. The same non-hierarchical > counter is read per task_group in cpuacct.c (tg_nr_iowait). > > Should the iowait state be propagated to, or evaluated across, all > ancestor group entities? Yes, it is not hierarchical and I have already written about it in the cover letter. cfs_rq:nr_iowait counts only the tasks sleeping on that cfs_rq, so with nested cpu cgroups inside the CT the CT group entity is accounted as idle instead of iowait. Its the same with vz7. This series restores that behavior, it doesn't change the previous model. If we want to make it hierarchical I would rather do it in a separate ticket if there is a real need for it. -- Best regards, Vasileios Almpanis Software Developer, Virtuozzo. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel