From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8DF5B8017D for ; Wed, 28 Oct 2026 12:58:22 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SCv4gk020178; Wed, 28 Oct 2026 15:57:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SCv4gk020178 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="oM2V6XEU" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SCv1Cg020174 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 28 Oct 2026 15:57:02 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SCv1Cg020174 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-679f2615dd0so1427242d50.1 for ; Wed, 28 Oct 2026 05:57:02 -0700 (PDT) X-Gm-Message-State: AFq9FYKDRh7uX2C3jL3VwlPv6Z3hgD8Yhn4NLxJ9NbnY0bsPCO/iSxx0 yieVqVyTIjDKnPHCMQaGolkPBhVHBanlYjv73ydplxOZK9p9fuN5IbVYena1chNqU3AYG9OYdn9 tJdJliPlRZ/fHkF5j0K3sosfRT2lt8M4tRm+Jn5sTThXJjfMU18ScGQ== X-Gm-Gg: AYBFou2oscn+/dGnlgZMJ6hrmRYGs+JJIhfc/7lXVj4zVS8RWrexst7YaHZsLtW8sIt ljI6IuwLtonbMKKMhomdA1+5XODyeqBf7h/QCU2SN+zqWEyHzXWGi7u6//qshoRwO1OJtIQHDrF Hluj6uNjIlJaZVX1XVpQBIOapKquyYoQp/R7cYa3112+1GTvW3B465GUQh4QWTusbDUoQuGGfDV 0ow0ZPbBZfdIimGOJmQDFSw6UoSS6cfwkFbCdbGE9UHZEq+JItyf0b9VeS/slKASI9cqv8DKTkI JNf9XG/8bQze44jcU9rRCENXFrHhF5Inc12iT7SjB66RPRIAksMnyLbCzOkyrO9/eWYZRTadMBF 3bO+/WIyIQpU6OovYnefDS4dYu26/Xs6u4LEiknp8lPRutytIsxckVKSOcK7L4gj4nNhc6y8ZjT 9CMgrg8V0T3u2l1VPCfy/26jtP7+a94GCbri2j X-Received: by 2002:a05:690e:1406:b0:679:bcd4:a9a6 with SMTP id 956f58d0204a3-67a7bf2c65fmr2246100d50.109.1793192221236; Wed, 28 Oct 2026 05:57:01 -0700 (PDT) X-Received: by 2002:a05:690e:1406:b0:679:bcd4:a9a6 with SMTP id 956f58d0204a3-67a7bf2c65fmr2246085d50.109.1793192220594; Wed, 28 Oct 2026 05:57:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793192220; cv=pass; d=google.com; s=arc-20260327; b=VBqxi7Nu0pSW07sZ3z+dvLhpzk/+wSWyPyXT/xn9e059pnJwgwkCpFyxUdtYdisWtB qvYg2P/RTrIIzdmmYrNtUJwM39R3S52F3pAzgZPpSjQdxPE9ZViX/ndTKcPgMHiu4UfT qrqT0lmSHKaL59dvuc2DQ9DIdj2iAjv0VPA0j0GIcLTPLVYmESFztm8IfbAb4iRkvusC wqAt7UAuwPbHq1KNel6WS/UseI54EbpsGjdJT8h8JkO3c65k+TH96KmDfka2rWs/SiCo UJDHOZkZX+0jg5Bf7oxiZ/Hsex1cV2mghIEGDPL7ijzgThFc9mA5701RCJLZe4tZDESz 14FQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=GoSJjJmSOeIO7HehfLLH38U3h1KMQOSn2eo0GVsY0hM=; fh=cZ72tgMlH9Mo/yU1ydTnVX7gSx4khQcwDMluwhixV90=; b=lbbYhFJzje+ql8X/KBdUoYp41c4Xp86ttOI1j1Py4q/QB+Get17GjMJDZ2DLutQFXB 29wCZqWzBlIevUuU2ioiwacd5N2d4IXW2BWFed+5Nb0UcOldyXSj7SpDB3eE4vsl4Qov nZiiHt+NaJwqjuPxrHZhvNzrYnnE4rAQRbTGQCnwuYNsw4gVRZQ4BGV9q84B8hmOQegn 8xiPQpEFgmTxm4hZK9YKsbU63kL3BXus8ONlXWQbYiqukC5rKq399wDX7TVAN5SYlj6B CNoGQqH4C6S+7XCBXgNLdk2vKc9Z3czTtx7rVHvooYgUKeLzfZQ+JudEuuJj3BH12ZFh YjAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=oM2V6XEU; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c200::1]) by mx.google.com with ESMTPS id 956f58d0204a3-67a7a184881si2368857d50.286.2026.10.28.05.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 05:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) client-ip=2a01:111:f403:c200::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=oM2V6XEU; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::1 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F81SLkbmEf1tNqyx8caIpIABJnJc6O2SZQlya5++hgjbvWPPjEeJ9J52BVBk+wTt6gXZaOBflKjSMRGqdx+SIfiEuUnbVryRTuA1VxytN8shQTOpNtzQkwzDwhB6qilf/747tiMPHihEEDHJnl659GWjaeYHIJ8el4FqQ5R6NqVJeLFxaSErnNXVtgRlbk9PheizRCs4hZFBmB2jyvqfZ8RNvCnZ6vVPXIa19ZXXEhnAu8GLkR77aXh0eseG8inMqBK5mjFjLNZjcLwV8e8RC2uFBWu0cG0Xe/iq/tBVIfoD1jaNR/IhMg+QK+By7nE0Nz9twhOozQYR8voQnAg/tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GoSJjJmSOeIO7HehfLLH38U3h1KMQOSn2eo0GVsY0hM=; b=ThM7hAsSdtmxXJ3qaxJmhGYghdQBe45hjBUGmRnJ5tVew7zALgfW6uxJdvausiPFggc0ZzrRy0bnt/1HJ6jcN5hKZblA8HAFgLGkqHx0W++088nMbJuGV6G7cmWW7Jn9BLodNskcJ2TnuVIzzslLS5m6g0tMzH9Y+EMwxYYT3nmTOR/OlUEcX08SPosDTR5EMv08xvIFeuDrCkdVlIPuALOhLqgROYe0PkqXIf4oVEkblzAIo1aG529sytKwIxyatLIrjIqCP+rLC5sr12MdlguHIqtZ5ojfSrXtzT/E0O7LmNgljMnSVqkzKT/7na2IhZhohdJxew2KJVdntjZ9yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GoSJjJmSOeIO7HehfLLH38U3h1KMQOSn2eo0GVsY0hM=; b=oM2V6XEUjmz/2XsOfDymRAK+wws6zbaX7ZxQYhhobhmjEEC5Y7qM/OkZ+22A/Bg11KUobDGWpXjFiLgAwdRijM0YsoQuuOT/R88r2/i+6EuxRAYF/KP+4NKgReEXZsKBTn8I5GAZ8uDDljsPLANJwC9Ydj7xTUV9YVSv/5ZiAwNK/gnomCJdK5wE4+LpmJiC4HxYJ0MyOt4hMf5nMDLuzLzjSb/AK2BaFFJWdhsXrUrmadHZctue1JyXudlgqQX7Tbp2cB9YcNjorS/U/e+R/ZptQVxY37EfQuvcMeYISTx0d7DthpMK2VX/5rlyiSLqEpYFEP6q6Ilxzkom364vhQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by VE1PR08MB5629.eurprd08.prod.outlook.com (2603:10a6:800:1a6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Wed, 28 Oct 2026 12:56:54 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%3]) with mapi id 15.21.0569.007; Wed, 28 Oct 2026 12:56:51 +0000 Message-ID: <576277d7-2cf1-4324-896d-129ebb490f59@virtuozzo.com> Date: Wed, 28 Oct 2026 13:56:50 +0100 User-Agent: Mozilla Thunderbird To: "Denis V. Lunev" References: <20261027174922.2254893-1-den@openvz.org> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <20261027174922.2254893-1-den@openvz.org> X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|VE1PR08MB5629:EE_ X-MS-Office365-Filtering-Correlation-Id: b6f09d87-ce2b-4728-4558-08df34f2ef64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|366016|1800799024|261026140227099003|56012099006|261021123027099003|261021121427099003|261022075727099003|261022115727099003|261009223027099003|261022105027099003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: OZckmLKqfNm46QFojmvlQApaT9vPTJ7wkpn6s2ClBzjVNnzeqHHV5wmqflOrKutOCNL1CLQ8Fei/Z0oZbh1IG+FajpnY1zo2Cyz+ZhdKZMfQU24axhXvuDuyKnEACqiDuD2Ja6HYyza+9+dobt7pcG90Ao9kPZX+KzymqTV4Q+SySE02XfsEDgtYB91p0xwgbwvFiSVu660MUf5EPAf2xCZeR+EOAcoT5lxqJRAGkxDUbY51Ekh8uviQ7q877Ml4VYrep1Gs07OkmrjVj/iFjcLgqWBvvEFL3rV7bnBPn7OBAIH18XnYhKb2kziSn4kCdj+VQfQ6eObVGlAeORxZrjEOq8Tm2qAj24V+8hchLEkgXQb+Oaej2fC9H8+RRoAjqMpS7VaWLG94spDGsmAArAxfyQ1Vq4720a+8PkPaKz3gYqNyCSplfTKk7nj2B9x1BTTauuudlCsrN/1IY7o24DZBHCmXQuf3TcKvpykmJHN95Cgs8uJ1ZR3/DFDFzN7zkTBR4U4YX0qU3JETzH+km+htp9LIWVup12dez215o/4AaHYuhGw6i5ed1WSY9bAAuW9Pi45Y2Z5Wg1Xol6NdkEyf4J/+0jL+i29Y3zdQ8vWSK2s+29EkECuQhU+K3tfLZ1srhgd8Lc6rt20hffbF8nIOTIfzLNkm2VOdgtJM00Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(366016)(1800799024)(261026140227099003)(56012099006)(261021123027099003)(261021121427099003)(261022075727099003)(261022115727099003)(261009223027099003)(261022105027099003)(10067099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXlBMmF6ZEFWMjN2ckhpRm43dC9MWjV0NkFmZitjcDQ1YUJxZlprRVJlRFJu?= =?utf-8?B?RTNyQTYvdXBFakJGQ0gvMWpJL2UyMVkwRWUyRktsOURleWxQSWFpSmtTN1lt?= =?utf-8?B?RDF5dW4vemZRUlNwSEpHcmxBMXY3Q3hXRi9zL0h2cHVod2ZRVmdZQU8zRnJK?= =?utf-8?B?em5ZeWlSS3pqZWJXOFlKTU1vVy94U0RyVFlIb2l5UkoyKzkzMVFOdXdQeGll?= =?utf-8?B?SFNEOVMvQTREMUo1emxJZ3czOHN3cmZoRGdHdWxqc1dORGxVeDZhRDJiUGo2?= =?utf-8?B?VXlGM2syMVZkZTZiblY2TXlubSs2bmN4M1ZMZS8zYUVhWnRwOGZNU3k1ek5S?= =?utf-8?B?NStXMElNSzdPbEdXRGhNdk1XY2NGN0N3ZmhnVVpWMEZJL3A3REVBdmtLVzZ4?= =?utf-8?B?SmduU1lRaktpb0g3Rklscm9MRm83aGFHSWFldG5jQk13am9ZcmVHeWNLWWJO?= =?utf-8?B?QXUwVDdEdzM5UUx2UWxKYkZkT21IdFZFL2pWdkcyN2g3bGxUNnlkeWpzQnRL?= =?utf-8?B?TGo2WFZNVUNBN2s5NHptL29zRG5vQ0NjUGpCV09xTjFneWp1UldjcjFtMElL?= =?utf-8?B?bVF2UDYvYXRlS0RndVlEdUVCaEY4a0tHZXFsa1ZUVXFmaGJ0a0pjRXEyY2pz?= =?utf-8?B?OWF0aVdDZXNWcEhSYmxmT3BNYklld1lmUndycjBjU0NXVHRpcUpYZmhoSXRE?= =?utf-8?B?QWFNM3VoR2V6bGZkUjJHUjJQYS9lUTlldHlBSDh5TXR5dWc3cUpGREQ2VW40?= =?utf-8?B?djFwdjMzTXNTbVRaTjBUZXBCQ21LU3czSURSMWN3TzhOdEdXelpub0I1WjlQ?= =?utf-8?B?bHRoR0w3RnNuYVJ0WGJYVEh5U1h6dElYYUpRVnEvOTNaRkRPd0MwS2dFSk80?= =?utf-8?B?dTBiRDdQaHFlU1paaEZNc1daSER2ZGJqdUZzSjhHcldLSE1jc0ZSb3NVSW13?= =?utf-8?B?bjU1eUsySTBSaldZSlpLOWZLajlrZVpwRE5PSlVkd1lzT2hQcFp2UjhrbGhQ?= =?utf-8?B?Z2hETzdseUt6V1o4VndLTmltUVN1N25Ub003QXUvUHY2cHg2cG5La3E4SmNX?= =?utf-8?B?bG5oaWtUbG1kbTM2SFZ5VCt4ZTZPS0Qya0NGcFlsZlNTNGRDL0tFZHNiUUdF?= =?utf-8?B?V01UcWFZa0owNHc3RFB0NGR2UklyaDNSSVk4blNXNzJMdXo2S2daUW43Rkc3?= =?utf-8?B?WkZhOEtTUTBkYThwOElkZTF4WksxV3VEVWh6L2NtMnY5Y3kwcDMwcGR3ZXNS?= =?utf-8?B?SXZ2VDFOQ1hyVHBzdVo4a1BCYk9OcWluWVp0VzlFN3NVbEhwOXlUN1Nrdm5Z?= =?utf-8?B?WnlUQjBDUUVldm9SV2o0WWtINXdzV1ZPYTRDVEppblJCbTY1UDVpZXVyWTl4?= =?utf-8?B?eElhTkpqeDh2M2tSdlFNclJlVDhmaU0zVjFVdDlveWRVTWdSQjZpSzNXSlQ2?= =?utf-8?B?MTdTdWNWNjJuUlVSajdVV3Fzbnhkam1LaU1QdUpLRnBPcGpvK0JDNEFLUDVE?= =?utf-8?B?TkVhc3QrTHgxMDFPZi9VR2VpWituNnBLTDJsSnFySjd0aUhXU1dQajZYMnRy?= =?utf-8?B?d21WcEJYUkQrWE45R0RPcEdGOUVIQS9HUTBUR3ZPdmh6QkFPdTdJSFZCV3FV?= =?utf-8?B?c1kySGFpY2NHVVJsdWRzcEdmSGNBM2JpNWk3YjFIYkM5dzM5WmdZL2lPN2Ur?= =?utf-8?B?TzlReEdiKys3U2JWc0wwc3ZuMVRyVG8rVjI3K3phOHN4cTh1YWcrR1gxMEh2?= =?utf-8?B?cHpnRlNVWXpteC8rMjF4TWUvSjJBM3RaQ2ZFbzRMQlJiNFRBbzFqSWk1VTZs?= =?utf-8?B?anR6emxtK0JIbERabVVzUDRkTzJMeVZPdVlXNndlb0dVeTEvUTliTVpocUFL?= =?utf-8?B?TGw1azR5RVA0NmlXWUs3Rm1heU5rZjRlN2trWER1SDJYTHN0WVdkWlhIQzI3?= =?utf-8?B?aWVNQ2VDZ05sbzFPT056S2wrTGdpQ01keTdDWjdRKzd6SFVYYk9oanpOdjhK?= =?utf-8?B?RmRZRWpMTTV5SUIrclFYYU95SUJUVnZuclFrSWRNMGV0U1djNEI5TzdHREtF?= =?utf-8?B?QUlGd2xaSWFuQXpTWG9peVhZVjBoRmlWeWhQd2FxOHFDNktBbGRMT3o3WUNu?= =?utf-8?B?dCtLY1NoMlF2eDA4elMvdjQwS3JRY3NnZWZJQ1ozaTl5dDZPbmJ6NEcyRHNE?= =?utf-8?B?OE5wQnZHSjBjNDM4bVNIMnBmRCtyZStHdmRQc21VTnNrMXg1cjFQcHAyb3hw?= =?utf-8?B?M1BaU3RNNjVzRlpUT2J1dHlibzJpaDI2TnJBM1U4SDZyUU5nWlVDam0vY2Vy?= =?utf-8?B?ZkROc2tCdXdPbnJMY0I2TDlsU2piaDlwYWtiY21JT2V6U3FZWXlWbFppVDBG?= =?utf-8?Q?ez5aJraPFj8cNx6o=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6f09d87-ce2b-4728-4558-08df34f2ef64 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2026 12:56:51.4275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /qwx6eCeIeJeKt9Nyx91EymuCOqPgi/w71sW4hd0KvPqWiWXWxifzGK1lt6DyzhpzOHaM1o0kd33bZAqKV4GY2ywIIkaYrQ+hhryYGq9Rjw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5629 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 0/2] dm-ploop, dm-qcow2: fix merge status shared by all devices X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Patches are great but BUG_ON chunks are completely useless. Let's not add junk. Remove them please. Other than that, Reviewed-by: Andrey Zhadchenko On 10/27/26 18:49, Denis V. Lunev wrote: > dm-ploop and dm-qcow2 collect the status of their merge service I/O in > a function-local static, so every device on the host shares one copy. > > In dm-ploop it is never reset: after a single failed fake merge pio, > every later online merge on any ploop device stops after its first pio > and returns that old error until the module is reloaded, which on a > working node means a reboot. > > dm-qcow2 resets it when each run starts, which makes it worse: a merge > or L1 COW break starting on one device wipes the error another device > has just recorded. That merge then reports success although a write > failed, userspace completes it and drops the top image, and the data > that never reached the lower image is gone. > > The status goes on the stack. The pios/qios carry a pointer to it, so > both loops must not return while one is outstanding: every exit > already waits for the counter to drain, and a BUG_ON after the wait > stops the kernel rather than let a late pio/qio write into a dead > stack frame if that ever changes. > > Tested on dev-cl04, 6.12.0-211.52.1.22.9.vz10 with the modules built > out of tree, using test-only module knobs to fail one service pio/qio: > - dm-ploop: after one injected failure, a merge on another device and a > second merge on the same device both failed with EIO; with the fix > both succeed; > - dm-qcow2: a backward merge with an injected qio error, held for 5 s > while a merge on a second device started, returned success; with the > fix it fails with "Can't break L1 COW"; > - the ploop pytest suite, ploop and qcow2 formats, passes. > > Denis V. Lunev (2): > dm-ploop: fix a failed merge failing every later merge on the host > dm-qcow2: fix a merge reporting success after a failed write > > drivers/md/dm-ploop-cmd.c | 4 +++- > drivers/md/dm-qcow2-cmd.c | 6 +++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > > base-commit: 02401c5e378f282fbf11bdc65996253ff65dad9b _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel