From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id F3E3B8017D for ; Mon, 16 Nov 2026 20:06:41 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGK5V97031311; Mon, 16 Nov 2026 23:05:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGK5V97031311 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Y8DUf9Sr" Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGK5THr031307 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 23:05:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGK5THr031307 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-67bec5d62ebso8189199d50.1 for ; Mon, 16 Nov 2026 12:05:30 -0800 (PST) X-Gm-Message-State: APuU4Z+M3XIDCKcPU7C0Z6be2XJ3BzIWDoktztywz1OPm5J4GWUnWORn Qk1VccRKn89jInGqKRIjwhwJ7na3io3VFFO2+km47OYKl/KZMWeKsKXtWAOpl6PktTAhfD+KMnT TANxAN+aH0w+H3hLBplElzy9OwWIpM7HIGhuvsAeFCOthv9+FmZfolg== X-Gm-Gg: AZFdTZcjGf2EZcun8vrapIGIsjigIt8IxeGQVIXGc6kF38GEdHLkJQzX0mNmOSnmVLx sLKM44pB8587waFydYHfxuW0d+SKG+44iu9g6m43L5qIVH/y8MmJWAh9Jdm311RG5RmYzg65l2C GSfcaynzhp2ZoeYuhY1lobbrvlf9Hx1mVbzDdSm6E68vTlcfgLCu5vAsIR6Naq+jA7Ex9WjGth3 HQAOABSm1sC8GflcgQBAsV7eutY33MPLNyv1hxy5UiWZYK5pfK78N5NOpbcmHwJlUIxwwEQ42sP GSp5Z6p/pna6skhIdI4AzXLMgJqPniqak6gKWsoCVxj7MF//mqbRWzFBbOhXJOzofx7ih0aaOML EQUfChXxWV0Ev3EQ4TtvVMW1LHbEXBsaB/Z0vEYDlBn/n4cmQFSZPjWTMK2BWkoKYSJGlU3ocNg nnpziSBYqpcb4bPHkRED2SBPwlivFZ+VgV X-Received: by 2002:a05:690e:191d:b0:67c:332f:3fd8 with SMTP id 956f58d0204a3-67d893729bamr6904852d50.5.1794859529310; Mon, 16 Nov 2026 12:05:29 -0800 (PST) X-Received: by 2002:a05:690e:191d:b0:67c:332f:3fd8 with SMTP id 956f58d0204a3-67d893729bamr6904837d50.5.1794859528814; Mon, 16 Nov 2026 12:05:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794859528; cv=pass; d=google.com; s=arc-20260327; b=LLuc4O1A2fOLHKvSlS25pcFF+0DSLgVzSKHQ0JxMRwfSYNeeuYoM8Buat/TK165F8m SHe0WJBcuGhuRnmU2Jjo7CwawcN0k0ddRS5MS8odgki73QX1SLKZ5cEtrvlHf42D+C2k gdIcmUxKBxikE2cFtT9HXt82hqUNbFVIV6eNHyKAd2Vi6Kju90rbwFymVoMxNQqpohTE qmf4rF9f4M2rgBQAW5yrpbpEpSmRQeVzDW6OTZ+YkMHzMSVl6aFChXz7er8u/JD8O/UM RYFFkg8pzGmFSvfKeuflAOgFtnqxdKJJrDIEhVg4WOyJG5PJZ2OMO+PpJAA64XV0lHVE wSEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=y19nlAKMJzc1mZra9PtIkGVZGjkStusJq7EbPwrGkFs=; fh=MPbb/fYAXD7RpgTj7uvhvDOA4h8fFgXedFicSITGHIE=; b=ThnZQS7bxziVbncQ43kh/P3AxHeD3NA50a5ilf7kmOQtJcjvlunivnPhyj4YPnsdy0 LdxiQB7DgS5+MVkoRl8oSUhyIgWCQRR8uBET8fkotOcUMpa6TRcISbqUaSXJ+bWxYjsK RKpdzC/C+GD1Ji1W8fypMxsoQvWnIc5Ex/+/dVuVMfMi2aSDOAzfkdEfitz2jlMgS3z+ akj4AILlc2FVIBfmlrmF377Mt3Ko0i0e1gcslD1cujVqtRdYyrA7d2JN/05p8xlGzCQ5 MZ1Pbwt+EKCtOmna/2AOLyVbqPPnW7J0SERaP0MHh9G/VmvzNqXFfA1eeYTq7uhxhtUF jZkg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Y8DUf9Sr; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id 956f58d0204a3-67da6f6ad7bsi4071860d50.36.2026.11.16.12.05.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 12:05:28 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Y8DUf9Sr; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UpzWXV7v45fYhyLNa/Zp5K1ztxFDVvTYiJt3UExi3EQ7ZxITPZcxdfFmrAdjIlbNftb759qaCPBjQuYdKST4V90hogZyY80NYBEXZSLyFI63FNtbytW+f5+fDJ/xqZGarNJnTOCV1aWbiZVea1oa85grwCAA4y2f9AStScEma1Gmpp1XDMUS53vSmKxb2HmN91XKFb4s0zTAzP43xbZY6eWp5zgHRZW1HufGB1BK6K2HBlNJ5f9xAi9WdnmvVn9EOv5MVxrtubYQ0Hysl6WFP56+6DOw4kvyif1275yRKCpwONN2EEvdhiUc4r1rUwShYjc4b35DM3HOxiKh9xl1lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y19nlAKMJzc1mZra9PtIkGVZGjkStusJq7EbPwrGkFs=; b=l3nLKa5i/wHTGwEgky3qZLICIZtgHCWCGYuqrujnQ8h5kRVsMmGgkBjj7wcPbdp9EH5rytIf3PFlcAxLdCnb5IUhiR0pDW50IgLJCsFrEuMO+x73uJPW40w45Qwpqh0GK+nLsGkqk4Stb7+2Fwy/JRQhBixvHam2sC2yUZzQ4SeO4oRzJ1hN9SC1RPNwi1eKjrHaS4fI6vqH5LJOjsyuJedpuO2y2jAKad+xG4hu658je1L99mD1SFFija2EEqKOkvBN9i08HWDYKBi5f3u844X356h+17+FGVskrJ3Fh7VofpULKEvvX6S/npGxgS6KF44KWxcGsRrFnpKBPxYdvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y19nlAKMJzc1mZra9PtIkGVZGjkStusJq7EbPwrGkFs=; b=Y8DUf9Sr2S1BDnL7p2Z41JEmNcInxGq4+r70otHky9yrKvTGEb0r3peeqwQa/NOgjywdohx3s/cooW1RlljGx3MInGeP4neDWovkVWnCJbXSIgb+3BIP/7++Wuri0ajdjANgc9HTOslBvKwKUqx5oBVNzfcIzr1oPBW49ve4EvlDMXwsIZ6kVZvVqcGA+0S8Lnu44kTv2EhXZ3LCh5Au9vhnuQnt0a32ucCCDINlDLFPohKycS7Npfyo0fsKdW6w0y75VGZuHAlb7CaAHCFNRkezJWId3tEnUJ1DAaIS0PD9tp9J4CKaY+5WDHK+WqftYQoOLlnHC5Wtz/4vRhjltA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by MI3PR08MB11878.eurprd08.prod.outlook.com (2603:10a6:290:77::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.13; Mon, 16 Nov 2026 20:05:27 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0615.013; Mon, 16 Nov 2026 20:05:27 +0000 Message-ID: <5a08a51d-4262-45a0-87a8-c97a2d5df9a1@virtuozzo.com> Date: Mon, 16 Nov 2026 21:05:25 +0100 User-Agent: Mozilla Thunderbird To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko References: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> <20261116-ovl-use-orig-ve-v8-2-dfe427bfd902@virtuozzo.com> <010701a1e5d43771-f7036827-225f-46e6-9cc1-7988f5626888-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1e5d43771-f7036827-225f-46e6-9cc1-7988f5626888-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::10) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|MI3PR08MB11878:EE_ X-MS-Office365-Filtering-Correlation-Id: 2809f835-89f6-49a4-5858-08df441cf4f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|376014|1800799024|10067099003|260925021311599003|56012099006|260925022911599003|5023799004|4143699003|260925021911599003|261026121527099003|261026140227099003|261028144727099003|261022115727099003|261022075727099003|261022105027099003|261021121427099003|261022113327099003|261102123227099003|261102130727099003|261009223027099003|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: 68X0CNAMED3T1ZOoHiLyYjuM45yXbij9/zk1YDHIDo5JQoOUQRL81zuYf0tswx773PbF4keKZIKBBVQ0XUuLPvBw8TyR4velCirzF8ik0WEG20l6Q8JByQIyf0Hv8ufLxXy/uZiatLynz/U1mSCyR1LwfioKQ1BMXUw6sHx/jiBINeBewgZM36LJl5xjXZ6OKqufChRRzipsmVw7izFpUHW8oUDDeQ6lDQ4eLLWPkyU7Njy4o80aOuU9Z1n7t4S/XOgBlsJBemENdDJp+/T3RXCP66VhDcp5b9wweBYau6T7UQA/j8sTBnQf5sp/TSTnLrNi8b+8k8B2wzxLDuapIkFFMz7ZSt3WXeKNSB4n0oF2LrOz8lkxXcA9LgCwTuEyNIlDrUVTRDhhun/b+1F/olo40P0kiEbNOn8Sbf0ApNDT4ZbNY93M56FmnXfdAOQuozweiHjwheKaYBb/d4AS9zU5cdJRUPpCHsIMEftLYYNKL7/SH6/Rmx6ezL88o8ZmC/LE7JAzdBp+blgVV7v4meuzu2gTP3Zvyt5AfG1uAZJqkuNhO+gHwdbQSHEjnU7MIVmT0W6peHiEEMIOXDourSz7QGd1OueAwvAuuOrPdSkMAKC8SY1usWO5iyulUcxP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(10067099003)(260925021311599003)(56012099006)(260925022911599003)(5023799004)(4143699003)(260925021911599003)(261026121527099003)(261026140227099003)(261028144727099003)(261022115727099003)(261022075727099003)(261022105027099003)(261021121427099003)(261022113327099003)(261102123227099003)(261102130727099003)(261009223027099003)(18002099003)(22082099003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEhUakdYMzVzamV5WHY2d2svQk5aWUtxVUNLM0F4UzFRK000cmdTaXIzUG92?= =?utf-8?B?T1FrYUl4N0RUbEFESzc1U1ZiWUlyckhvcHNzYlQ2UmlRWGUvYllFZVo2TndL?= =?utf-8?B?YWpVUHRpQjhQRWpFa0pNTUd2ZTcrc1UzYWQzQWhwdndpV0hUOHVDdUJDRnM0?= =?utf-8?B?OTdoUGhrMk56b0l1aWx0ZzU1d3BVcjVPKzYyL1dLWmJwY0c5TUtKa2lldXlF?= =?utf-8?B?cUZVL2w0RFQ2d2tUci9xa3FmM0Q5NXFFUlI4QjROYmxiSkh0K0VQMnhGc0Z5?= =?utf-8?B?NER5Wk4wc2ZjNXdSN1RVdngrSVVVV09FTjhjeFQzT0R4ZjB5Y0lsV1k2Nzh6?= =?utf-8?B?NXh2Sk95SGNHTjJ4OG54YWlqcmp3cWtsMHdKVXdaZDFtU1BZekwrVTd6bWdE?= =?utf-8?B?QnZOOHJiaTI4N3lIamJMaXFBdmlkcHhIbFRSbExYY1VId0VGNmxORWFVZnp1?= =?utf-8?B?dUdsNWZKSTVMaG8xeU41WHg1VGJQOWZqazJSM0lMYlJQTkY5d1ZlUTNoSUxS?= =?utf-8?B?aE01eHNhTlgzemZjNk1rbTV0ZjFWZ3VVTkFlMzA1c2puSUQ0NzlxS1FZdnh5?= =?utf-8?B?OE53bXh0RUg4MnhQTzYwWHUzSEU2Z0dhbDI5U2NuUCtlVCt6REFCWVNpU1dI?= =?utf-8?B?bFdSSDdReHZwRTdzenk5MVk3YUJjNFExcmphSFExR1pUeW05TEx1SVIvK0Rq?= =?utf-8?B?MURaK2ZibkdiWG82cFlINzBEcmxzeC9sUU4zQjluZ1Z2UWJlNCtNeGwwb0w3?= =?utf-8?B?d2M5OVdxU0J6eWlZSlZTVk1udVU4R0s3Z0FtUERhci9oQ0Z4aDFUYk5sN2NV?= =?utf-8?B?SS9ZTXU5R29CWko3YW9ZOHNKWEkzdGRQMmF2SVVvdkpHaHdyWXJ2VUIycDNh?= =?utf-8?B?dzhMcnEzUXBNK2JYWlFoOHhQaVF0SXNuendtdmFCT2tQMjNEakEvQUlhWkkw?= =?utf-8?B?YWJudFROeGYrWUpXUmNxV3RMOWkvSkFIeHRsdjFHVFovNnlvNTJBbWo5Y2VL?= =?utf-8?B?aktXMW51bEhZQ3hBdzJiZ0JuaDU5YkYvSnEvVDYrTnJwRVJJMkdCRDZ6Sm1Y?= =?utf-8?B?Wkhhb1daL1BtemlHMTZmaVFXYXBUV1M4VS9xalF0SWJNYmpVVVVnUVYvb25J?= =?utf-8?B?NUtpd2loanFJYjh3bE5VMW4ycnVSZmhDeDYra0ZndHJtU1I4N21iZGhYSHJU?= =?utf-8?B?eEN5aVg1d0dWVGlBS1B6TXV1dU9nS3d4QWNhYkJrZDZpTEhyeEpwa0tMa29I?= =?utf-8?B?L2ZIVlpsSWVGY2UzM3JXT2krVHIyMEpFcDJVZWV3ekdjWVNFZXNNZjJxMkFE?= =?utf-8?B?MHE1eEpMWmU2K0JDNjNWR28yS3hNZWJJSlkvOEMweUtNOTFtMzY0Z1hsQ0Z6?= =?utf-8?B?VTIybDlrWlhSOW5iRW5LMkZ6QWRsbW5pRGZLNG9kaDU5SU9sWVFNWW80UGlh?= =?utf-8?B?N0syL3VKbXcvc0ViekROYXRMVWdqUXpBQ3prRE5kNDFic2VQWmNZNWRxSzVN?= =?utf-8?B?cjFnbkdrL1B6eEpKUnJqdHk2alpCaUUvdkxQZUFJdXNhTURIRWp4eEhDVzM5?= =?utf-8?B?TG50KytjMXZPamJXUEI4cXJ4a25PSS9US0VQTVpqVmhYUkV2ZUJGL0xucFRH?= =?utf-8?B?dDlEeVoyVWhXYVBEcFQ3MHFQenhNMG96NitJY2dycWFIRkNKRzVGS1N3S0p6?= =?utf-8?B?aGFjSmlPVU0zV1BZdHduRFZrcHQra042NnNLd2hjdThHT3JVUWFpa3JVTzNS?= =?utf-8?B?MUVEQnYxeTNvV1NLdE5rV1FlY1JES3RSVEFNZkw4V3YyZXRvdVl1REVsRHE5?= =?utf-8?B?UDZxSDdCOUM3M2tzeklhdjlhVVRnK3I1UVBQYXpaWGpjdkxIK3hORkcrTEVW?= =?utf-8?B?SFJyQTJYL1ovNmhtL3lEN3JHZlNmc2xvSForSi9WMXNVcHUyRnVZeU5mbjdm?= =?utf-8?B?V0lMLzRjU25wcjlzSExoQjNYOCtwR3lpUW5raDFXTm5Qam42QjNRckJ1WTU3?= =?utf-8?B?TFVYSlJtN0g1bUhVT0JVUFlDZiszZ2Vjd3R3aEdqMTdVOURWbkFnKzE4dFJ5?= =?utf-8?B?WXVzaU5hYzhrc0RoTElUZ2UydGNEWWJiQzVQM2YzOFlXcmhWRnFNM2lVTlNr?= =?utf-8?B?aFNsbmdHUUllWWhIUk5UYkY1NUxGalg4VGUxMElWQ0RwUUZvdEd3VUxsSjEw?= =?utf-8?B?VkJiOVJ6bk5JNGx5bnZwdW5VZDY1L1ROVC96OVRDTVN4WFpIRUdiRjk4UEVx?= =?utf-8?B?UnBRMXZNSWs3VXkwU3hibTQzTjlPNW5WM2lCVlgvRklJMEkyR0czNUlSK2p2?= =?utf-8?B?a0xobWZwWTFQeDFMOUdibzZsZ2Q5WkFuSHQyLzh5M0xGSjJQQ1NxNFQ0VXEw?= =?utf-8?Q?1BX38kvN/RLDrKrE=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2809f835-89f6-49a4-5858-08df441cf4f2 X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2026 20:05:26.9912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MrguCp+3uuQ4qZrHZlc8LuHBwXYfKIkkpGXt0jj7Exg2Nt7ybOx7mqmOYclSn6HAJzIyNFK0sUqsjegdb+421igUH50SDFNjIKyDxyTMIVI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI3PR08MB11878 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v8 2/6] ve: Introduce override_ve/revert_ve helpers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/16/26 20:27, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential > issues to consider: > - [Low] ve: feature_capable() ignores overrided_ve while ve_capable() > honours it Would be handled in a separate task. > - [Low] ve: commit message omits override_ve() switching rules and fork > warning They are clear from the code. Commit message shouldn't describe code, it should describe intentions. Code already speaks for itself. > -- > > commit 9e8643e97f9ec1b7bd7c8e72db3c7d5655736399 > Author: Vladimir Riabchun > > ve: Introduce override_ve/revert_ve helpers > > This adds override_ve() and revert_ve() helpers, which mirror override_creds() and revert_creds(). It also adds a task->overrided_ve field. ve_capable() and ve_capable_noaudit() use that field when it is set, and dup_task_struct() warns if it is set on fork. > >> diff --git a/include/linux/ve.h b/include/linux/ve.h >> index 717567775f58..5c9260799db5 100644 >> --- a/include/linux/ve.h >> +++ b/include/linux/ve.h >> @@ -295,6 +295,29 @@ static inline struct vdso_image *ve_get_vdso_64(struct ve_struct *ve) >> return ve->vdso_64; >> } >> >> +static inline struct ve_struct *override_ve(struct ve_struct *new_ve) >> +{ >> + struct ve_struct *old_ve = current->overrided_ve; >> + >> + /* CT tasks are not supposed to switch VE context, this is a breach */ >> + if (new_ve != get_exec_env() && !ve_is_super(get_exec_env())) { >> + pr_err_ratelimited("Invalid VE override: %s -> %s\n", >> + ve_name(get_exec_env()), ve_name(new_ve)); >> + return ERR_PTR(-EPERM); >> + } > > [Severity: Low] > As reported by Konstantin Khorenko on v5 [1], the commit message does not describe this switching policy. A CT task that asks for any VE other than its own gets ERR_PTR(-EPERM) and a ratelimited pr_err. Only a host (super-VE) task may switch to another VE. Could the message spell out these rules? > > It also does not say why the helpers are needed. The sentence about the fork check does not say that dup_task_struct() only warns when a task forks with an override active. > > [ ... ] > >> diff --git a/kernel/capability.c b/kernel/capability.c >> index 34716847c6b8..6de4dcba2283 100644 >> --- a/kernel/capability.c >> +++ b/kernel/capability.c >> @@ -389,10 +389,11 @@ EXPORT_SYMBOL(ns_capable); >> bool ve_capable(int cap) >> { >> struct cred *cred; >> + struct ve_struct *ve = current->overrided_ve ?: get_exec_env(); >> bool ret; > > [Severity: Low] > As reported by no-reply@sashiko.virtuozzo.com on v7 [2], should feature_capable() be updated as well? It still tests get_exec_env()->features, which is the task's real VE: > > kernel/capability.c:feature_capable() { > if (get_exec_env()->features & feature) > return ve_capable(cap); > else > return capable(cap); > } > > During an override_ve() section, the feature test uses the real VE and ve_capable() uses overrided_ve. If the real VE lacks the feature bit, the capable(cap) fallback runs and the override is silently ignored. > > This also makes the commit message's "ve_capable and friends" wording broader than what the patch covers. > > [1] https://lore.kernel.org/r/179448942112.4060562.12042466360723083159.b4-review@b4 > [2] https://lore.kernel.org/r/010701a1e564cf2a-d6ec1bc0-01f7-4f31-9a2e-03962f66dea4-000000@eu-central-1.amazonses.com > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel