From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1D85C8017D for ; Tue, 22 Sep 2026 14:52:35 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68MEpDTJ019382; Tue, 22 Sep 2026 17:51:14 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68MEpDTJ019382 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Pa9daqIo" Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68MEpBD9019378 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 22 Sep 2026 17:51:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68MEpBD9019378 Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-6711c640f79so1184534d50.1 for ; Tue, 22 Sep 2026 07:51:11 -0700 (PDT) X-Gm-Message-State: AFuF++lzohYsQGuZzqlloWscMUNZ4mDrvyBhm0mfJImfV5avp9TC9ZxM pfkGWZfCKV5875XMSNBt1fjGXCxYYfOk7j40kEwidfpWNhjo/+Cmtd1onZTVyWJToGdhETGithw F2bqWS4R7/Z01ILgjkAn8IWOu/P0uzwj8EZDONehHVeUw4t2tAjOB+A== X-Gm-Gg: AYBFou1BF9akJw3ZZB8QwUYRRj9Ky10khG15RcrCqI+dwOYEHYakfavPlHKxinQuaS7 YvG9EpE4d2jYyxUVfZY2To9QBjkrwocvSigYrE6r7fVEhw+DaIdTKqcy9kpATzxet9QxbPyjJJp 0X3khlnQmoQZK02MZP9y1a5iYsXHRGqxCFAubn2U8LWRxfZjxNHG+w//C/5QcNKRf1jesHs5qnQ rMrAjNT5kFAcRIbLEW6rGOtXCEwrLKuRUekfkJ0BXHCLNYszo1qKgSBrMQi1/n4KFNmpPc9/Nc/ aDegMwBW2OieQVhAmLwwjkKUt6Z+h9tuMTKt/qDG/5+epB5vpdzl2NtEwmMmtCacGY5yLkECO++ zPoZ8Xa1krCS15ycNuKXN+IwHAsnVYY1SsOWPAMaWT2rEvb0LL48y9w194C0ZvsNvyYuvUKlaNM gF42yymqV47jblWN/Sd1Sw X-Received: by 2002:a05:690e:1347:b0:672:aad4:403b with SMTP id 956f58d0204a3-672c271acebmr1305385d50.0.1790088670459; Tue, 22 Sep 2026 07:51:10 -0700 (PDT) X-Received: by 2002:a05:690e:1347:b0:672:aad4:403b with SMTP id 956f58d0204a3-672c271acebmr1305365d50.0.1790088669597; Tue, 22 Sep 2026 07:51:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1790088669; cv=pass; d=google.com; s=arc-20260327; b=T5rouF5GaOOW8LnT7y3oyngoO77GQoyWtPtdrC2q6C+vnUCBN4pTngdnUQdg7ZDGfo qeS9zjlbtY6yrnblr/CwZzIaiC/vrXLVmsisO0PKR66Vnt5fX1Py1Q5sVt/xkMqTGYeh 058aUCjuXWQ975GUpQFtXWbK3DERKCwsVCCZ+quDMbRARKJg63urqs+CswckfbDf6/B0 O6wzQelwg7javoeSzS4+uc+Lxm9xh83rbLXN774uwl4isWLTYyhnRAitXvgA3tz54TSJ GeluVz54t3cstgO2SL20RMGYWDY4bwQjI8fxdxwQq1Dpn44kqJKTeqEDp3364N27xLZV 7ZYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=5Dod5fONVplgOVdRcbK2NbCtP6Ya/Kx+65d8TNwN0Ak=; fh=nOJBEMwvTUlb86CvHPJZUpHi79iyIg3a0kFZ9jEyhnI=; b=WgASfpf+OwNmzLd432q45NesfHhojhJICyLpJYFwEgv8iq2oU9e6THibS5r9p3Pom2 D1q57rtsdUt+Woxd2DkMp2bkVUJRazI9hrK7MQhio6fGU2FhBISr46YsGbCXwCB0ezUX rTzVwbwEMZ64k6dO6ZShnET9DIFYz9dOW5peJb9jcRrmUKc3a+WvXC48uYlV8ZPc8JrR zQzuOEX7EtQzcL8d2dgFkbU37QZGSMUJTUJF3LqGDD+KkBdzoaLyDbFV9jr6IagoVF+C phDMFb9+VIgAi4G3/PljzKfdYEtJsBvQCupkg00gY6MEAcdNgduBvovwTmHrpQpleJXd RHTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Pa9daqIo; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20f::7]) by mx.google.com with ESMTPS id 956f58d0204a3-672c77900d7si822642d50.257.2026.09.22.07.51.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 07:51:09 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) client-ip=2a01:111:f403:c20f::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Pa9daqIo; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dUW8yix/qdxzVrZ7vrBaZqx5j7yHmgklAcUfCUsVKrxY7JOBtEluCea3i+4QwRHmQtP3YbwiHVBYeQf3lvCpJw4jYzVOc8v6+bcUdvG3i/KU/8N5/5hligfLxBcmuM498HuP05/ddEU15FSXzHZY5uQzsW7bpKkzTiWrm2ZpMiyUGU7/RYyJUVIbhGo4NdGNDKrWFgK3Qts5CfCtZNkJ9pBNg+bflZqmAQkRXc865hAuzBcgUx17JtW2/knkPyAwD2l//iVdna1kxDF8sIO9qpLEpGAWhayyosl1dCRNQwho/QZ9BmZuxns/dE1/SJb+Y8gUtarEYchx8alwGx2e0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Dod5fONVplgOVdRcbK2NbCtP6Ya/Kx+65d8TNwN0Ak=; b=Xr8ZyTtktr2/Kp66TpAL8EAIInqMKWCedWVYi5nCq6oH/eBgOXNWWnkrxDUK+JCfrQgJvyIUmtbpUKApP5THlu9exisTV52VN1IbDd4ZTlSUetgIu3QS1ryC6XjeiXnlJ82/wf6/OCPtRq8CraykwJUUI+d+g76xDdVBKnbPf/TYtXiJEOVxNC+NUZSXfYvJEG/x1xiUjpGTfNb9f5ABFmj/tC8TndyUtzArVSMRwNMfjseaiHx/tMmjXswoFFCPJaNC6LRSIsGgXW32JCgdO/hLCxS4JHwnV0JqC61ndi4TYb+UhubsMjSxJ5VgpG6y0YC/McTtJU4dTbBQKa9mrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Dod5fONVplgOVdRcbK2NbCtP6Ya/Kx+65d8TNwN0Ak=; b=Pa9daqIo8TfOVgLiAVei1G9e4HZMCTHBbtcvHdrF5PMWNEfrsnXQueu3ja/lNdD/HxbfujhqD5TDVe5Y7NJMoz7uHEnKEXglA3tvjSmIWdJwOWpdD2QlCNTZ92wwxLmX96k28LmzHM1T1H6FupiMHZSdJgTjARklVZVRffFAgxwGNkSHzUk+W//ndwZ47Ln1TcZChitFm3zhBguPtVghzugVnZyMtdfpm+bHUWaZ0hERJggv5Jy4qJb1j76rsf+ILRqLS5Np27iNj0jVgKMBHNGKG/QhI/iSwO8UKA8J0NZ45wdENdxmeU3rAB+PWA5WBC7QxfneflIpYNObFEpeIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA6PR08MB10708.eurprd08.prod.outlook.com (2603:10a6:102:3c7::20) by AS8PR08MB9217.eurprd08.prod.outlook.com (2603:10a6:20b:5a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.451.14; Tue, 22 Sep 2026 14:51:06 +0000 Received: from PA6PR08MB10708.eurprd08.prod.outlook.com ([fe80::1999:c6db:dc55:494a]) by PA6PR08MB10708.eurprd08.prod.outlook.com ([fe80::1999:c6db:dc55:494a%5]) with mapi id 15.21.0451.012; Tue, 22 Sep 2026 14:51:06 +0000 Message-ID: <5bef3ac7-0181-464c-9415-00305071279b@virtuozzo.com> Date: Tue, 22 Sep 2026 16:51:04 +0200 User-Agent: Mozilla Thunderbird To: Eva Kurchatova , vasileios.almpanis@virtuozzo.com References: <20260922120235.2729869-1-eva.kurchatova@virtuozzo.com> <20260922120235.2729869-3-eva.kurchatova@virtuozzo.com> Content-Language: en-US, ru, sr From: Konstantin Khorenko In-Reply-To: <20260922120235.2729869-3-eva.kurchatova@virtuozzo.com> X-ClientProxiedBy: AS4P195CA0048.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:65a::23) To PA6PR08MB10708.eurprd08.prod.outlook.com (2603:10a6:102:3c7::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA6PR08MB10708:EE_|AS8PR08MB9217:EE_ X-MS-Office365-Filtering-Correlation-Id: e82fa57d-3d86-480c-1cdd-08df18b8ee28 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|23010399003|1800799024|6133799003|10067099003|5023799004|4143699003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: hOdmuVeHTEydnUNrtcThqfbOZHnbssZarzxovmwP8BbP/CyXYmWtIyS+gGF2eNO6FuaHZaFPFplcas16LEx+/tRL5nmbqKz4+bg5kRIwhO81CxNueGieKkmbPSoVM+RKVJiu/Zzj4pfqBtk4L0h06ww421Bal+IlWhn8oUBpB5zAU1xlZyGjzp3vTz9kSRgDyJHcOGkk1kPRJv/C/F1fNfewUDWIZyEVxCFX0ohp2O9sWLrwozBAWSUpVj2LI3IagFxgjSCgrSoaVHJsWrqfjudMsguYty1dGw4r7RHD0bo6vcnyBeOXhaI51W4ER2xjrgpoD7QRB+pIfAjoPr3ce8Gcn5mVCI7ydz5UPHq53dT2fghp5stmzDFmJRvYcoOCP9TX4BOdCDRw+BP/IZCQAdIb8Wq38zohhJ7PQT4hYZHeDWJ4BkGLiKKn43ZvRGj1DXXNGoQUTDviqK8dDV7LMx7QeoEeUs/VdZuUc1lilwayT5R4ebGTGAest2CMHl0HpPNlyA8k0N7o4KSGVAoJHlkjNo3nHRUbhsFthMVm9ocuSXee6QVQ5H90PUU7LZMgTW7x3Q6LCNUPaF2xym/2BvuYY0iFyJg4iB/Q3/L8BPp9SOqBj7D7yjG4RnXjWLy4A14WkU7FX0MSI6YGNsuqI2vcdUPNjrKo0B/waCNlOoM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA6PR08MB10708.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(6133799003)(10067099003)(5023799004)(4143699003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VExVQnQwd0lJZXcxTkdpRWtSQXF0Qy9CRENaT0EwUHUwY1N1OFFJc2RPcklR?= =?utf-8?B?RHJPdUtYd3VkV0ZNNDdaK2NVQk9DeFdNdFlXclcvTE55RVdUWnBld1lkUDYx?= =?utf-8?B?WFpnVjJUTlBpdjFjMFFsb2EwVTB6STlHdVduMkVsWE0vU0ovMDZaWXFnV2Js?= =?utf-8?B?SWVGMi8vODh6aXVaNXRCeG5UY0o5bW53K2ZOY3ZUSVpycDE2TWQ4TmN5N09q?= =?utf-8?B?bGJ0dWdkQUV4aUZZa2Z4VWYyaWNTSnJXbWFTSVJORTc3ZngvdGRMdUJQN2o3?= =?utf-8?B?c1YvOUNXN0pQNkVvS2h0Z2kzbEE5Slk0MVVUTitlTGgzQmY3MS8xM1NwcUpm?= =?utf-8?B?cnVSWis3bDkvK0FmR0tOUTN0Y3FkNXcrL3JlcHlvbExBNE5jK3RQMGRkRGlF?= =?utf-8?B?SnpFblliaGlOcW0yYWdkWWhhQ0xybnVkY3RSRGpucGlqQ3h6VVF3a2liZ1E1?= =?utf-8?B?bm10S0NTZ0hiN1p6T3hKRmZFWEJwWEpBc3Zycnl2cW8xNFdGQU1DVTVzWE9K?= =?utf-8?B?SWt6d3hMOWpnanF4OTBmZ0ZDMmwzSlMvQWVBVjkvSG5UemNTNU9SaGsrV0Fy?= =?utf-8?B?YmkwanpkVXlHVCtpcnJIQTUwNVhEU1hsdmZ2K1JBenBJK0xMRXVZcC9pOC9Q?= =?utf-8?B?aDgyajdDZWlXdy9qc3FuTlNoOHorckxDeUpzQXJITkFSbk9yeFROd0ZtNFFy?= =?utf-8?B?dkxzK0ZzckR6ZDdaMWcyZjJNS3FGM0hSd0ZqMlZvbU5QMkdUNFNxK0I3ZENk?= =?utf-8?B?NjJ1M2c5akNyY245RTNHWFZQMStKSDN6UWxVZW1GQTlrMFFwY3pkNFdSQXVv?= =?utf-8?B?eXcvUmx4cEkxeHVoN2h2Ky9nNEN6b0FYVXBOZnJIZFdhOUZzM1J2WG5UT2RW?= =?utf-8?B?TzlITThORlhSNGFobkhGTzRMZUpOQVAycmFwZFJpVHpEdlpFZGxocCtoNHZw?= =?utf-8?B?Zm5tanFYUzlvYi9PbVVzbDRNb3h4dXVMN25qc2lXamZhRkZVTGhKK3lUcGRt?= =?utf-8?B?dGVoNnJaVEFNRmJGTmFhbG56SStYeUVKWkpPZFdhUG5RL3FVdG80bFNIMWJo?= =?utf-8?B?VEFmSkdkcHF5OGJkNkc5andlT0cxZ3V0OXdtQzVCVUpIZER3azV5NFcxbmpr?= =?utf-8?B?ZzNnUDBzRUNoQ0IzSmNTU2lqZkNqQngwUldoYUROenZrdHJudmNvbDlKTi9O?= =?utf-8?B?M3dUYktwK1NvdTYyUlhQK1RuMXViMnBOMmR5cnAvaU0vNEU2Q2Uxd09HOVk4?= =?utf-8?B?UkRMWWZrTmNhMDF3azVwWTRJaUk0VmFaZHhqVFdsZUtZYmZGVjVyOWo3WVBt?= =?utf-8?B?R3BTakpjdW1BV0hYMHJ4NTIzZW90MUw4QnJqSkRuSVFoaHdNVklpeUxmejFo?= =?utf-8?B?Z3ZNR3pEVFBxMzg4eWljaE1jNC9qQXlwSU1RSHZ5OXlvUkt0amRydzFSMTFV?= =?utf-8?B?K1dvSGFQZkZpdG9tMDFBa2VvRXdqYUdPcG5qdFF4aHpITDN2RkxrY0RNb20w?= =?utf-8?B?aVppVmtSR2p4RnVJTG95dFBKZ1VEOWs5OElEUGFWWm1kdWw0bkVVcnNzeUE0?= =?utf-8?B?UlhQNW93c3hSay9KV0VRK3pkSEtDZ01CaWIwYzVUZjJzREo1N0Z5SEtUR1cv?= =?utf-8?B?RkNjeG9kY2oyZEVhZ3hxT0E5YStlU0pKSUNwakRISGFyWUV0YkZiSVNVeXRU?= =?utf-8?B?VVFaZDk5cE1QOGdLb1FKOWJ6am1DdFZteFd4cldaZnNZcmFmVy96c3loT1Jy?= =?utf-8?B?cWxLOUt1L01OQzdVQXEwaEtlVlhQS2tJVmYweDEzTWR4Q2c0NTJzaEFnODFI?= =?utf-8?B?bTFEa0YxVFFQUHRvTUF4R1FrK1Rwek9ZRnRaTUIvaVZ0WkhwOGpEUUpDNldu?= =?utf-8?B?Q3Qyc0FPVU12SG5qTHgxUGs2VkZRL1NKZ3N0b2VnRG5Yam9qTWhFSWJoVXRO?= =?utf-8?B?a1VBZDNYOHgrR21KVjdLYWYxMlRJZEt0SmV3c0dRQWF0blZrZWFwZ3BqVXp2?= =?utf-8?B?dk96R29OZ1lEeHdXYXVVZGVwZ2ZheFhBMklVRklKTkwrQi92WlFtZHZlSlZN?= =?utf-8?B?cU1jNGtIb00zeXpGZDNmdkR1WkJzSUs2OE96MjlOV1MrUXVKR1hNM01CVHNF?= =?utf-8?B?M2FRemc4NHh2UWJqTUxHYk9VMnRqQUEzbDdSNHBscDE1N0J6NmNLTm8xdldL?= =?utf-8?B?ZjRkcG1MR2c4ZnlPVTlHbHVHbCtqV1gzbTROSEZiaE1Eb01XK3JjYTZjNW0r?= =?utf-8?B?R2p3bEozeFc5VHY2UWJIQWwwblFrbHFsYmE3c3RNQlh2cEdKM2dkTXArdGhU?= =?utf-8?B?R0dnUndYZkg0MWtlTlhmUEZidEJJaWF0VnBYY1ExekNWUW1EbE16dz09?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e82fa57d-3d86-480c-1cdd-08df18b8ee28 X-MS-Exchange-CrossTenant-AuthSource: PA6PR08MB10708.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2026 14:51:06.0850 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r6/8eCsprZVZJRe40cF3D+s8CSKjkd3CdyA2F6SW+TKRyKAG5Mq8vYr73WqfmXz0yDDAJdM8QrjW58eT494uCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9217 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10 v2 3/6] selftests: net: make the veth GRO checks independent of host tunnels X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org The diagnosis is right, the fix is not. udpgso_bench_rx -G does setsockopt(UDP_GRO) on the receiver, and that setsockopt calls udp_tunnel_encap_enable(), which is a static_branch_inc() on udp_encap_needed_key. So the -G receiver is itself the UDP encapsulation socket the message wants to be independent of. After this patch the lookup in udp4_gro_receive() happens always, on every machine, and finds this receiver with GRO_ENABLED set. udp_gro_receive() then aggregates through the (sk && udp_test_bit(GRO_ENABLED, sk)) branch and NETIF_F_GRO_UDP_FWD is never consulted. That changes what the test covers. The three checks that expect 1 after "ethtool -K ... rx-udp-gro-forwarding on" (lines 252, 296, 359) no longer test rx-udp-gro-forwarding at all; they pass with the feature off or broken, because the aggregation is now a property of the socket. The checks that expect 10 still get 10 only because GRO is off on the device in those cases and udp_gro_receive() is never reached. So "where no encapsulation socket exists the lookup still does not happen and the device flag still decides, so what the checks cover there does not change" is not true, and the comment in veth.sh repeats it. Not taking this one. Please send a v3 of this patch alone that: - leaves the udpgso_bench_rx invocation as upstream has it, without -G; - before the aggregation checks, detects whether UDP encapsulation is enabled on the machine and SKIPs those checks if it is. The static key itself is not visible from userspace, but the things that turn it on are: vxlan, geneve, bareudp, fou, l2tp devices in any namespace ("ip -all netns link"), and UDP sockets with encapsulation enabled ("ss -uapn" for a vxlan/ovs port such as 4789/6081). The test then stays meaningful where it can run and honest where it cannot; - drops the comment; the reason for the SKIP goes in the commit message, one line at the SKIP site at most; - says in the message that the aggregation checks need a host with no UDP encapsulation and are skipped otherwise. The rest of the series is fine, I am taking 1, 2, 4, 5, and replacing 6 with the upstream cherry-pick as i've already said. -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 9/22/26 14:02, Eva Kurchatova wrote: > Three aggregation checks report 10 packets where they want 1 on a host > that has a vxlan, and pass on a host that does not. The kernel is doing > what it is written to do. > > udp4_gro_receive() looks up the receiving socket only when > udp_encap_needed_key is on, and that key is global: any UDP > encapsulation socket on the machine, in any namespace, turns it on. > udp_gro_receive() then aggregates for a packet that has no socket, or > for a socket that asked for UDP GRO, and consults NETIF_F_GRO_UDP_FWD > only in the first case. So with a vxlan somewhere on the box the lookup > finds the test's own receiver, and rx-udp-gro-forwarding never gets a > say. > > Ask for UDP GRO on the receiving socket, which makes the aggregation > happen either way. Where no encapsulation socket exists the lookup > still does not happen and the device flag still decides, so what the > checks cover there does not change. > > https://virtuozzo.atlassian.net/browse/VSTOR-139651 > Feature: fix selftests > Signed-off-by: Eva Kurchatova > --- > tools/testing/selftests/net/veth.sh | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh > index 6bb7dfaa30b6..b95167f0b4c2 100755 > --- a/tools/testing/selftests/net/veth.sh > +++ b/tools/testing/selftests/net/veth.sh > @@ -105,7 +105,15 @@ chk_gro() { > NSTAT_HISTORY=$STATS ip netns exec $NS_DST nstat -n > > printf "%-60s" "$msg" > - ip netns exec $BASE$DST ./udpgso_bench_rx -C 1000 -R 10 & > + # -G makes the receiving socket ask for UDP GRO. Without it the > + # aggregation checks depend on no UDP encapsulation socket existing > + # anywhere on the machine: udp4_gro_receive() only looks up the > + # socket when udp_encap_needed_key is on, and that key is global. > + # With a vxlan on the host the lookup finds this receiver, and > + # NETIF_F_GRO_UDP_FWD is then not consulted at all, so nothing is > + # aggregated. On a machine without such a socket the lookup does > + # not happen and the device flag still decides, as before. > + ip netns exec $BASE$DST ./udpgso_bench_rx -G -C 1000 -R 10 & > local spid=$! > sleep 0.1 > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel