From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v4 0/2] selftests: ve: fix ve_perms, introduce vtty_stress
Date: Wed, 30 Sep 2026 15:32:24 +0200 [thread overview]
Message-ID: <5fc7cab9-c486-4568-8034-693d756b1050@virtuozzo.com> (raw)
In-Reply-To: <20260928151802.377553-1-eva.kurchatova@virtuozzo.com>
This series do not apply.
--
Best regards,
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
On 9/28/26 17:16, Eva Kurchatova wrote:
> Patchset for tasks:
> https://virtuozzo.atlassian.net/browse/VSTOR-144955
> https://virtuozzo.atlassian.net/browse/VSTOR-144771
>
> Should be merged in this order, since without the ve fix, the testsuite
> will not pass at all.
>
> Changes in v4:
>
> 1/2:
> - Check the snprintf() in set_entry() against sizeof() and give the
> buffer PATH_MAX, similar to how ve_open_rel() already operates.
> - Correct comments.
> - Fix the Feature tag.
>
> 2/2:
> - Move the double release_tty() history out of the file header into
> the message. The header keeps what the test does, how it reaches
> both ends, and the usage line.
> - Match "general protection fault" records as well, they carry no
> "Oops:" prefix.
> - Reason about the test reproduction time in the commit message.
> - Document that the test assumes its veid is not in use by a
> running container in the commit message.
> - Default to 30 seconds and drop the settings file, the run now fits
> the timeout the suite already has.
>
> Link to v3: https://lists.openvz.org/pipermail/devel/2026-September/085277.html
>
> Changes in v3:
>
> 1/2:
> - Code unchanged from v2. Only the test count and the sentence about
> the proc variant were dropped from the message; the rest of the v2
> review is addressed in v4.
>
> 2/2:
> - Corrections in commit message and comments.
> - Bail out on the first open errno that is not EBUSY, EIO or ENXIO,
> on both ends, and report it, instead of spinning erroneously.
> - Match /dev/kmsg one record at a time.
> - Keep reading /dev/kmsg after EPIPE instead of stopping on it.
> - Put the slave node under a private mkdtemp() directory instead of a
> fixed name in /tmp.
> - Kill the slave side when the master side gives up, with
> PR_SET_PDEATHSIG as the backstop, so it does not hold the cgroup
> open against destroy_ve().
> - Call destroy_ve() on the one exit path that skipped it.
> - Default to 60 seconds, from 600.
>
> Link to v2: https://lists.openvz.org/pipermail/devel/2026-September/085125.html
>
> Changes in v2:
>
> 1/2:
> - Add the Fixes: tag, the code is unchanged.
>
> 2/2:
> - Add the binary to .gitignore.
> - Formatting: single spaces, one initialiser per line.
>
> Link to v1: https://lists.openvz.org/pipermail/devel/2026-September/085081.html
>
> Eva Kurchatova (2):
> selftests: ve: grant the directories the files sit in
> selftests: ve: introduce vtty pair teardown stress test
>
> tools/testing/selftests/ve/.gitignore | 1 +
> tools/testing/selftests/ve/Makefile | 1 +
> tools/testing/selftests/ve/ve_perms_test.c | 34 ++-
> tools/testing/selftests/ve/ve_vtty_stress.c | 314 ++++++++++++++++++++
> 4 files changed, 348 insertions(+), 2 deletions(-)
> create mode 100644 tools/testing/selftests/ve/ve_vtty_stress.c
>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-09-30 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 15:16 Eva Kurchatova
2026-09-28 15:16 ` [Devel] [PATCH hci-8.1 v4 1/2] selftests: ve: grant the directories the files sit in Eva Kurchatova
2026-09-28 15:16 ` [Devel] [PATCH hci-8.1 v4 2/2] selftests: ve: introduce vtty pair teardown stress test Eva Kurchatova
2026-09-30 13:32 ` Konstantin Khorenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc7cab9-c486-4568-8034-693d756b1050@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=eva.kurchatova@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox