From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konstantin Khorenko <khorenko@virtuozzo.com>
Date: Mon, 24 Aug 2026 15:48:05 +0200
Subject: Re: [Devel] [PATCH vz10 2/3] selftests: netdevsim: skip the rate
 tc-bw check without tool support
In-Reply-To: <20260821164137.813192-2-eva.kurchatova@virtuozzo.com>
References: <20260821164137.813192-1-eva.kurchatova@virtuozzo.com>
	<20260821164137.813192-2-eva.kurchatova@virtuozzo.com>
Message-ID: <61fc7bf1-8bb7-4287-a118-08e4a0fc5fe3@virtuozzo.com>
List-Id: <devel.openvz.org>

On 8/21/26 18:41, Eva Kurchatova wrote:
> devlink from iproute2 6.11, which vz ships, has no tc-bw option, and
> the rate test fails on "Unknown option" rather than skipping.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-139651
> Feature: fix selftests
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> ---
>  tools/testing/selftests/drivers/net/netdevsim/devlink.sh | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
> index 030762b203d7..e1dbbfc7da29 100755
> --- a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
> +++ b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
> @@ -616,6 +616,11 @@ rate_attr_tc_bw_check()
>  	local tc_bw=$2
>  	local debug_file=$3
>  
> +	if ! devlink port function rate help 2>&1 | grep -q tc-bw; then
> +		log_test_skip "tc-bw is not supported by devlink"

It will be printed 5 times, but probably 1 time is enough.

> +		return
> +	fi
> +
>  	local tc_bw_str=""
>  	for bw in $tc_bw; do
>  		local tc=${bw%%:*}