From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4D3788045D for ; Mon, 26 Oct 2026 12:20:36 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QCJFYg010564; Mon, 26 Oct 2026 15:19:17 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QCJFYg010564 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="kqByJKcS" Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QCJDRY010559 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 26 Oct 2026 15:19:14 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QCJDRY010559 Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-6768601940bso6495883d50.1 for ; Mon, 26 Oct 2026 05:19:14 -0700 (PDT) X-Gm-Message-State: AFq9FYLQk1TqC4mDRDlqaF68qruP+3g8ATP4S9+7IFfSXMgz9k5Xepsc 5duBlJzd/8MuiMcN6PmCRAhNTYYsPLaKrn7jUGDeXnhKJoMLj4yoLv+NmYLm3ITgaSfMEPdrlbn pS6wwLLZykn3Z2Sarb7947b919axPutxQSo8CWfxRwFtI1WMa+FFOHA== X-Gm-Gg: AYBFou2RwZtyfD4NQVSaFRbixRs8SHokInwfEhPkroFvH4x8Ku13pS9pPHY57IFl8Gz tGA7EOUSvl5m1gKJo15UgZRDk0yNv2Tg0hti03wy5IwFhhN3uU3IUXuYQ804MzGZATf0lZQSFkc 0HzdjSUqxH5YlfCqAZUg4F3CP/CXafvLokZL92Y7nRw24T0+PprBTdw0z+e9S1VzP0mpnPwMUoP xiXZCfcS/85hFxMpVBpWtrmALY2CQ764Xm5nyXSPowz0nCQCM//4sVvlaH0dDo3uslXDRxIAuqK qTrz7h8BZUq/1wc93NR6tNwA2xO6xaLz7rTFJSq6g4RNFK6cncwatZ1YPbw0SYguRFZnQHg2lTJ BRa6fMqGvJW+4SlMbe4ZCZRmkWklgaVzJc5EiVM7oscbdC6x5frriugLBlhhvkz3Eq2PKpmwMe1 wIo2zHeGwhDvMi41alen6eIVE17+z/ X-Received: by 2002:a05:690e:4401:b0:679:2c7b:de40 with SMTP id 956f58d0204a3-67a4579d9e9mr3597517d50.24.1793017153217; Mon, 26 Oct 2026 05:19:13 -0700 (PDT) X-Received: by 2002:a05:690e:4401:b0:679:2c7b:de40 with SMTP id 956f58d0204a3-67a4579d9e9mr3597506d50.24.1793017152721; Mon, 26 Oct 2026 05:19:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793017152; cv=pass; d=google.com; s=arc-20260327; b=EOjzt+dpAnDv9MKAI3bvecsqozKQt/Yx4NtuyF2HWBL3ofajkEzlpj7XHkODp6LTO7 EEZPdrsvuOmfQ4G8r/Y8ASiHIwm+rvVbLzLj7SfI+TXRVBtJisvzcDuGnNt9AjCoMONz JQAF3CLqosNawMKyqn8gtwpkYiUBnTFx4LRVkmhbjTh9NZ1WQMSg4wR0LpYlrRAAVafe ER/MoQHA/1U/zqAZatRaNxCR1AG/SSUCF5zzPDZs60U7cc7bhWJXuvvCuSloSXQZlZ19 iEAZorN63NxT4uyWiFDXXSQGTw1/6Ew+021gqitOtkHaHrPw0j2bGlCUGBC5byp4zaZ4 n8tA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=B+EvASFlQf8g5FWntRCrVBI+C4Erhvp1U9ezi8Gf3f0=; fh=/b0OCvJkPsVoW3lAtK7S1vFCz6wT18YFUFRxjV0ocU0=; b=OZNBnKHYgg6fWyeh3/upc+TYYbEoy3spAjHN9Pzt/Kozy7n2dKofN6il8gIySDFJSP 3REnN4eslvIFxMpeyOseLf1vzlD2lnLT0dAXPH90JlrbTxliCePNAZN80wnzftio1/LD naE9mpoCzNTyvjTqAt7K7N6sozEVdwF2U6HvbSADAAYdDAEum+erTxz8AiZgpNBwuFU4 9518XLf6Gdhz4dSHxww+kQCHoOIAIrbbRpdoQbCkB8XzQl8NzL/+eVgwEU9cdqwfqHsu j2v6ZUMuInsIC7OMQ6KTfaHs+5dtp6h/6cIFGb/pu4MWpAIKhxBYZdqkb+dGHuiG4l7U wqjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=kqByJKcS; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com. [2a01:111:f403:c201::6]) by mx.google.com with ESMTPS id 956f58d0204a3-67a4614b898si5298565d50.67.2026.10.26.05.19.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 05:19:12 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) client-ip=2a01:111:f403:c201::6; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=kqByJKcS; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C1dUp4QoMLIrNQcN0tjp2pR6jfsG9eAaEz2F+cTySFKCReLayicz6MGJeG8i3UJDK0GZzA705QwkiNUPLxTgZtL1Yi+PY7YGGB8SoUWQiTxXN0n5JV/zwm22jRuV8DjMQnbykI+28S7umeGGQISZa8gqja/YDJRaKHAgv2lonBxW+u0uc5JN1C/nhfDpdffc1d0c8Zb65n4VADbqL1N0FWF94L3fhbUCPWJAzE+LDNvRQu6QuilXEHQmUeaeQYUEMvIvX1yUIs7Eh7O3kv3PRvxt6/TBsekDN4cAqFUR1yIhyNoMezx1Yz3LmgyLUoOHNfchDWYC0zq4JOj+zRAL9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+EvASFlQf8g5FWntRCrVBI+C4Erhvp1U9ezi8Gf3f0=; b=DFoQtj+niYDxrt4eel6Rm4XARJ+f+rfFwzr1JAm/6WfInI4DmckH6+cFUwL8InC2pec0dqPkzPXHjUHaOdxXuoVQrcJoUq7roZvuNMgmt3yWGA9dB7V2ettBir5IHdLl9B/jWmRrq9HXeqEU20dWxU1ji3nucPPVqLExK0/SKj7vjDBoZ9vmfAVSYfE4xt/5cNO9XLvgDY/bzzECo8GXB81T843yjEEwU8Tr+drvlxigUKZ79tRRkAerq+uFyAx8T0eo74qMoBdP/ui0ITolbistzAOX9NW+NdUB0qREh2Zb0D9zZPkczeX5Gp4bLRDZYwVOiwOqchIrEka4sCsNmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+EvASFlQf8g5FWntRCrVBI+C4Erhvp1U9ezi8Gf3f0=; b=kqByJKcSWaMmX3c+SwVTRU5iHF1Vv8F2PCqPm8KevLop2aTnGm1YHPHXeINLo2QUt3LWpgdy+C7bpJAZ5BgdpKeMVE/NmMvDJMo0648TvNFRR0zqr7Q98Gpa73vz/siVr1lxOZVO+SQB7IbHankprCIKtd+RQTCWXQZ/lE7L3PQ6YFEaJ0Z5Nd0MZ/IR8nf7ZToFyasYaCsAnYf6bVlfyRE5K/aU7yPiLHeWgAJwjwrsw0ZSr2jjhWMd60ZGDXL+JxoaQKkxeSfbuXkPoWQmbmGyjWTwzwYoZsk4v4DEe9jN9s2hmMxsFCOTAPqmQ8lXBIfcxkLbAoBd+3lkHc4Svg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DBBPR08MB5929.eurprd08.prod.outlook.com (2603:10a6:10:208::8) by DU4PR08MB10958.eurprd08.prod.outlook.com (2603:10a6:10:56e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 12:19:07 +0000 Received: from DBBPR08MB5929.eurprd08.prod.outlook.com ([fe80::8c14:5279:76ab:8d35]) by DBBPR08MB5929.eurprd08.prod.outlook.com ([fe80::8c14:5279:76ab:8d35%3]) with mapi id 15.21.0546.021; Mon, 26 Oct 2026 12:19:07 +0000 Message-ID: <6585e5f2-db4a-4cff-ad35-79cad11d5089@virtuozzo.com> Date: Mon, 26 Oct 2026 14:19:05 +0200 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, khorenko@virtuozzo.com References: <20261023192121.356062-1-eva.kurchatova@virtuozzo.com> <20261023192121.356062-2-eva.kurchatova@virtuozzo.com> <010701a16a39f7e9-54fa1894-3cdb-4114-ac8a-424bf293d4eb-000000@eu-central-1.amazonses.com> Content-Language: en-US From: "Eva Kurchatova (Virtuozzo)" In-Reply-To: <010701a16a39f7e9-54fa1894-3cdb-4114-ac8a-424bf293d4eb-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0146.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::7) To DBBPR08MB5929.eurprd08.prod.outlook.com (2603:10a6:10:208::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR08MB5929:EE_|DU4PR08MB10958:EE_ X-MS-Office365-Filtering-Correlation-Id: e51cb354-10c4-4d7e-4f8f-08df335b54e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|23010399003|376014|366016|10067099003|261021135927099003|261021121427099003|261022075727099003|261022105027099003|261009223027099003|5023799004|56012099006|4143699003|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 77uSNywd1a0wSHfDzspoZg1X8yu/4y0sswVqEA6xR4WFk+sMlNS73yljJl2pDhPVcurMkabX+zPyr3WMuFGHt65TgsmP9fz3Kl6JWmL2AM5UhNTWVCiWk6bE+ZgYSsU5Qg3kVcSdVt+UMsLKzN48E4mCbjD3UGBU9Pj69XlqENqIgLLvTzkntaCE7MZZdRi2kKQSgGr4O9mnIqoj+4rVHqjsKfT64O4xwV6GOE5G4kivB01dr/KNCbhh6UDGAL28f9msMAhngBBZI4UhnU5zhlGZBNfNAK7sBv5IQ8FboUY5H8E0RoEPcjy3/uvwqegkNI/tjRG8IrJSiqQInxEio72P0gMxtZ0JadDrMhDfBctQjyFiSneD/jUrqtIvA5fTigm39Iea7XKS0DQjtz+J5pGxJh50VzIZjSGw/dHMFneHNeAMNVTOmWWM0yIZh4FlFJwAEc7r5cz3Twg0mNbgr77MpS8aVG90G+GlsXNMTthujP1fTI9iqbh9sfK8NM5+43/sgLoK7TckmAPbIMCAJ5DfapBf8Uicx+KRzeZ0jOv8vtF0M6VIZ0StrTx2K5MbFZf71f/PUuGMjwq4jR5Cpfm5fqmVyOrDN2SQoBFG6R2iJ5BvPFyB/IWEAMpxwzpr1MFXVtagqnTTi3EumahrlEV+ju2Ar0qcuZBTIm4/DOk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB5929.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(376014)(366016)(10067099003)(261021135927099003)(261021121427099003)(261022075727099003)(261022105027099003)(261009223027099003)(5023799004)(56012099006)(4143699003)(6133799003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0FQWDlvR0pkcnNkMHR5cVQyY3haQmtZWUhmVnBHcUQ4Q1ZpRG56VEY3TG9h?= =?utf-8?B?T0kwM3l5UHVSemwvbHkyYWFNaSttN0lKT2pvSCtWdjVIWnN0ZndGZ2JkTUZB?= =?utf-8?B?VFE2cG94RnBhbFdpZDVDR1lhYUt5TWRjRmxrVk9uTmJaVnFmSHd1K3AwRWxr?= =?utf-8?B?ZVdtUFBMcXZQazlwWGdKbHhYTDFqSGhxTC96Wm95bVZKSktBWHFIbFVUc3Rh?= =?utf-8?B?Zk1zanNOeFkzRW5WSVQzL3UwR0o1cTJLdHI3WnVIZytwdFgvTFc5YlhuQUFt?= =?utf-8?B?dDI0dGlxc2cveDVOUGJDSnBpdE5CeFRKSWZQSUl1ZFBmczlEM1F0cGszUUUx?= =?utf-8?B?SWxrUlNDeFp4bXZhaXA2YVN2dkl3ZzRRM0h3Z1krWm0yNzZmNk95enlzK08y?= =?utf-8?B?ekhjL2Fac3Jzd1BtVHlOWC8vQmxiWmJtWFpCd2VpaVl3dm0vNmR2S3VTNnlx?= =?utf-8?B?M2pNRXZDU3MyOFE3aWhha0tOeFhucVhra0tBeXZqV0xGeGtEMnZQLytNK1dT?= =?utf-8?B?aitvSGZvKzE4MTlvcW0wSG9tTld2bFNRUHUwTU9FZmcweFJqMlVFNFZ4eFlo?= =?utf-8?B?Tm9FRndSaVI4TlQ3MXlpdmRnSmMyU0ZocHFrVzU5dGc3QmpjSzl3N1BoY2Vr?= =?utf-8?B?L3I5VDlMY2hRUW1kclZYOGJHZk0wT1oxaUhROUZFZEtrZEoxdmw3QVVvZ01q?= =?utf-8?B?U2c3RGt0KzJ0cmcyeFU5SGxXaUhaQXNnd0JiT3V3bnBQbHhmZmI5TjRrQnFv?= =?utf-8?B?SkdFQUlMdm9GQkU4ZXd5R1Z2aHI0b3VxaklxWHVkU1VMdUJBeVV4UVBTdjlC?= =?utf-8?B?Q1R3MzRHYW50NUduMUwwVlIrcVE0YTlWcXpmSTE4UTdjaUgzUzBTMTh6SEpG?= =?utf-8?B?Z1lwRzY4Zk0rb1F0TVpzaVR3emt5N0FCRFZRVGNIUExhMUR1d1FtRVpRaTlN?= =?utf-8?B?MlBHVDZQZjFKb2tqMGlFVFJFRE1YZE95cmhQcnU1T1JsdDFDS0ZQLzdKU1o4?= =?utf-8?B?SFlEZUtIcEZhbnRFUkl1aXdxckMxbG84bVdublp3U2ZsM2V4a1grbnFUNVBi?= =?utf-8?B?alkvR1luaVZ4MXI4eXRDUzduZ3pXc3hYb251RXlBVDJ2dlZvaU5vY3pCeVZ5?= =?utf-8?B?cEhwRFIwblBMUWpyU1F0aUhYdTZtbkxTVWFvc1BnaUdRb3ZXVzdPRm9NVHVw?= =?utf-8?B?bkRXR1MzYlFtOGdsTVp1QVpGOXBsdUxEek1TUWgrcVR1ZDR2NnVYckg0RStp?= =?utf-8?B?Qk1PZDh6d1dVaWFxRnQwT2wxdVZ2OUZpUVpFWld0S1lMZVdKc3YwdzFDTEN0?= =?utf-8?B?d1dSR2V3d1FzRS9iNkFYV3oxcklQT2cyajI5K3hkdTZpVjVEc3F3RndtSmI4?= =?utf-8?B?MlRVNGJmV00rZzhyQXgwU3Z5V1FOdEZ4ckQ2blBtRE9PNFovTXRaendGRWFT?= =?utf-8?B?a1FnSmdxUU5FZHJtUEFkY0RDclZ6SXZsNWdHc01sKzk2RzN2eUQxUmFZZjc0?= =?utf-8?B?NU50MG5aSklFSisydWV1WDJMOExCRVliUlQ3dFJXdndsWVBvcVcwT2xaTStj?= =?utf-8?B?VDNxQjUwK0xQSkxMTDg4V2V2c3VaOVFxYng2c0VHbTQ1bDVSNHJmWjlZVEkr?= =?utf-8?B?VWlqNFFZWE9CM2syUzB6VFl5UzdlbWg3MFV0a3FrM2I2bUVZa2ZZcnoyQ29F?= =?utf-8?B?WXQzWUJ4dDRSTUZkbkdXWDVMZzlaM2tReTJ5SnhYV2NUVjdMNXhheTFNaUhE?= =?utf-8?B?M1lna2VmcTdnRnBnaEE0ckRkZlFnUzZwTFhoSHRuaWgxY1BPSSs4dEZaZDZL?= =?utf-8?B?M01pT3IvNXNhVUFrR2lCZWdreGtady9jWHVkbUo4MEFiM1dRb2RiaVhGOFFJ?= =?utf-8?B?aWpqQkt5dVIrR3RLWHlFWXhPWFJaeWY1T213YVhoWHllTlVEZ1plMVJUYXVn?= =?utf-8?B?ckFoQzNPRklRY1B4UklVdWF0SnVSWXhuSmJwNllvUFgxK1c2WTBOS1RLR0Rw?= =?utf-8?B?cGlDWjFaYTB4S1ozdW5vTlI0QklxSWxGTXV5OE1GYVhWWmdYcmZYM2VRZlA1?= =?utf-8?B?VytBNWV3TUdkRFBpdEVzOUFCNGlwTythamM5QzFqV3pJekJRTlZBdSt4ZDJN?= =?utf-8?B?TnF5N3pXTkJnb3RVK29YSzNQVTVjeXZyN0NoMVZ4a01vTmZWbEgzZU4wQ0FQ?= =?utf-8?B?R1VqNUtCbTQ1cHZGc2pBYUNrK3RFQXVEMmpCVnZZTUZFOGpVYTc5cGE3SlJp?= =?utf-8?B?bkFaQTMrSGl2TFV4Y1hyUjFWLzkzUHFPQVVyRkhlSkNZS1lhend6VjZDb2pt?= =?utf-8?B?TE9pMjhkL3pvRGpwN1Jib1RJMy9JdGxDYmdYSlRMaStkTCtyM29YUXB2ZG0v?= =?utf-8?Q?A/3Ftc47wpOQkttU=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e51cb354-10c4-4d7e-4f8f-08df335b54e8 X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB5929.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 12:19:07.1020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /zQiIqheq6xy2xLsX2rg5EXSX7noVZ/WCuzYDt6CM1A+SePqFXkPHV1QFegX6qGCni/Vpy7TH2VznEmGOrHYv/aKSWho33kr4fATaglrrJc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR08MB10958 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v5 1/1] selftests: drv-net-hw: skip the tests that need a real interface X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/23/26 22:25, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Low] selftests: skip_on_veth() skips explicit veth setups with misleading advice > - [Low] selftests: skip_on_veth() honours NETIF_FIND_DRIVER set only in forwarding.config > -- > > commit 8d2d6696991f9f7d35e072ffc95cdbdbfc7bbe48 > Author: Eva Kurchatova > > selftests: drv-net-hw: skip the tests that need a real interface > > This adds a skip_on_veth() helper. The ethtool, ethtool_extended_state, > ethtool_rmon, hw_stats_l3 and hw_stats_l3_gre tests call it before sourcing > lib.sh. The helper skips the test when the first interface is a veth, or > when lib.sh would create a veth pair. > >> diff --git a/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh b/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh >> new file mode 100644 >> index 0000000000000..b65d474ac7b24 >> --- /dev/null >> +++ b/tools/testing/selftests/drivers/net/hw/skip_on_veth.sh > [ ... ] > >> +skip_on_veth() >> +{ >> + # lib.sh takes the command line, then forwarding.config, then the driver >> + local p1=${1:-${NETIFS[p1]-}} >> + local kind >> + >> + # lib.sh skips by itself when the driver has no interfaces >> + [[ -z $p1 && -n $NETIF_FIND_DRIVER ]] && return > [Severity: Low] > Can this early return run the test on a veth pair that lib.sh creates? > > skip_on_veth.sh sources forwarding.config at file scope, so > NETIF_FIND_DRIVER is non-empty here when only forwarding.config sets it, > and NETIFS[p1] is empty. The helper then returns without skipping. > > lib.sh checks NETIF_FIND_DRIVER before it sources forwarding.config: > > : "${NETIF_FIND_DRIVER:=}" > > if [[ $NETIF_FIND_DRIVER ]]; then > unset NETIFS > declare -A NETIFS > netif_find_driver > fi > > At that point the variable is empty unless it was exported in the > environment, so discovery is skipped. NETIFS keeps the default veth0..veth9. > forwarding.config is only sourced after that check, and nothing repeats it. > > Then lib.sh reaches: > > if [[ "$NETIF_CREATE" = "yes" ]]; then > create_netif > fi > > and the test runs on the auto-created veth pair and fails, which is the > failure this patch is meant to remove. The helper's comment says it should > keep in step with lib.sh, but it doesn't here. The environment and command > line cases look correct, so only the config-file-only case differs. > > Should the early return only apply when NETIF_FIND_DRIVER is set the way > lib.sh will see it? > > [ ... ] > >> + [[ $kind == veth ]] || return 0 >> + echo "SKIP: needs a real interface, set NETIFS in forwarding.config" >> + exit 4 # ksft_skip, lib.sh is not sourced yet >> +} It is not empty. skip_on_veth.sh sources forwarding.config into the same shell that sources lib.sh afterwards, so a NETIF_FIND_DRIVER set there is a shell variable lib.sh sees, no export needed. lib.sh then picks the interfaces by driver. Checked on a VM with NETIF_FIND_DRIVER=virtio_net only in forwarding.config: lib.sh took the virtio NIC, and the helper stepped aside as it should. > [Severity: Low] > This isn't a functional bug, but is the SKIP message accurate in all cases > where it is printed? > > The same message is printed when NETIFS[p1] or $1 already names an existing > veth. In that case the advice to set NETIFS in forwarding.config doesn't > apply, because it is already set. It still applies: NETIFS has to name a real interface, and here it names a veth. A veth named on purpose is skipped by intent, these tests cannot pass on one. > Also, only p1 is checked. If p1 is a real interface and p2 or p3 is a veth, > skip_on_veth() returns 0 and the test still fails the way the patch tries to > avoid. Same as in v4: lib.sh builds its pair from p1, and a real p1 with a veth p2 is a configuration someone wrote that way. I can change this, but this seems out of scope. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel