From: "Denis V. Lunev" <den@virtuozzo.com>
To: Alexey Kuznetsov <kuznet@virtuozzo.com>,
devel@openvz.org, khorenko@virtuozzo.com, kui.liu@virtuozzo.com,
azaitsev@virtuozzo.com
Subject: Re: [Devel] [PATCH VZ10] fs: adapt to new checks of fallocate mode
Date: Sun, 6 Sep 2026 15:10:41 +0200 [thread overview]
Message-ID: <659b6fa3-0463-4370-ad08-c40bc9d6ca0f@virtuozzo.com> (raw)
In-Reply-To: <apyxOCup3tpcv32+@mops2>
On 9/6/26 02:20, Alexey Kuznetsov wrote:
> This small lapse halved performance of vstorage
>
> Affects: #VSTOR-142784
>
> Signed-off-by: Alexey Kuznetsov <kuznet@virtuozzo.com>
> ---
> fs/ext4/extents.c | 3 ++-
> fs/open.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index b771cb5..38f5077 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -4769,7 +4769,8 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
> if (ret)
> goto out_inode_lock;
>
> - if ((mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_ALLOCATE_RANGE) {
> + if ((mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_ALLOCATE_RANGE ||
> + (mode & FALLOC_FL_MODE_MASK) == FALLOC_FL_PREALLOCATE) {
> ret = ext4_do_fallocate(file, offset, len, mode);
> goto out_inode_lock;
> }
> diff --git a/fs/open.c b/fs/open.c
> index 91f4785..fc72ad0 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -267,6 +267,7 @@ int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
> case FALLOC_FL_ALLOCATE_RANGE:
> case FALLOC_FL_UNSHARE_RANGE:
> case FALLOC_FL_ZERO_RANGE:
> + case FALLOC_FL_PREALLOCATE:
> break;
> case FALLOC_FL_PUNCH_HOLE:
> if (!(mode & FALLOC_FL_KEEP_SIZE))
1. Should this go to mainstream?
2. Can you add some more details pls?
Den
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-09-06 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 0:20 Alexey Kuznetsov
2026-09-06 13:10 ` Denis V. Lunev [this message]
2026-09-06 13:15 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=659b6fa3-0463-4370-ad08-c40bc9d6ca0f@virtuozzo.com \
--to=den@virtuozzo.com \
--cc=azaitsev@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=kui.liu@virtuozzo.com \
--cc=kuznet@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox