From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id B98BB80726 for ; Wed, 7 Oct 2026 13:18:00 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 697DGbVu005932; Wed, 7 Oct 2026 16:16:39 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 697DGbVu005932 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="pYMD2dnb" Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 697DGZi0005928 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 7 Oct 2026 16:16:36 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 697DGZi0005928 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-8af95378e7bso21831727b3.1 for ; Wed, 07 Oct 2026 06:16:36 -0700 (PDT) X-Gm-Message-State: AFq9FYJdGeJyhTA1R+9m+UXQV50TKyOBEvFPYFAALOx09cWzty+Bhkp7 y9Dd6XJOLBVro4lFQ0XrVCqhF7JmYgKRk0a3nn3OY4zZt1revRm80Zii/5Ah/YD29w6Gwbg+/yI 1rXWLC3Ww+zZDazb+4LSM22m2O4hVPo3trvGEI/V7fYPBfq8H/+polA== X-Gm-Gg: AYBFou2C9AIIKteXKC/OhEqsVFytoxMweo3WlHfEQL+86ukjdJwWmEQKmuBGWzxzS6z qc/V5JYb+PU1QxkiQSVMCLjlBDLAfwqrwXs+91R7gS0fwRw3ae5E+uQuco3FSasmRL+lB89ECXq gbQC/VUZqL/8AIbYEKRp1WsXdBV2wkoxmPbINtD5Bk/IrkXH7igDV4P5h3H+Fd62r5+0+tQI7QB RAstNJnxUwEFsg4qmD5dwE1o83Tu0iQbA9R7CIllawjMdIrZRFpA8C4xri9UfsPaaPPqXKeycOY GOc1FzX5Qqz62ceSb3iyqOwMbYQ8vdGj0yDNJoELDdE+4cD2Rz7CLqCwm6dqe2IZWV+Gao8xSlT 1pcDVnAbsvvWUT2lqffDMneUtLYbFK7ClSfRQhX4e2eDueeXLNduOIKUI9Wl+xiplAijU2TorxE ItlUzhxIsyD1gBA8SarYlj X-Received: by 2002:a05:690c:4a05:b0:8ab:5f2a:3920 with SMTP id 00721157ae682-8af72061b02mr34283527b3.17.1791378994877; Wed, 07 Oct 2026 06:16:34 -0700 (PDT) X-Received: by 2002:a05:690c:4a05:b0:8ab:5f2a:3920 with SMTP id 00721157ae682-8af72061b02mr34283397b3.17.1791378994317; Wed, 07 Oct 2026 06:16:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791378994; cv=pass; d=google.com; s=arc-20260327; b=TXAOCKbxYMzu6/eLAQgsSMuMYBIVYGZ9yKFz91MuVvfZMXtj14qLxiOyVqx8vQBI1F ZJpboqftpFzESabk92yVZOGYszjVJhZ7cPi7HYzntluUFcSoWIcohqwzQXP9AYusAoto /9YuvAr275QV3mYxGMbwbI9oBS4Za+1/liWiqxHb4rZ/RU04IY2OnAUiSGdfy9hBOeor 24e3vaUagk+e4J1ks05SNE8PqtjiA44u0GLmG9BDgWaXOltkEm0lsJoZKTHiKucitTnw 7MJRzLokCEh4+ww7pwc8/XdlymMxY7aKdJu4UtODVYrI2tH8UIN2Va0Eb5ejAtb54z0D 527Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=A+BPazapHTBzStio5iFGMT1LxADuFcqiGHcHRVJB2Dk=; fh=P4c6nXhXRSFSGAM7iOsKo9r3ld04QCoUd5t6fQFqYtY=; b=V++g4N/ry7Dhsb9U1FZmL9Mhi2SPXpJ30VurPkrZA859SjmKojoW7rnG9Q3qh5SmgR PmljQRM4QaWyB8/INwbVDFCJB3DMCVH4wme4ChNHiBxxwW++v9Bi4oyiYG1b7Ils5zCM yb+/p6ZQ5xbgTfTLOE28HRbcYqXKLuA1/GbDTyzmFmN0FhKCToSVRVgF8uJDdSNeM2jr yKsKdqdNGXIyys65sSQ98ND8RW4hbGYNObCS0+xXj+HCkczW2t3ttRrxEh+FyE7oOtuy 3tQOP0hR4RiPEUdfYjBhjWHYZSm5B1n2sKSL/kLxcbJAUyYMc9Lqd0hbCGNcvSA6y1RN SlrA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=pYMD2dnb; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com. [2a01:111:f403:c201::6]) by mx.google.com with ESMTPS id 00721157ae682-8b05ac3f4c4si9498707b3.231.2026.10.07.06.16.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 06:16:34 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) client-ip=2a01:111:f403:c201::6; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=pYMD2dnb; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uAw7eZJzPKLCb4u9BpJ9h32dni1DVYR7H6E4uvDhntU1H9Wm1zrxFSW3h66t+tFk1PWCTW40WsmNbRKdnhgCsnZusrorg0cLvCssDk97PSt2j6mWFrzhwbfXvO3EK0l6Q2jT2VDRYvfu/skeN+bRUXAhLCN8fDz7m341vCzzRYSqcIalzFTNP9MuHFVi858EIl7KfvwxV29RepH0Ow95C5bDeluLvJ9qvJbecop1L8UraobDD3fH+7MclWMByCooARGIAlJVxtqQ9NTQ/xllRhBwXsGhNC8PleI9epPlzJevjI8/nVjyvIC8HVKehhEYIy/sbexfUIA7nmAqdfunyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+BPazapHTBzStio5iFGMT1LxADuFcqiGHcHRVJB2Dk=; b=V1wCaE2cgaDcomy9XO7/Gq75P3NLUo+WIU+19YbSVjKHJ6NVL3HUqtJNaXcNsoXc5yYlRiP6P+2lyrXLN6PO6eB2QXCDtXuDgLEGxjIhAHyE/YmtCSTxRploJxMEXFhJ7SdeC6pXHdjJJ1Tt6v3faOWP4skb2qWPKTM8SJEHoVmEE4KtfZF/LlpKMufVufuj6+vnWzbY1qGFcXDwwKCoUBCiHBQ1BFUTM6N0f3Z63WzqXs1jbrYJKys+ZSN6lWj2E2Btifgs6QfvjGeuLe27rPsm4kFkb8r/ab7tNpjd1B5lawiD+a4mI9ugYN+qcn6RurHkpfMst13SbHQFm/PLRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+BPazapHTBzStio5iFGMT1LxADuFcqiGHcHRVJB2Dk=; b=pYMD2dnb7bla74gg/5Hsevy3uIa+o5SQhKpbverPS7WxfYQK+elm2ymZjm8bPi8aeyb95W/NAfZiY4eNOBU6nsmNRK5nHh7xc0RyFGY7QZryz2XSJM7aANLInu8xo9eLl84xLCG0IuyxiDFi5nUuLFYnbOFTsuGWU9FBtJI2ulWRiy6Lgyd6O/dnssXlVuBvsFo9Fb61bwg1pkftCuMvzkrPuqiS0PNjVcIu6Df27umuv+/LWlng2HgoCPW5VJD8XKW0RkW3eOzoY1/i9jMbj5k8C1BLD473NlmqY3rFPSM+zNxR8onLBqY6DtVZ8/X/GsnuLXqBykOAt0OCkXsSrg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA6PR08MB10708.eurprd08.prod.outlook.com (2603:10a6:102:3c7::20) by GV2PR08MB8002.eurprd08.prod.outlook.com (2603:10a6:150:aa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.14; Wed, 7 Oct 2026 13:16:26 +0000 Received: from PA6PR08MB10708.eurprd08.prod.outlook.com ([fe80::1999:c6db:dc55:494a]) by PA6PR08MB10708.eurprd08.prod.outlook.com ([fe80::1999:c6db:dc55:494a%5]) with mapi id 15.21.0522.002; Wed, 7 Oct 2026 13:16:26 +0000 Message-ID: <6bfa2d88-6532-453f-9b8c-9ba924d1b8fb@virtuozzo.com> Date: Wed, 7 Oct 2026 15:16:25 +0200 User-Agent: Mozilla Thunderbird To: Pavel Tikhomirov , Vasileios Almpanis References: <20261007-b4-prep-khorenko-vstor-148656-cpuid-v6-0-a8eb906e69b8@virtuozzo.com> <20261007-b4-prep-khorenko-vstor-148656-cpuid-v6-1-a8eb906e69b8@virtuozzo.com> <010701a116405519-8d9fc189-e7d8-494f-83f7-991983ed4b6d-000000@eu-central-1.amazonses.com> Content-Language: en-US, ru, sr From: Konstantin Khorenko In-Reply-To: <010701a116405519-8d9fc189-e7d8-494f-83f7-991983ed4b6d-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: AS4P192CA0019.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5e1::8) To PA6PR08MB10708.eurprd08.prod.outlook.com (2603:10a6:102:3c7::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA6PR08MB10708:EE_|GV2PR08MB8002:EE_ X-MS-Office365-Filtering-Correlation-Id: c13baf7f-3d48-4b4f-8777-08df24753109 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|5023799004|4143699003|56012099006|10067099003|18002099003|22082099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: 4f7QoW2EJv17/NSBeLRQEClOknquvrmtqpQ+MKXqvDyxdWVxk3ssc1c9WNkMtIqmsQxbSU0NIgU8aaOxK67Hj/ioAfwezA86VSBU7YyG72W2G4XNlN7HMyvMxIP+hkSgb4zyMJgcg+0yNHYZKZNfEyGBu8NShlIGkSXxfwIG0r43uQZG0a5/lfkpYIYo5Oi0f17yJv8YFRp7lG1YGNgAc8mPVNqvc5qwUkbbJf6B60QnpVJZCuorUh2HrqCsUV2gvbnTe4W9uXwTS0w/cWRiXE4aQRhVUAYikTMPFBGvTRn87dmGE9ya8CLi5ugwKTw1NXmTvDjZ7K6B8N0GIWWWELaunt6zpfZPlirLlO+U2OaO7wfLwB4DJgqWQaRnqGlA/I5NCXJn/6MghvlLkgasxI4G//vpZQWg9r/vbpjM8UqiFilP2M2iC0Hq8cO3v6UuICve8MNLa3jwEj9WSR+3a3GVZwr3kgxiRqdFwkSaznKun9YjuhpWp2LNAPdN+rQTe5yTsZ0wi70iJmj/BtRWZJxRxrzHZwdLRAMCj/14N865BmfI+s17NZfpE0PSlZnwcb3uFHfBjnSAURKIK1c1F+/Hg+YVcIwmkyZW2B5tbCxnI3Iln4Fd3FsFxj8bFOGfuHdlb12gM2ad23X5GBZBUD1UxqT3OsJ0nofgBSPFgRE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA6PR08MB10708.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(5023799004)(4143699003)(56012099006)(10067099003)(18002099003)(22082099003)(6133799003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXdVUm5zSkRKSVFOS3BJam9iMmQyM09uK3l5ak45dmF0SkRMV2NtM3hoVnFZ?= =?utf-8?B?RlBsTjFJaDhkUGhDVWZabTVuSEd3Zi93dTlpYWdFZEdlL0dFc01YcjBoejRZ?= =?utf-8?B?SGVlVTFDZm5zR1U2NmQ1VzdydFZQeWhNRXlQeS9KdWVvSDFlMG04VmNtWmJs?= =?utf-8?B?ZU1SLzc2THRLbkpZNkhtSkFUdE9jY1FSLzhKMEpCYXF4ZkwvaGpDdHhlMmRH?= =?utf-8?B?bjFoNW14czkzSGxJaUZiQ3lMNW5DSnRiQnZDbFZWSFFzNnZEcmZWaXUvVE1R?= =?utf-8?B?bmg3Wnk2THVYQXNBRENzUUdGb1g2NjBrckZQaEJBczhGU0tqTUdUeXRDTUVV?= =?utf-8?B?WE5pNFZpd0JyQUdwbWJrNnVHc0NYRDVUUHk4cDRTV0t1enhmT1ZXTS9YV0lF?= =?utf-8?B?Z1dOY21md3JuU2p1YXJGdFdjV2k3cFNzbWlXQWNxY3R6TzRhdjVSaFJUZlU2?= =?utf-8?B?MVVHaVFxNE11cEIrVFhZSnNGWjBTbUxLOEdFV3A0Um4rT2ovbHB2ZXRGM1M0?= =?utf-8?B?a24zcjd2cnpzMzJYSFljMk9uRW5sL2s2VkVOMktrVGN3V3pLTnJtK1N5Zkps?= =?utf-8?B?VG1vVWlreHhzQmprMXR0YnNPdTdRREZPTGpEcEVGZnJ4T0JSbzdFRmJsQWFL?= =?utf-8?B?R2k4azlMN2tWTWFqSXExdjhEOHE5aXNRV0FZYzFabkRxVm9oWExRZjJkU3p0?= =?utf-8?B?NHpHYmNPZlhPdkpYWmFaV2tIWnc3dWpvdHE3WkdtRmRCaEE4OWpQY1BvQ2c1?= =?utf-8?B?b1VERUpia3A2TXlLK3RnZDNIQW5rNU9kRnA0V1R6c1luTTB3eDFKallKQlZw?= =?utf-8?B?N3dXWTVlSVQxdWZhbVVhMVU5dERsb1l5SVljWVhaUmpsUWZYR050WlNuekJE?= =?utf-8?B?cmtSMk1ZK3FudEJBVlB5MGY5SDBmYjljaEpSR09jWlUxbVk2QlRGYUZrajVv?= =?utf-8?B?eHU1bGc5TzZWZTlZcnFRWS9ER3B2SE9JbW1tYXVCazB3bEhwRUhyZ2RJN2My?= =?utf-8?B?eUJvenZoREorMzliVVcvcDRsRGdIb0xaUDlRekx3anFtUGJ0clE1MEdzaDFT?= =?utf-8?B?RGhJREo2cGNzdzQ2Q3dydE4vc0NoeGdNUGtHREdKWXJFQ0I2bWsxY1JSMXRw?= =?utf-8?B?SkVKMWR5Y09EUjhoaXI4MDF1UWdic1ZsQng0ZHZjVitabFlHYnRjTWJobTdk?= =?utf-8?B?bExMSGRUUHlnNXp1VDMySTByK3V0RTdHbHFrbUliYk5HN09DQTd1STFNRWlS?= =?utf-8?B?aENyWWhIWGVON1ZibVlMbTdxVktIRXkxaWxyWUNvT0pDbG81LzgvRXYwblBI?= =?utf-8?B?cVBYT01aMDRmZXFPUHJoSll3S2Z5S1k0QWJseGZlOGcrTDhqMGdsU214NHZW?= =?utf-8?B?bW5NakJIR0VnM1NwUUpUOGh4K2NkVXB3cCtBWXJpRTFLRTRMMEd3dFoxVU9k?= =?utf-8?B?elFOQTJJU09yR1B4R1VDNTFTTlhjQVBEa3ZueVpnWVRoaEFHR0x0S21xdzNN?= =?utf-8?B?ZjdDNGVvYzk4TDk4bmxENnZEUXEwakVnNWVhMXlWb0NCcGxSY2tnTGNHakRU?= =?utf-8?B?d3pORWF2akVkN2M0OG9GejlmTThkM010cGozZzIxZENKZGFCbFZOYllvdXFm?= =?utf-8?B?M1hXRTVHWU5aemU5azMzajlZNThGcS92Y1pJL3psVXkvZlNqeXg2SXM0YWll?= =?utf-8?B?MnZMa0ZHSjhUdWIrcUlrdEZ1Z1VKd2RQYTFJUlV2NWhMQ3NIVVduaGFCOFkv?= =?utf-8?B?aXNLUUNTR2pLMnkySHpyK0t1Z1hQOEZpcWhiQ0lDYk9uZVBOY3ZycFFrY3Fv?= =?utf-8?B?ay8vakh6Sk8vbXdYMHhPVU5uV3NUTEdKbW5DZ2J5VTVPUHJHWmcwWnlWR01E?= =?utf-8?B?NGN0SzY1eDBIbHdxbXh5d2dTcXVXK3c2MHlDZnkrellXUFR0akVqSVVvR0Q0?= =?utf-8?B?RlozdjZWZ0tmMVFUbHp3dWVMREswaThtMDVvUzl0a1pkWElqY2N4VkpMaThC?= =?utf-8?B?NGFYNFFvaG9HbHNKMC9yZm9tbTl6WGNBaTRTMi95dS9VNWJ0Umg0Y2tzWFpx?= =?utf-8?B?QVpuODIvek1na2RvR1J4b3RSd2RxVXQ0OEtEbzlodnhadnRxeWJZVjZyYUdE?= =?utf-8?B?MndYTXQybFRXZUhaTk5lVEFGVjhzWlZsM1pHbVp6TVA0dVVOK2lnRERSSE11?= =?utf-8?B?d3hPK0VZb3ZoMWNiL0ZObU1GWXY0N0Ryb3Q5OS8rYS95YWNoTXpwQ2NlVjI0?= =?utf-8?B?OGF5UnBPNU5LK3RDc2F3ZDFodWFTUHZtMCtRN05RVnJFaHVOa2c5TTFVanh4?= =?utf-8?B?UjZTYXo1MVMyOXdpNFZJWW1BYnAwcUd5L1JoV01SYXFnejJEelEwQT09?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c13baf7f-3d48-4b4f-8777-08df24753109 X-MS-Exchange-CrossTenant-AuthSource: PA6PR08MB10708.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2026 13:16:26.3649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x+iQXAnaFnv5lH6cE0d/XJet8OaL4YLv0qGtxtF460wuP2YSnfJBly2UzaQJGPkXETg2HwWWrN7kVZIgZaWZdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8002 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v6 1/5] selftests/ve: check CPUID override emulation for VE tasks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/7/26 14:04, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] selftests/ve: arch gate runs $(CC) -dumpmachine before lib.mk sets CC > -- > > commit de465213924e8ab9123a95613dab45358f011917 > Author: Konstantin Khorenko > > selftests/ve: check CPUID override emulation for VE tasks > > This adds ve_cpuid_override_test, which writes a one-entry > /proc/vz/cpuid_override table and compares what a task in a fresh VE and > the host see for CPUID leaf 1. A second test flushes the table after the > task was armed and expects the hardware value back. The test is added to > the ve selftests Makefile for x86-64 builds only. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-148843 > >> diff --git a/tools/testing/selftests/ve/Makefile b/tools/testing/selftests/ve/Makefile >> index c6efe7c4b4fb..3f494a49270e 100644 >> --- a/tools/testing/selftests/ve/Makefile >> +++ b/tools/testing/selftests/ve/Makefile >> @@ -6,4 +6,10 @@ TEST_GEN_PROGS += ve_ns_owner_test >> TEST_GEN_PROGS += ve_perms_test >> TEST_GEN_PROGS += ve_mount_accounting_test >> >> +# CPUID faulting is x86-64 only. ARCH says "x86" for 32-bit too and lib.mk >> +# picks the clang target by its emptiness, so decide by the compiler. >> +ifneq ($(filter x86_64-%,$(shell $(CC) -dumpmachine 2>/dev/null)),) > > [Severity: Low] > Is $(CC) the right compiler to query at this point? This ifneq is expanded > while the Makefile is being parsed, before the include of ../lib.mk, and > lib.mk is where the real compiler is assigned: > > tools/testing/selftests/lib.mk: > CC := $(CLANG) $(CLANG_FLAGS) -fintegrated-as (LLVM builds) > CC := $(CROSS_COMPILE)gcc (otherwise) > > Until then $(CC) is make's built-in "cc", unless CC was set on the command > line or in the environment. > > For example, with a cross build from an x86_64 host: > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- > > "cc -dumpmachine" prints x86_64-linux-gnu, so the filter matches and > ve_cpuid_override_test is added to TEST_GEN_PROGS. It is then built with > the aarch64 compiler, where and __cpuid_count are not available, > so the whole ve selftest directory fails to build. > > The reverse case also looks possible. On an arm64 host cross-building for > x86_64, the test would be skipped. > > The comment above the check says it decides "by the compiler", and the > commit message says "The test is built on x86-64 only". Neither seems to > hold for cross builds. > > Could the check be done after including lib.mk, or be based on ARCH, > SRCARCH or uname -m instead? The observation is right: at that point $(CC) is still make's built-in "cc", lib.mk assigns the real compiler only later. The check cannot move below the include, though. lib.mk derives its rules from TEST_GEN_PROGS while it is being parsed ("all: $(TEST_GEN_PROGS) ..." and the per-program rules), so anything added to TEST_GEN_PROGS after the include is simply not built. The alternatives do not work either: - ARCH cannot tell 32-bit from 64-bit x86: the top-level selftests Makefile maps both i386 and x86_64 to "x86". Assigning ARCH ourselves is out as well, lib.mk uses an empty ARCH to mean "the host target" for LLVM=1 builds, and a value it has no CLANG_TARGET_FLAGS_ entry for (e.g. "aarch64" from uname -m) makes it error out for the whole ve directory. That was the v2 version of this gate, and the review rightly rejected it. - SRCARCH has the same granularity as ARCH. - uname -m knows nothing about cross builds at all, so it is strictly worse than asking a compiler. What remains is a gap for cross builds only: the gate asks the host compiler, so cross-building these selftests from an x86-64 host for another architecture would add the test and fail on , and the reverse would skip it. We do not cross build the vz selftests, the feature under test exists on x86-64 only, and I would rather keep a three-line gate than grow it to cover a configuration nobody runs. If a cross build of tools/testing/selftests/ve ever becomes a thing, the gate can be revisited then. > >> +TEST_GEN_PROGS += ve_cpuid_override_test >> +endif >> + >> include ../lib.mk > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel