From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id D80A180024 for ; Wed, 26 Aug 2026 19:34:24 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 67QJX7JA013130; Wed, 26 Aug 2026 22:33:09 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 67QJX7JA013130 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="KCN1RVXh" Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 67QJX41j013126 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 26 Aug 2026 22:33:05 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 67QJX41j013126 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d63c16fc5bso28613485ad.1 for ; Wed, 26 Aug 2026 12:33:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AHgh+Rql+He/veKwVZpWmWymNs1JeYviuIvGypiNIdgDyLXnEdOa0ADQGsE/ZnP3KcpWZ2pqBe+v7A==@openvz.org X-Gm-Message-State: AFuF++kkP1SnYkZXumZGiH2ScR/E8jeaLYp2j6kiqY/R+KhNVEz00gQv iSc2u0ylrKX95pnqmqW4Oda1uOI0OunXjBqa6s6N0XQ2nzgGVc9vN2qn4C0+h6O5PyTwrt1E43k gbAaw+YhwHIHYHhJbCp5yAB8S4APYT4PvPk9d8bYKvHLG8U5eMDG8Qg== X-Gm-Gg: AR+sD11fhBrr9/gdNqEti4Q3HQQ1xIuRJ97/DCC8f6hios4AQJPm6oZYjvu2+D+XW0Q DJETEVwCYvUKcGObq2OJiH1tqdoUGuoycjHicCZK7nzw0G2S4Gi8htSrJVQTKr8o3TmMakck4/W 1Peb+A7x0nzPAcFTXUT9VldYLowAviBaPop3RdwO0gOtJeyDQu7j1I+IfcBhELWgiMyKc4vuYZo usRIw0Cf1NVMXZ8HFFVGvIm6wFBXfjQg9DXHSqgpyVmaC1Fp6Ciea66r4LJ/Uwo2XU9x2UCkGAb zrlqvMQtuBDNIDldSTWCyZk8eD8FdjbkQFE/t/2JVOB3D2V9/IATF9EVmWaNPfADtRH7vLXe6Z5 XlK0NbEMkLyzBy/tJx9C5/hMN4M+vBmwJJKqGG/IqpE6hT8wK6zGg6jitOb91VYk3SgmGkohjL2 aooTZ8u/k6V1us/D6Idz+HA3+hJZHZUwUH X-Received: by 2002:a17:903:1106:b0:2d6:f961:994f with SMTP id d9443c01a7336-2d707a59e04mr153589735ad.8.1787772782977; Wed, 26 Aug 2026 12:33:02 -0700 (PDT) X-Received: by 2002:a17:903:1106:b0:2d6:f961:994f with SMTP id d9443c01a7336-2d707a59e04mr153588915ad.8.1787772782445; Wed, 26 Aug 2026 12:33:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1787772782; cv=pass; d=google.com; s=arc-20260327; b=r+YEZtp/VXp0GmQkoBUVG8DtxpwjSLBLd7wYKdL0iMQNXuU3wQEl6u7uIsu21jyPLm gEG+RRaCOVgrig0AFf1MdFn7/3Zt2e163iZgM4cgM30dv1XCHEYmQonDsak6DKkjbwyW sCM5unDKygx69uM42Vg18FETC4dHIxjiCN9NeSiL+PYmFZeDNgXMdwfEmt1VowRBI81O nsbNOpt2fDf9niwRxPHguZt19WjMKikDK7CzV43M64MoseR6FT2NJ3CjPYAZbfyXjYO8 7cvfqIMqMzUiKksd1gbgyHflHPN6FXC8mFVSfx/LjcWtipYTUysvMBR1bBYkB++/GQIs d+nQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:to:subject:user-agent:date:message-id :dkim-signature; bh=iDN4h1Hyls615CEtKghbccwYUNaHDAX9pAMelwFb4rs=; fh=0CpBcJcqjnkxH4NiUo2yN+aNhbqOKx0t5BzQlVn7z8s=; b=eLzug/uTu0S9Xt+pWNGfMD+IGfHWn7a6PADhwo9LyA75PsgroSVWJ4PVzgomHG7z/q Fc4pQX+Dz5eymN8OXOLT/usSW1bqb2QHg6KLnt7DsXD/aP0SEGHqmxJICtU3o7KliLba Rky+5eiO06HmT+k535jdGqWpOCmFxZd3vt7Ivce6mQj8NOYEl1GwFbtbKuD5vH0B7H6B 2nUQ758S4LRVjvtSygvTVHGTlN4EM4E2BY4ndrn0cD+1ITZRWOY1QAki8LRrYDEjFWQ5 /DorFv6f/u4pAtqVoMpfjO4u6KQxbTt/wn4qo7+yHwkc+pm2s6Kz+Gp/W8u/TRMqbXxq 4jGw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=KCN1RVXh; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c202::7 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c202::7]) by mx.google.com with ESMTPS id d9443c01a7336-2d704c47274si63902665ad.134.2026.08.26.12.33.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2026 12:33:02 -0700 (PDT) Received-SPF: pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c202::7 as permitted sender) client-ip=2a01:111:f403:c202::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=KCN1RVXh; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of eva.kurchatova@virtuozzo.com designates 2a01:111:f403:c202::7 as permitted sender) smtp.mailfrom=eva.kurchatova@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RZlKf1NCgUB6UnA0v8f8Di78sUsE+tAy0fngWh519HeyqMTbgHeutgWtrxHFUrLwXGXC8lFOQ1J1tUWOVGpW+c/dUVMMY3zUTTKq18CdUx2ecSxu/crMZCliddk29HKmigOGQak/792VNN193FDcQaJbepNN3kXq4C4WEGQybR7ftn8Sz3hPnp4tSzkon25/nEJz9RNnqlxcP0XHpZ6fn9vAVd5ASfuqCNFVtZHtN9omiAJwJQKNZODG5XGogkEG0SfCsqIlakpC0s6oPUjwnZZI0BUAB3gs9AnkRMyROe/qXV0KpME/oPbFn4H5LrF9seYt7ZMnOfLZZNrlmYZMJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iDN4h1Hyls615CEtKghbccwYUNaHDAX9pAMelwFb4rs=; b=cpeLBrG6ldBiZRjbeDQYuaiD4yUgjXcErA725dvSwKwcfy7xBC7MkKbOsndDkbhHTaq3IPBAjl3O2qzYF1IzsuydNWcAGWerSomsviE8EURUHSRJB/Z3EJm+ykqJVZVFryCxDXtdpZR5bwvvcM9AfpxUg+nODlD28RwDKr8/7JqmU6rPZHEVGsmN5IkMRs2P9qTeui3gELxuHH7vx6ASNTOPY+CL4JjjyJnfNLM0TMpviRRpZhfBAuRo7liatKKwBwUJo8YJFyWBl994rPXtJnK3HIvLUspApvSLWOuo9ixAs4ras0yVXzu7zGG+hFmqFWwJgdXIvh/nEORLZprw4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDN4h1Hyls615CEtKghbccwYUNaHDAX9pAMelwFb4rs=; b=KCN1RVXh5FE7u3thFwP9y5AgooN1J9bto4LZTav/n5rEhzS8FeaXZ4nWK3iDBMtRD4Vj9mthohsQxoFi8D2+mjDKS4I4DxyedvI6p0r0Zhk2IVvmtRBZfCYjDzDsHmCUggb0x+o5ULI7UXqPkriEKpUKX2cCBXGFvDm4T74tQwbBcHjs9wsvE/Ul3kEBdR0Qkv4tYPWLGrZvaMv4YZw75RunDiV2nU0yzs8ElxUcyJFqxXD6MPDMIv0RCI7+EEdowwxYt0JetxAPnGeAMysOrADFQgY6MHeTJbp0HwQKx94xfQDUD6C+WaXCH0PEI/j4kg8cPTW1+ndyB85MhU97pA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from GV2PR08MB8487.eurprd08.prod.outlook.com (2603:10a6:150:b4::17) by FRZPR08MB11163.eurprd08.prod.outlook.com (2603:10a6:d10:137::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.12; Wed, 26 Aug 2026 19:32:55 +0000 Received: from GV2PR08MB8487.eurprd08.prod.outlook.com ([fe80::df73:1ef2:9c47:9a67]) by GV2PR08MB8487.eurprd08.prod.outlook.com ([fe80::df73:1ef2:9c47:9a67%6]) with mapi id 15.21.0360.006; Wed, 26 Aug 2026 19:32:54 +0000 Message-ID: <6d350b33-2b0c-49b6-8c08-bdb24df770e6@virtuozzo.com> Date: Wed, 26 Aug 2026 22:32:52 +0300 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , Vasileios Almpanis , OpenVZ devel list References: <20260821150402.792278-1-eva.kurchatova@virtuozzo.com> <20260824130922.444331-1-khorenko@virtuozzo.com> Content-Language: en-US From: "Eva Kurchatova (Virtuozzo)" In-Reply-To: <20260824130922.444331-1-khorenko@virtuozzo.com> X-ClientProxiedBy: FR4P281CA0384.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f7::18) To GV2PR08MB8487.eurprd08.prod.outlook.com (2603:10a6:150:b4::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8487:EE_|FRZPR08MB11163:EE_ X-MS-Office365-Filtering-Correlation-Id: 786e9105-b929-425f-a637-08df03a8d360 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|10067099003|56012099006|6133799003|22082099003|18002099003|4143699003; X-Microsoft-Antispam-Message-Info: kf0EplXDinCj6NLiF//xIK0ICyrWekTvCCu5X17Pft+hBMu5IHhL3oHJz6hSF+P7XHAQMx04gvAyWHX8xnr2yWGW3YHxVgm7LVbZd1KOvqUJb1sk9n5BOV2k3Uv+4pFQ1EOA7sBRb8zpfKS3wNSOLtL+Zoh8ejkHZzmwQqW99VGFkl9aePpQZfzWmsivrCw1JGPJQVm+9qnh5/LSiO4/vJafhEDh5OZYC7wKcGMydLET65HZZZE0WmFGYXp1zFLUZK9nVNSlQXpVGPEBcSJUH7qI3vHQqOzupqjPbFHSs2tZOAt8Dmf6xRu/J0iQoRpNeLiHYqIbbSIAJq5CatAC6bBz203/vzAxw91jrK0zo/u29nuAVIvJYSjs+/d3X3SaDnHxq88XUBeAGWOTwrH6EL6nRCopjATZzal410pNbTN6iKKdBV17OtqoRm/2M0twIpkKPML4j7+dXHQRGgNW735uffOFE2aVd3BZb17uG8ibVcc/feG+aVjj8QpJ5z2Lkjs12SPwigszc87+M2XXBGUgkAsPT3jGgG2zCIa84LibAE0S6ArVNFhFqAEOXMiIHMCw5lKKug4K91T/LzCfSSlqm1G95481WbHdmwsUPhdNxpgiX0TtPF8EMHOvbl/KtD4DDJgIu9CBm1kQssHjH3E6vxit6ogAofhuUeTqLBs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV2PR08MB8487.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(10067099003)(56012099006)(6133799003)(22082099003)(18002099003)(4143699003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cStsTXJzYjRsbEZOWjBiUXRjcFBvNGhuUnMvdis1K1JUWmZiUGw5OFV2MnFO?= =?utf-8?B?K0t6QjdsV3ZWZUJyVkpDNEtaYWp1V2JoazY5VFlyNEUvVHN4KzFvTDVSWG5M?= =?utf-8?B?QlNqVFF3R2JPZms2MGVHMHlKSVBGaUV3V0RiT0J4aU4xMlN5SXlBcjIxTFpu?= =?utf-8?B?T2U2RXM4alJHT3RhN2ZDSzhBTkhLQmk3Y1FSaDNZTHZuL0p4bzRlUDRrVFFp?= =?utf-8?B?MTZHWGVIaytqVmlaQlRHQ3JTbGhSMk9TN1lOVk9WWFVmTi9JRDJQSnllR3JM?= =?utf-8?B?NTBSZi83ejN5YWxTd0MxYmNOT2VqTDR2anB2eXV1aFN3WTRkV3JNTkdUYlNP?= =?utf-8?B?Y3pzSTFOS0xtVFlKWGNaWnNYelpLeDdyUFVUSU1heXkwZEMwRVdaSDI0QVFy?= =?utf-8?B?YVlPNEk5ak5CTEFPQnUwUXFxNkgyY251MHQvaU5CRUdycERhTkt4WTNWZVEz?= =?utf-8?B?TzRhQ2YvKzFLY0ZTQTFybnBiMSswb1lJaE41SU42U2pCUndJemtianBuNU1I?= =?utf-8?B?WDRNTzZkTk9vSUpqdk5rMmJ2TCs2bHVDNnM1cVlweloxd1pYMG9EU2tXbW1F?= =?utf-8?B?NUo2dEJ6bmE4K1Jtc056Y3duRnpFVUtEdnlHNDE4Q1Q3OGJpTzlBNTRuUTNS?= =?utf-8?B?S3hTNnRQTnd5WWZENkoraWxNZHFjNGZYKzdCTEZIT3RCRkgwcWJhU1d2MmFw?= =?utf-8?B?TW5kWjZTRmVRUE5rMWJ5MEpvQzdkT2NLNEY3NjlnN0d3bjdidjlpM2xxaWdN?= =?utf-8?B?blV6NVhKaFlHYVBxdjZnSUFkTTVLQVd4US95L1VyZ2xwOWtOSFJNLy9EdEJH?= =?utf-8?B?RnNrUkVWUkdmdTBoa00vN3o0c0Nwd3ZiakRjL0gvbHF5T0N0eHg5cUtRells?= =?utf-8?B?T3dPT2hRcEZKMFVnWmNJQ2lNYW5nM25MU1owNDUySXdLYmlNREJPZFZnbjJM?= =?utf-8?B?Sk5JKzNLbEZOb1ovY0dlTiszODhSQ2NwNW5yT2ZYUFhxSU1RM1A4cW14aVE4?= =?utf-8?B?U3gyV25ySm9IMGpNMDM3bWIyMCtSVDZrUkpYRCtZT2IybU5lWFFha1VrVHNV?= =?utf-8?B?dkdXT0pONmhvVUNoenNaMW5QOUJ3ZkwvU0lsM2dhQjRuRnNEbjVEUHRXUnJn?= =?utf-8?B?V043S3lseVJlN1BSZU1ockhzOWJ2a2E4WE1jak00QTRQbktueFhjdmVQRmtK?= =?utf-8?B?ck1QbkpZYlcvS2V3eDJja0JTbVd3T0lyZTJCWWFLTmJVeE83bU5VeEc1Mk9Y?= =?utf-8?B?OGY4WmVEcW4xSmpIMjhCbk9SWG9rSGdVbE1GeFFZRW9zU0EwbWFSMktYZVI2?= =?utf-8?B?Q2t4T0UyNnB0VDZadDFZSkJJMms3R1ZoK0hCaDF6SDJUSFAwVFNUWjRHK3kz?= =?utf-8?B?VmV3ZVk0blh1aHpTU1R5ODQwN3oyZFVsV3pjNFRqMXVJaUVxVGhtbzlPQkNM?= =?utf-8?B?Y05rNGZtaHR2WnVidnpYb2hXK3VWVVRPY2NqejViOEtQdjAyWWRFbElBTitU?= =?utf-8?B?Z0lpSC9DcWxZUG5KMER4RFFGWTdxRDlOOVU5eEtjUnRlbTlaOEJNaTFvVG5n?= =?utf-8?B?TkhaU0xzdHp3Mm1QOXJpaS9iS05HMmpwSFF1TlJ2ek40TWFmTWpkYkJjdklp?= =?utf-8?B?OFBNMVZFQXpUcmd6MU43S3NOdGdqL3BEVlY0T1ZCOHdQYVlURExKd05uRzRv?= =?utf-8?B?WWErYmdzekliZ0ZWSms3c0FTcjZLai9kcHM5WTN4V3VIRkZ6TGNsOHgycVJW?= =?utf-8?B?MDhPSklHcUk5UVRDalgxRnVDN1VUMEl3cDFsYW0wUHJ4SnkzRUVuazNlR0xX?= =?utf-8?B?eFRVVFJiNm1SbjNZTUtpdGtGTy9wdHlONE5UVDZhNzh1Sk1GeWQvNEhZYnZ5?= =?utf-8?B?M0ZMU0hZWjJ2ME1uajRidit1YXZBMFBFYm1wakYyR0IvZmZTUVZ3MHcrSS94?= =?utf-8?B?WVUrWGdnb3N4QXpWRk1jL3MycEN6M2t6eVltazN3UlEzRWQrbmFsUWJkZUhl?= =?utf-8?B?b3JKc2U3VHo2elgxVnJCNWtRUFIzU3hSVkdYYkJqTVlndEQ0akkzMVJ6MjUr?= =?utf-8?B?SnpqK2VISnFxdjFXby9ZblRVZ0ZyV2Vnd3YvaXdIM0xwNTlGRlZqTWszSTE2?= =?utf-8?B?VGtsbWNiY1o0a3VZemFhSE5HMDMrdFBEOUgzd01HQlRzWXNWQ012U1E3c1RP?= =?utf-8?B?VlRmM0xHYWlydWExWkpqVjJqOHE4OE1aclh6RmlpWmNzelltSFZld3lmYko4?= =?utf-8?B?eG9ZSm82NFkvcVppYnM0K1NUczBRaEhVdFRDdkhLV2VyNUdGTEdhVFI2b1c1?= =?utf-8?B?ZktyRWdhZkQzc0Q4SWtwY09nSHVaQVlna2JlRDZ1T21pb1VhcnNrREJDR0ZX?= =?utf-8?Q?/RuV4qJ+hPnJdQlQ=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 786e9105-b929-425f-a637-08df03a8d360 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8487.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2026 19:32:54.6805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iTQUw8vg/trpgUj192UOQnYsz2otlpk7cVGzFTONYdKoUuxLMMgSD5E3+CNQFhLVz8OKtNnufpJhfFRbfLUPRJn2AZjz12HkbGHt8N3JB28= X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZPR08MB11163 X-OZ-Fwd: true Subject: Re: [Devel] [PATCH vz10 v2] selftests/uevent: do not fail on a netlink receive buffer overrun X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 8/24/26 16:09, Konstantin Khorenko wrote: > SO_RCVBUF is set to __UEVENT_BUFFER_SIZE, 4KB, which a busy machine > overruns while the test is listening: > > No buffer space available - Failed to receive uevent > > Two things are wrong here. > > The socket queue is sized after a single message, while do_test() > deliberately triggers ten uevents "to account for the case where the > kernel might drop some", so the queue has to hold more than one. > > Give it its own size and leave the message buffer alone: the kernel caps > a single uevent at UEVENT_BUFFER_SIZE, 2048 bytes, so 4KB per message is > already generous. > > The receive loop then treats every error as fatal, ENOBUFS included, > which defeats those ten uevents. Netlink clears the error after > reporting it once, so the copies still queued, or still on their way, > are perfectly receivable. Retry instead. > > do_test() bounds the listener with a two second sigtimedwait(), so a > retry cannot hang the test. > > https://virtuozzo.atlassian.net/browse/VSTOR-139674 > Feature: fix selftests > Reported-by: Eva Kurchatova > Signed-off-by: Konstantin Khorenko > --- > Changes in v2: > - keep __UEVENT_BUFFER_SIZE at 4KB and give SO_RCVBUF its own > __UEVENT_RCVBUF_SIZE. v1 raised the shared macro, which sized the > socket queue correctly but also turned the per message buffer into a > 128KB zero initialized array on the stack, while the kernel caps a > single uevent at UEVENT_BUFFER_SIZE, 2048 bytes. > - retry recvmsg() on ENOBUFS instead of failing. v1 only made the > overrun less likely; the test still died on the first one, even > though do_test() triggers ten uevents precisely so that drops are > tolerated. > - subject and commit message updated accordingly. > > tools/testing/selftests/uevent/uevent_filtering.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/uevent/uevent_filtering.c b/tools/testing/selftests/uevent/uevent_filtering.c > index 8062804ff759..735eb8138c44 100644 > --- a/tools/testing/selftests/uevent/uevent_filtering.c > +++ b/tools/testing/selftests/uevent/uevent_filtering.c > @@ -23,6 +23,11 @@ > > #define __DEV_FULL "/sys/devices/virtual/mem/full/uevent" > #define __UEVENT_BUFFER_SIZE (2048 * 2) > +/* > + * The socket queue has to hold more than a single message: the test > + * triggers ten uevents and a busy machine overruns a small buffer. > + */ > +#define __UEVENT_RCVBUF_SIZE (2048 * 64) > #define __UEVENT_HEADER "add@/devices/virtual/mem/full" > #define __UEVENT_HEADER_LEN sizeof("add@/devices/virtual/mem/full") > #define __UEVENT_LISTEN_ALL -1 > @@ -78,7 +83,7 @@ static int uevent_listener(unsigned long post_flags, bool expect_uevent, > { > int sk_fd, ret; > socklen_t sk_addr_len; > - int rcv_buf_sz = __UEVENT_BUFFER_SIZE; > + int rcv_buf_sz = __UEVENT_RCVBUF_SIZE; > uint64_t sync_add = 1; > struct sockaddr_nl sk_addr = { 0 }, rcv_addr = { 0 }; > char buf[__UEVENT_BUFFER_SIZE] = { 0 }; > @@ -158,6 +163,12 @@ static int uevent_listener(unsigned long post_flags, bool expect_uevent, > ssize_t r; > > r = recvmsg(sk_fd, &hdr, 0); > + /* > + * The queue overran. The kernel clears the error after > + * reporting it once and more uevents are on their way. > + */ > + if (r < 0 && errno == ENOBUFS) > + continue; > if (r <= 0) { > fprintf(stderr, "%s - Failed to receive uevent\n", strerror(errno)); > ret = -1; I was originally concerned about spinning on recvmsg(), but considering the socket is blocking, and recvmsg() should consume the error once, this should be fine. Otherwise, this is a good improvement over the v1. Acknowledged-by: Eva Kurchatova _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel