From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id A249E8017D for ; Tue, 29 Sep 2026 17:00:09 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68TGwsU4000417; Tue, 29 Sep 2026 19:58:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68TGwsU4000417 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="SeCS0Zqh" Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 68TGwpQr000412 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 29 Sep 2026 19:58:52 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 68TGwpQr000412 Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-671321441d1so6052562d50.1 for ; Tue, 29 Sep 2026 09:58:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AKwUvBwxLPbwxj/TEYMuFgFQFS0vsSgxr2FTSXZICbyfwFv/k5o4Cr4SDgNNJHOEXmYV3p08J70/dA==@openvz.org X-Gm-Message-State: AFq9FYLvWb0ZFDrBnkP3OSSEQV4d2VqWchQJ9uPpb+PnXJijcJLJnumV PWW7TKZkTdMJn77kv1aaRoycmXX6/ezyvgIQcMLxGlKU6UZxCUuyoZDCOkiEVWqmdCBi4T8IfG2 WFu+myHf0DTLJU2OihgLzinOIRq/KwPUAFAwd1vjfCCgv8c+IirzI7g== X-Gm-Gg: AYBFou1Zw51Fzc8S0nqSMqKvZobaa5nBr1mQ+9mABy4hZIsSl9YxQLvOv5FVWwiijXj AF48HNH+kocPvY5eAYtgOWB4f0l1Wh8bqcXIp/a6myW4R/6+LXJTysz6zLTVkhDLE1yC5gEeuhH gtQkgs4JconWHv9DLhA/CN8POxuwC8Qx5aV7VWEWA8LIltRAXijrQ5Dv1uH6USMSnFetJiEETFH 6G+tSfc2UwEoJ0MIS9/YZT0RN+R4/hcKdxScnMw6blFa2vlOcKguqt/5gXWi76A+rwrJiuS/zA3 DspFY7YF0FcMajIfDMm7NTtflWhHuoTxdulqZTbPfd4KKN52F8wfLaewTBJ9+mfMZEY/LyrPzJB Xfp1h6sZXl1125GSnkN/NWDU/58GuajeTsBsdzB1yv6CvcEn5vWIgRz6U64V+6s4PuLCyRcchoU alsrHZI4ste7vri38ch5SUhaynEB5fFKxFUw== X-Received: by 2002:a05:690e:1c0e:b0:675:3431:d51c with SMTP id 956f58d0204a3-6753431da19mr3707654d50.50.1790701130977; Tue, 29 Sep 2026 09:58:50 -0700 (PDT) X-Received: by 2002:a05:690e:1c0e:b0:675:3431:d51c with SMTP id 956f58d0204a3-6753431da19mr3707640d50.50.1790701130134; Tue, 29 Sep 2026 09:58:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1790701130; cv=pass; d=google.com; s=arc-20260327; b=lB4R4Wx5Emw83ryrmtdG4Pfgf2KFg+kX5fq9TwC14QNQ/UGtLGb5iBrxYojsDn0euE WzRDg09WqHmu6nb95KPuG0Bi0DlQCrbYccKDgLWANnIZ3VuwcM8epkHk3xA7fv77KH72 EH2BisjPiWqbHPQufKTA8b/+oh0Ky3PCXYG+qZb2D0rEZer5mFaV6HfTxeGvBS2R3jA0 yCrquCnZtO8oLpzAR4iF0V89YCdLBrgaJw0T5aqrXUDTuiunt1XV7i535lpiDhNUbYf5 aptsPhFJ3xpuGCSZKwbJS4BVYxAs2ksbISh91F0TKOjovHYn9kjSKo0T6pF3DIaSDyYp bOTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=7sB0sHpd6sADxqItgYMknJ/Q2/gaqipNKyJTj+KXonw=; fh=xAO51fuejxXwJU5EjvbxP/9Lw0EyCX4rtsnaQswDLbY=; b=pRxFopm3SBrQJ8kcyHbDhs9rfk8Vhnw19EdgrRg8qUTDI9+VTxmRqN7p3KoZP6YHB9 tb/H8tG7lIBrg9eTzDIVcmIQFzwPUsg9hNaQgo0KJBgV2QgZ4lC4wqV9a0WPNcWv24rJ 0dW3Mn7G2X9BWOWd46WcalEu6uzvpHXkKEVMU7wotkfCjilgyhtxqEWGZ1FNw9Jzube9 OfGjVB4iPgrogal0XtBsYA7pd4x28p2sIPhnleNnvCpuWDlRUFYCilTsXKxSZPocQQm2 KkEc0sVG6KaUwgWAk6w6rTXu5VaHITjmONuzVvFNTdFWw+4oREp5bnnvsNOAqDvu39nr COfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=SeCS0Zqh; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com. [2a01:111:f403:c200::5]) by mx.google.com with ESMTPS id 956f58d0204a3-675b76e440bsi131873d50.127.2026.09.29.09.58.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 09:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) client-ip=2a01:111:f403:c200::5; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=SeCS0Zqh; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::5 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tppFtnvbxk9KEjzYkfJFk6KTLfnJYXRLLjlGiJUdPcxpVtySSNze7kUjgl4yULHTiADP7L2dzrlrgCcN9edGNHO5Zg68a6GIHaFULv0Si7jf0UkP8dyChMCP2gCNvfEbybc+extrdqlLZ+T6wUyRQ63peZ2WCoBI5mUr9IXFEzOqr6iAbbnPlb+uvPaPeQ+jIio5t0yvirOsP4dZoohr+dpFPxmdy06jAC7qyvPz8hc6uhU44k8cT4851Q7iWbQPGjfShIxOIMJRDWuCSyNyTGmHX6+QjzuyzJW6IbSe9Izj6AP6ymhx7rFiaA6buNjWeXqA77TWmBIxbtuk1r7MkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7sB0sHpd6sADxqItgYMknJ/Q2/gaqipNKyJTj+KXonw=; b=e9Sr4n1A//T/6EIFX4FSpA+sJfsE6HzkpeHEphH/xyj7Rxso3bCZodN3lRFyIo+tUpmwcXRLzgejb2bH2C0aLxwPo9WmgXyHlujIw1s9HOyn6tiILzIkLnYU/nmDGFgYuytFl3AFoiyRq8s4SRLBVnq8/OkDSdq1t8XtjXtnh8CeySM92lXzGRYZcLyjHtCg7U039WrlgV93RDH3W2BI3qnkpPQ0vjd0JuggnqnSbUG6kjVzS4MIiVPNCshVQNTrOGILRKa8nzga8kWvkgkjUp4Hss+n6+MYn3TcegWUaK6Q2gnduFo1dBXXFk3CcHc0GAO8YQvP3nPKAqsokinQvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7sB0sHpd6sADxqItgYMknJ/Q2/gaqipNKyJTj+KXonw=; b=SeCS0ZqhlMQN5mvml6yyCLKlwKbfTEcZKUtYUUt54SuBH8X43YvOQB/z8UcTAgrgIqDnWNe3DPC974Efrx5LbXKQzia+thq3yPheZHI7r5o8wkE4Dzv70FjxIF76ItDmTyw9jZ+jFo1i3pQSM3nZNfvCG7+hbP8uaLGQp24BGmQksDMYCQwHyrKuFXMEYbN2a74Ir81QkXgWr20DpTq93/q/328v+0WWX1BOv6g5XP4IwFY9EIVtjOr24djNe9qRGmsynDbsDlflVfkA4/bkrTJty3XgJWpXh81I7luKX3FUW1CGfpJVc1d6AKuX4P/vaC/kPKXar5kG64lESD0O9Q== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by DB8PR08MB5385.eurprd08.prod.outlook.com (2603:10a6:10:119::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.14; Tue, 29 Sep 2026 16:58:47 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%3]) with mapi id 15.21.0472.012; Tue, 29 Sep 2026 16:58:47 +0000 Message-ID: <6f244655-ecaf-404f-95ce-f903d2bd6f21@virtuozzo.com> Date: Tue, 29 Sep 2026 18:58:46 +0200 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko References: <20260928-prep-kh-vstor-138640-vhost-blk-vq-mutex-v1-1-48ae0775bc8a@virtuozzo.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <20260928-prep-kh-vstor-138640-vhost-blk-vq-mutex-v1-1-48ae0775bc8a@virtuozzo.com> X-ClientProxiedBy: PR3P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::7) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|DB8PR08MB5385:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fe5d390-c58c-4dae-30d5-08df1e4aedb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|1800799024|366016|22082099003|260925021911599003|260925021311599003|18002099003|260925022911599003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: SmxYWjzNsON3heM7M3yAER+xei9s4gcUzOwVCwedQimnQJcuJCQjAsEKarcMjMNBlhLETt1G6AmdH9wfkP/UAFZ1Sr1ZGAXAhY97CgVFduH52FR7Dr+dPeCAiSYlr5B46i1iGEnBZXEfXzhqBZvdYPl1+U0JfxhjKQNKchjmchUHZ1RYfz7jYFLZZyXf4LMnymcXxNPeGQhojccF6M+emkDB2q5PxV+FIfwKk5GxlS31ziEUnTSEPucH6YQvs1KYDZ5eFyw5TXG5Ua0+WvWqB1qN43c66QFnpgceJQeEpipB6XrMwZBFh/JFysCHfNhlpilAAIwkh++CxeP7+sX82SO5iaqrCA6nIsAt88LK8UThS8IhikQQzb6bAxSKulvcptiYDIfSe+akEIB0xYZ669jgUW2REHU6NAneHacUm9bn0yYRxSR2PSL6oKPFpuWyTrwm/rVRRnOoPn2gTOVexMEj7ntFwhS0UL+RcUuIG+p2TS+z+dFgUWKQ9KzZhT+6QD40U3IgyliuwewFkFYMRHqIQ6c7MeCHMPnjseOrdMGbNEHlTSE6q3ojONXXpgKYGZxd7LlkOq4wSVcfO4cBRg+6T/Zcaxz+hPNe4HMgoM77SWzDOy2G8dTVxZkAQwTo7/WxIqLqw7HtxmZpYBuZZOr63s5mkwDiKVuupVaIzVQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(22082099003)(260925021911599003)(260925021311599003)(18002099003)(260925022911599003)(56012099006)(10067099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djdoRkhEY2c2dld2dkdVNXhDTTRoWEQzMmIzQUY1RitCd2ZOMXE2WSs1Yjlj?= =?utf-8?B?NHdhOVZVa0t0cm11N3B3V1R4ZDVHUCt3VFpsYXp2TUtLQmhvajNxOUlNdnNQ?= =?utf-8?B?ZG9Td0lwNEU1ekpNazRhbjU4bElXcG82TEU3SGFDcDlWVWxJQ0s1c0psVjY2?= =?utf-8?B?RGVuUnpVSWY5L1gwOHRXZmVBSGpyRUVvYjhmZk9HMW9hODhWNHZ4UnBMTWVZ?= =?utf-8?B?WnBxZzYzeG1WM3BnQ3BLeHNrMUZpbEp2MGFxNm4zWS9nZFM5akFhc0lXWW84?= =?utf-8?B?VkxsdlJ0ZEg0Y3Jvc1o0K3F2azVyUUdkeEdFSVlkUnZaQnE4elh0ZGYwN2l2?= =?utf-8?B?MnNaQm4yZjQxZGRBOXgzaDU3a3NwOEtkSGVqc0RiWXNJM0phZUJtcmhyUDhL?= =?utf-8?B?ZHVJYmtZVldDTjJkRjNka2lTYktwaEt4MTlXU2N1OWFjbEdnNGkxVkplYmls?= =?utf-8?B?TTI2eEI1SjZwaUR1SzFTT2VmWGMyOUxsRFpSOW5yNHFwWGJzNDhlU1pXc282?= =?utf-8?B?SzFCOVJMSStmWVZ1ZGxJWS8ydWY4M3gxQ2pJNTVwaDE5WmVKRE5DVXQzVzZ1?= =?utf-8?B?L09BMjQyUHl4UncyWTFINGJNeC9SVkQyblA1akpzak9FSnhMU0V4MTErVk96?= =?utf-8?B?dWlCalZRcjY3TUxaRHFwODJkU1NKc2ltdEFuV3ZIUFNLeEhILzlPL2pTdTVW?= =?utf-8?B?STFvaUZNL0czWXFzWjkxMlVTNFlCTG1QMU5wU3M4ZTZ2Z0lEemZkbXEzaTdy?= =?utf-8?B?VHMvZ0I2MFU4K2ptaEEwQXFNY3N1Q0hzMmMwc0RXbzRaRkI5UEt5ZGhmTEZL?= =?utf-8?B?VHR4dnMweTlPUTlITW1hWWRyMHkxS3VtYUwyTUtCMi9sVFdzRXRGcTZDUVBo?= =?utf-8?B?NXh4TGZHNGR2eXpFNDZzTXpLem5ZTmMzZ20yOUZHSnFjWWtkdEpWQzQwTXNW?= =?utf-8?B?aGwrNmxGNkFuTVR6N3ExS3lPRWhkdGlSZlIyb2UxS2VTanZmRFFaNzRoaXBh?= =?utf-8?B?L2lFVEl1eEU0aWRmemp0SGhuVmoyclpkaHcxakUzR2habVFGUEFtY2VUVHAw?= =?utf-8?B?UTBCdEhzUlk2QksySkxMQnlLR0sxdEZDbXZaM3hwZEk1TjZjS2NyZ3VaWnNW?= =?utf-8?B?eGFEbjdoY3FxM3RtVFBDb0piUUJ1QW1SQzU5cTVlclUydG9ZWm52ei82UTBV?= =?utf-8?B?bnFpL25UN0dzYmxkWHdYcU1GUCtmUUtlOURLcTZxV1VIN1ZRR0ZieVJLK3ZK?= =?utf-8?B?RHNlWlVteUtCTFlzd0RhcDllU21oSmJBQkEvYS8rZ2RKa3lveW5IVk1lV3V6?= =?utf-8?B?RklnclRxRklPVWYrUzYwNXArNGY4QVFCQVZqNVA4d05jbzdDNGRnUzcxYjhY?= =?utf-8?B?Q2dXOWo0Sm5HRFU2bHJiLy9WNVptV0RTRlpQb0NwVTBqdFdvZUhseXJLd1hi?= =?utf-8?B?RlQxaVA4VzEwbkJiV0FoR09oRkk1Y3Y3SDRha3h5Z1RUb0FpVlRLd29PQU80?= =?utf-8?B?dWtOc3pSeFRsMk5RckpUNlkvandwVGsxMnJIUzl0VDBabXRyRy9sYXFVdElx?= =?utf-8?B?bURVYWlNc2FENmgza0VVR3hiRjkrM1Jqb1p2ZmFubCtMdG92SkJBS1dPeExN?= =?utf-8?B?anJMYVJOaHE3dkpyUGZKRFhzU1FJU1pucVgxbTVWQ3lkZmVGenA5QWdFQmkz?= =?utf-8?B?STRsNElUR1VHQVpaSWl3RnpmcjJXRVJDV3Y0QitFbEU3RGdqbjJyMGpZTkw0?= =?utf-8?B?clZkTk5EaVJQODhsYWRYNDNiZkJocDBTaHRxb0lzOVYrN2hsNk92NGg0WmlF?= =?utf-8?B?aDRIN2NTR2JYYk5OR2xXWEdZdHEvT0JtQ1dGVDVCMXBDZEh3NUs3c0tMU3JB?= =?utf-8?B?enF1SFh2VzBOb0hER2k4TFVrTzd1UzB6WmNneUlJSkhHdGpqZmNmNi9Dblcw?= =?utf-8?B?OU1zY0M4TVZsU3VjWm1VUVZGaWhEWUhXWjFFT3hGN2s4S3QzVzVtUTBzRnRQ?= =?utf-8?B?NGFsM1cxbmZiRFU1aEllZmNXVEVkSzFBdytZSzZqbWZQL3kvOXdiQjVtUVUw?= =?utf-8?B?TklsYmZGSlgvZEdhQXZweHd4eDJiWDExNmZySEVjZ3VLVE50K3MwOGp1Y0FX?= =?utf-8?B?aDhOWUlsZlBReXZDQnlwMnFQZmdSRXNIbjNUeitLcmQxQU00dUdWaU95MGhl?= =?utf-8?B?YmU0T2ZiYnZaTzVvMVkwTlJ3VldmVmVxYU1LeXhHaHQvNExrQWthbEhDSUth?= =?utf-8?B?NXRGd1hVVzIyM2hERk9DR3lDL2I3WmZEd1JLUVBUYUQ1V0tMN2RIMGVObEUv?= =?utf-8?B?eldSWEdNVDNaNG5TY3NiUWVKVVlKTDNtbVdYajZMTDMxZFk4bUNqUTd6dzd5?= =?utf-8?Q?yaAQct4/vk/5CNts=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe5d390-c58c-4dae-30d5-08df1e4aedb9 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2026 16:58:47.6097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0cAn8khi1dE4j3FFnRXCVI1yJNVTrb2mZkQk4Sc9IWwd8r8p//CSpoa9xWmqkxZH0mI9+VRPIjTHdXkyl6nXZD7tHaccE7KlX0UnoPoZOwk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5385 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH vz10] drivers/vhost/blk: take vq->mutex in the kick handlers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org LGTM Reviewed-by: Andrey Zhadchenko On 9/28/26 17:25, Konstantin Khorenko wrote: > vhost.h documents vhost_vq_set_backend()/vhost_vq_get_backend() as > "need to call with vq->mutex acquired": vq->private_data is a plain > field with no barriers. > * vhost-net, vsock and scsi all take vq->mutex in their kick handlers > * vhost-blk reads the backend and works with the ring without it > > On a weakly ordered CPU (arm64) the two stores can become visible in the > opposite order: > > CPU0: VHOST_BLK_SET_BACKEND CPU1: vhost worker > ----------------------------------- ------------------------------- > blk_vq->req = kvmalloc_array(...); > mutex_lock(&vq->mutex); > vhost_vq_set_backend(vq, backend); > mutex_unlock(&vq->mutex); > > backend store becomes visible > f = vhost_vq_get_backend(vq); > /* sees the new backend */ > head = vhost_get_vq_desc(...); > req = &blk_vq->req[head]; > /* sees the old req: NULL on > the first SET_BACKEND, a > freed pointer after a -1/fd > cycle - a NULL-offset oops > or a use-after-free */ > req store becomes visible - too late > > x86-64 TSO forbids both the store-store reordering on CPU0 and the > load-load reordering on CPU1, which is the only reason the current code > works there. > > Fixes: d8722ff88c5d ("drivers/vhost: vhost-blk accelerator for virtio-blk guests") > https://virtuozzo.atlassian.net/browse/VSTOR-138640 > Feature: vhost-blk: in-kernel accelerator for virtio-blk guests > > Signed-off-by: Konstantin Khorenko > --- > drivers/vhost/blk.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/blk.c b/drivers/vhost/blk.c > index fbdd04f5a7e28..b170439a1806d 100644 > --- a/drivers/vhost/blk.c > +++ b/drivers/vhost/blk.c > @@ -530,9 +530,11 @@ static void vhost_blk_handle_guest_kick(struct vhost_work *work) > blk = container_of(vq->dev, struct vhost_blk, dev); > blk_vq = container_of(vq, struct vhost_blk_vq, vq); > > + mutex_lock(&vq->mutex); > + > f = vhost_vq_get_backend(vq); > if (!f) > - return; > + goto out; > > vhost_disable_notify(&blk->dev, vq); > for (;;) { > @@ -580,6 +582,8 @@ static void vhost_blk_handle_guest_kick(struct vhost_work *work) > break; > } > } > +out: > + mutex_unlock(&vq->mutex); > } > > static void vhost_blk_handle_host_kick(struct vhost_work *work) > @@ -594,6 +598,8 @@ static void vhost_blk_handle_host_kick(struct vhost_work *work) > > blk_vq = container_of(work, struct vhost_blk_vq, work); > vq = &blk_vq->vq; > + > + mutex_lock(&vq->mutex); > llnode = llist_del_all(&blk_vq->llhead); > added = false; > while (llnode) { > @@ -627,6 +633,7 @@ static void vhost_blk_handle_host_kick(struct vhost_work *work) > > if (likely(added)) > vhost_signal(&blk->dev, vq); > + mutex_unlock(&vq->mutex); > } > > /* It is forbidden to call more than one vhost_blk_flush() simultaneously */ > > --- > base-commit: 0679f0d70523972eec3a0643565521d93e26eb9c > change-id: 20260928-prep-kh-vstor-138640-vhost-blk-vq-mutex-84a1a46032ae > > Best regards, > -- > Konstantin Khorenko > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel