From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id EB0E580474 for ; Mon, 26 Oct 2026 12:38:27 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QCbAPB010690; Mon, 26 Oct 2026 15:37:11 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QCbAPB010690 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="S+972vy3" Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69QCb7rJ010686 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 26 Oct 2026 15:37:09 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69QCb7rJ010686 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2eac6e96bd4so14093815ad.2 for ; Mon, 26 Oct 2026 05:37:08 -0700 (PDT) X-Gm-Message-State: AFq9FYLDmT/FGoN7EDrPtefT5Kkd12cz9IpnrG+Zcc45CGaeNjxbJ6Fd mLKXeQ3JLNYvnpiqdM0mRyoHTg9CsEMt6KKk0Apu7eFKbhxkJDLQk6lla0RUcU990JoHfb6uUqD BQQwPSZmMvXxtlwt3VdRMTjOGzfNqDf0mWTmnQMqjcUhqowOBzLb6ew== X-Gm-Gg: AYBFou02vnUY+mJ7r32j34pN5AupZclX1ypPbceg/CCnf31IkB5VeZlafSXnqTrbiWD FamLTZt+6x03EwiHD0MXSYnK7fcREU5z3MM0dtfFvn6DRwiXpUxhar4KtHtVw9gqT4JZSHuudWP VM2zfW9BgaUc4dv6XZUwphsTkI6rJf7iCu3TjPj81jrhW3y4HHRm0XK8Vbhz6f/oLfm0nsfwrHC nBYdxaMCrvPmwc2RyUA7DjgSOpqMa4IdFQWy2tE4QaA8VDNfLgUektBYfUCqrExcX2uw5d+o2AG wSaaFurtBKpDuE8zvgBuvxucfULlne61NTWETMuFuHQVRWHNfN5dTlVywILj7LEA+736yZtNgPj s5HpND/znUwBs0MXcDMIsKTBmge8tIKQVe6PE3KVIpDCkpNjziy8RuimofrSbZLuJZ4G+nPbfYh uCuHsMTQvvD7iSuEKlz9xsZIifx96JF6vZ X-Received: by 2002:a17:903:1cb:b0:2e9:5008:3ecf with SMTP id d9443c01a7336-2ea9c12fefamr57842905ad.3.1793018227268; Mon, 26 Oct 2026 05:37:07 -0700 (PDT) X-Received: by 2002:a17:903:1cb:b0:2e9:5008:3ecf with SMTP id d9443c01a7336-2ea9c12fefamr57842555ad.3.1793018226572; Mon, 26 Oct 2026 05:37:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793018226; cv=pass; d=google.com; s=arc-20260327; b=pSeyjF7yrrKyqQk2RWU18UhwRESoZFUQIP+S0vS0Jnb0G1EHI1J2fIgPjlJjmOP7fw DexGGcGH4M+hnwZPatXlmhSyzyfR9E3SbDu6gvZTaH48a3Y0wECCHvkzDluMkkHkT7/K Uf7JAKrxUd823zwKFVXP6uENwdyi/gkPYNziMGnd8snzjnh62+Zgxh6IDehjmtdd30pU zmRRfd+/CdGWvlfdabQlgw+9lCHT0Gq7NLG+F8RClxGX0BIlrA7uyMFBjB5F/jI8iQtC o00ZgaVNudR7nrMjkUrYnci2nXfIsOS4uBt2RkhF0+Me+wavymupxCcWXwsj9oGeUmKj Ekxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=mVYSN3ZEuv1/3CaZjCLU2XFOYaovszdjY3OL30wh+I4=; fh=PQ9u4oqSSilxvxB4IBsJIx5D182yvRMdCSndmo/gcL4=; b=CidFVaRUulT2fHagpC2nkv63o1wPFHkr6GM4z8mXNp11eW+FIbVi/yVr0pC7wq9j0x S8QxBKjPeOtN3zK58mz25euF3BC9RbZP3kDqbZb3x3qxdFyXPYMnlNvVsDSFWkldTRO+ FBnQCr2pMFWJMJ5kGnCS90DTQk/9XRCRT/As09nfy+jDPLsf8/AsDIhN6SHFeqTuXOLJ 1SRJCaGkbEM6BYdyVRPT7e3z1mFMInO8o7UDFoR/7aAZmcnpiA5HI5meXDjfzfjWUhee LfbxlWD/xBvKFo4fC6gdC1y+wXy8BFgMIgL35mHGPtcDQ9f4BKFf7jqya9Y2hKvDujoL yF1A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=S+972vy3; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20f::7]) by mx.google.com with ESMTPS id d9443c01a7336-2eab0e5ac10si96590225ad.96.2026.10.26.05.37.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 05:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) client-ip=2a01:111:f403:c20f::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=S+972vy3; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iTzbihY0f1EtXgMeJnYIrd535O89FF4+DKHtxV2hn0md23gS9XS5S+XsK7ijmVuAvsrorM6geQ9sGelqlj36r/+Np3Agju3NndHfuKnwlLYD3scNKhwUbwzic+LDddVpW1V98NH8bJeaJIeH/GzVBxsYKDuXoie8Y4kiRezSP+z8fbZ1bTipmzqFOTe67GoGexOR1Bj9vNKJbrjvKE6KzQsFnjhgLpFgjtAKWGjdcUx9cVOWy3tVqPdJa+C+gt0yZquceehTznZaQLdO8ou5JBb25RLLnEaNO8rZD/wfrVUoqsY+rioWQUNzsQit8jqy9PSL4fw3OrAmVO1FEfb5bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mVYSN3ZEuv1/3CaZjCLU2XFOYaovszdjY3OL30wh+I4=; b=U0HBwkyZV00FwLPFcq09J3cGB0ELDCEZ69O1l420HgIqCdc0f78IsH57jHA0PLKeYWHSxiK0oXM1xCK06k+/FqFDn6VsEAizOpMS3hdxP15nTr2iSoD/ITXXsZfQ31oA4Aw9W25/IxQd0mOzgtjUGFNGagEslJyqgUB2dG1jsz7GhusMtzZVvGMk0FRBdZMefZxYSEKooNqzXu1MEqBpEW7F5CABYEy7hzd8dtx7l6ZO3XEf6ND0fYkWigH1y5rTOEOL5VztQQz6t/+bezBqlvLnxM2cZ8OuuSDZfv4H1miBZMi7xvi8WqWUlGuZ21jYaoHuR/+Tf8dGbjm9+hStVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVYSN3ZEuv1/3CaZjCLU2XFOYaovszdjY3OL30wh+I4=; b=S+972vy3ZNWn7uhkvI94DJ2SIeXGzZMC41WSlu1uIY1i8n6Tbq/ZY5ntHGaNIfZcq3zqwkNdc/xIXrMn0LCktaEwnJfbcVd0R0BF3zAQbrd/vbhfwEUEaFDnPRi9/SExFh4CC1tnQiMLPiXyaKypBDsth8z5DCBMAA9nMeEKFa5/T1yYU++iqimoEa8ID/lsU1W90S61HnaJsGuP5WId3YZ4TXrorWY3DGiEivZKCo6ozDWweDnmK+/cT3WKIL5kr8s4aESN/7RoOc5Wmr2ktWcSFmfDRPGSkezi7wwCz3CJC4QvXmAFWi2Jc7f5WUzX9CEcSqEamUFor+jrOjrNxQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by GV1PR08MB699232.eurprd08.prod.outlook.com (2603:10a6:150:802::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 12:37:02 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0546.021; Mon, 26 Oct 2026 12:37:02 +0000 Message-ID: <6f4b6fe9-e008-4857-af87-b05923a062f0@virtuozzo.com> Date: Mon, 26 Oct 2026 13:37:00 +0100 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , ptikhomirov@virtuozzo.com, vasileios.almpanis@virtuozzo.com References: <20261022-ovl-use-orig-ve-v1-0-da84c00c8065@virtuozzo.com> <20261022-ovl-use-orig-ve-v1-4-da84c00c8065@virtuozzo.com> <010701a16430b31f-e56803c0-e929-4678-bd6e-403113fc2ef0-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a16430b31f-e56803c0-e929-4678-bd6e-403113fc2ef0-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|GV1PR08MB699232:EE_ X-MS-Office365-Filtering-Correlation-Id: bb310a09-208c-4cf1-4461-08df335dd5ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|23010399003|376014|10067099003|18002099003|22082099003|3023799007|56012099006|5023799004|4143699003|261021121427099003|261009223027099003|261022105027099003|261022075727099003; X-Microsoft-Antispam-Message-Info: SjPVfFkU8U2bsnGHlevCST43FN0UfbQZJ3z8WUnd8AKxbOH5KZXHawM494S+rjXDnE8/R6l/4Q43Tm/6/389q7qy8yEqnrnlCadDrgt8Eoo/QW5VFY44KQDEX7d5ZpN4/7ykGWnwpXkmc4+4Rx7ecGhBBTuT++yq+vUksewJjFDKQ2B1mep225hETupwjSRDSZPydovu5TN9phbFIVG4CB2anHj1jRY/IzfXtrZ6gkYPPfh38pMCCEEiR5wbj4NT71xh7VIOqqgn+s/GO9eODxJN39tupQIlYT95+UY8mhN94/DoeWV7C10VrY7l8HN9bqP3o9Az6otQILjmxXbtQJb56XpK0M+JY7RdipAA6XQqK0N96uBub9/dUBLEFSqQ/+G6a9x9pQe6aiY3diWRc2Kuu1jrVqXpMo07yQhGPyXvAjAcXctQv2pkX6g+u5+vb30t/NMO4TiSUkSNVyRUrhil5Uh27uG/weRlrVZaW1jquWpbP7J/YYR+oTrVtlbl77dn6RNY6RV/wjE3ZKAB3HzkVzs9QnzYuQ8Rn4N+6zee+JJJ9GX4dxyegejDJA+yjvRPZw1DR0NcVMpI8RFq2fZ8em2iSObLR7S31ZQ4XH6cNaIX9rkLVFBGctvLfQrY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(10067099003)(18002099003)(22082099003)(3023799007)(56012099006)(5023799004)(4143699003)(261021121427099003)(261009223027099003)(261022105027099003)(261022075727099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnpEWWowV3V4c3dwcnBGSHBqejlCSDd1cnc0eUdUWkhacGp0eXRydW52VDM2?= =?utf-8?B?Ymk0VDRWZCs4QjdJUGhsMzBoTlppUjZicldUek1DQW4xbDR0QnV2b0F6cVBQ?= =?utf-8?B?bTJ4T1NsdW83bUsxZXE0Y2hOeWluVXRvd0Y5MXkwbUFEb3YyRFdYS1FBZ3Rh?= =?utf-8?B?b2MwWWI2cDg0Z2ZxKzVLZmk3QmJSQndBTGkrR3dDdCsxdVVCaDhkakNucHMw?= =?utf-8?B?UVYyMUpPbWFhL1ludlRRZGpYVXdQbXlna1NjbHAvb2xqcWFia3BlYWhETW8v?= =?utf-8?B?cUdUaWg0Nlphb3cvdlpYbStMdlV3ejRxQUdXc1pZSmh6bDBEVzBQT1BRZHE0?= =?utf-8?B?WjFMeWpHdFhxTG1IN25Oai9xOG5lWUhUYytGY09WV3YxVXBJVGJ4MlE3QSti?= =?utf-8?B?d3ZxclBRNGFYNU9ZZ3V0bnV5SmxXb1dJcVBFOFNYSjdYNUJnYkduby9FaldS?= =?utf-8?B?d29UdUtzUEFlVElQMERYdWRrN2oybGNpeHl5ekFhK0JRZ0g1d0xLeFVwenlE?= =?utf-8?B?eEloWFBRTENKM0tTTkRmVVova0o4d3hTVW1DUTZyY1dDUWNTK09wUkpNbE1j?= =?utf-8?B?NmczQXgrQldrandZK2dMSlV3QkpwUmhMUnpUeXpPU25oeENuZWRhenp0Tk0v?= =?utf-8?B?cWY4ZlhlTnlqUFdFdTNSWjZyOW5rMUgvd1VNeW10UU1hQ2dWdEFYYmJpZ3RN?= =?utf-8?B?T0FhaHlIZHc0dkMvNk01cHlGREtRbjVWZldZc2NQeXdNZm1venRVT0Nsc3Jq?= =?utf-8?B?L2hVMWI1b0tpRFFiU0UrdGNOdEEwUGJEc29hb2VGRE1md2gyR1ptSmp3Mm53?= =?utf-8?B?ZGI5S0x1Z3JRcFdmdWMzK1p4YkVzbGtEZGYya2gyVHNQWVlCREY5K3JTQ256?= =?utf-8?B?YVVqakRVODVMeEVsdDdMdHN4Y1JjT1VjSDExdkRRSFlNQWJNdXdrUkZDZHdG?= =?utf-8?B?bUVJWHQ5Z0Jacm9wWm5JcGhmRzI0R0tvSWtHdkM5WDg0QyszcHVaRy9lU2wy?= =?utf-8?B?UDVRM2hGZmNyWW1JQlllNHRwbzVjdmliWHd1aVRDcVVidXBTSTd4ZkpFeUdm?= =?utf-8?B?dHJSazZKYVZmMlpXYS9mUUJxdWdQTkNFS0xQT2FyVk9UWTRIb09ocXRackM0?= =?utf-8?B?RDNpVW1IVG01cXIySzlDOEJ1SUJLZDZ2SXV3SUZGcDYxM1BiYUhIUm15T0V5?= =?utf-8?B?eFRzUDFCL2oxQjYwb1ExQkRZTlhQRDh6cWFMRGl3YzlxSjZBN2syUUsvUk5r?= =?utf-8?B?ait3bHlwdHlVMUFtMkhrQ2p2WDFkclhQV0l5aWpaSW4vMWNiY0dIak9aRGRR?= =?utf-8?B?cjEyWWVKMzB5WmpLVnFOeHFGa0xOT010VWoyTUphTDhpZDh1L0dNSVJaamVm?= =?utf-8?B?SE80ODlXR3R2cWZGdHFNaFVXamdTQWIxSVRWL1RieENEL05xNVl0OVJabXhs?= =?utf-8?B?N1M0bU41WndVcW1NV3Awb2JPRXcwZGdHUThxRkVITjFhd3p3TnQ0S0IyMGpS?= =?utf-8?B?d3BPZ3ZubVZuTTR0NVdvdzFaeDBlYnN4ZmtmTE9scEJDSXVaTG1pZ00vNjVj?= =?utf-8?B?WW9QNkJxREhzVmxVbTltbmNLczBYUm9iSVVTOG12NVhCQVhaNXd2SmhaanZ0?= =?utf-8?B?Q1FiUFp3c0JPbmRVY3lTNzhhNUpONG9yalpsMGdxTFg4ekZzZDlhSWJCSDRn?= =?utf-8?B?V243SmV1SlVPYktQaW5FUW9kKzRqMEp5SDdsMG9haUNUbXBmdTYwY2dVNTYy?= =?utf-8?B?UHNud2ZhTTVGRDZQYno4WU9Jdzc5QVZsL2ZyT1hDVUZxd0x6N3dnOFBqdXhJ?= =?utf-8?B?Nkx2MHdRWmZLbGZxN212TXVtMGh3RWlRK0ZTK3BWcE1ZZjNDSm5Wbkt5cGNo?= =?utf-8?B?NSsxMEdaVzVwcXdtN1NaUmY2ZkZTb3o1bEpwQW5WOG1SOU5UZ2dWK0xYTXJE?= =?utf-8?B?d0xiY2ppQko5LzQ0cFpodTVWVE5mdENudnZINXJsK0NxUWNLTE9IN3AvMS9j?= =?utf-8?B?L2hHTmdDb0lzT3RjcEZoUU1sR2o3TUpvTDZKOFBJcEVybGRGS1hVQlJvNmpJ?= =?utf-8?B?RFB6K2p6M09mWVBjSWlUUmo1TFhkRUkvN1pBMzRqTWlVQTQ2T3J0Q0x5Y2lY?= =?utf-8?B?Tkk1SWRYTHluOFJzYzVZdWZrTGdRVnhqWHVWb1cwa3pyWmhUN1VkZTlRQTR4?= =?utf-8?B?VHZORDBLYXVMcVAvdU5tWFMyMUV5UmNGeG9kdlZsOUhVRlNLaVA0K2gvWFl6?= =?utf-8?B?eForQ040bW1UM2xQWGhkSXp5TTJ0UzV3RHlNeXkzbWxzdnFPaW9FZ1FrUHY5?= =?utf-8?B?RkNQZGVleHNkUkRuOHR0Yi9lOFVRb25zRS9ka3owZG9qNjRtcHY4NXVpdGdP?= =?utf-8?Q?IKdNUNcqjcB+Z3Qc=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb310a09-208c-4cf1-4461-08df335dd5ad X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 12:37:02.0210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MnjfGJMLokmJhDjWvn6vkXyt5esho3eeO1bXv/dpM+rcoL77pP5+9mfkUU8WPhs8jhnVb3HtOelCYp8wb13Zxyl5RocA6Q4OYgmsJdDAXCM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB699232 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 4/4] ve/overlayfs: Override VE together with creds X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/22/26 17:17, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > - [Low] overlayfs: typo 'inforamtion' in new struct ovl_creds_desc comment Will fix in v2. > - [Low] ve: override_ve()/revert_ve() store current->task_ve without WRITE_ONCE or task_lock > - [Low] ve: override_ve()/revert_ve() !CONFIG_VE stubs are x86-only; overlayfs now needs them Already reported, will fix. > -- > > commit f580a7811856a41f48d8fc37ebc70368ebd6d989 > Author: Vladimir Riabchun > > ve/overlayfs: Override VE together with creds > > This patch changes ovl_override_creds() to return a struct ovl_creds_desc > holding both the old cred and the old VE. It adds ovl_revert_creds() to > restore both, and converts all overlayfs callers. The aim is to make > ve_capable checks behave correctly when a host user accesses an overlayfs > created inside a container. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-142405 > >> diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h >> --- a/fs/overlayfs/overlayfs.h >> +++ b/fs/overlayfs/overlayfs.h > > [ ... ] > >> +/* Credential inforamtion used by overlay */ >> +struct ovl_creds_desc { >> + const struct cred *cred; >> + struct ve_struct *ve; >> +}; > > [Severity: Low] > This isn't a bug, but there is a typo in the new comment: "inforamtion" > should be "information". > > The commit message also has typos: "swich" should be "switch", and > "Stroing" should be "Storing". > >> diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c >> --- a/fs/overlayfs/util.c >> +++ b/fs/overlayfs/util.c > > [ ... ] > >> +struct ovl_creds_desc ovl_override_creds(struct super_block *sb) >> { >> struct ovl_fs *ofs = OVL_FS(sb); >> + struct ovl_creds_desc desc; >> >> - return override_creds(ofs->creator_cred); >> + desc.cred = override_creds(ofs->creator_cred); >> + desc.ve = override_ve(ofs->creator_ve); >> + >> + return desc; >> +} >> + >> +void ovl_revert_creds(struct ovl_creds_desc *old_creds) >> +{ >> + revert_ve(old_creds->ve); >> + revert_creds(old_creds->cred); >> } > > [Severity: Low] > Will this build when CONFIG_VE is disabled and CONFIG_X86 is not set, for > example on UML or on non-x86 architectures? > > In include/linux/ve.h the !CONFIG_VE stubs for override_ve() and > revert_ve() sit inside the "#ifdef CONFIG_X86" block of the !CONFIG_VE > branch: > > #ifdef CONFIG_X86 > ... > static inline struct ve_struct *override_ve(struct ve_struct *new_ve) > { > return NULL; > } > > static inline void revert_ve(struct ve_struct *orig_ve) {} > > #endif /* CONFIG_X86 */ > > #endif /* CONFIG_VE */ > > ovl_override_creds() and ovl_revert_creds() now call these helpers > unconditionally. fs/overlayfs/Kconfig has no dependency on VE or X86, and > CONFIG_VE is a bool that can be turned off. > > With CONFIG_OVERLAY_FS enabled, CONFIG_VE off and CONFIG_X86 unset, the > helpers have no declaration, so fs/overlayfs/util.c would fail with an > implicit declaration error. Should the stubs be moved outside the > CONFIG_X86 block? > > [Severity: Low] > The helpers called here, override_ve() and revert_ve() in > include/linux/ve.h, store current->task_ve with a plain write: > > struct ve_struct *old_ve = current->task_ve; > > current->task_ve = new_ve; > return old_ve; > > Remote readers such as get_task_ve() take task_lock() and use READ_ONCE() > on task_ve. The writers take neither task_lock nor use WRITE_ONCE(). > > Before this patch nothing outside ve.h used these helpers. Now every > ovl_override_creds() caller, for example ovl_lookup(), ovl_iterate() and > ovl_copy_up_flags(), flips task_ve for the whole duration of operations that > can sleep. During that window a remote get_task_ve() caller, for example > sched_show_task() or update_sched_lat(), can race with the store. KCSAN > would flag this. The remote reader can also see the creator VE instead of > the task's own VE. > > Would it make sense to use WRITE_ONCE() in override_ve() and revert_ve(), > and possibly take task_lock() as well? > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel