From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 54421802A7 for ; Sat, 3 Oct 2026 12:27:26 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 693CQ8nI003572; Sat, 3 Oct 2026 15:26:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 693CQ8nI003572 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="yz9uipws" Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 693CQ7wP003568 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sat, 3 Oct 2026 15:26:07 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 693CQ7wP003568 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c293e604f0eso55859266b.3 for ; Sat, 03 Oct 2026 05:26:07 -0700 (PDT) X-Gm-Message-State: AFuF++l8Osbt+U9Nabkqs8tz+BrfUYadrhIEHZ91sBDa2mN+P3hpblE7 EXVI1ldb51JK7peMBJbDnSByK8C/t21XW0OBuAaWSmIU8nU3BghUUYjaXvnJaodZPpgo1b2aH/r YJYON4cEkXrq21lr6ZMl/3mrTdZpHn0dlWEpuvFfUMqOpkDZvlOE6Pw== X-Gm-Gg: AYBFou0PVBn2mHaNDJgCJOKBXRp/0qjP9bviBMA9rxXvslcbUqe7THWaGaR+XV2oKP1 VOdMHwOxlFl4Snag+hLpcj4h18iky1T15jnuygqRoQRV1Qb99KDcv/aNo3wRIjlYGLL24oP2thv le5OkuVvuVk0D8HV2VVhzN888o87QY+9kTywwy4Qhlv+Om3YpxzqW7GCRRbGntf30wzRE9RIi+7 w0wFp3kN4nP0o00vqBO5eXEZazx/TeYnfsSb+DDvIPugJyn581md399FyyazRgR360PU/hgpjN2 g1zWW5r8WZO3/oab362mQo8mv/s/oUYNqo3Dm+/P9Xx5joGW8IXlN0joQrz/soNRE9/23f1ZD/L 6NcPnZKZvGCdpeB/W+fRUEpTCgU5b+bD407RKvOkzhu4EdCT71ENLJFUikEdhcrnMt62vT/IV+a sOc68tWToI8sK+Y8tdmMmeE+OcStI9tW0x X-Received: by 2002:a17:907:c21:b0:c2e:65ad:d72d with SMTP id a640c23a62f3a-c2e6ebfd3a6mr202582766b.5.1791030366881; Sat, 03 Oct 2026 05:26:06 -0700 (PDT) X-Received: by 2002:a17:907:c21:b0:c2e:65ad:d72d with SMTP id a640c23a62f3a-c2e6ebfd3a6mr202580966b.5.1791030366345; Sat, 03 Oct 2026 05:26:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791030366; cv=pass; d=google.com; s=arc-20260327; b=WSeF1rnUAvQXRb4NXOwPtGl58agOGdEGFW7p0DxrqdtL09HNSid/lrEU51f6G0WvJT vz7Iwpbm19ZPYEHRrd1M+6pvbTNBEoJ8Dstm+Xi9mfP6Chxy4D4VoSNSM7VX00dCcuuA oM+MGbEg1VykN2N8let+VnF8imDiCpNshERt0pyYPx1BzVOrBH92DOJKEUdVN6CXk43S EZkDq1wxad0q6S1CGOhEeurUSw83kt9oXiAIulsgwZXwDyyZu/yDt1qtmvIgzgEAHFHO EsQGW9jajmEPImJAQICjYEYTX7Clvj7qqRlK8u6YIiifahpqbSTozeYdisg8CLeSdAO2 OsaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=nGCn/7u7Qpk3bNlG1zKxEE/pP4PBdbxe5zAdydJCYzs=; fh=A7R+PbrUHauVvppXKl0MrUrmlodzEiz0O3zRHlzVAvI=; b=pTt6AnF84Z4BDC0tG75HFWYCgmEv7/Zseqcj0ekv2E48v9k4+APMJLCD9LVblx5UA0 CXEdDqsOprkB9cc5EcWHelV1bG3H5B92UaySNnBIuhnuoEE9sw35JtHOQmQkomDnOkkm 7A9+qkbcqCrZk53KhRSeu80GD+V38UV5BfddLI/oAYWdZNStt/1PYDRSkdwZgCbqrp4h vuOiciCBykgTH18acKstdmgJ+PznRX0ybNK+3N+vMveedVTJq2RouLBmPiwbsbBqn6MP 4NrL9R+wB6VJDPCp7AdHkk+RQMklr7O2YVAOzyfRm+r16HAj0L9Z2J0aJA5XoeIO4ps/ FcTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=yz9uipws; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com. [2a01:111:f403:c201::6]) by mx.google.com with ESMTPS id a640c23a62f3a-c2e71b710e4si139461466b.35.2026.10.03.05.26.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2026 05:26:06 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) client-ip=2a01:111:f403:c201::6; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=yz9uipws; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P4gVUUfsOAIJdraoN5wRQUWIVPFc78NioO5g1qvEKRXjHfqSnXHN520jdAiztLNo6kvXE/yU7pqpw7aPUQCJpCu+lQYsMujjqTPBb0/HL8yJxVHojzVOXDxqRZyQjCXGE4yAiasY5yK37duWA4HStqNRhgHCRFXOcPu8KkgPu7M84pPPqRtJdxH82NGUuoJTt7t5Fjco1l7poLBz4Y31T6aV284mD5yqR4zh1g/Cu332S0W2id0HOOuDD/CbPtZgf7P3psKy8j1rVmQAffSnMEw1VEfAJjVDMlmfR/n8Ixh2b4ALqOPzqEOL9DHqaHTtpDrXCxkQsqMa6dX5LrM0mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGCn/7u7Qpk3bNlG1zKxEE/pP4PBdbxe5zAdydJCYzs=; b=GJJXnfBkJ8N1vT4udiNdWux+QuYkZUi0RvfgsXWihEr0whOaGGrPv09kfQ51lW/NY8l75g7yrfYwEy4kmTbJMJbwA+rOa9rdQSPQp4Ijn8ww008BGrgJ3xvBdT1uDqiPjmC9kc6s2v7ejNYukQoiMVWY8KgOKgc1bNFQU8ADjs/LDJ/OOKDRzZoBRbRpWH7M3nsQofzATTR5khoRKFQKqnYdJEzjAt8Sp842Tvsxi9thCHuBBlyLQ0td7VN6so6pxkn6ynHb5yQYn6KkzMzuq2t8UF3E6T4lSkL3wL1J0zN3IoZnIR3zubk3l7e5e4Rz+OYO/jwLadWWu67GmBZ1aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nGCn/7u7Qpk3bNlG1zKxEE/pP4PBdbxe5zAdydJCYzs=; b=yz9uipws4RbUDMcnWic4hAuzPh5Zg5PPk8pv9XmDBkEVuvRIdaBup7/2J+Wj6kNMWMyxKquNEARnz8EjltKvLN872Qluk1i+exd0Mplzgl1P8OVXHZw2+CNuDyoIpJ1eVKI+Nnl3BEPV7B4EfPHPIXqp1WtWWB1pDdvUjAjFTt9oBzVv22x7TqB0pLGh5yAzNpTYRHonH7ocTmNhaB73DWuVitijcRLuutnl5t03m1bTpg9J1BfGmnH3hAKgTTaTRR9XvFTKaFxWW1GEJ/MKV5HdDTa1Eg6dSrWYWzSb7og2XyMOQXD2zhNHpkapCdFqBfIseDexXSZHPJkaNMtNVg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by VE1PR08MB5647.eurprd08.prod.outlook.com (2603:10a6:800:1b2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.13; Sat, 3 Oct 2026 12:26:03 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0472.012; Sat, 3 Oct 2026 12:26:03 +0000 Message-ID: <79c87fac-773c-4f11-9bf7-8f909f30b56d@virtuozzo.com> Date: Sat, 3 Oct 2026 14:26:01 +0200 User-Agent: Mozilla Thunderbird To: vasileios.almpanis@virtuozzo.com, Konstantin Khorenko References: <20261002-ve-printk-irq-v1-0-cb55896d455c@virtuozzo.com> <20261002-ve-printk-irq-v1-1-cb55896d455c@virtuozzo.com> <010701a0fe87c530-6148b930-e30b-4de3-b6d3-6ceb259bac9b-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a0fe87c530-6148b930-e30b-4de3-b6d3-6ceb259bac9b-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::16) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|VE1PR08MB5647:EE_ X-MS-Office365-Filtering-Correlation-Id: 597b74f8-16b1-42ec-ec1b-08df21497d72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|1800799024|376014|366016|56012099006|4143699003|6133799003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 5h0WT0oF006rMEG32Yz4cVFLhDLvoKc3GRvoE4Be5Dd80Ai33kXbWiskFKm9gATVEV1N44pfd6zFpcZ0tRf4jasTXFuLI6VCM9YfaiH0ZzEZj0M04I40zfK3E9wgJaeTOvJKxYFZqC3D2f1w5zyiTup351Yf2XpqWEGbCp5It8UzFafmwZdqA3UR6GdKaOCbpnpZ+4CuNDnu6UKlXk/5KgIVrrUnK7R5075kQmu92Djihb9LhJYMOTXrMABE6FMJRJHTvJWqExhKyTv+9WDwM2JoU1zZzm2mBMy6dLN/S9bhrtW1oSEt51avikaHTqMYTC0TWoXUUoIMn8DoZwV2/fCWQLues5j9o9b+GYU6MTkDXS/TVhL3ZuXkBf7vRtpySwS+wd1rX/MifFt1/U/BG1i2JrOqtV/NHpEaVDGasKEtNrTHacJTf/3KJMxaZOs3toJAtpebrzIuG2QsCVNWHMpjlVYohu6e4nzWfl+IO7Et9N+6LODj8MJhOz6BR4rM8rtqWRq+X0LsC/LKXgBUvtRhqxOeCHJMpMvIuT1p7fbMyueFA0eLh7VmaVPAiL5IEiE7MXplpGYubPjx1WPafNkoFqviNzXfSU9OjkKDeEZ6wAKgvtaQvrDGhoMR5mR6FK6wshODJGzdItPoivdeudvpLF+AFZBbAx8sJ3oLwGw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(376014)(366016)(56012099006)(4143699003)(6133799003)(10067099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVM3TDUyQjRjY2xzZWN1VDEwWjBnMHVMR1ZDelFqQnUxd0Y0dWkvc0pVcW5W?= =?utf-8?B?VWpCNmxscXBIQnJweFJSWVJ2WExzMmF5eVM2U1pLU2NWMUlUSmxReHpQZXZy?= =?utf-8?B?ejNrcmZ2eFdPWEU2MEUrZ2hxZ01BTFg2czBKR1NxS0J0SldNemoyZFFJRitI?= =?utf-8?B?OE9FUW5kd0FLT1lIaWE1YVlaTUZ2d3BCcmhIa29XRUtjWGZ0ZVpwZWJGcHpI?= =?utf-8?B?QVpReVVUUHZZMkxpeEtaamE4Z0lFcFZjZ2QwM2pjTnNmcmhGMEM5NC9qMENt?= =?utf-8?B?QndrQTA0MFRvb2VYWStncUg4cU5vZXhVMFRPS29tNEs5eUlsUTJsR1VHTG1T?= =?utf-8?B?VXIyeUM2Uy9kUVhpNklNTUUrcmY3R1BwS2ptN0k4NW1maWdWMGV1SUdMcHpY?= =?utf-8?B?VnZ6ck05MFJZaVNBOUorSzJYNUpwOFVJckxuMWJWb3BJazYyT3p0eDYwYVFO?= =?utf-8?B?UGZVZVB6a3hwNTlScGlScUplVStqY3RKTE1VTXBMUURJRmozUmc0cVYxWjVO?= =?utf-8?B?bDFUTGJ6WU5RRUQzSnB1M2Z0VTdxR2lLcE5zUXV2R0FkNjVONWRwNzM4dkNR?= =?utf-8?B?S3lPT29CSHV6Witoalp6TmREOHNmNndZYUhXNkZpdWN0ZDVzUlEweXFqK2ho?= =?utf-8?B?QU5aRk40TmhqYUxYS2VISmxzOUpXWXlvajRqSmxyZVBBMkMzc21GNDQ4Ujdm?= =?utf-8?B?M25INjJKK1lpT1loejJWVXFsaDlWa3Q3UjYyU0ZJUVhFUlhsc1VZNWd2N0Rw?= =?utf-8?B?aUVJT2svNlhBaUppQ0lXTllDQUljU1VEdlIxR04vZUZJNXQrYmREZTBDanJT?= =?utf-8?B?OWhzaGtmaEtFL0E2TXNvcXkzdVBTNWJTQndSVHU5S1luOUFXeFkzd09ZZUFl?= =?utf-8?B?TlZaY0E1Q1dUcWJWcnA0c0xuamR3Tlp0QWNkNXg4RnBqMGxYWDZQL3EwOFNR?= =?utf-8?B?b05RZ0x1dzhhMy9tOFBHUUtad2F6TnlWeVhERktNbzdQaWdXRlAvTUdvTjUv?= =?utf-8?B?Q216RVgra1JDWlE2S3BCVGg4ZWR6TE1RcGs2MnA1ZTEyS0htM3oyamZJS3pC?= =?utf-8?B?MDdvQUhCUmNYZEh0ME9lVFVWZkJSVVltUTIzangzTTNpbk95Rkx0aTM4TzhO?= =?utf-8?B?NFJXd2tPdVgwVEl0QkpjY3N4QWNCUDNXZk5mK3hQSFhFbW1abTF3c3Y3bytq?= =?utf-8?B?YXl3NnljQjFBUXRaMHppK2ljUVhCZ3U2UGtNUmM1SWhNRUQvTE85RUkzSzRa?= =?utf-8?B?bWtlcGNyZGdYdVlyQ2RSbDdySGZzN3N2TTdJam9GQ0x1dWFGZk43ZXVrZVkv?= =?utf-8?B?dmtBOXpWc2ZoU29DTXM5SC9vc2NlZDVmMk8zTEFHa0htOTMvVm5JUkhCQWRO?= =?utf-8?B?cUV1RTFwVXJaK0FFTlg2WDJPVGxYL0J3d09rUEl6MWZmVW1ybEJhVSs5TjRV?= =?utf-8?B?WUxsNStIMXozMVlqZDBBVW05QlhocURuN3ZPMGtLODd3YnZQUExscFJZNTk3?= =?utf-8?B?dno0Mno5OWJDTTc3eVdQMkd5eGplNDFSb2F5UTB6STNZeTh3VytCMDYyb1pj?= =?utf-8?B?VW51dnFmZnNJeXh2Qjc5dDRhamxOeDIyWWlaWWZmM2paZnVuekpDd3E1dStG?= =?utf-8?B?SHozVXVCS1lHNjNlTTNaTVhxcnNKZlZhb0FCaTdVNksxb0ppaHRzOHlheE04?= =?utf-8?B?MGN4akxFcldaWTU0TEtKWTMyaHQvWWJSVkpONUFxSzZjckhDMERQbThJUEFG?= =?utf-8?B?bFUrdDRWd1JxV295a2ZoL0RNV0JJYTNnRHU3L0VWT3VZbGk3MTI2Ni9nZUpX?= =?utf-8?B?b05pZGI3QUlKK3lQY1A1VVI3RnJ1QkRBQW1GWjBWc2ZGeHZHSHlSNVpEUGdC?= =?utf-8?B?Z2tKUnlpMWVhRHhRaFdWY2cycWNySTdKU1lCYmF4YVFla2JERHh5YnhyVXh3?= =?utf-8?B?aDgzR3hJanZ3MUhaeUVLdllFSlFFanNHSkY3alkxS29najh6Y2tXc0hWZTR3?= =?utf-8?B?WTE1Vm4vcjZxQXRaQVlDcHZwTXZoTFdrY2o5ZkVDT1BqM3ZzR2R5eGNuaWpm?= =?utf-8?B?a2VhQmthc1p4V3ExU2EzMFk3aFpoOHZnU0lhWks0WlJYTzFNVWVZSXR6Smtu?= =?utf-8?B?TUNPYk00blcxZFVxT0JLTnNvUWF3dEtydDlodGZRQWZtZm01QWE4VkgrcmJK?= =?utf-8?B?ZW04b3pqQVNnaE9Za1lqeWZ3aFp4TitRNzlhYUJEbFYyUjQxREVOMHZCSk5V?= =?utf-8?B?QXVMbEJiQVMzTjloaUV1ck1JYzQzb0k0OVlUUHFKdUwyQk5pbGEyOGZtUzBG?= =?utf-8?B?RlZ2T25RbWx6OFZ3T1ZvYzhqcVMwcDZFdEJMQ2FPUUNiclBIV09wYXRUU3RL?= =?utf-8?Q?6eTuifj4nztD2+C8=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 597b74f8-16b1-42ec-ec1b-08df21497d72 X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2026 12:26:03.2641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: je2WUvoLuAADo8qg3s9zS3eYB2KSR4CUZQJrSXEjyNRcUgwVEAsKoc3JDO6VMd4E+bKW62mTHvILWdCwCo9oC7JRkJ6RVdyTnuG9gdmVov8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5647 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/6] ve/printk: Add sanity checks in ve_printk functions X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/2/26 23:31, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Low] printk: WARN_ON_ONCE() in ve_vprintk_deferred() uses non-deferred printk path > -- > > commit 2b22fc2da5243bd2b5c695100f66ab107b28c158 > Author: Vladimir Riabchun > > ve/printk: Add sanity checks in ve_printk functions > > This patch adds a sanity check on the dst argument in the ve_printk > helpers. It also reorders the VE_LOG test so the dst bit is checked > before ve_is_super(). > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c > > [ ... ] > >> @@ -2567,10 +2569,12 @@ static asmlinkage int ve_vprintk_deferred(int dst, const char *fmt, va_list args >> va_list args2; >> int r = 0; >> >> + WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); >> + >> va_copy(args2, args); >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); > > [Severity: Low] > This isn't a bug in the normal case, but is the new WARN_ON_ONCE() safe > in ve_vprintk_deferred()? > > This function exists for contexts where the regular printk path is > unsafe, which is why it emits at LOGLEVEL_SCHED through vprintk_emit(). > WARN_ON_ONCE() reports through the normal printk and console path. It > can also panic if panic_on_warn is set. > > If a caller passes dst == 0 or a dst with bits outside VE_LOG_BOTH from > such a context, could the warning recurse into scheduler or console > locks that the deferred variant is meant to avoid? > > I did not find a caller that passes an invalid dst. The trigger would > need a buggy caller, and the warning fires only once. > > Would a BUILD_BUG_ON() for constant arguments be more suitable here? > Alternatively, the report could go through a deferred-safe mechanism > such as printk_deferred(). We can't know passed values when compiling this file. Also, WARN_ON doesn't print anything itself, instead it executes UD2, leaving all the job to the exception handler. And kernel does use WARNs in sched code: check force_compatible_cpus_allowed_ptr, it has both WARN_ON and printk_deferred. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel