From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 44C7D803F6 for ; Mon, 16 Nov 2026 20:04:57 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGK3eFU031255; Mon, 16 Nov 2026 23:03:41 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGK3eFU031255 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="sEHUj/wR" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AGK3coQ031251 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 23:03:39 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AGK3coQ031251 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-67532014b2fso6748268d50.2 for ; Mon, 16 Nov 2026 12:03:39 -0800 (PST) X-Gm-Message-State: APuU4Z8ujtwFBkZUghE0aqjP0Qo8UMWkTiTds0jXkB70azTGRyiNNeK5 6KaQSuJh65uuZIy0UM+NcCTIjrmlJ7+iJZR05/4bLbbt+TZemdlWXSLmwIRvZ3jhT6KZzUgTJE7 vImsySIlQWzXOjdRotKhLQykwjB/o+WQbaAdL26CAedrDWlYQ/QUNwQ== X-Gm-Gg: AZFdTZeLDGrxLsrWr088oQZlxeqc18JbaUbrQAB04hbyS5EmCgr1Ry5pKNb5gOrcAZ2 n2vvQbOleRLZ2stt2e6Jz/L3y7MkXV4GAnRXX/8qgC3qBiNGTjDMbJkokTMtG/w+joSRSNJ8802 tTfDf8K+SPjQt7q7QZGbsH+2glmiGZoBDxC7epRgGUHjIFwapeMTp3wtTRyc1HUlPXHCixHZkFU 1J+B29fw6pvS3ah7Kf/FnSOUH8UvoKcfBiZEM8xUyXgEv1L0CJ1uCWfZtgodpoMLYn9rAW+Lf4a XZiQNZN8JAkpGpP3fYrjSKEpbWplm22KgffR+1ZQLAcITbhOpgJjaCbiIKwO/HB5fFwbtpfRbxX CV5CZMwgaYREiXPBDL+Im4w6ozmBOsjebAnzM+SoCkJDjQN2juQi6JXpURQgzvlS626Epsd3PT8 kvks1CFuMNursXum8MzvXkmDZrWNrLHMF5 X-Received: by 2002:a05:690e:13cf:b0:67d:ab75:a924 with SMTP id 956f58d0204a3-67dab75b4a1mr3214892d50.45.1794859418193; Mon, 16 Nov 2026 12:03:38 -0800 (PST) X-Received: by 2002:a05:690e:13cf:b0:67d:ab75:a924 with SMTP id 956f58d0204a3-67dab75b4a1mr3214874d50.45.1794859417615; Mon, 16 Nov 2026 12:03:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794859417; cv=pass; d=google.com; s=arc-20260327; b=Hf5iF2gIRI3CjLHHG9rZvFDdDfefkoGMh1JZMXmQZZjdmWdyQSVo9CrkAgzh2Chins 587Z9GPuoBJD1rbnOntLzx0AORmNkFFCeizPxgB11LfvKsb2ty5op37XPXy9NIkDE4T/ d4F/LKYtSOKvRif9Ng1FE7Pw5GBXiQ7ePWWqNQ+pd23G2U7aAmy8/2o3WC7/vURUBTOq 1gM7eAVertU5T2NkusNGGTpBjPoJ+TwEdsefVmsBXUUATVKsSJJb2m5B/urzwu8M6fzZ QcNTDmJH2Jjq9Ww8HEAT29hf65GYtT6B2m4w8SE1Eaj+XHMwVY1pinb64HWJDMzpg7Py I12g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=gElIeE4ou4oPGGHABdYPNQcc+FYzLHizC1fhHxZibh0=; fh=MPbb/fYAXD7RpgTj7uvhvDOA4h8fFgXedFicSITGHIE=; b=GDWKjdIku17h4htpomLhMitEQ+PlQCcXS1NWvZZEw9rrH1zJzqZh15/I+oRLqC4DUr I6KJINaG9jvvYasAJCPb2T8xM+TkERxqOxCCnDM1WDXAHWQV9qEEhuRRqu5MCM7HuqnU zQyHMtTO/LeLGIFJKUIXJzKGpMQ9tyhOWiap8eyARRoZLDognwbQC1vzVSd1gU9taZbu cpEm4LudFh5kptZuRWt11QzdRtEB4v0a5GwnpPpkUatZT0iv6QxjpTK5C611CW3KjOSM AnPUqN5oh03fXdSzXU5TUbytdJFhBYILQA8Szkrj21nuoBiPkj3UYXMiu1zHUTElfLeK 3zfg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="sEHUj/wR"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazlp170100001.outbound.protection.outlook.com. [2a01:111:f403:c201::1]) by mx.google.com with ESMTPS id 956f58d0204a3-67d8a5d9744si7332961d50.154.2026.11.16.12.03.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 12:03:37 -0800 (PST) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) client-ip=2a01:111:f403:c201::1; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="sEHUj/wR"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::1 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=emS6Ctw4LGPlD9jEzaSBY97LxLY9/k+nqR65c65a454Kv7Gjkr1KjTGlLDzgmUKYYFHwZc+R+pecObgBvWb7SGEzB8lw3/o2Yi51mghGmdHEcOz8FaCuV0ZuEFRkvYjM/1Rxnx5ygUAMiIBn6p6fcygqgyUaPNg4/7WBCP4GVL3xIC/YSbNgxAfDxS8rTjA7w+a3wI7AT8kxJC3b6BkPLmP7iHBT4wpfDrzdBduhqsB06qlxoqBZVWF6641OnfjBYwTVq1asWC48pdUTMtWawCO6rQePXnpr9Oj70G4KARcGIrOBMc2U3V9bK7V3kEpUcfWOaMpU81xlX3S06iuJBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gElIeE4ou4oPGGHABdYPNQcc+FYzLHizC1fhHxZibh0=; b=KV22e9QkiztKUVGG7pGqm5nKmI8LUfkTrzJibx0kmZV1pGUtrAVKibSadaSZLKJCAsAEiZR/BLkgep84jX+b0TSNZB5Lk6o0FYqJZfDILa/VGNgEHlp821s0w1g5eiW5/n/BzXqCM/MRqsiCLGo1+Et71yjwxy7ftDSRGXghC4BQmeJiW5a9cRHDCprHrzGQ/QIknHUS6PpOs0DQy86OpSkJgYVn40btuhyAg3dWt4zeBkAo+Wse+U9RBnyz7c8nKYah9dmX7tLd3eqN7dJQcMipA63rTQJ05KA4gAgEyYvCJd7Zka9Sp185N3tziq+Q8TIWJULMxh2cFgO6+saQng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gElIeE4ou4oPGGHABdYPNQcc+FYzLHizC1fhHxZibh0=; b=sEHUj/wR9u0g0Bny2JslZPc+Zxp+QkvEEk7Og9n+D4vPDW3lLE5U+X19D69xln4QLj7I5FKLlz95HfqaSIEVRGVTbzdMYaqpgTdVpoL46+Hli/WIfUR2aYxctJ4v7ReIhJxUWJwtyCt6gnv1pIjNDcP/xzKPHfiP1q3781ajdbOqcD5qS25CzNj9XAEa8mFwoqg2ww5JIg1e2tatB2MOhIo0ZSzcYIxv4k7w74po5fA8TLctDqiU023gtNTev0Gm+xScFe+E8FxMd0XmsNhOJQaLcCuQXOp80td7z0qxke8LOEs6VcLeHl933e+vmpCHsGLrJPTScD7cUoBP+eH+3Q== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by MI3PR08MB11878.eurprd08.prod.outlook.com (2603:10a6:290:77::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.13; Mon, 16 Nov 2026 20:03:34 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0615.013; Mon, 16 Nov 2026 20:03:34 +0000 Message-ID: <7e7d00f0-debe-4294-ac86-63c0b36b22a1@virtuozzo.com> Date: Mon, 16 Nov 2026 21:03:33 +0100 User-Agent: Mozilla Thunderbird To: vasileios.almpanis@virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko References: <20261116-ovl-use-orig-ve-v8-0-dfe427bfd902@virtuozzo.com> <20261116-ovl-use-orig-ve-v8-5-dfe427bfd902@virtuozzo.com> <010701a1e5d54e35-6c3ca6a1-8743-4db5-89ab-f9888893d9a2-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1e5d54e35-6c3ca6a1-8743-4db5-89ab-f9888893d9a2-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|MI3PR08MB11878:EE_ X-MS-Office365-Filtering-Correlation-Id: dc3e4cdb-4a88-4b9e-afed-08df441cb1e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|376014|1800799024|10067099003|56012099006|4143699003|261026121527099003|261026135527099003|261026130827099003|261026140227099003|261028144727099003|261022115727099003|261021135927099003|261021130227099003|261021133027099003|261022075727099003|261022105027099003|261021121427099003|261021123027099003|261022113327099003|261102123227099003|261009223027099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: lMvTmmJuQyEVhqHJopo+eejJjFhW0HC2dvxcxbapUNbftZU5sF6gPJlbtynu/qKxBvcutx8jw/Lk+a15rdQYroNrmQ/RdPK7MuEIYyO+JfXWeYcKZprNsWyd8LAjqseA+xAobenE4Qq4q8UhoxcqBIhCQkPDPuIVvRM1iOImlVCivtU0Royfk4rxMNn8yN5Z2Jpt4soFEDfaVMcWwu4gyFYG7oTeHTzccNaaxlVQRZEylchSU07kihYwbbSg2unbIG1LwBmbs/F2My+YUvwBRGczfhHBmensu8bIIRRDyH1hKJhqZuBIHTM6tqtWEBnzfJf80byedux3QXDezs68xAvDs6l7z7Xne1gY578bMq59ptIvh2mFtj40wbYxEKD1C/RqhpXnoGl2FqW+bx+zlwbapTLa3bgVJ8VrFL7h2J9LeEIRo8UUJYP1CcyJChfvWbW+FSGWGpVWqPRTMX0hMNWRTpSQI01gIYCJiCgWbUcSVJ9BRuSZmzYUfFSlJ2G5R3rFrwZVNVA2mNNXeCRmo5S1Gky93ClPefimdnKFWOlSeoeatbei6GgaIhZ+Bj3NyEZNbTbMWmt/cbMs+vWyjnWjuQGLgwd0bnnuKD0UAu5/sR6ohkPdZTzLeJy8v+Yk X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(10067099003)(56012099006)(4143699003)(261026121527099003)(261026135527099003)(261026130827099003)(261026140227099003)(261028144727099003)(261022115727099003)(261021135927099003)(261021130227099003)(261021133027099003)(261022075727099003)(261022105027099003)(261021121427099003)(261021123027099003)(261022113327099003)(261102123227099003)(261009223027099003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDNwTDVBTGlpU25VQy80cnIrL1h4NEZ1M2FKSjFuN1M1YVdQcU5EcjF1T3ZO?= =?utf-8?B?Z0gra0d2bjBod0gvVEJadE1XYmpITkFMclB5by92SU5yTXlUaGN5NlVuZ2JM?= =?utf-8?B?cGF6S2drOSttb08xRWppNHpIYUFYbVROSGNzNml2SG93MTJKblhXbGRwVW9l?= =?utf-8?B?dnRGaiswM0FVek93dzhHQS9XanQ1cUloOEdhYllNR2RNbkc1dUlUNkova3cr?= =?utf-8?B?WThVdld0YVVNRG1yemJnK3FtQ21jUXM2YkZzYUNTR0xpMTRLZzI0UVplbVIz?= =?utf-8?B?dk9pNGFvL2s5NWppMGplRlh0cHJNWEdIdW1obnkyYXd2TkloSzEzbGJpWFlz?= =?utf-8?B?SVkvbjBrRUtXWWRndC9xdWQ2aHNXOVcrenZxTXJ3bXBTSUNDdmJ0ZExtdDJH?= =?utf-8?B?cG44SU4rdzhhOFgyM29OM3MzRncvSnVLVGhNVEdNcEhpSGptb1JqQWRlOFJS?= =?utf-8?B?cnJXYVE4WkpEVHExd2lJdnpMdHBUL3pxcTQ0dXZ1WDJnM2hKbjNXanRjeE9T?= =?utf-8?B?ZkRsMElTbWFTOGp2bFVYSHV4blJwb00xcGxXR0g4RjlwQzl1MERLYnE2YzQv?= =?utf-8?B?Mlhndy9NcDV6UkxMTVQvZWhHZlhEdjVvRUZubnZHd3BIcW1yTnM1VlRQby9j?= =?utf-8?B?TFZESS9DaEdxU29QcVZNTHJRci9YNTVQVzhwWEZGdTc5a0JIZUNhOERYeTJ1?= =?utf-8?B?MXdoMXJDN240cUw1cnNCcEt6SHNTSENjajUvUG5TR3BHU3hKd2lkRWgxYVVx?= =?utf-8?B?Q01kMFAxUm5PMFJzYS96WU9GQkYrWW1UUFRZalhJendmNmNPaWpmRjdvclJn?= =?utf-8?B?ODVxYThSMFJQTDEvTGVkRCs3d0xzWUNSYXRmTG1pWnlnNmNZbVNxcGY2U05u?= =?utf-8?B?OTV3ZGpwRERnR1MrdkEyeEhiVi9jQkxvNUFRbFZveERTajhsUlhmM3pta1NH?= =?utf-8?B?dXZoQXRGYXdYOTJ3eTFGOGlLK21mNG1IaGNvQ0o1NjFtRXRhVWMyK242SDFG?= =?utf-8?B?SHcwQ1BWb213N1NqVzdqZis1TnFldGk1dU4rVlVyRjlLK2NxNnowMkY1L0Uv?= =?utf-8?B?OU41Y1FYNnBzWkVrSmJmUW1XNWFQNXAyM0dzWTZveXo0QTVlVUVxcWdlZFRr?= =?utf-8?B?b3lwUmJ3dUFkMUsya3crTEUvSjN2UktXako2V3FjRXZldXl6c0pQV3dsWlhN?= =?utf-8?B?WXczeGNjeGR5ZkpHZzdnWUZhUkQrN1NtNzZpOVdoZWU5ckgyRzNnaXhVWlh2?= =?utf-8?B?WFJCNFg2bDBncC9EMkQrbjJRQjZjbjlMRHhPQW0xOVZPdm9mNHBWb3JsMW5v?= =?utf-8?B?WHlpcFVYb0svT0Rqek1laVl2S2RmUEY3YW9PbllHRGxVeXM1bU5CNUhobkUy?= =?utf-8?B?Q2Z0dVVkemNZcUVrUkFCZlFMUWRRRUJTYlh0YldCNFludWgra2dqV1h2Q0lV?= =?utf-8?B?TVZrTHoyQlB6MGpEbFRlbjhxSlVVeGJqMUQ3dDl3RHJYR3ErWE0xRE14Z2hl?= =?utf-8?B?TSsyOG5EclIvNmhGbzlHVTFQMEZ2VGpmeDZPajY1VUhiL0dHWjF2SUF6bGhC?= =?utf-8?B?c2txRDRCMjhWaGRFSjdaUVZxM3FZSDJJdXUzcmgyVkIrdjF0aURGOUJYU0hL?= =?utf-8?B?b1dqZ2JJd2w2Mmd5ZVdkTVRQNklJTUpOOGdUL3NTYjhTOFhKWEZpL3dFaUVs?= =?utf-8?B?TjRWWXQyMnpGNmVxUnRkTUVKbWgxc0h2eU5BRy9JbXphM0ZzWmRJZkJCc0Fj?= =?utf-8?B?RzN0VzlLNnNsbnpzT1RER1JlWmZITU5EcG1HbFhiQmlPWVRNUFpVcllZM2hO?= =?utf-8?B?WEJ3NmJFblBaUmZrc1pGUi9jU2tCTk1MS1ZrTlV3ZE4xaHBTSFhCTzlqNDBF?= =?utf-8?B?VXVCdXlKRmoyS2drWG52YU0vMlVVdXJHUDhkVTJKOVBUcU55SmZOOGM4bEhW?= =?utf-8?B?RnNiUGRzNnJCVUNMTlQ1Vjltd01PUEpEcENSNWxCV3NNcE1Cd1VzbVB0ckVU?= =?utf-8?B?S2F5cGNib2sySjh0NzBLdU9aa1VRTHZYWm9XVVF1ZHNUMTRqWTNXcTBUOUtz?= =?utf-8?B?TUNOSU5BQTFnSUtiRWVCUS8xeDNvRXNzYzg5ZnhlTHA2aU13d0NKTWxndUw1?= =?utf-8?B?eHVrazBUb0U0T2RsVGZqTlkyVTZBZExrQWl2VDFRaGhqVGF4ZjgvY1FyQUVP?= =?utf-8?B?OFN1Yy9hVWh4Rno3N2V4UWViVmhqR21oR2hIWFNSbGQ5K1lBSktYalhJMjNi?= =?utf-8?B?c0pwNlFReG9XM00rRDIrUW0yckNBR2JZQjBFOVRyMEdVL1JWMzNJbE5saXVL?= =?utf-8?B?d0w0Z0VkekcydTBNVmJqSGJ3U0RWaHdwanpjUVJibnZuUENQWHV2ZkM0WCts?= =?utf-8?Q?RBElKj0jNsvYfeTI=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc3e4cdb-4a88-4b9e-afed-08df441cb1e1 X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2026 20:03:34.5063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pAvREWJMtsuFIMDFZo4hdKlmmhT2NwiVXH0+MUSzQU+fRwacyY5WnMOglHCAPffTb8esR0U3zuDutCSx4lXemBdJtsJl6vhZsnWDqZvhW6I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI3PR08MB11878 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v8 5/6] ovl: Fix leaking fd references in ovl_copyfile X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/16/26 20:28, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Low] ovl: commit message does not state the actual fd leak in > ovl_copyfile() > -- > > commit 19e71b9ba90a3111ae72b566162542bd1c41d68d > Author: Vladimir Riabchun > >> ovl: Fix leaking fd references in ovl_copyfile >> >> We lack of ovl_real_file, added in d66907b[1], which changed >> logic so that the code needs no fdput anymore. We still need it. >> >> Imported commit a1e0eb8[2] didn't bother with fdput cleanup, >> because it relied on d66907b existence. We need to perform >> a cleanup when rw_verify_area fails and put real_in/real_out fds. >> >> [1]: https://github.com/torvalds/linux/commit/d66907b51ba0 >> [2]: https://github.com/torvalds/linux/commit/a1e0eb8f55cf >> >> https://virtuozzo.atlassian.net/browse/VSTOR-142405 >> Fixes: d5a10d38e534 ("rh10: import RHEL10 kernel-6.12.0-211.75.1.el10") >> Signed-off-by: Vladimir Riabchun > > [Severity: Low] > Could the message state the leak more directly? The sentence "the code > needs no fdput anymore. We still need it." contradicts itself, and the > message never names the path that leaks. No contradiction. Code with d66907b needs no fdput, but this is not our code. > > As far as I can tell, the leak is in the cross-sb check in ovl_copyfile(). > When rw_verify_area() fails, the code jumped to out_unlock. Both > ovl_real_fdget() calls had already succeeded, so this skipped fdput(real_in) > and fdput(real_out). When FDPUT_FPUT is set, that leaks the file > references. > > The message could say this in one sentence. It could also name the > upstream commits by 12-character sha and subject instead of the short > shas and bare URLs. The leak is obvious from the code. I'm not adding useless words to the commit message. > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel