From: "Eva Kurchatova (Virtuozzo)" <eva.kurchatova@virtuozzo.com>
To: no-reply@sashiko.virtuozzo.com, khorenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 1/2] ms/selftests/bpf: test_xsk: Initialize bitmap before use
Date: Mon, 16 Nov 2026 15:40:24 +0200 [thread overview]
Message-ID: <8053639a-1a0a-4ec3-8a44-5dfb9c5d31f7@virtuozzo.com> (raw)
In-Reply-To: <010701a1e47d8c58-7ff19a6e-540d-448e-b859-1f2365603acf-000000@eu-central-1.amazonses.com>
On 11/16/26 15:13, no-reply@sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] selftests/bpf: xsk bitmap fix lacks Fixes: trailers
> --
>
> commit ee0829e53ca566bede00c40365c639ece9f4e9bd
> Author: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
>
>> ms/selftests/bpf: test_xsk: Initialize bitmap before use
>>
>> bitmap is used before being initialized.
>>
>> Initialize it to zero before using it.
>>
>> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com>
>> Link: https://lore.kernel.org/r/20251031-xsk-v7-2-39fe486593a3@bootlin.com
>> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
>> (cherry picked from commit 2233ef8bba81e02e8fee6300a81dcf389aa17c58)
>>
>> Rebase note: applied to xskxceiver.c. Mainline moved this code to
>> test_xsk.c in commit 3ab77f35a75e ("selftests/bpf: test_xsk: Split
>> xskxceiver"), which is not here. The code is the same.
>>
>> https://virtuozzo.atlassian.net/browse/VSTOR-154851
>> Feature: fix selftests
>>
>> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> [Severity: Low]
> This fixes reads of an uninitialized on-stack bitmap in receive_pkts() and
> send_pkts(), but the message has no Fixes: tags. Should it include the
> commits that introduced the two bugs?
>
> Fixes: 8913e653e9b8 ("selftests/xsk: Iterate over all the sockets in the receive pkts function")
> Fixes: fd0815ae9b8a ("selftests/xsk: Iterate over all the sockets in the send pkts function")
It would indeed be nice, but the original mainline commit lacks such
tag. I have decided not to make up a tag for it, and keep as-is.
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-16 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:07 [Devel] [PATCH hci-8.1 0/2] ms/selftests: backport xsk fixes Eva Kurchatova
2026-11-16 13:07 ` [Devel] [PATCH hci-8.1 1/2] ms/selftests/bpf: test_xsk: Initialize bitmap before use Eva Kurchatova
2026-11-16 13:13 ` no-reply
2026-11-16 13:40 ` Eva Kurchatova (Virtuozzo) [this message]
2026-11-16 13:07 ` [Devel] [PATCH hci-8.1 2/2] ms/selftests/xsk: fix number of Tx frags in invalid packet Eva Kurchatova
2026-11-16 13:13 ` no-reply
2026-11-16 17:00 ` [Devel] [PATCH hci-8.1 0/2] ms/selftests: backport xsk fixes Konstantin Khorenko
2026-11-16 17:00 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8053639a-1a0a-4ec3-8a44-5dfb9c5d31f7@virtuozzo.com \
--to=eva.kurchatova@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
--cc=no-reply@sashiko.virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox