From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 82C2B80E7E for ; Thu, 29 Oct 2026 15:51:17 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TFnwt6001986; Thu, 29 Oct 2026 18:49:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TFnwt6001986 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="JUB30dRo" Received: from mail-yx1-f72.google.com (mail-yx1-f72.google.com [74.125.224.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TFnugr001982 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 18:49:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TFnugr001982 Received: by mail-yx1-f72.google.com with SMTP id 956f58d0204a3-67906c453b8so1881259d50.1 for ; Thu, 29 Oct 2026 08:49:56 -0700 (PDT) X-Gm-Message-State: AFq9FYIl0Q+e1T2zP6ISfQbyeQudGqz6w6Hpsl2rzeiA38zhRXCXWYIE 5lkuNNdZATOaC///LBpX9GIavMFVbwzs+z+fBs5JIl9dQM+O2AyyIdYq59ApJ9zXDHcTCLy2ieG dcZFnOFIA403RBRCZbca8lgqb5WuqAvvv00Jdyd3wYH4zHc0JlbTbbg== X-Gm-Gg: AYBFou0Ov1Pka+h8leCPcMTYWVAPAbcgn/C5lR1rIBDswlWopIurSEZ/schDrigmXXo DihHEAh9NfOYvkbt4Y/ylFCygUklj/8LP8nkBYYxt1co8JsW8D3/CydX3DHjUnFj8p7EcS3SjOx w7+kHCZf2TLdtatC1wtbi2CKLmPFFIIFY0hQxYYVZbmaAo99OHPCXzBnYxSF4nE9PH/4Bm8YsEE +c1C2Osx5b7eh09vQQzAhFP0tO5NvAo0jsm1f0fQ9XCE4sswF/jELV2Jsw+uz0dotpb3ZGuLJlk 9kztc0McOwoATt2iSXbHMru4Wl/2KOhDTiQPPwmasCX4AkiLE2QaYtQRNeAFjZDud+qtk5U0UAs I08f+W70+1dYSKsaGnb9UUljGfOQl4BLC8WgcTciFPPWAZJ1HUM7cRD5Gal+T7y15hJ4wXLeq/H 8o7x64QZsZ741H5ei7Whb7 X-Received: by 2002:a53:d40a:0:b0:679:a56c:e2df with SMTP id 956f58d0204a3-67a8d4e614amr1618130d50.41.1793288995800; Thu, 29 Oct 2026 08:49:55 -0700 (PDT) X-Received: by 2002:a53:d40a:0:b0:679:a56c:e2df with SMTP id 956f58d0204a3-67a8d4e614amr1618114d50.41.1793288995087; Thu, 29 Oct 2026 08:49:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793288995; cv=pass; d=google.com; s=arc-20260327; b=b7BoBG8x3H+Z4yApmICYdEdABIglsZ7pPJTEWN9mdhNYJIdaWaemYbbjONPGOYL55d as4p7xt6kJrLYuxawHYxM0ICmL8v23nwlfKnWNV+Mw0yi7NdKZ1yHsD1bO/jab9/KEJs lriRIpDBUxCtdiZqX7t+cVyfJdlK99RmLHQuMD+h6Gd3Jdqoq23Lfw+xGo2Fu8ZSjr14 WXrqHZ6XdKtdrSKmyn5wkMDesWop1GntAdC58rsQPW+mKhoRF1LaOYwYfXIQpIGqq0m2 V9L5Yhbd6ElLRYu2g926gEluPe/n3Inr9zFwpGHljcl+gylJS43McKw1WSEtxFOrFdZT KupQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=f85VaHQj4DVZgikkwnB9k7CZ4XDVi/2hjx+g9PczZCI=; fh=KqGNj48vwLu+JHb35ovSuvOLAH3jvZoTtP32/go8yBk=; b=faDEX38FeKoJCp83FVUaPnK3T89kPnhePbTwFjd4fFBgpuYsxDgr5nhJGkOTqCICPH DSWZgRGNIM/nFWs8nAAlRHN4D63J1W776QcBk0uH9oG7NzHkONTAQ4Wqt09ezjIEA1D/ xdWoGcTX5LY4MwC8QkhXI/3nlaT1MBKHSOYTKmYvRJaOlv1uRFHA+6vR8F8EueWi4QZT 2wjYstRlgqvh9POfDyAeFi8MLdRgwLABh0I6riCeykxnk2rr58AymiE4i3QQfhMHW8ex ZpbbxtqzmyPhaqY8965AuKjsNk/VrdMISJzKZ6k9OhU3XP7brUgBkWm8OoWgWP/0G/BN pkWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=JUB30dRo; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id 956f58d0204a3-67ba1dc0b48si63003d50.15.2026.10.29.08.49.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 08:49:54 -0700 (PDT) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=JUB30dRo; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FDoeUskdkyGRYC/J0G0NhBClIzmCnAoj4SVuwgEa77XCfXDxps1cVyujmMrk+LN86/RuWsgRqdCUwWZ7ZmfNI57hRgkPDlTv8hciOSh4aI5sU3gXUB2l/WWmxyRMYVB0lUYzmyOLhb0J4NPDSs+iqyWUJ8m+fXbES71zP1P/r9wMHVZhN+ItsFJEEPueQCWYf6mbRCCwLWayoxNeFqsBp9+9ncM/7StkesygJn8gAlcMuuIG6kOfb8r0t6oEBmEIis7SgCzFQsFlBQn+IOiI9DESraPHgr3DpFLgrsoZjJGzKSJzeRFkt/RSrKkIQludy+T4ADy5kMlcrUq2KXQoQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f85VaHQj4DVZgikkwnB9k7CZ4XDVi/2hjx+g9PczZCI=; b=Z1c7a23cdj5symOglQrq6BJH1Ke6m6JuYABwai8FVXhBmCQCNPsJczze9efWXeTC5P8lH8cZ0Q0L/ydm9SClCUkGIUv6VAEoME6ZEDiMnPY+zvTR2c3i42jI59BUaPPTJizRTuxuZC5v8Uj+jrDquI2ZMODi+gr0fUT2IcoHbIueU1hVBsxjedaaqSH1+P1DhC+FNXA08JRX/y+xAr1BvrJyLfwqsqJeHx02SIkSTke66TU3erwv/p7d2ccnyAeYpyuybNDl+5xClJXv7ygu7o4RZ/utLUYSZqXKAP4AZ9pSxAmzqRM1YUTV2+P/qUYWu5+JVf7nKJZQAUla+gBozQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f85VaHQj4DVZgikkwnB9k7CZ4XDVi/2hjx+g9PczZCI=; b=JUB30dRoewVco5/jKCVpgN1v/MvpGmQ0V5y3UG2IUi+8nz24sBiYkCjRAWNASaT0+ryy16J7qn7oSmEi9zNndF7OYzaww4TtubcC9XdnCIq4lBPgsUWerFE1ctAYXxXUbxFQ3zzTs20sPcGbmobd3R5UFcPOw+R+0NV/8vJSmWvqfFxqa5KWUMBMX4QNeRlgIaFbLm0uYnYiXHzPU9q6bXFW+2z0VKHosckA5cKYcuBTAPfTitI/3ettQcThwbgS8uxKexXZvQgAmHBTtfwq88G+dNfTUNVJpVaoSeKoP1+UhAqIVrBJ8Z5J0lxkr+H9RmsyDI+hycyYHeh1o2HWMg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AS2PR08MB9075.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::9) by MIWPR08MB640794.eurprd08.prod.outlook.com (2603:10a6:290:e8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Thu, 29 Oct 2026 15:49:52 +0000 Received: from AS2PR08MB9075.eurprd08.prod.outlook.com ([fe80::3f57:9ced:7a37:1bd8]) by AS2PR08MB9075.eurprd08.prod.outlook.com ([fe80::3f57:9ced:7a37:1bd8%4]) with mapi id 15.21.0569.007; Thu, 29 Oct 2026 15:49:52 +0000 Message-ID: <830d0a54-508e-47c9-bd63-5e15b379aec2@virtuozzo.com> Date: Thu, 29 Oct 2026 16:49:51 +0100 User-Agent: Mozilla Thunderbird To: Pavel Tikhomirov , Eva Kurchatova References: <20261022022554.2427456-1-eva.kurchatova@virtuozzo.com> <20261022022554.2427456-2-eva.kurchatova@virtuozzo.com> Content-Language: en-US, ru, sr From: Konstantin Khorenko In-Reply-To: X-ClientProxiedBy: AS4P195CA0005.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:5e2::14) To AS2PR08MB9075.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS2PR08MB9075:EE_|MIWPR08MB640794:EE_ X-MS-Office365-Filtering-Correlation-Id: e6101de1-729a-4f55-485d-08df35d44556 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|1800799024|366016|261022075727099003|261026140227099003|56012099006|4143699003|5023799004|261022105027099003|261028144727099003|10067099003|261021121427099003|18002099003|261026121527099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: xnTZCBk7ylhOr6V3JPjG4mvS4aiajj1u1Rt+7gsQiawYqlEQqxsfc9EnsTCYk5mePOJXdcfkMZmpGxZjKt6rVoz2I93GMul7sUCaaLsZY8tGjKyxiiCx5eh5etgL18nmp8+EK4tYsr+8J1Pl90FynZk6x1f1vBAyEQc/lOaG5BnHtK87qQqYFJmNZStPVitzzO1WwMS3tPg9feX24NsYp9zqqDVwQOk+Qv5YHeLgF3Rgn9t007ahVkTD6z9ONWapXwxvx07B1fbpbLPQA/t8ooeeKVV0+xp6rsX2JhQxBeyO+QrWVZYY4mAR5PUgTbWoGA7o8V/ULmDFX5X3FaDi6zJbjbcSBO2R4vp0g70qUH9BCjfdOxh4lRuRX0Rf05RmCnOyFhBL+pjIFXFOC3ff9w+47UNcFc4EAVAwx+rWAw19GlB5krNWeaDBiIRiWEIh5p30VACp601BXWmM3MqcgYdwsL2L8fklQnSILP8W0pJWUqcIZW3ekrLNhqTFI/w4K163J7p2U3SmYZkVJhRE1MS3yUe1gV5XRsnlT9Pb5sal0qVnoZAtfXOtK/LhLrBy0rUSm3IfzIkk+6R80d6+D31WMxXKXle3kufZdy6FGklaDEBr4hvwhXpS179+dgCLoEKHm+NHOI0wk9ILfFwGT0qGsHHvfBsoBBMqH+IoEkE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS2PR08MB9075.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(261022075727099003)(261026140227099003)(56012099006)(4143699003)(5023799004)(261022105027099003)(261028144727099003)(10067099003)(261021121427099003)(18002099003)(261026121527099003)(22082099003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1Ayb2ViOUpldFdXVlN0RUNxRitSUEFraU5DTndMR0lxaWlSTCtjU0xOMHMr?= =?utf-8?B?dnBlR3N3UnVLa05wQ29jY2FVKzZVQ2pzRkJ3ZUQzMlNEaDlTclBlajNnUVBC?= =?utf-8?B?TWZRYUpCK1hQYzZYRUFmUStTYXQ0Rm9nVFF4dTBwcTJLM2FtQUpsSXFOLzE0?= =?utf-8?B?M01WaUd2K0dwZTVnRVNZbDh6VzZWVTNKZkxoOUJXVlNRQjkvb0ZndENUWkJH?= =?utf-8?B?cDNwSTFWU0FzK1JhdTkzV0w1cnZycGFRY1dUTE1wcmduUVRXMG5RYVpXbGZh?= =?utf-8?B?TUQ2ZCtqS0ZZOHZ3NDRnRGFNdkt2ejBtSFcvMFg5ZUNkWkdCK2Y0eFJYdEtI?= =?utf-8?B?VnZTa2prSXN0MGxjWG1vRFNiUGpWWFQrUXh2TFd6VVJZMWRGaGJxeDhxNStF?= =?utf-8?B?M3pJbzlUSnNXRHpTQjJlbmlvZElwTnh5Ym5ZQWtkYzF0MFlDM2h1NzUyVXc2?= =?utf-8?B?bCtXdXRkcDE1L2lIaGp4YUpPaWpSeFk5WktMaFNGV0dJcmNzL3pablZ6VnZ1?= =?utf-8?B?MXRrcDcvdVEyUTdiSFdVZ3dzd2s2SEhVWGFiL1ZRd0hyaG5RNCs1RUdJQVN0?= =?utf-8?B?SW9saUxrVGxRcHhOdlJZNnBoenlYbVNjMERrcEhnRzZhM29EUnZBNWZDWlpB?= =?utf-8?B?UEwyU3c3a1BjZGZreUFvdlNOem5rOUtjWE5OUTVWeGp4MHFjZzdOVTRFMVJ2?= =?utf-8?B?ZTg1UEI1Z2dHVHZ0amQzTHY2MDdYZnRFWGVSQmZOMTBHZ1MvRytFNHBSRGtX?= =?utf-8?B?dEU0c1RSa2xLTVUxU2lFTXhheGN3czBZRVdYN25RaVNOQzhIeXhweFBGNEU1?= =?utf-8?B?WStabW5zdGNubzZsV1FlVnh1U0lqaHpxaXFqbUNXcXFRb2tVOVhwaXNXZWwr?= =?utf-8?B?d242RFZuRkVtL0tNNm9YVDltcHZweFNXTHl1UFEzWG5MUE03VVU4UTFIUzRU?= =?utf-8?B?T0xZVFNYTURMTklEdUdWTEF5K2ZPOWV3ckh4WFJ4Q3VhK1BmVWpKaWhKd3h2?= =?utf-8?B?SkRGRk1tVHNwcnNESkVSN3dnRkhZSU9PQ2dLbGRoLzdxTnpsd1NjVzhZM1Rt?= =?utf-8?B?bk05SmhOWDEvUlB5b1RkSXkzQTk0MWlWeDFqdFU3Mlp6bnVQZTJaZGYyNjYv?= =?utf-8?B?N2hNbU9PZTk3ZlJmRXRLaTdwS2xMYXNMeTVUanI1dnFKMGFVdHplWTRGNUhR?= =?utf-8?B?U2ExQVFkY2U0Q1FWR2RlTiswUTlpMlIxUkEvTnc3SEVjRmhFRTNqaFdnZEU4?= =?utf-8?B?UEZBaWtPV05CMEY1eGhhcDNVYi9YVFJ5V0JoVGFqanFRTFRFSnVTOEk1cnVk?= =?utf-8?B?TGptYWNPQnZsS1JHa2pDYXFxaXViQ0xEVzV0VHhjNlZ5ZGZCVVNyOFFkMmN0?= =?utf-8?B?Wnd0MlpvSzhrbi9NOUlKMDdJM0loMFZOY3I3cHh0SlVjS2QrK01qMkRhcE5P?= =?utf-8?B?Ni9aaGVkeUpFRnJSeDY3NXl3cVZPK242TEhxTXdlczhUSHBKbUhDWDMyV3or?= =?utf-8?B?U3lUbU1QTEp0Z3pScjhBVTUwVm1BZTlyekV6QUwvZEQ1WVQzcnZTVDUvbjM0?= =?utf-8?B?SjdYejZlM0pZZXRORTQ4ZjNNejNnRC8zK1VWam9FZUs1MHdsS3Rtdjc3UUR1?= =?utf-8?B?VDdZU0UxSDVEY2pVNVd4dm56QUt6cDRxd2IvZEREZHJuT2VkMm1BOUxmTzdX?= =?utf-8?B?T1MyQ2VVUm9YK3FyL3FKK0x5WXRTZC9rNUE3TWFWN2hQbnVRakUyWWpwZ1Ni?= =?utf-8?B?VnkrT2g0bWh1M1hpWUlaSlVFWWdoaENWTkJ1ZlFuTXlCSFpZYWxGTGt6QTZY?= =?utf-8?B?QUJtZ0gySi96cVdia1c1Z2hici8yOStSdkJKblJLMk9HNnZ6OHl4NTIrVjhP?= =?utf-8?B?ckFLQkJJWm13WHpwTllHR3h5ei9sbnIzYWwrY2V6TUU3RGRtcHp2RTUwdDl5?= =?utf-8?B?K0h6ZTRBd0xQMHdLTjdVTzIwTTZ6MExOTEpBWDNpN0pBVTBta3U4ZjhIb3U4?= =?utf-8?B?U1FJOFlOQnBYYWdiTXg3NkZzc0QrZEVWQjhIOGdLZml5TVpOdlB3cm1zWUVD?= =?utf-8?B?T1JRRnBLSDdlazV1ZkVSR29LYi9JaUNUOGtQMWo0bUJmM2RrTXYvNExNZHQr?= =?utf-8?B?akk5OGVHMXAxbHVRMkprdjBiMjYyQm1qT1RwUERGcWhHVWUvUzlWbGtIV0Qw?= =?utf-8?B?V2REOVJkbHV5TzhrQ3Z6T29Na2RGKytLeUU1dkNtM1ZxdXZETUlkMlBBZFB0?= =?utf-8?B?Rklpam92bUc5MWUvN0tvZlFGdGlZKytmRHpxd1pCUDc3SjY4Z3NGK1NldmJQ?= =?utf-8?B?NnNpQmhjZkdkTFlqY29YMEFIVnNyTDNKRUdSK3FYYkc3YmdDVm5QQT09?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6101de1-729a-4f55-485d-08df35d44556 X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB9075.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 15:49:52.3536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oSw8dXOIgg4OireZZdn5bqWC7AeArf9iehIweKg5Gwvvm7e/P+O4RyP8k+VDaBV+ACeEvBzCdZeawcnbbyMKrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MIWPR08MB640794 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/1] block: let container root set the block size of and flush its device X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/23/26 12:52, Pavel Tikhomirov wrote: > On 10/22/26 04:25, Eva Kurchatova wrote: >> static int blkdev_flushbuf(struct block_device *bdev, unsigned cmd, >> unsigned long arg) >> { >> - if (!capable(CAP_SYS_ADMIN)) >> + if (!blkdev_admin_capable(bdev)) >> return -EACCES; >> >> mutex_lock(&bdev->bd_holder_lock); >> - if (bdev->bd_holder_ops && bdev->bd_holder_ops->sync) >> + if (bdev->bd_holder_ops && bdev->bd_holder_ops->sync) { >> + /* A filesystem on the device is synced by its own mount, not from a container */ >> + if (!ve_is_super(get_exec_env())) { >> + mutex_unlock(&bdev->bd_holder_lock); >> + return -EBUSY; >> + } >> bdev->bd_holder_ops->sync(bdev); > > This looks a bit overprotective, if we allow writing to this disk directly, why not allow syncing it directly, mounted fs or not. > > Not a blocker though, fine either way. > > Reviewed-by: Pavel Tikhomirov > This looks a bit overprotective, if we allow writing to this disk > directly, why not allow syncing it directly, mounted fs or not. Agreed, we will open this path. It is reachable only with a device cgroup write grant on that very device, bdev_permission(BLK_OPEN_WRITE) is checked at ioctl time. CT disks from vzctl have W (write for mount only), so they stay at -EACCES. With a write grant the CT can already overwrite the filesystem under the mount. Forcing its writeback is strictly less than that. fs_bdev_sync() is what syncfs() does: sync_filesystem() under s_umount shared, with bd_holder_lock dropped before. Nothing the host does not already get from any syncfs() on that mount. invalidate_bdev() drops clean pages only, the dirty ones went through the sync first, and busy buffers of a mounted fs are skipped. The cost is a metadata re-read, not data. The only thing it bypasses is the VE sync filter in ksys_sync(), and raw write access to the device makes that filter moot anyway. On the CT's own mounted loop it restores host parity: blockdev --flushbufs behaves as on the host. > Not a blocker though, fine either way. > > Reviewed-by: Pavel Tikhomirov Thanks. -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel