From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DD2D6803BB for ; Tue, 10 Nov 2026 13:52:25 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AADp2rx015253; Tue, 10 Nov 2026 16:51:03 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AADp2rx015253 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="G0cNsrzn" Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AADp0od015249 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 10 Nov 2026 16:51:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AADp0od015249 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cd66551e02cso2335764a12.2 for ; Tue, 10 Nov 2026 05:51:01 -0800 (PST) X-Gm-Message-State: APuU4Z8X2k6jueyvPyGbQHHGUmCCvT3mmfpYBzyx/Tf2zOkmAHmfFm9+ MTaUZp3gWSEkupq4QWUxpscwJyRT+wKTqo5I8F0nckP/V3QFacPFRKAUg06DiU1fqTdLEJRGM99 NSFXegDxDPF7gq3sQiwBM8WjpQFFD4pJouiwvR436T79yxbH9oUGjag== X-Gm-Gg: AYBFou23/Wnwe8yHCCOnK5BxD42l9lY+j+W9MiYWNDnlqzFwp0soxBX1kIZHu9F9N0m eHsBk/rPWBCCHw0AkotOAu9h+DQsukZjxvPKLLkGH12+vKsY+TBpVPnYmNfExRT3tIWlt2Bc+PW aoJtFUrq3a3Cu/q+ksMuFiHhmczJLmIleloCkVG3V1KrvamsquZmJsPfkj/lfWwAmTZqNHlXJ4d OhZCBlluC9uIXs6vNoLvJcUfTwXAXzvLDxQlbGq5SCVjlKa/qJRgWZOorTEMElm3f0YSOClv5FV 0FXWPnzATmyTeyTDXeQALBC9zcTqGojx6ZBcq6tKuyCUrcDvdM0reUqAoXQBgLqCjov807puYKi Q4BPonOfY6g469kndmR7aCIeh4c1GdeT0CbQdRt7qmH7YpAWUI5wu02oH5bpzCtMrdFwFcu56KT kW0HQzXQNTTVUGCMEpKBveg0zw+rkyPccoo1l3 X-Received: by 2002:a05:6a00:4b56:b0:8b3:15b4:45f2 with SMTP id d2e1a72fcca58-8ba867aaf6amr2973244b3a.25.1794318659753; Tue, 10 Nov 2026 05:50:59 -0800 (PST) X-Received: by 2002:a05:6a00:4b56:b0:8b3:15b4:45f2 with SMTP id d2e1a72fcca58-8ba867aaf6amr2973214b3a.25.1794318658889; Tue, 10 Nov 2026 05:50:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794318658; cv=pass; d=google.com; s=arc-20260327; b=DZuI9MJosHn1oNPI29gaa5xLMj3BNBEMZA1ptKrDR5xYvlpcXbniHx0tbHlsbrTORu jYqK/oissMZhC6wlm/2xWjiA37QXNropfrS7JwaqXEUoLQcFqKUFJ8R4pVUwXSuYtkEX BrNOLWc02gcXq+0T+Gy0Q9Qg85v3W6ssKCHMvNdjW26owFNnRmjDup49/wGF8KvGL9oZ C3+TVm7JizJhXepJXK2hhnsBUcCcmiq9MkyFBa3DIsX0YPZGGh9Lc4f85XKWlcSDl+QC KPzE8+VMA6s80Gv3E2cVYC4D//E3RZZiWrlOFFgGN3BEXacraLznQIVLmS1KvM942gJm 00EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=z2aIYvoPl98M8cnF9LW3iIVWXp0+PBuwFFXjaaHw7sw=; fh=/dRgTijvo1ePWcNOaQjvarTNnlaHT6OMdL9Zu0+G4+8=; b=f4ZBgJvQPLcGGof0gC1DEI5RsWkT7El56Oo2O1/QzCFaHnSreE7C8GIdO/Xha96Fyi /tzN0ekqWeS5sXdDqNmRwy5mmS7EHdvHq01+ZIiYtB46otHmygDhC9hFtOFikZPyB37C 7ymDYVEs3AYyqtVgG4VW9DTsMTmnVht1/ORc39DF2YI+tivvt89ZZQ+B7VzwUX/oVLqy Id4Y5XTZ/jFC3GIkQUJJw0QZoFc0uD36ktt8eKCMXoAJTyoU2vdLFJfsSOO2Chf9nlB/ xDJCs+GdxNDTdiFjNAe+Gh7q03actjJVrdkZkwzpwo/RolWGTbtoSiGbkUpNMox7QPwE fa5A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=G0cNsrzn; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20a::7]) by mx.google.com with ESMTPS id d2e1a72fcca58-8baace299c1si4294813b3a.196.2026.11.10.05.50.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 05:50:58 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) client-ip=2a01:111:f403:c20a::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=G0cNsrzn; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o2J6O4sb1CG+JghtvqzH/SBTtWQuxoAoeLqj7cAeohB5y+M9In+eeC5V8f5VqYxhIjp38Uyn1maTYhkktpn0sQQ58d4VAQpT/aw7LYb2jMzHUSDtcWDOSgfYnHsV7yma0kg4YwXvB/bfUtu8Ruz/P2n/x8esUajjp2Qq8Krhk1WlB19y+RCCf6QY0UyBvzPh9E+/auGXdqKMvITvYZucEPPnIymjFnagp3JH2dg0qc/HN7tKcvByx1JIQ8vaxU6VfpGz3Xpz3wwDNyP8UjoR+od66mK9ofDs6vdErZkRZ24Zyw5nVJ9bOvR7StuTjeXl+pEGt7PSpHnOFlVu07tfow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z2aIYvoPl98M8cnF9LW3iIVWXp0+PBuwFFXjaaHw7sw=; b=Cm80rMjveILYUic5j1U+hjoph4aoQkiKjOApPqB3jNd/GuKKb2su0U2Fj9lugfFgTzSRUUPaictwVY3u7/j0RfhYf6UQ2MpNw+4rdKBekleM0qBuE+E1yLRxqLmjzoVWPjdC50uPPNEO+JxxaliIBMzi/m2+bpUlrpWWbD8jd2n4zLtpAWJBDNBqwRYGMN6BFqUu7/jUa2X4LObIzm/f4Uq7gAbbLc3z4FOaSQLppwWNysuv/ERb7OfFfnHdy9yh3uPkTLy9N1+CXdwQbW67rbDJrmTmSlEpuHKk2S2yY72hslbxKel01ZEZlOZp/p8sGlWXSFXa+dzshkuU48vS/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z2aIYvoPl98M8cnF9LW3iIVWXp0+PBuwFFXjaaHw7sw=; b=G0cNsrznzD008ydmwOGW6BlDwnVQ2qcgICDDgOsoRBG7rgEO8SdXiovdxwFUF+Uk0hpse/4+Xwm3hJilm9zOaG526u1ELf2mjp80s+6Og/c8E0JcK65iOpeDrv8oAh/WFlYFopqDfXiX04+R3Ty9uP3IRP5l9smQW8wLSmpkQp0NWnd5Ew4IWPEgVkocnMdB8TBELYmuZeeU7/jJN4A/b8yKnMZuc1ej8MtbhUVGU1lnSXaruEpJOro+eIEfVXPrwMp6nsBTTB25JROFrTkup5+dLpVYkQ+Vf7reK/eRR8IW4s1b/gM/6AjWS68gAWB2Xb7eLCPteUzMz0gmtbMiqw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by PAXPR08MB7551.eurprd08.prod.outlook.com (2603:10a6:102:24e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.10; Tue, 10 Nov 2026 13:50:54 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%4]) with mapi id 15.21.0592.012; Tue, 10 Nov 2026 13:50:54 +0000 Message-ID: <877270f3-0b1c-425d-a0d6-0dbd8725485e@virtuozzo.com> Date: Tue, 10 Nov 2026 14:50:53 +0100 User-Agent: Mozilla Thunderbird To: alexander.ivanov@virtuozzo.com, khorenko@virtuozzo.com References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> <20261110114629.416695-4-andrey.zhadchenko@virtuozzo.com> <010701a1c553f3b5-5af01626-0d79-4ffd-9d21-56aab2f433b7-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <010701a1c553f3b5-5af01626-0d79-4ffd-9d21-56aab2f433b7-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cc::16) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|PAXPR08MB7551:EE_ X-MS-Office365-Filtering-Correlation-Id: c928d09c-27a0-45c7-98b4-08df3f31a3a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|366016|1800799024|376014|22082099003|18002099003|10067099003|56012099006|5023799004|261026121527099003|261028144727099003|261102123227099003|4143699003|261009223027099003|261022075727099003|261022105027099003|261021121427099003|261021123027099003|261022115727099003|261026140227099003; X-Microsoft-Antispam-Message-Info: 2jHBbi/CQ7aN8m/jzqU0TPQi8ezixq1d1mG9IoGUPxbJSIawq7MUQbp/EIEKhB8EZGkCKdgjC7ld7D5W/fq93B2Q0MGue13dSDwYMnagjWsUVCZfLY2NZQTWj1hi+RoJ5ljKLvtBInIVJ0druSaN0G1Hcfralt8rxcbKsVxq5HckkvdRr6oJSdwdWdZbNKlTY+g9MqfPvOHW4cpp2W2JZ5H95dTzG7W+9DyW53uSchQ+TDRcNw9c5LsNhwOIjVy1+XtH7RHdxPp7in3Ze8ffqGugUfWRzrXcK0NvsxNhbbJwjqoZTb2EN/baJ7EPUow9NK1f6XyTR74Mg/d9VbHQwh5i9BLZk2ORnrxbdSqz7RmrQUX3+QVGyvMB4X0rCdKpt383XipCdm4ne6HpXt6x8JxzTMpH8/3LKmxShfx7a5NLhZwsO6+49yVW6grFodndTh4QDJ3mgcFw9ksRYT/rBww8JajZvc2ChwiqVKrol/up3OTLDNo5SxbhjmO3V+jEAF0eBVuTqeqVyRaiYtXHBNN6HaRq9rcm1kXgPTbkTAzloAvBD0pkS4RL7fyppZCIXw/cXBLrLlxJwPKyCmls4RotgjA0021NWusyBAIH47iGnE4A0rand0So8UiIosKr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(366016)(1800799024)(376014)(22082099003)(18002099003)(10067099003)(56012099006)(5023799004)(261026121527099003)(261028144727099003)(261102123227099003)(4143699003)(261009223027099003)(261022075727099003)(261022105027099003)(261021121427099003)(261021123027099003)(261022115727099003)(261026140227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2pVOFFGNlgvSTFIK2VxWk9uMEJveFZubFp1bndwOEtmSjlWemkzQXo5YmtH?= =?utf-8?B?RVluTzVadDNxY2NLYUU2YU5LdWtYdlpDZlhHa0tsR3krbEJSeHE1Szc3QVRk?= =?utf-8?B?ZnM2OU5vc1l6aFVMVm1pS0t3TlBDczd1TW9NOEplZ1FpQkd2MmlIcEZkL3l1?= =?utf-8?B?SGtNdGF6ZmdhWFBQR0wxbGdvS0xMWlhlQnB3QTBPemhVS1dVZ1JxcVpYYkVR?= =?utf-8?B?MktMN013QURGTFJ5bkZSM2xqbEUzRExQVm04eEZVNUVwOEUwWXpJK2VoaW0r?= =?utf-8?B?Qm55YUN0dEpuN1FNSklEU0FWOEJQcEFrUmdwcGUrQUw1dzZwNzErWTZsc00r?= =?utf-8?B?VXV6VVhONmJ2OXJZUHBTVjZiakx6TElDd29vNnp6djcrRW1sRFBBWFRhSDJV?= =?utf-8?B?V21Uays4OUw0UHVLVENLMm9LK2krcVlVZno3K2JTb0hydDJTV3l3SWtra3J0?= =?utf-8?B?MVJrRTliNXpPNmRuZjUxMVZDQ1NZWnNyQ1MxUGRIdDUxTmlLMTJKM0t6MENk?= =?utf-8?B?YWdNRFR1TjBLa1FWdFA3OUJSanFuOWlsR3hyVFBvTGV3WEZtZldzdTJTalNJ?= =?utf-8?B?RHp4R1B5TjJ3b2c1Sy9uM2hSdjdsNCs4ZDQxaUs4cHJ0NURxZVNIdS8zUUNk?= =?utf-8?B?bG1yVWM3c09iZUQxVW5UcmF4NVNZN3dlajYwVUpKTEJ4aURmMlZneG9tWkV0?= =?utf-8?B?NHVPRnNTY0grNVpYcGR2YlBvUW9rTktKMC80bzJJbmNJZE5XZU14eXBTTTZr?= =?utf-8?B?R3RmcFVNZG1YelU3dHcvNUhxSm9hZDhKN3RaQVhHU2xHeVhLcC83MHYxTEc3?= =?utf-8?B?T216SWNPbElHUXl5QUJkOGo2a0JkZ0ovT0J5Q29peWZ4QkpSWFRIZW9maEZW?= =?utf-8?B?eEhKOUR3SXR2RDViMkk4UENBckZzaHZjODNjbVl1eUl1aXlVamFidWhNU1BE?= =?utf-8?B?SC9TRVpicXhZWVg2aXlnNThjT0ZLUEFJb1Njc3d5MDM3NVlrR1NTT0Z4SUpS?= =?utf-8?B?OWVtK2M4SDNKTm1CanJMUHdjNlNwZXpEVWplNWVrWW5ORTZDU3IrbWhBbmRq?= =?utf-8?B?bGg1SmRlRWFxNkorMzhkQlNsb1dhVTNqeHhYbnN6VlBzcFJZMnBkZ2lIRE1r?= =?utf-8?B?c3dVMU9zMUJ0TFVZRko1ZEVnNEVxVmZzeHlZb2FrclNWdG91bWpjNnBydUd0?= =?utf-8?B?UmppOUZBVHJXZkxCM1oyRG5ZeW1WZVpFTUZMNlMrTXhLVXI0OThsRFBubmhY?= =?utf-8?B?RXFHNUJaSDI2WFU1Tmg3WWpVSW1mZTNNY2NVR3JYREwwTkl6bGIwdEw3UWJt?= =?utf-8?B?eU93TFkyRjNoc1kyUDVHN3JTRjhTOWlYSnUxbHBsQStEUjkxclZjZCt1d0N0?= =?utf-8?B?UERNVUM3M0JyaHJjMTNLQXhHSEN2ZExxTFFUeFVPaU1za2JlZndobTJlRnpJ?= =?utf-8?B?RVN4MFZNbkdsalpKWjhRdHJrMnpxMS9sSnZOKzBvRFBVajl5WkxDTm9DUG81?= =?utf-8?B?TkpTUFdSNUwrNHRuZ2g4bWJ2ajhuU0hYZ1BydlpCdlNqVElISEwxdk5PcnU5?= =?utf-8?B?Q1hQRTBWb0hkUUN2TlBtUXNyQXI2dXFrOFlucU52UDZHcVNrTDg5TlhGemgw?= =?utf-8?B?N0I3ZkdRK3VtR2NldlV2cFNieGpNdmVHRitHa0E0VDRKZmhkcUZhancrcVd3?= =?utf-8?B?cWF4bnhnQ3hmdzAveVNQbklkRDUwd0VNNEo3YUFEdWtJYml5amE4Z1NkUTBT?= =?utf-8?B?bHNVWlk0L3J6MkJ4MXNIZmd4TDZxNjVtMDBGYXVEY1E5bGJxSXJObCs1K2F3?= =?utf-8?B?SVR0c0VLS0Yvb1VGM1dQMkYvYVIzdW5wSk9Oc1gwRzJZRWo1N05lWVRHU25n?= =?utf-8?B?S05CRUtEbUtZRTU1amZJODZEUDdJVHlHVmxTbTkzdE1JdnE3VDRiWGo0dTNq?= =?utf-8?B?RUR2cWxMa003ZEdiK0VPdHJ3cHBZKytNR01lVDAvUTNUVGdMUmNseGJON05X?= =?utf-8?B?YjRlT3V3aG1sdWVRVkpsQlY3ckptYW5GL2NHMHk0cVBVcUxyLy9ORXo1MnVE?= =?utf-8?B?VDJFY0ZmaG5KNm1aY0FkeDZvV0thTVBVd25BWHZycHR0OU8vS1hzS29SNEF4?= =?utf-8?B?N21lOXFNYWx5TlBtVCtLK1YvOXdidlAwOVA1QVJpZEJtdzB2WFp2ZXNCSXMv?= =?utf-8?B?S0djU0loWnEzUkVaalhZejJrN2V2QnV1SVR2ZzZiWjlkT2FqbHJrUkFKVDN2?= =?utf-8?B?N01NcjF2Vm5hUUJNZXNaMEFMVU0wclQ0Y2k2NW13TUtsODBxd0ZxZE95NHMx?= =?utf-8?B?Skx0M0FRb25nNFV2cGlHaElxTmNSS2E5R3RDdmEwNUhaYjNOSUR1bVFWTzFo?= =?utf-8?Q?Cr7zRHDKyhqf/uPM=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c928d09c-27a0-45c7-98b4-08df3f31a3a6 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2026 13:50:54.2814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vSOjsMxGlYiXdD9xzdpIkq4YMMpJhZZ1cZxdQrGy4oa7Ah3vTMV9cjekSg3bWCHCkQ1mWJzO7XLCk6ndHjUuOVfKd4QOPnsB+WgjP8z1ERk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7551 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 3/7] dm-qcow2: prepare process_one_qio() for fastpath X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org This whole situation is pre-existing in general (the same scenario is possible for base dm-qcow2). Theoretically this issue exists but practically higly higly unlikely because on each re-allocation we first do fallocate to punch zeroes which takes inode lock on xfs/ext4 like discard does. So not only there should be concurrent write/discard, there also should be third write, and the write into discarding cluster should be paused for astronomically big amount of time: after first query it should at least outsleep two inode-wide exclusive IO locks and a lot of actions in-between. Despite the gap becoming bigger after this series, given the pre-existing nature, I have not planned to change this behavior as this is a separate patchset that implements per-md write counters or locking for discards. On 11/10/26 12:59, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] dm-qcow2: fast path uses unpinned L2 mapping between parse_metadata() and data submit > -- > > commit a3dc5e64e9aa8f73ed35df62194a86cf78276045 > Author: Andrey Zhadchenko > > dm-qcow2: prepare process_one_qio() for fastpath > > This patch adds an avoid_metadata_changes flag to process_one_qio(), > handle_metadata() and parse_metadata(). With the flag set, a qio that needs > metadata changes, R1/R2 lookups or a compressed cluster is handed back to the > main kwork through the new QIO_NEEDS_MAIN_KWORK return code. All callers in > this patch pass false. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-95494 > >> diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c >> --- a/drivers/md/dm-qcow2-map.c >> +++ b/drivers/md/dm-qcow2-map.c > > [ ... ] > >> @@ -2075,6 +2084,9 @@ static int parse_metadata(struct qcow2 *qcow2, struct qio **qio, >> if (!qio_may_modify_image(qcow2, *qio)) >> return 0; >> >> + if (avoid_metadata_changes) >> + return QIO_NEEDS_MAIN_KWORK; >> + >> /* Now refcounters table/block */ >> ret = qcow2_handle_r1r2_maps(qcow2, pos, qio, &map->r1, >> &map->r2, map->compressed); > > [Severity: Medium] > In this patch alone the flag is only ever passed as false, so this path is > not reachable yet. It becomes live with the later patches that add per-qio > fast processing and per-cpu fast workers. Those call process_one_qio(..., > true) from outside the main kwork. Is the L2 mapping stable between > parse_metadata() and the data submit in that case? > > parse_metadata() drops md_pages_lock at its unlock label before this point. > A qio that continues on the fast path then carries map->data_clu_pos and > map->l2.md with no lock, pin or wpc_readers reference: > > process_one_qio() > handle_metadata() > parse_metadata() /* md_pages_lock dropped at unlock */ > process_read_qio() or perform_rw_mapped() > map_and_submit_rw(qcow2, map->data_clu_pos, qio) > > Meanwhile the main kwork can run the discard path: > > prepare_cluster_discard() > prepare_l_entry_replace() > issue_discard() > qcow2_punch_hole(qcow2->file, pos, qio->bi_iter.bi_size) > > issue_discard() punches the hole immediately. It does not wait for fast > path qios that already parsed the same L2 entry. > > Can a fast-path read or write then go to a cluster that a concurrent > discard has already unmapped and freed, and which may have been reallocated > to another guest offset? That would return stale or foreign data on a read, > or write into a reused cluster. > > As far as I can see, wpc_readers is taken only for compressed and shared > clusters in submit_read_whole_cow_clu() and submit_read_compressed(), and > this patch excludes compressed clusters from the fast path. The other > mechanisms only affect qios that parse later: delay_if_wpc_readers_locked() > and md_index_set_locked() do not cover a qio that has already parsed. > perform_rw_mapped() only revalidates the DIRTY and WRITEBACK state. > > Fully allocated, non-COW, non-compressed clusters were already untracked > before this patch, so the new exposure is the added parse-to-submit window > in the per-cpu worker. That window can stretch if the worker is preempted. > > The commit message says "if the request does not require metadata changes > we should be able to immediately dispatch it." What keeps the L2 entry and > data cluster stable for such a qio until its data I/O is submitted? > > [ ... ] > >> -static void process_one_qio(struct qcow2 *qcow2, struct qio *qio) >> +static int process_one_qio(struct qcow2 *qcow2, struct qio *qio, bool avoid_metadata_changes) >> { >> struct qcow2_map map = { .qcow2 = qcow2, }; >> bool write; >> + int ret; >> >> - if (!handle_metadata(qcow2, &qio, &map)) >> - return; >> + ret = handle_metadata(qcow2, &qio, &map, avoid_metadata_changes); >> + if (!ret) >> + return 0; >> + else if (ret == QIO_NEEDS_MAIN_KWORK) >> + return 1; > > [Severity: Medium] > This is the other side of the same concern. When handle_metadata() returns 1 > with avoid_metadata_changes set, the code below goes on to > process_read_qio() or perform_rw_mapped() without any protection against a > concurrent discard on the main kwork, as described above. Is there something > that closes this window? > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel