From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6D5838045D for ; Wed, 28 Oct 2026 21:15:59 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SLEbUY023752; Thu, 29 Oct 2026 00:14:38 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SLEbUY023752 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="D4/t6G0K" Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69SLEXwB023748 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 00:14:34 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69SLEXwB023748 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-88c768885b4so2497126b3a.0 for ; Wed, 28 Oct 2026 14:14:34 -0700 (PDT) X-Gm-Message-State: AFq9FYKVeopVRv+zsSiPQCYooxEzrPS+v63QE25g8tTOltN4iz3gKsYB 8UT2/oDEWHzWWqDIBZN/kMUsvlERnrr59bxdrNyJw/D7gogYjbdHSLHbJl4bGbc/j8U6Orc8Qvo 73cHPR1FYoeruU1x6TkvO1SqKTCpDZdaM9Jya5lRInR59Q3cQgUuUsg== X-Gm-Gg: AYBFou2BScZJp2cTjAqDUvw/ESoneaNQNkSQxXN+W8Qz1inz9Vb62xZAGo8Nt2CP5kh ny8nWxOXTTu4hVI7iCx8JOPif9yez/6jeonGIxcQP5T35cZDsY7jZjs9AdF3Z0EVoz7gUd3Vj1p T0Jo9yPfIOqVj+kb88jsNhuHrrd9++VcxaWqRWXiIttlED4tLlWx3D7NTt8Txp0IfrxClIlg2A9 MOmHS1pPNInNDeZV13+Wac6wQOtTGjQxKKyQJ8wjKa85N/TIUIn62+qw9leFOO6Ju0fFcOFuO2F to+Xc9po9GDlQ3PFIxTDXkrPLP9Qql08S6p9Bi9uaRhbN2PV1349xegPXZZe0ch2ldKAO/ZtXBC RAYtunevcLNUm+uyVMQv0g3KXvZ7NuQR5nUXDGQNnuYoapxwnQQpfTuLBZFk0GXe5fZWwXJomkH 9DvQaUNdcssTORepArjXH/J9SC0cc/vRneWuH+ X-Received: by 2002:aa7:8f9e:0:b0:8a7:917:4388 with SMTP id d2e1a72fcca58-8a709174728mr1952347b3a.19.1793222072747; Wed, 28 Oct 2026 14:14:32 -0700 (PDT) X-Received: by 2002:aa7:8f9e:0:b0:8a7:917:4388 with SMTP id d2e1a72fcca58-8a709174728mr1952335b3a.19.1793222072189; Wed, 28 Oct 2026 14:14:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793222072; cv=pass; d=google.com; s=arc-20260327; b=mjUF8dx4dskSPuQ0U03jWRuj37WXQdi79hgk9cDg5MMuyCLEWDdeqlMoTDO/V/TtAz ixUtHaCiyHhRT+lJF4ae8SxX9gR0JfYOUaxz34B1GBY7Me7b5OPqpPl0FSwi8SoXi/FR DtgXB6qiEFjTxNZkt8M31/MNHbbTqrC0WDC7Q4bqRbWbcWOjXYP3p67qlygzupie/DH2 aWj2W2jB3vBb+efh1PYb7P8wMcS6Y+f5AG2R6j6CS8Coh31XXl+aWm2yft6hpPkVhXCL PoHDAkgLSRNHaaacZXKIbEx6I2rm4IbH2G0s+m2UWHkOCaTBCKPUqcxiC4NNMQPijT3l 1Qkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=wu9kkDj/lRkOG58oXoCRPSf5GWI6nWjyVXd4gN18cTw=; fh=lDcH/AoEq9GlEqGnfAM3WWP3S1pTgZTBlu1eNYhzdGw=; b=N/PV9K/8NgSLY9SzWmi0/7FdtygcZTX19J4tJc86yoLFx/pikxW7GAF8+aAjMWtplt jfbgeE+hKOzOSmBFoZxWSvu20RPPvt86hRluiaqhDys+IHCIx7KXOLbig4oVTWFmNqFz XoiOnCrv2WDoXPEopm9lK3sq5WnMmDjmK02D2r6IK4lUwMVmdzH3PzqNxretPJs4mtcc 0sitzCzyPJ+eogt2XfbQdpi1nGjTAfwqAACSN1wYKhiv7nG+MwaShhJ5snDzZFxuTfMQ 7fr9a5oCU2gmJfd41JEVWKRjFU7J6E/HOwTm0JqfUdo6KJlQRsf6/p5jyqnpeo2Le0H/ pICg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="D4/t6G0K"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20a::7]) by mx.google.com with ESMTPS id d2e1a72fcca58-8a6a3975a02si7566346b3a.56.2026.10.28.14.14.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 14:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) client-ip=2a01:111:f403:c20a::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b="D4/t6G0K"; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UBdkja7k6UeA53m8Zag2SNpLXBfVV3EPr0tx4XfgFnU1gUSxe/FrV0xqwJytC/O6aix/OrofYm4ty1JnURN29PnKdlSeMWGGv5C8E8XWWev4dmlll3BVFZ604hALyv6Updb4QpFSMIQf1QmOUlkT9OfJvZ6d49MxD8AL+nxCirllByddDT4DIUzRhuva4Oyj31ohrPKp3+83qhGJk7LaACxdUfXD1uLGFObW6hLVlJ0wy4sTa49AARWuhPFKRpr2iy3yi2XxEMY30Z1jyPpOPOl4YHjCoIGmLf01WcqDs49VnzoSgsySV8qDxi3zijThEMZ2DbuKXWfFwJPNsIDEEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wu9kkDj/lRkOG58oXoCRPSf5GWI6nWjyVXd4gN18cTw=; b=bScuG5LiEKP2arnxVf61Bx0bkA6OsPYhF3gIcJ2hNwJSawOncex+MG1QGxngb1QGjm7T+jH8HJ0EQsJrpXv5ZxDL8O9gX1aQv1w5cmmBo/MiIp107AEzAPUCGibp+nNTaOZdWlWa5cStIg8NdLCOw7O4lrFESxkfDkluBj9vethDqu7Gf1KczwmcWZvJdP9FCq0TPAb5gU2Gr/xeOTzqvuiSXXB66aTox06f5sjkY131dAD5/J136pFSfyU9E+Z5PC8EnyqsGZxcp+sMjYG0BAIDXXNwGtyrRLnyctbrmJJ+VdViKQZGnrfHayOJmaS5cUDxMSVmTv6UPdgv1fMamQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wu9kkDj/lRkOG58oXoCRPSf5GWI6nWjyVXd4gN18cTw=; b=D4/t6G0KhOUCAawG4PtI91vsxI8SmT03CsYxs2ei+sJe4BNXgoryeDCewUv/kbnXKwy+sAy63fgSr/7CaXIbC47totAZJuuY7R59/anZdzNLzv5qld7dP5/YNMQfSwOzt/AisWtQHMN4iC9NL2vbuf8itiTwu3YKsdCSnM6OJBJpGTk9/RBVcp+Vrk9vmaRNZroZBi4BeGTSLY5g226bHYHKR4b+bz9zwDuaoDf4Tx5otYKpq0IY+OWg8a8D/M2H58iP04yNASjmC0KeKKYPp1irN8J6wjJPVOCMA0EOJusdw2CLUAxYT0fzUIp6Eap2mIhsl8o4DupElAEY6aP2wQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by FRZPR08MB11190.eurprd08.prod.outlook.com (2603:10a6:d10:139::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Wed, 28 Oct 2026 21:14:28 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0546.021; Wed, 28 Oct 2026 21:14:28 +0000 Message-ID: <8b9e8a7a-641e-4d3b-883e-bec760f6edee@virtuozzo.com> Date: Wed, 28 Oct 2026 22:14:27 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, ptikhomirov@virtuozzo.com, Konstantin Khorenko References: <20261028-ct-invalid-nrpoc-v2-0-968fe985ce27@virtuozzo.com> <20261028-ct-invalid-nrpoc-v2-1-968fe985ce27@virtuozzo.com> <010701a182902da0-a8187bad-49d7-49ca-8c52-26fe48583e26-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a182902da0-a8187bad-49d7-49ca-8c52-26fe48583e26-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR2P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::8) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|FRZPR08MB11190:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ceb7251-6ee7-4142-7a55-08df3538738e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|23010399003|366016|376014|261022105027099003|261026140227099003|4143699003|56012099006|261009223027099003|261022075727099003|261028144727099003|10067099003|261021121427099003|261026121527099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: A1PIqj0qOX+rOYLV7tO9FF7oP00O6Kt2fO0jGkDA2pWoPfkruwDAvsvLM9X7rHoF//wBsyfJEJgGeSBK4Il58T/ZscdA25XKYQZeAgqb9bDma0nv9/SxQrXbv4r1nSvyqp14GPNAIe6RIE3CVTKLsBQ3T/yn8+f5nS0Jcfip3yP9zZaF02Dy+PxYpCi/pNljP307l9QJQbO3mlU2yPr4/SXDtq4kJgMZzizsXUmqb69WymcJ7I6sX2cxUOnH6dPpRmVrIVI/yIlQJz0WIO/9TXuJXBtZ9eEJEkr+o0eS+Kn7Yj5Hh0xgWctoph3Sfo1w/jeFjL21meaPkI91PGQiG8e5lngb/CJ/LLHfpXhf5v8+SJEgyk8useKHYaOWrcFpl9RCsHlK2p3CX7jD2oZPBXF8AkPgb3YqRCIRzL30qytVQvxfgGSh6xdm1Equ54n0m3T5epAYXH/rcFrfAyItXB7GYNnpaz+3xNFcfux0FS1wUtqNVsXxXkVVOVZgpwTsGmFe52BUseLM35/R673mbIbqRKPg+BVxleyczbsNFqV+sg7VPswKh3hG23pI6zrjt/cZX3rABZ7X5nbHiECTwjcDYQRJWGjiRGHIjaeG43Ymy3xhNdz4sKAGRhI/YuoF X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(261022105027099003)(261026140227099003)(4143699003)(56012099006)(261009223027099003)(261022075727099003)(261028144727099003)(10067099003)(261021121427099003)(261026121527099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEVvcmZ0ekxqaFdwYWN2bW1ybmR4VGlTcFU1Q04xQk1TUDM5WTRucnRZSGsv?= =?utf-8?B?SjFSd1FjRGkvTjJJT2dtUVRDamdJQVhEY0ZxVEtMQU1PSHluS1NvcTduYURL?= =?utf-8?B?UTZSWmprMm1MREtmcUlqVG1UZWF6Z05iYzh6Q2dxbld3N0h5UU5Fa2dCa05o?= =?utf-8?B?amVqSEp0ZTdQWFMwcmF5ZHh5OE1qS1Q4d0ZNWnRlcWJ6YjFQTUxNd1o0ZGNU?= =?utf-8?B?OVlFZnA3MG5yc2cvU3VMWVFIdGVyaVBDT29LMzF6YzVlZ0hhOUZVUUo2WThP?= =?utf-8?B?RXg3eDRGZ21ZT0JKSHQ5K09CWFVmcThhS0lyTS8yM1NiZEpMMG93RWx6dk9n?= =?utf-8?B?d3pEOE5qTWZlaXJJanhNM09HSTJKRXM2enBXZS9WaVBrbU5EMjMwWWNJSTVt?= =?utf-8?B?NDljblBubGJocnNFZlFWcUhUb242WUNEaHhNV05pTjdNRUNIWEZMTlN0K2wz?= =?utf-8?B?Nk1QTFRlVWNSZmNwelJKekZTRnA5OXFhdjhVSURxdWJtNU5kNDR2SVFoMzlX?= =?utf-8?B?bmZTY3FSemk2cnJyc2pwSVUvMERmOWNYL3NwaDBaN3ZjTDhPQVgxSnRjL2lw?= =?utf-8?B?TSt3V1NsUGdwWkc2bFd0QmYwN1JFSFVXcE43NEdrQkkzVzRvSGd2dkduSnc5?= =?utf-8?B?SktiL0h4T0FaY05VcVpnRTYvM21kbE8yQWdoeVpuSE9ESXV4RmZPUDZpOHJn?= =?utf-8?B?RElKTk5Ka01TNk5rbU9uNUJjak85RVp2MWNxR1M0TWZWREtBM2NyaU9qQllM?= =?utf-8?B?R2REajAwRWxLWnBKaUxGUnNQaFVPZFZrM3ZQNWRnTHA2RGhZZmdGQng0U2tn?= =?utf-8?B?elhBYUkzaWNac05oMTdNRVNRNktpS0ZZc1lVQnk1RDU1QldqTnZPUVh0b0o5?= =?utf-8?B?bzNlWjBCMGszWUd5ajQvWnUrNzBzL2lNNWFYeUg4Kzdid2NTNTBOZzBKYWZi?= =?utf-8?B?ZTNZQkxYWmRBM252L1NENVZnYW9pajUxUStQRjJlWVJXMUhpdmVtUjF4NEtN?= =?utf-8?B?QkFQeTdRd3pPZ21MYjlVK2lwRUJuL3RxSys3aW9idGltTkZ5N3BYanhVLy9V?= =?utf-8?B?c2NxbTZ2Z0V5MVhJK3NFVnpkSW0wdVNrUXdCd3RhYVZLWWRxRDFHNDNMdVU1?= =?utf-8?B?TGlwRTFXT0sxbnpTbVhreHFlRDV1RlFva0pHUnFsQUc4bSt5ckhEdlg4L2la?= =?utf-8?B?cVdNVkFieTBlNWgxRHNBbFd3cjM0SjI5Y3VOTW5tclZJcno2SU15QVZzMldI?= =?utf-8?B?YmhXNlhiQm5mSE5aZU1YS05yOFRRYnN3ZUQ4bk53L3pzTHBzY2xOenhFNnp2?= =?utf-8?B?enBDTnRRd2pHejJQaVp4Z0pmSlQzYjYvVnZkVUZoYVVaNDlKaWZ6VmVBWDVU?= =?utf-8?B?cGRYNTJoM0Q5Y1FiZ014aDduSEovOExKZDJCbk55MkFLeEVyVnZ4NUVpZE81?= =?utf-8?B?WTlnVDJHdkJFY3ZrRDl4ZUJ2TmdSZVpnWkREMWtlbTNVTU15VmRLWmRwZmFS?= =?utf-8?B?T0RUS0R1VVZ5WlIwZjVtZTRseDlkUEt1RS8yTDFsKzhZWjZKa1ZNbFp3U25D?= =?utf-8?B?cy9wNjludTB3YW1xSGFCbnFBOUZJT0JPU3cwemdmVEwxRFIxd004ZzIvMXln?= =?utf-8?B?QjUvL2taa0JKNFl1bjlLbFpVZnVIWktrcjQ1MDdYZlNqOEJtUkErTDYzVDVr?= =?utf-8?B?d3krVEROa1lWNmg0RTNDWHdFNFlCblFCdzNtWGpib2dEazBUZjhlay9ScUtu?= =?utf-8?B?YmtWcXFoUWs1MHMxQ08vYmRSL2xVTTlWZzdKU2MyNVF6T3Rhdlc3RlE1aDhw?= =?utf-8?B?bWtKdm5nQ1Uxeis2T3lRQ2tQRnlWYzJ1bW1UaVUzY0dDMERJTTdSTUhhdWF6?= =?utf-8?B?WEsvc1J6M2hWOS93TXg5MjdGZS81RE04SVNEZ0tOYmx2em9YYjFrVEw4WTVG?= =?utf-8?B?MmxJQWJIY2ZuU2V5VG5TKzVBd2tkVEVWaUdBU2tLdk42TlNpd1c2NnZIRHlE?= =?utf-8?B?Y1VYMW1tbytqQXVoSHIzWjgwTVZWaWp1YzZ0N3NUVGxKeG40SS8vS2JlU0c0?= =?utf-8?B?NytDZmt4K0pDUGVPcWVSWmtjaTlDMnBhdkhMOVFHMlEyRGhZR0hsSmxGdkw0?= =?utf-8?B?cEM0c2s1azZ4OTRHTXBkSFNncjhIblBNbzNyOWJmZ2R0MEs5RytGNHBpRmI4?= =?utf-8?B?NFdCQzdpTU9SMTVjR0Y5SnBoNDFQdlVKcDVCUlBnenUwNzZLTktyZW0vQnlF?= =?utf-8?B?K3R1eUtLYWwzS2djWGhSaHhkdU1qWllzWmk1cEo2eUpxM1BhaE5LUFh2ZEdX?= =?utf-8?B?M2RvbXBsUnh2ekczZVpwOHZvdHpnYkI2RXU0T1A2VVZQckQzK3o0dXR5bkVr?= =?utf-8?Q?0ZcdpVLo5DM4YdWw=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ceb7251-6ee7-4142-7a55-08df3538738e X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2026 21:14:28.3863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GV6s19XsU/6945nnODRgb2hvzmeiSXQt65rRs+dbo0nyJGllvulp+liDEimt3LW/wc6BQSu5TL6/ZXe9zibFSf8E8V5JsdyZ63pQZ8jLVVk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRZPR08MB11190 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 1/2] sched: Fix sched_getaffinity syscall X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/28/26 13:50, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Low] sched: sched_getaffinity() mixes current's vCPU limit with target task's mask weight > - [Low] sched: sched_getaffinity() in CT can report an empty mask with success > -- > > commit c2d8d2fc58cee7091fb732ace961d0d72a6ccb84 > Author: Vladimir Riabchun > > sched: Fix sched_getaffinity syscall > > This patch changes sched_getaffinity() so that inside a container it > computes the intersection of the target task's cpus_mask and > cpu_active_mask, then reports the first min(num_online_vcpus(), > weight) bits as set. The host path is unchanged. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-141682 > >> diff --git a/kernel/sched/syscalls.c b/kernel/sched/syscalls.c >> --- a/kernel/sched/syscalls.c >> +++ b/kernel/sched/syscalls.c > > [ ... ] > >> @@ -1316,15 +1316,23 @@ long sched_getaffinity(pid_t pid, struct cpumask *mask) >> if (retval) >> return retval; >> >> + scoped_guard (raw_spinlock_irqsave, &p->pi_lock) { >> + cpumask_and(mask, &p->cpus_mask, cpu_active_mask); >> + } >> + >> if (!ve_is_super(get_exec_env())) { >> + /* >> + * setaffinity is not available inside CT, so these bits >> + * can only be used for counting. >> + * We can't have more than vcpus and we can't run on CPUs >> + * outside the mask. Reporting smallest will provide true >> + * information about CT resources. >> + */ >> + unsigned int vcpus_avail = min(num_online_vcpus(), cpumask_weight(mask)); > > [Severity: Low] > Can this combine values from two different tasks? > > num_online_vcpus() is defined as task_nr_cpus(current), while > cpumask_weight(mask) is computed from the cpus_mask of the task p that > was looked up by pid. > > task_nr_cpus() reads task_group(p)->nr_cpus, which is the task's own > cgroup and not the CT root group. nr_cpus_write_u64() is registered for > every non-root cgroup, so sub-cgroups inside one CT can have different > nr_cpus limits. > > If a process in a CT calls sched_getaffinity() with pid != 0 on a task in > a different sub-cgroup with a different cpu.nr_cpus value, the count > returned for p depends on the caller's limit and not on p's. > > Should the vCPU limit be taken from p instead of current? The old code > also used only current's limit, so this is not a new dependency. Correct, will fix in v3. > >> cpumask_clear(mask); >> bitmap_set(cpumask_bits(mask), 0, vcpus_avail); > > [Severity: Low] > Can this return success with an empty mask? > > cpumask_and() can produce an empty intersection transiently, for example > when p->cpus_mask has only CPUs just cleared from cpu_active_mask, before > balance_push or select_fallback_rq has rewritten the mask. A cpuset whose > CPUs all go offline before the cpuset hotplug work updates task masks > gives the same result. > > In that window cpumask_weight(mask) is 0, so: > > vcpus_avail = min(num_online_vcpus(), 0) = 0; > bitmap_set(cpumask_bits(mask), 0, 0); > > bitmap_set() is then a no-op and the function returns 0 with an all-zero > mask. num_online_vcpus() is not the cause, since task_nr_cpus() clamps > the result to at least 1. > > The old CT branch never read p->cpus_mask and always set at least one > bit. Callers such as nproc would count 0 CPUs here. Should there be a > fallback to at least one bit? I see no problem in returning a zero mask. If the task has no CPUs to run because of user config - a pity, but not ours. > >> } >> >> - guard(raw_spinlock_irqsave)(&p->pi_lock); >> - cpumask_and(mask, &p->cpus_mask, cpu_active_mask); >> - >> return 0; >> } > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel