From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 024A280726 for ; Sun, 11 Oct 2026 21:37:04 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BLZlCA008902; Mon, 12 Oct 2026 00:35:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BLZlCA008902 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="l9bpx3WM" Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69BLZjQk008898 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 12 Oct 2026 00:35:45 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69BLZjQk008898 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c3167afb84fso174625466b.3 for ; Sun, 11 Oct 2026 14:35:45 -0700 (PDT) X-Gm-Message-State: AFq9FYJxGVw1qMCJlkr2v9fveElFVvLwTFL8VoclVT3ZmdcpC62wHy7F +gN8b3P/hnr1NotFT8/F0GPTgPg8Xy5YQlT7oBEo4IqW+z7Zr+ZxgzziuSC9w42FqGhn8kyTY5p kwlaZAueGiXwiRRdJtNCeJlN0M8yOSky8eOfgfhSLpxo3z6YEkMIxaA== X-Gm-Gg: AYBFou1dIqizxLT7c9UadX7DXhMXkPk9w1fM5Y8jHv15LVeoZbbx7qcZyvUUIg+h9Aq r7gw65hhWV6M4vKW2AY1RbXwC5IqBbN2+goSCY3Wiuj6GY8NcV1O9xqegJWpePf+0q9DXUkZ3RV i9sOWWnnY75wNuV+cukzjaR1B7ru57Cqo4QKI2EOhnmjcjiqPw2RrNJhxipvR2sPn4xHn9Wa6Xs tzGB6/UYaGtR5HA9nmrKqL6xrmd+fk50WTwIgU7U2JKgMtgscR3SEwxJBH4725Q0t2007ihyk7i 5vML1tP3KIxsNMhuNnSWAUDv10QdDTzOLNELJ6CQM6Al1Zl1uy4nT0DqdnxWI+QQ0L65cI4W5+J JcpfwGe5mIEPfM4LmFR7lXij6aRgc0pt2WMDpXnvi8lxEBFDQJlSlG6AbiUlLfrVNrm4kG0kjzp TEoPvBpKUVOsLbRhTbE8XYHLXg9/87Yfqz X-Received: by 2002:a17:907:724b:b0:c2e:1d6a:6b78 with SMTP id a640c23a62f3a-c31aa0e0cb8mr847031766b.47.1791754545488; Sun, 11 Oct 2026 14:35:45 -0700 (PDT) X-Received: by 2002:a17:907:724b:b0:c2e:1d6a:6b78 with SMTP id a640c23a62f3a-c31aa0e0cb8mr847030966b.47.1791754544989; Sun, 11 Oct 2026 14:35:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791754544; cv=pass; d=google.com; s=arc-20260327; b=H38ndJLQ6gyEhAlYhGbsn38kvMykQE1jsZcCgVTR7tepJEGMiUrGyLzen7x19Xsvaf pHdKht6VoD2Vtu25fnCc4Dvq8ZW/t6RqniN9w1ntiKvTzOpHtpO9zWdZP9886+q2NF5o mkldZGNb2JoyrI6ubKvnUpNhjFsoeC6Ac1CiRWRZiRNxxGVtSpq3abGiZAFnD6e7s0SC 8bG8cb0OZrLM1lkbUrlKQs7IE+wk2XmrCApWuUS956+TR8Wr8cUXT2zOSnNuWfoRjLRn efDsuA846Cv7sVU//U6crPiAFPoVhlxAgiuLIXoUornIzBXG4OK/5RSeO4ZIb7pAFYFO mD5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=uogciTalgH6QeYIt/1cRg66I3FmRq2zDimPnmv0QMJ8=; fh=V2ANHK1W6FdhfBK2o6cAAa31PeXneYn0BdgOvBWS89w=; b=PfMWVmXaIjbTxWbpHPM+hiPTKLSJyjWXWwBjhj9pNrKMzDROvD/9To37uoyVcKIA5g OJdcXqyEWaKukBdMFgq9D3xAMw1AggCPn5qFhfJoh/XhISVjIiIQ/8vXEd6FQPg29sbM QD9UuN3q6FwSe2p0VE6nI32hmzxMh3cP/3IEMi08hK/krfOIDM00YKwWQODpqvM6tigd IXnFXKxcD00nehz9NycFM4Pil8XJ9qJ99650MCbSHoSySJytIejC7OAUklvdiSNNiC6f oTiOZhLRy81Z5bjuFlByBf/WswO6Z94alV0DBvIc/IpGWOduAjEu3s/VQwU172wmpDle Sr0Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=l9bpx3WM; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c201::3]) by mx.google.com with ESMTPS id a640c23a62f3a-c31a977fcecsi675512666b.6.2026.10.11.14.35.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2026 14:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) client-ip=2a01:111:f403:c201::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=l9bpx3WM; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c201::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VhwSEUWoB2Zz2Qvhf4r0S+bBQJYJlRHgJW5oKCVJm8sdjAtQj5hIWQC/i6GFNdIPa2r90/+YvHc9rltQsTKyC4M+4aZtrLCPo0t2Kz0CA/7sEOZp8YOOzNCGZOhZfeqXX8ZsgLKMU9sHQQ/77koS+TkfKqbPYwKgN930gG5OI2tLtMV2LMpMXSpQr7q28p8MSM4htJidGYUI18rx3qF2sfm342YgKbPQW3Gcfv01T2ZSLK5Emdo0AW0aj4d2j5OVMM/rZ/9N9X9EseSSpX9qtFJke9bBhP5yI6JlrmWgZSt/Y0CA5nYCJ5/41ctlIrilpDh2PI4QfyOqikeWdSFSpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uogciTalgH6QeYIt/1cRg66I3FmRq2zDimPnmv0QMJ8=; b=jW73QZuKHcfURV86V/3hf7vRhPA1fEcNk+JMGQJ5B1wTqmbAb98gTQolNls6Ej4+68U4IgXub0WCMG9BK+qv42RCvc89Qzq6fEixKxC14P11+eojP5KZnQiMBP9XZEURKrk4TR7dDwL20MQACyzp1QoUKfjfDZO2hqKqR4xJp66vc5fnpmrBpO6nrDMGrV5Qe3PSpn25GeQHn0bQTpAuMgFVADIFC3zMaXXwUt137i4QkMvAYU/8oVfE6xjFxdVDKOsEHw03Yb5wuBvdQ2tfVany/lGchKi2YCgIgLwtNr3GeoxWWr0uUgK6sTbWYuQGO1tgI4uJjQDrxIaJ21HqOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uogciTalgH6QeYIt/1cRg66I3FmRq2zDimPnmv0QMJ8=; b=l9bpx3WM4a6l4AlBTQ8K6J9Go6fehx5SyUWahi0xnSroIzM70Vg20zsa27BDLfztYDhaJfnWh6WYVSTPozn25gnZE0X3UtlTA2wAW3m/z/OiCT9U1Eqwarz49p11byBsjszEoh+8lV5aWJY/PzFNtFSuqVvRRf4hhy3rizdkJCSaIPQtjc+wsvk3HaVwPveMXH25rtPmdtouHd7SVvCTV/eXZlwotcT49w9Sy6Vn6ynL72mvj/eDb4jeD7J1ipT3jtjxJHqcaLBODfelV+Ke9wlv9cfN6rqnSF1qzPRkFTRI+LTQkeqsHjkZ3FuSTlW1qFgJigdiGay6IQr8YxJVSg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by PAXPR08MB7443.eurprd08.prod.outlook.com (2603:10a6:102:2b7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.10; Sun, 11 Oct 2026 21:35:42 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0496.010; Sun, 11 Oct 2026 21:35:42 +0000 Message-ID: <8c4c7700-6b54-4050-854d-1b21c825b9c0@virtuozzo.com> Date: Sun, 11 Oct 2026 23:35:40 +0200 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, vasileios.almpanis@virtuozzo.com, Konstantin Khorenko References: <20261006-ve-printk-irq-v2-0-db1dc4f6ed07@virtuozzo.com> <20261006-ve-printk-irq-v2-3-db1dc4f6ed07@virtuozzo.com> <010701a1133e4998-03e159dc-2432-4439-99e5-214c1a4dfa08-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1133e4998-03e159dc-2432-4439-99e5-214c1a4dfa08-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0424.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d1::17) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|PAXPR08MB7443:EE_ X-MS-Office365-Filtering-Correlation-Id: 726d5a34-f6ed-445f-9160-08df27df999f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|23010399003|56012099006|4143699003|261009223027099003|10067099003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: 0Xlj8HyXUfg2mSuH4xyjwkZ8ACkGmE3TEVCpJal3CSh8ESVsF0P8QixvbxfFA25e7Yweg2URXcZAtZAoaUrI9ReLg9Oacpb6K/+CJozkq901ZNgDdbYmjtnC6Z1Ij5x0bUtpO4mizxLt0H6O2zG1Xghsf0axrIsMWqQlABdquUWbDgJQiGpDnOdiASje9sRsiyja58Ct0REFpIn8tsYcVmeNtNhJAyiwgEwPyiFIMHPTZA3ZMlXKjpnQDMBTORdU1PqG4PjRhcp7GLWwD6cfT4ry0LsIKxPrKv76x+XD50+sNojP3dEHqBPYi70tNGvEMHv0jgIRqD46F5mBK+NZjY177W6KgpHxsf7XAred8/9NtJGDOM70S3tWhbU0lffsOJHa1OTNaum+GqwPh+/UdzeK1sGPPHWs2WNgnmW9adqoiMDoleeBqP28lMJRx4CjF82DsoV5ggv575KRa9dQ9yeQGlJAuzCk/WFKNr9xV2vPzJBfQUQZoPFIICTVMxqe3JLt2uu5yoioI7sBiGKNm0vEte0RgjuDd4SZvfPeUkboXguhVgVIOLRbZsGwytdMqxbWSh036fclQjL+6WndeGdLtGHcffCEjZY7A8yIuIFhqCYhRhDCEgbXZxjoq/BuJetGXzHG9/YqCG5Upgy06ELM47cnIchsnd+CcP8ixSY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(56012099006)(4143699003)(261009223027099003)(10067099003)(18002099003)(22082099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXc2NVd6RDRCS0NpQnQ5QTdzTmViTktHeEdlOU9YaTdRc2dEOXA4SHpEcGht?= =?utf-8?B?UGJLcG1UKzlMWnpla0I2bG0rWmkxMjdJUU94NW9xMjlyQS84YVBRWlZhLzE3?= =?utf-8?B?Z3Fja0s5UDQ3aW15ZnlNRW5nVTJNdjRFR2ZJbnRHcEEvVUNSWFVvTTV6K2lL?= =?utf-8?B?U3FxdkExWTRrd3dWQmZ1cjdLcHJkbituREgrWjg0V085UHBSUjlRSzNlOW1K?= =?utf-8?B?NGRCME9PcDZXUlJibjNyZVg4MzduUkVmcXVsUzFoMnJjZjZNeDBVdzVmMmVj?= =?utf-8?B?eUduRU9TYXYwYVMyUTJZSng1NEZpdXQzQWdYd1ZKNVMreHkvVTNKWjRRbnVK?= =?utf-8?B?WWtncTZ0UlRCenE2eTJFSkRoa1g2OFB0QUc5d2pBdjFPSEt4WFZDeEdBTklu?= =?utf-8?B?aGwrMnYyOS9rZWF1SVhaNG83TzBnWHNGOFVUSTlOQXVwdXJzcEZ1OHlVTUNn?= =?utf-8?B?cit3eEp1NHI3Z0gwMVZPZXdXOEx1NUxYSElmcFBDeEV5VEpDVUc5bzNOMlAz?= =?utf-8?B?VVhsUVRhbzY3Y1QyOHdPRVlTZFZvTFoxRkplRW93TEdFemFJa2JKRUxPdkVO?= =?utf-8?B?Y1hEc29ld2YwcERHY0pTTlJBNkhrTG8rcEUwOElwSndFUU8xVmJLMDM2dzdx?= =?utf-8?B?Y3F0WGZHRDZJaWNETTQ4NVRIZFdndjlZeW16Q3Z3aDA5blY0MG94NGdtUEMy?= =?utf-8?B?V0t3Y1U2VDNzUk1BY2J6cmd3Ykk5RkNxMDY4SUhkOStaeTNITkRVanpVN1dY?= =?utf-8?B?c1pHcXl6TVlDVkFzYTFnQlg2R01uNUZrQzlEUE5vN3hTb2dUbTNPZFpobDlU?= =?utf-8?B?SjJybEtPdjViNEgvY0lWZEx5WG81MzhTZWplTjdjODVDRmQzVklySEQwL3FW?= =?utf-8?B?Qk5PRUFtdXlCY1VrblBrbmd3YklaMjZza2NUUVo3LythRm4xRDVSTURDK1hL?= =?utf-8?B?VGFGbGdaeFFkQWE5K1M3cVdnZVdTQlVWUU5nLzhVZlQycy94TU9hK2tZejFq?= =?utf-8?B?dzZ3b041TlUwTzFrOEV2aWp4S05SdlFjR3JFL1RJbGVwaFRsUkNkWmlORjdy?= =?utf-8?B?MGpqRHBHR3hmVS9YWjI1T252QVlwaFdJUVRLRWw4eTA2Qkx4RkdjM2ZXTzJ4?= =?utf-8?B?UG1lNXl2WWJPaDlhUXdXQlZ0QmNPSFAzZGNWTXRtODZZaEpUY21HL0JTcDRa?= =?utf-8?B?NlpYVDdndlRDb0JHbEx4OTdwRHBvL3NPU0x6Ti9CeGE5amVlNXJhQXJ1WHZs?= =?utf-8?B?dWlKazFQZHlyNHFUdVNjL0h6UitwdFNNSmU1RUxlTFF1eGpHMjZBR2s1VHFV?= =?utf-8?B?WmkvZElIejN2Q3N2L3RXQzJVVmw3VFdhYWJvSTdTTG9HeU5iQzBSMzdnbUpD?= =?utf-8?B?S2w1M25FZEljTDZvNURFaXU5SkZmMGJOSS8zTGJadi93UnVJcXZ4QW9laE1Z?= =?utf-8?B?RHNHcThYM2tHLzFjSVBmZWtsVVl6bzErcUVBS0VpRW94RnM4RG5kRTgxT21w?= =?utf-8?B?Q0dxZDVpTkxwQUMvQ2RoUEtMaHU1YjNFRUlSWUk4YmhWM0VmYUVaNmVndkU5?= =?utf-8?B?djB6UCtzVCs0ZEtFNWdXOUJSSXBNaC8weUJNM0Y5NkRCQ1pFbFpXQlA4NkFL?= =?utf-8?B?SHVzb1RHZE5UTzJ2dW1Za2dSLyt6MkluQStHWGI3UmxnclhVZzhRWkNjTDN0?= =?utf-8?B?dW8xMjBITnA3NjZIY3JBK3R0TXJGbmxCekViWnhXSVFKRmNpYzdGRUE1YXpX?= =?utf-8?B?QVVuOVczS0o3VmEwT1I5K2pGQW0wdGhjQ0cxTUFYMG5BSWVISVhhdS9GT0kw?= =?utf-8?B?NXAxaUxEZCtIRWRONlBGWHhlbDlyR29tNFg4L3ZWWW52TnJaMmUrTlhRcitN?= =?utf-8?B?SVpXSmdHdjRMUndQNFZOUUs4VmlaVml4VUNHODNZUno5VE03N1V6c3QzQU50?= =?utf-8?B?Zm9XQmJtRXN3bXA0ZURqQVNaZDBBbWlNc3V3cjE4ZnlQc3laVC9QMEQ0WXQ0?= =?utf-8?B?Y3lUU29BaVhTWG11NVlnWjc3V0pMZFUrOU9sdENZeVZYaFV5ZVhpdnNnZlFK?= =?utf-8?B?VklzeWRSeXZwQTVQVVZLZCtHZ2RCNGZGZ05telZlNWJ1YXdBSG5mNVhTYWlL?= =?utf-8?B?TGlKRUxodGhUTkM4RDA2b0llQXI0WXhaNGdBVzdRaTBpekhSRDJuODBscDds?= =?utf-8?B?MSsxRjBtNlVHNnpJbklFL2hVbGpCTUZaNUNGc2dpdjJGQVA1ZG1RVHN5dVBG?= =?utf-8?B?amdXVWdPczR6K28xa2k0STNlR1E1cFdhQVFBbk9ZTDJQNzlPbUFtNEtoazg1?= =?utf-8?B?bGNkL0FSV1RBa0NJUjViS21adEtKUGYwTDZ3SGJDUWJ2aVFWTE95VGROY05P?= =?utf-8?Q?1PHgpR+QkaIv5sbg=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 726d5a34-f6ed-445f-9160-08df27df999f X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2026 21:35:41.9615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4pNpAv5WN2gyq15SDR17gsWZqFgHX6jEGMCwEBCfXst670i8QaiPAfRKqeLNTN8yn3n7bvXk9dJ1Uphl6c7EPk7LCFiHkxESiDxUqHcuEUo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7443 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 3/6] ve/printk: Specify ve in printks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/7/26 00:03, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Medium] printk: explicit-VE path skips the in_task() guard, so VE log wakeups can run in softirq > - [Low] printk: stale IRQ comment, trailing whitespace and duplicate struct ve_struct decl > -- > > commit a71d74a31e0ae4dbd29bc8edddfdbf1bedab2ffe > Author: Vladimir Riabchun > > ve/printk: Specify ve in printks > > This patch adds ve_printk helpers that take an explicit VE pointer. The > ratelimit helpers and the net_ve*_ratelimited macros now require a VE > argument. The conntrack and TCPMSS callers pass net->owner_ve. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/include/linux/printk.h b/include/linux/printk.h >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h > > [ ... ] > >> @@ -76,6 +76,7 @@ extern int console_printk[]; >> #define VE0_LOG 1 >> #define VE_LOG 2 >> #define VE_LOG_BOTH (VE0_LOG | VE_LOG) >> +struct ve_struct; >> >> extern void console_verbose(void); > > [Severity: Low] > This isn't a bug, but this adds a second forward declaration of struct > ve_struct. printk.h already has one further down, just before > ve_log_init(). True, will remove in v3. > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c > > [ ... ] > >> -static asmlinkage int ve_vprintk(int dst, const char *fmt, va_list args) >> +static asmlinkage int ve_vprintk(int dst, struct ve_struct *ve, >> + const char *fmt, va_list args) >> { >> va_list args2; >> - int r = 0; >> + int r = 0, ve_provided = (ve != NULL); >> >> WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); >> >> + if (!ve) >> + ve = get_exec_env(); >> + >> va_copy(args2, args); >> - if (ve_is_super(ve) || (dst & VE0_LOG)) >> + if (ve_is_super(ve) || (dst & VE0_LOG)) >> r = vprintk(fmt, args); >> >> /* Report IRQ usage here - printing to VE requires explicit ve reference */ >> - if ((dst & VE_LOG) && !WARN_ON_ONCE(!in_task()) && !ve_is_super(get_exec_env())) >> - r = ve_vprintk_emit(0, LOGLEVEL_DEFAULT, NULL, fmt, args2); >> + if ((dst & VE_LOG)) { >> + if (!ve_provided && WARN_ON_ONCE(!in_task())) >> + goto done; >> + if (!ve_is_super(ve)) >> + r = __ve_vprintk_emit(ve, 0, LOGLEVEL_DEFAULT, NULL, fmt, args2); >> + } >> +done: >> va_end(args2); > > [Severity: Medium] > Before this patch, the VE log branch was skipped whenever in_task() was > false. With an explicit VE the in_task() guard is now bypassed. Yes, this is intentional. > > Can this path now run from softirq or BH-disabled context? It could do it before the patch series as well. > > __nf_conntrack_alloc() runs on the packet path. __nf_ct_expect_check() > runs under spin_lock_bh(). Both call net_veboth_ratelimited(net->owner_ve, > ...), which expands to the non-deferred __ve_printk(): > > __nf_conntrack_alloc() > net_veboth_ratelimited(net->owner_ve, ...) > __ve_printk() > ve_vprintk() /* ve_provided is true */ > __ve_vprintk_emit(ve, 0, LOGLEVEL_DEFAULT, ...) > vprintk_emit_log(__ve_log_state(ve), ...) > wake_up_interruptible(&log->wait) > > LOGLEVEL_DEFAULT does not clear ft.legacy_direct, so a non-init log goes > through the wake_up_interruptible() path in vprintk_emit_log(). > > The waitqueue lock is a spinlock_t. That is fine in softirq on non-RT > kernels. Is it also intended to be reachable from these contexts on > PREEMPT_RT, and from any future explicit-VE caller running in hardirq or > under a raw_spinlock_t? I don't want to debug working printk. It works, it used to work. The only thing I change in the end is rejecting prints to random containers. > > The commit message only justifies the explicit VE for the deferred > helpers ("This is true for ve_printk_deferred functions, and their > users"). Yet net_velog_ratelimited() and net_veboth_ratelimited() use the > non-deferred __ve_printk(). Interrupt != scheduler. > > Also, ve_printk_ratelimited() in printk.h still falls back to ve0 when > !in_task(). So the two ratelimited paths now follow different rules. net_veboth_ratelimited uses explicit ve, so no rules are needed. With generic ve_ratelimit we will redirect message to host and drop a warning. Consistent with the behavior "print to host or drop". > > [Severity: Low] > This isn't a bug, but the comment "Report IRQ usage here - printing to VE > requires explicit ve reference" was kept in both ve_vprintk() and > ve_vprintk_deferred(). The in_task() check now only applies when no VE > was passed, so the comment no longer matches the code. True, will drop the comment in v3 since "!ve_provided && WARN_ON_ONCE(!in_task())" is self-descriptive. > > [ ... ] > >> +static asmlinkage int ve_vprintk_deferred(int dst, struct ve_struct *ve, >> + const char *fmt, va_list args) > > [Severity: Low] > This isn't a bug, but this line adds trailing whitespace after > "struct ve_struct *ve, ". I was looking for this whitespace for days... > > [ ... ] > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel