From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DE50E803BB for ; Wed, 11 Nov 2026 15:36:07 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABFYku2028528; Wed, 11 Nov 2026 18:34:47 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABFYku2028528 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="T8eRRB41" Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6ABFYic6028524 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Wed, 11 Nov 2026 18:34:45 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6ABFYic6028524 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8b647bbf87aso2946212b3a.2 for ; Wed, 11 Nov 2026 07:34:45 -0800 (PST) X-Gm-Message-State: APuU4Z8VaQNtgFn4DFwMCUn9YSrQju0oqwpXPdWapq3eXDmCvpFC0hOX W3br0wm4wzGwBR8FVOfa6Yy9CuhW1NxbC31Mtk7LL7yghLKsfJzW2H2ZJFNJraAKOWHXSxVx7r7 bZWg2Juf0mLPoRq5R+4jGsd8wx6d7/fkDDqk34r6QNxIJ86fDx82Nsg== X-Gm-Gg: AYBFou2i5eNHGfm1gXH9d26cNV8g4YLkGqNlVhttu7KLCrDeZ5OvIe99VIvu7DfoOdD nfPb2OygoeIP0p3QNJNLi4MBGIkX0U00rO9wgpT0n2O2t0kaAyXDWszQMcsgO+i05yXkKbT2ZQZ AEwQi7Cphj9csiTyz8HG/juWHTcBcaSL359GtifxGuhNJ+rGT7AVQLPchBdAutoiI1WimavUc8M 5l1+/8IS86FfgL+zjKzTnz6QTVJwK9pt/7wfzFDbkQaHkYHnuYetSvMn38AsUB0k0xJMD58R3SN ZvWCsOF/h//iZvCKlcAXsyYr/DREBFL8uucfxLUPdc8TY0X0jtD/Ut8uOU3wggXzODU1InfiYA1 G9kxbWtmZvcuagk62By5qMyWJ69m/hRTzn+qz8/gW1xgtP3OKksJwKNidOFjQkYUQN0Toz913zD Bo6armSEPnziGrtZ6sAsPXZ5Vd2dHNosGG X-Received: by 2002:a05:6a20:2d08:b0:3e2:3392:541e with SMTP id adf61e73a8af0-3f2fc9a4dabmr3361006637.22.1794411283577; Wed, 11 Nov 2026 07:34:43 -0800 (PST) X-Received: by 2002:a05:6a20:2d08:b0:3e2:3392:541e with SMTP id adf61e73a8af0-3f2fc9a4dabmr3360968637.22.1794411283001; Wed, 11 Nov 2026 07:34:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794411282; cv=pass; d=google.com; s=arc-20260327; b=YGwnrboKEsW9cy2YsTH9SatxksffTHWISR+vwVTAt7eebb3EnhPXFMpi8nMV6P/J01 7OvkYbHEvIzs2NGj3P0r5lu7fobDPXqvbvFoXKL6cQfveM3jZ+ZONkW619IpPRlhmt9R Gu5aVB92NXeZ5efWfAAPzBbYD4inPPJvqKJ6g4gTTERSIZSpEcoxEI9q0z+XrtCj/Yxx Q3PzuL10olyDFUQ86bKdAXtrttuneQgP3VJB+lBJNJ/xQgHWYOSzIZ/qAsai1UbyARQ1 iHNzr5PYOkXibnBscALzdVSnEKZVKrK8n8Lh6NhFcYI7xRHmKIq/wxs+NUpWmxTHkTbb yvdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=8L4573Nvn1+qAYkOmVBchVa2aPO4dej5ZoAeTwMdRcc=; fh=ElTTnnNtphHTCCOZ+58STyaWac7y7ytLDJZIF4HMMJ4=; b=lrGj93ssB8179+2duczgRNbkVUACn43gsqg9+Y3aJlpqIGI4mOm7+2rg5YvyEJy7Gg ANYBQaRPP7LzVJrUTlfueWkWhCTlv8Hbfaz5clf8jPwItf3DtbPVgkQbkTu6xIw/Wi/z aqGXjEJ00fEn6hOHISaGOE2glkfsQng9uW/L0K2qiU/iNRS9A4y3yWYh1sjYSoMp9MTp umFMJEdGV5DvJdhLUEY9VgkWezCJBUnq4gmmkZTzxm7pcurJRBDP5om0unh0LFOxW3FT j+xZcbUI+YNFXKBq3G7VKrk7hf0jbL6/E/SnCKOzfNocoTXu/xi3sB2i7grradBoyoLd gnRg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=T8eRRB41; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-cdd8d8660a8si8408698a12.123.2026.11.11.07.34.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 07:34:42 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=T8eRRB41; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=diW/thtrdGq8vjtlVQj0jSLcQMUjPW5GTbosis3iGPHoJ0eIqmyn9cDzNDF8GWBtFzHk1w2gifLTwNFRlNA84NlBDRlbRT/KC5p1bQ1Jh3nqkid1ZDOEVdbdss0KxrT/eSZXAswY1XNbKkC57ToGHcfzQ5lNH1RuehKfbAOmYtQO0dWCGrV0/XJmz4QhyyyzwldZmGH2YfCa4UNsvQDqJIIBw3fkfcn8LNOLIErNPMpCAoedClQdGl6cmkSpCYV3Wa1uqbWpcb3ghmyYjGeB0wloIDGN4GQZmGzqKG43szlkgnKtMjM4oTPCwy2hFUCs5+OLoc2H69JbUKdPWSwQpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8L4573Nvn1+qAYkOmVBchVa2aPO4dej5ZoAeTwMdRcc=; b=QofqqT7VPw4CgKxCX7VSfwRIWfcoi1huRL5bIH+yUy3eKO3kRsM5Vqag8nKBqC8CGAPvQcTzmJyoIr8mS+0UZm8mqNw2mN+AlzQmXrBw+HeLlZbhTQ9YhCJ4xMtsqm1sG4bZ6coerBJCDf7AOz31b/FEOsno02AcKhLKZW0RTfe75HUI2JYPgUDjPy6/dHIVorLdQqbVjTNcqIkO2EnwlAO3ebfW9DP0edsFPlzhGsBHUzX6e02S3WFEMBWVQccOoveE4Qu59vFSOp9ce+eswOdybf0BMDrGnWGxCaGY+/XiTsjdb2mTHnWyG9rz8A/FXmuoKEoSZZnxqr2jViarJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8L4573Nvn1+qAYkOmVBchVa2aPO4dej5ZoAeTwMdRcc=; b=T8eRRB41TdET0rQNQVbP1nWvETBA6a2nSfYgemvCTHuMbuvyA9xS054XW9z1ZC6l7xaYPneP1bUWTaUjhuSphEQNQRW1xLSFM6KS7UX3HG+LiNQ8+h6iETFWtvDm+9+x8SMyiw7joUdOqHi0WhDmNd0q3brTcTidytvNmsUtFwbP5633yGyt/uFDB+/ueZBkHr3YBJhNm9PLJgLL1CRPZsa1N/s3o/zurTvfmSFFsDvbSLTOQoHdFzWoTVRzMdhGNdFGfaa5FxtgvsA9QwqCLqdTeDvODQKM5TkH6ij/2AMQy+7BPg7FAtON5wzN4hOYZz/q/bzCzWbmrv8GIBnR+g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by GV1PR08MB8216.eurprd08.prod.outlook.com (2603:10a6:150:5f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.11; Wed, 11 Nov 2026 15:34:36 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%4]) with mapi id 15.21.0615.007; Wed, 11 Nov 2026 15:34:36 +0000 Message-ID: <92b5dce5-fbc5-4072-a893-f5affa82bf37@virtuozzo.com> Date: Wed, 11 Nov 2026 16:34:34 +0100 User-Agent: Mozilla Thunderbird To: khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com References: <20261110114629.416695-1-andrey.zhadchenko@virtuozzo.com> <20261110114629.416695-5-andrey.zhadchenko@virtuozzo.com> <010701a1c556541f-a3b013d6-70e1-45b6-bfc1-37c018cdf88f-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <010701a1c556541f-a3b013d6-70e1-45b6-bfc1-37c018cdf88f-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR2P278CA0090.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:65::14) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|GV1PR08MB8216:EE_ X-MS-Office365-Filtering-Correlation-Id: 2728e05e-edc8-4a4e-54d5-08df40094a8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|261026121527099003|4143699003|261022105027099003|261026140227099003|56012099006|261009223027099003|261102123227099003|261021121427099003|261028144727099003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 1Jlw9GHDCgzEwEZO81E0cjjLSOx4PSJ4EU4UddhBNcnl57MoBh6yhSJN1mi2i5BkcfHO7OiqV8awE6ZE99cPFSCi1UuXhMw6tnRKDDDALD0/z63BPYjNT35A2wO9rM1KUSurgwpbqZfRr2+mZZ/RmeDUHWK0ZsI/T1Zip1HE5V/rijdpajsAeLtBdFjkkca2C5ofUcL5pYNIhSKpYjtymEkWTh55NMv8Kk+0E8syDi09RG1IXqhHQIIj74enrq9vL0QyWCx5JAizahTkQUM/HLG9TWmvqcxsjVHNiO08IjoHcPGRd4mjAUoEw5audej56gVcXyRzAOrm8AHdGYluG9QqcA2buHOGLW+A/KbSjCYei45zlhsM322/e8HlVCFy2nLLotrONsfTRfe+W1xNGIe8/1iuJ9XBBg18sGKIlfyHdWuO4uzfirwo4Mhjq+dEW/aO6SIAcR1a9aqBjEblJrqgbifa3su6pTed3eludAvnZqOEnJhroBC6keCm9ebovLknjslVkU0IMmtN0z1nq+cdFDMNO0wpYAu0dyknnwYBkfPxi2m7MKQjrgGSrS0xU5lf4BjOCXrFkUF5/xO/KsCwmCTnr2fyOunGmFrYAHkKf/b/tMaLhhAIrdapIr+B X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(261026121527099003)(4143699003)(261022105027099003)(261026140227099003)(56012099006)(261009223027099003)(261102123227099003)(261021121427099003)(261028144727099003)(10067099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWszKzRiNFBLc2RnMVNNeDNPbVZsYVBkcms1amxpeGFRUjhHWHUrRGt1Mk5V?= =?utf-8?B?ZzJoUWViNFhNaU5OWEwyL0ZsMk93NllpYUpRaWhEZ3RQZ2ovWjk3T0Fac3Ev?= =?utf-8?B?eHhGYWJydnljWW1IUWorNGtITUN5cHFISklJUEhNWjdSQk9YbXRZMUpsQUF5?= =?utf-8?B?YWMzc082N2Z4ZDlJSWN4cXBrMFlaVTdUM1hLSnVkRVRJb0RKalZKbFFnUHJV?= =?utf-8?B?UlBNRWNmSWM1d0lnRGxyMTN6TlozcWtLR20wb0hZQXY0Q1J4TXpQc1dVY2lW?= =?utf-8?B?TmlwWUVPQkRaR1RxbTU4dUppU25sdU1xMHFSUkJSb2lEOFJlQkd5cmIybktm?= =?utf-8?B?VjZ1aGtwNUJiYUpPYm11R2hZQ2FUWU9mWFBYWUl1NjhmV2hOL2djdkRZMzdW?= =?utf-8?B?VERVRGE0elRuRURuRnRoV2JOblJ2VWJ0RURZYXE1d2ZaMW5seDh6Y3d6MW1t?= =?utf-8?B?a2taUlJIL2M0UDNQbVp2Qk1kc2xuSGRWc3FYM2RQRXF6QVlTQ0FVZ2N2U1JY?= =?utf-8?B?cERlU09ZTkFEanJTNnZKK0w0ZlEyQjVQcDBWVTFZWklYQkY1dmpJZ3VxT1FD?= =?utf-8?B?RzRYRUIwdkZpdkdzd2pxNVAwd2NpZWNXWS9hRW9xbk9MWjZvajgxYklDV2wy?= =?utf-8?B?QlNraFFLcWIyVUJQQ241VFEyZVNQOHJHWk9WTVE1THNxdmxaekhZRXg3ZXZW?= =?utf-8?B?WVEyUXRuVHZhSzBGRUwzelRxS3ZqakpxaFdLWXcwWVBUQjZlbDJqNEtRN1pE?= =?utf-8?B?QVQvLzlsYkhVYnJCam11YWczVGdxbE0wYy9KUFVoSzQ2VjNHc0Z4c1VTTmN0?= =?utf-8?B?TitycmhvQjJ2Z1N2VE1qMjk1aXZBZHF6NWh1SEZyK3hOcTBwMkt6L2Y5L09L?= =?utf-8?B?TEhSMXR4NjlOejJOV1RpTUcxZU1aRzlodkNaZmtGOVZUdzYxR2p2V0pUWHUv?= =?utf-8?B?bnA1VWlkT0JkSy9ycmVaTUJKSlhDQVFIWnIvbnhVY1NleTNaVUNMb0VrcEsr?= =?utf-8?B?anAwZEx5Z0tEbWZaS0NCRGlSTjIyM0hSMllYM0tMSHhvMmUvSER6TGpxY0t5?= =?utf-8?B?MEpyU0QwVnpNUUNOMjZIbnJ6ZmhyTHAzUlJnaWNyVUMxL0RMVmwra1RoTFpQ?= =?utf-8?B?Y1dqelkrb3dQazBlM0F2eldnR2xVMmhGdTlUV29adVVsaDJDT3J4MjNDL1Vv?= =?utf-8?B?bStJcmVBNjY1SFR5MFVXV1kzbGgwRGo1OUkra2lUeUdIZkdUWXN3N3JWRTJw?= =?utf-8?B?UHNjaHBOcjF0R2M3a3lhN3dLNkJObUY2a3ErQVdBa21iRXI1ZFllWlZ3R0hv?= =?utf-8?B?NFdXQkd4bXg3Y0ROaWpZTHBDbGF4Z0lhcFRpRGNhZFlGVzFBMXFBVDZ5Tk1L?= =?utf-8?B?bVlWNEZaWW81QVdxOVVseWdqUVlHeGF3UyttdVNXNzNkb1hyQmIrTC9JOVpI?= =?utf-8?B?bHBBSGFodGhFdWJaZDg4OEJvMWpmTnhrN3JZQWQrWVpjclFqT3VXK1RFY2VD?= =?utf-8?B?aTBkZ1A0cXNYMnUwWDBUSC9LRUM1ajJhTkIzekNtWWNIZ05xL1M5dm1UYThy?= =?utf-8?B?d3Z3NE1aR1NDUVloT2RMcFVteVVhTjZ3Ull2cGZGTXA2NEFMWHVVbVJwMmF4?= =?utf-8?B?UHBxNm53WG9lMUIzYjFpRXRaTzIvUzcySTY5a3BVOElqanJrZWN5c0JEKzhX?= =?utf-8?B?RzErbUZBbytBYnUwR2k3L0tFajR1N0VoR3FNK2paNE9nNVp0SDNweGlJdC9L?= =?utf-8?B?NVhLbHZ0ZmRRS1Zzb3ZFME5YV1o5SHZJSlhpUDJXSlF5c3dyc0tMS1A0WEE0?= =?utf-8?B?Q0dmNHZpaE9kcDhXMzA5T01ERkV3WFFrZm9VNWRubVNzMTFGNFVseXUvckZF?= =?utf-8?B?YlhUck84STd1eUF2ZHVKRlQrMis4cnFtdzMwMTFFeU1ZQncvdTluVzYzQ2R0?= =?utf-8?B?Sjh2RDFnZ0x2anpoRE5YcFZHMGpHdlQyVWo1TTBCeGNzeGlpNFhSdVZSaXJB?= =?utf-8?B?bXFBNjRobXV3dDI0WHdzVTRsMGlkaGxYNkVES0llYXhtc1YrdC9yQU43YXdH?= =?utf-8?B?SnlMYXU5b0wxM3pHUWs2dnBoNFg5dk96YzA1bkZMZ09DK2M2WmV5K2YzS0ov?= =?utf-8?B?RkMrRzRySWs1ZkM3OGlRRlk5dUttamhScGg2aTFwY3Z6SHpIYUF5aTg5TGVx?= =?utf-8?B?dVJmSzA0MlcxZTRRVHd4cWpKa0xweWV2TDlEaUg4VGVaY3NUcnltKzU4V3JL?= =?utf-8?B?c0xJMVFUU0c3eVlKb0szLzNlSFB5a002czBXN0RaTU10bE5ZakZ6QTFralFG?= =?utf-8?B?STFMNDJydU5URnBpcmF6bGRmYWRrd3cyOXlyYmJxWS9pR2YyaHBmMHo5VnpM?= =?utf-8?Q?mvqNpWFXVUONzJ80=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2728e05e-edc8-4a4e-54d5-08df40094a8f X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2026 15:34:36.1790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fpe4Ax9I//8JDxjxKxnqKlG4f5xG6O0f+EzJD3VnoYy46qV6LkEV5KP6jBM6xqhkd76hMEO1VZdef/4qZo+NNb6lAdBBDzQrrIoK6W9nfE4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8216 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v2 4/7] dm-qcow2: add per-qio work infrastructure X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/10/26 13:02, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] dm-qcow2: concurrent qio preparers can deadlock on qio_pool under memory pressure > -- > > commit 1b2b6ed6f3d2b43e71cc7424d0502aa9998c0d28 > Author: Andrey Zhadchenko > > dm-qcow2: add per-qio work infrastructure > > This commit adds a work_struct and a state field to struct qio. It uses > them to queue the first pipeline step, qio preparation, as one work item > per data request on tgt->wq. Previously this step ran serialised inside the > single qcow2->worker. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-95494 > >> diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c >> --- a/drivers/md/dm-qcow2-map.c >> +++ b/drivers/md/dm-qcow2-map.c > > [ ... ] > >> @@ -4519,7 +4511,7 @@ static void qcow2_submit_embedded_qio(struct qcow2_target *tgt, struct qio *qio) >> >> if (blk_rq_bytes(rq)) { >> queue_list_id = QLIST_EMBEDDED; >> - worker = &qcow2->worker; >> + worker = &qio->worker; >> } else { > > [ ... ] > >> spin_unlock_irqrestore(&qcow2->deferred_lock, flags); >> >> if (queue) >> queue_work(tgt->wq, worker); > > [Severity: Medium] > Can concurrent preparers deadlock on qio_pool under memory pressure? > > Before this patch, preparation ran serialised inside qcow2->worker, so > only one preparer held a partial split list at a time. Now one work item > is queued per data request on the unbound tgt->wq, which has the default > max_active limit of 256. > > Each work item runs: > > do_qio_work() > prepare_one_embedded_qio() > qcow2_split_qio_to_list() > split_and_chain_qio() > qcow2_alloc_qio(qcow2->tgt->qio_pool, true) > mempool_alloc(GFP_NOIO) > > The split qios stay on a local list and are only handed to QLIST_DEFERRED > in do_qio_work() after the whole request has been split: > >> + prepare_one_embedded_qio(qio, &deferred_qios); >> + if (list_empty(&deferred_qios)) >> + break; > > The pool is created in alloc_qcow2_target() as: > > tgt->qio_pool = mempool_create_kmalloc_pool(MIN_QIOS, sizeof(struct qio)); > > with 512 elements, shared by all preparers and the rest of the pipeline. > Up to 512 requests may be in flight (qrq_pool), and each request needs up > to request_size/clu_size splits (about 20 for a 64K cluster and a 1280K > request, and more for smaller clusters). Total demand can therefore exceed > 512. > > If kmalloc keeps failing under memory pressure, can several preparers each > hold part of the reserve while all of them sleep in mempool_alloc() waiting > for more? The only wake-up source is a free of a qio from a completed > request, and none of the blocked preparers' own splits can complete until > splitting finishes. > > The later patches in the series do not appear to remove this. The final > state (d9084b95) drops the per-qio work_struct and runs do_qio_work() from > per-CPU qcow2_fast_work items on the same tgt->wq. That lowers the number > of preparers from up to 256 to one per CPU, but each preparer still builds > its full split list with blocking mempool_alloc() before releasing any of > it, so the hold-and-wait remains possible, mainly on many-core machines or > with small clusters. > > Would it make sense to throttle or reserve pool space for preparers? > Even before the series amount of splits could exceed 512 and theoretically exhaust this pool and sleep. Anyway mempool_alloc also has kmalloc retry logic and other mitigation mechanisms. Not only this issue is pre-existing but qio's are also quite small and if the node is out of 0-order allocations we are likely doomed anyway. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel